<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>83811</bug_id>
          
          <creation_ts>2012-04-12 13:17:53 -0700</creation_ts>
          <short_desc>Stop exposing RenderLayer knowledge to the code outside rendering/</short_desc>
          <delta_ts>2013-02-27 20:42:49 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>83728</dependson>
    
    <dependson>83816</dependson>
    
    <dependson>84090</dependson>
    
    <dependson>84607</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Julien Chaffraix">jchaffraix</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>eric</cc>
    
    <cc>fmalita</cc>
    
    <cc>jamesr</cc>
    
    <cc>krit</cc>
    
    <cc>noam</cc>
    
    <cc>simon.fraser</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>601472</commentid>
    <comment_count>0</comment_count>
    <who name="Julien Chaffraix">jchaffraix</who>
    <bug_when>2012-04-12 13:17:53 -0700</bug_when>
    <thetext>Currently RenderLayer&apos;s getter is public (RenderBoxModelObject::layer()) which makes it convenient for people to start poking the layer. However this is hurting us as objects outside rendering have some very deep knowledge of how rendering is supposed to work. This breaks the rendering abstraction and makes it harder to refactor RenderLayer in many ways.

I haven&apos;t thought deeply on that but RenderObject::hasLayer() should likely be made protected too as this is an implementation detail.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>843512</commentid>
    <comment_count>1</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2013-02-27 14:35:02 -0800</bug_when>
    <thetext>Sounds like a great idea to me.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>