83778 2012-04-12 06:39:49 -0700 [chromium] Fix threaded compositor HUD crash 2012-04-12 10:41:21 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 skyostil skyostil anicolao cc-bugs jamesr shawnsingh webkit.review.bot oldest_to_newest 601165 0 skyostil 2012-04-12 06:39:49 -0700 [chromium] Fix threaded compositor HUD crash 601170 1 136893 skyostil 2012-04-12 06:43:33 -0700 Created attachment 136893 Patch 601318 2 136893 webkit.review.bot 2012-04-12 10:17:03 -0700 Comment on attachment 136893 Patch Clearing flags on attachment: 136893 Committed r114000: <http://trac.webkit.org/changeset/114000> 601320 3 webkit.review.bot 2012-04-12 10:17:07 -0700 All reviewed patches have been landed. Closing bug. 601329 4 anicolao 2012-04-12 10:27:23 -0700 Sorry for introducing this bug - should have seen it when I did the merge with the other refactoring - but also, it would be simpler and just as good to just hardcode a 50 instead of 40 and ignore the font size in all cases. 601336 5 skyostil 2012-04-12 10:38:23 -0700 Right. I wasn't sure why the font size was being included in the height, since here the fps counter is drawn to the left of the graph instead of on top of it. Feel free to bump this to 50 if that is closer to the intended effect. 601338 6 shawnsingh 2012-04-12 10:41:21 -0700 FYI I'm about to clobber the font rendering code anyway, so that the HUD can work in multithreaded mode =) I had a nice layout that I think you'll like, otherwise feel free to adjust it afterwards 136893 2012-04-12 06:43:33 -0700 2012-04-12 10:17:03 -0700 Patch bug-83778-20120412144331.patch text/plain 1778 skyostil U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzOTY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzE4OWE3NGQzNjc1NWIx MzYyNDBkZWYzNWU3NjZmMTNiNWE4MjNjYy4uZDBmYjg1MGI5MDI2OTMwNmIwNzM0ZTZiMzJhYmMy YmE5OTFiMWQ2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA0LTEyICBTYW1p IEt5b3N0aWxhICA8c2t5b3N0aWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0g Rml4IHRocmVhZGVkIGNvbXBvc2l0b3IgSFVEIGNyYXNoCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04Mzc3OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIERvbid0IHRyeSB0byByZWFkIGZvbnQgbWV0cmljcyBp biB0aHJlYWRlZCBjb21wb3NpdGluZyBtb2RlLCBzaW5jZSB3ZQorICAgICAgICBjdXJyZW50bHkg Y2FuJ3QgcmVuZGVyIEhVRCB0ZXh0IHdpdGggdGhlIHRocmVhZGVkIGNvbXBvc2l0b3IuCisKKyAg ICAgICAgSFVEIGlzIG5vdCB0ZXN0YWJsZSBpbiBXZWJLaXQuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0hlYWRzVXBEaXNwbGF5LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkNDSGVhZHNVcERpc3BsYXk6OmRyYXdIdWRDb250ZW50cyk6CisKIDIwMTItMDMtMDUg IFBpZXJyZSBSb3NzaSAgPHBpZXJyZS5yb3NzaUBnbWFpbC5jb20+CiAKICAgICAgICAgW1F0XSBV c2UgUVJhd0ZvbnQgd2hlbiBidWlsZGluZyB3aXRoIFF0IDUKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDSGVhZHNVcERpc3BsYXkuY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NIZWFkc1Vw RGlzcGxheS5jcHAKaW5kZXggNThmM2QwNWM4YzQ3MmQ3Zjc3NThkNjUzYWI3MzY3NTU0ODJmMTQ5 Mi4uZmUyZTUyMDFjZTIwNDY4OWIyYmI5ZTU3MDYyM2RiOGZiMDExYTg3MSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NIZWFkc1VwRGlz cGxheS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0v Y2MvQ0NIZWFkc1VwRGlzcGxheS5jcHAKQEAgLTIwMyw3ICsyMDMsMTAgQEAgdm9pZCBDQ0hlYWRz VXBEaXNwbGF5OjpkcmF3SHVkQ29udGVudHMoR3JhcGhpY3NDb250ZXh0KiBjb250ZXh0LCBjb25z dCBJbnRTaXplJgogICAgICAgICBjb250ZXh0LT5maWxsUmVjdChGbG9hdFJlY3QoMCwgMCwgaHVk U2l6ZS53aWR0aCgpLCBodWRTaXplLmhlaWdodCgpKSk7CiAgICAgfQogCi0gICAgaW50IGZwc0Nv dW50ZXJIZWlnaHQgPSBtX21lZGl1bUZvbnQtPmZvbnRNZXRyaWNzKCkuZmxvYXRIZWlnaHQoKSAr IDQwOworICAgIGludCBmcHNDb3VudGVySGVpZ2h0ID0gNDA7CisgICAgaWYgKCFDQ1Byb3h5Ojpp bXBsVGhyZWFkKCkpCisgICAgICAgIGZwc0NvdW50ZXJIZWlnaHQgKz0gbV9tZWRpdW1Gb250LT5m b250TWV0cmljcygpLmZsb2F0SGVpZ2h0KCk7CisKICAgICBpbnQgZnBzQ291bnRlclRvcCA9IDI7 CiAgICAgaW50IHBsYXRmb3JtTGF5ZXJUcmVlVG9wOwogICAgIGlmIChzZXR0aW5ncygpLnNob3dG UFNDb3VudGVyKQo=