83774 2012-04-12 05:30:35 -0700 [GTK] Test runner crashes without recent versions of pulseaudio-utils 2012-04-12 06:33:45 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 spena webkit-unassigned abarth dpranke ojan pnormand webkit.review.bot oldest_to_newest 601126 0 spena 2012-04-12 05:30:35 -0700 After r113849: <http://trac.webkit.org/changeset/113849>, having pulseaudio-utils was made an implicit requirement for running the tests. Although Phillipe fixed it partially in r113850: <http://trac.webkit.org/changeset/113850>, it still crashes when pulseaudio-utils is installed but pactl doesn't provide an index for pulseaudio loaded modules. 601133 1 136885 spena 2012-04-12 05:46:18 -0700 Created attachment 136885 Patch 601135 2 spena 2012-04-12 05:50:34 -0700 CCing Philippe (sorry, I misspelled your name before) 601140 3 136885 pnormand 2012-04-12 05:59:10 -0700 Comment on attachment 136885 Patch Looks reasonable to me. Thanks! 601159 4 136885 webkit.review.bot 2012-04-12 06:33:41 -0700 Comment on attachment 136885 Patch Clearing flags on attachment: 136885 Committed r113969: <http://trac.webkit.org/changeset/113969> 601160 5 webkit.review.bot 2012-04-12 06:33:45 -0700 All reviewed patches have been landed. Closing bug. 136885 2012-04-12 05:46:18 -0700 2012-04-12 06:33:41 -0700 Patch bug-83774-20120412144615.patch text/plain 4199 spena U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzOTY0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDY1YTQ5NGJjYzZhZmFjZjQyNjcwM2RjOTQ5ODIxZWY3 ZGQ0NjZjNy4uNDgwOWY1Y2I5MWUzYzRhNjE1NDZlY2RjN2NlYjNiM2JhNDRlNmMwZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTA0LTEyICBTaW1vbiBQZW5hICA8c3BlbmFAaWdhbGlhLmNvbT4KKworICAgICAg ICBbR1RLXSBUZXN0IHJ1bm5lciBjcmFzaGVzIHdpdGhvdXQgcmVjZW50IHZlcnNpb25zIG9mIHB1 bHNlYXVkaW8tdXRpbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTgzNzc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQmVzaWRlcyBjaGVja2luZyB0aGF0IHBhY3RsIGlzIGF2YWlsYWJsZSwgY2hlY2sgYWxz byB0aGF0IGl0cyBvdXRwdXQKKyAgICAgICAgaXMgdGhlIGV4cGVjdGVkIG9uZSwgYW5kIGhhbmRs ZSBncmFjZWZ1bGx5IHdoZW4gaXQgaXNuJ3QsIHdoZW4KKyAgICAgICAgdHJ5aW5nIHRvIHVubG9h ZCBwdWxzZWF1ZGlvIG1vZHVsZXMuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9wb3J0L2d0ay5weToKKyAgICAgICAgKEd0a1BvcnQuX3VubG9hZF9wdWxzZWF1ZGlv X21vZHVsZSk6CisgICAgICAgIChHdGtQb3J0Ll9yZXN0b3JlX3B1bHNlYXVkaW9fbW9kdWxlKToK KwogMjAxMi0wNC0xMSAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBGaXggcmVncmVzc2lvbiBpbnRyb2R1Y2VkIGluIHIxMTM5MjcuCmRpZmYgLS1naXQgYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2d0ay5weSBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZ3RrLnB5CmluZGV4IDcwYmJmMTBkODBm Y2Y2ODgyMDRlZWI4YzQxMGJhOGE3NDI2ZTJmZWQuLjcxZTVhM2I3OTIwNzFjNmM5NTM1MzNjYzg4 MDg0M2EwNjRjMmRmMzggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3BvcnQvZ3RrLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3BvcnQvZ3RrLnB5CkBAIC04NCw2ICs4NCw3IEBAIGNsYXNzIEd0a1BvcnQoV2ViS2l0UG9y dCk6CiAgICAgICAgIHdpdGggb3Blbihvcy5kZXZudWxsLCAndycpIGFzIGRldm51bGw6CiAgICAg ICAgICAgICB0cnk6CiAgICAgICAgICAgICAgICAgcGFjdGxfcHJvY2VzcyA9IHN1YnByb2Nlc3Mu UG9wZW4oWyJwYWN0bCIsICJsaXN0IiwgInNob3J0IiwgIm1vZHVsZXMiXSwgc3Rkb3V0PXN1YnBy b2Nlc3MuUElQRSwgc3RkZXJyPWRldm51bGwpCisgICAgICAgICAgICAgICAgcGFjdGxfcHJvY2Vz cy53YWl0KCkKICAgICAgICAgICAgIGV4Y2VwdCBPU0Vycm9yOgogICAgICAgICAgICAgICAgICMg cGFjdGwgbWlnaHQgbm90IGJlIGF2YWlsYWJsZS4KICAgICAgICAgICAgICAgICBfbG9nLmRlYnVn KCdwYWN0bCBub3QgZm91bmQuIFBsZWFzZSBpbnN0YWxsIHB1bHNlYXVkaW8tdXRpbHMgdG8gYXZv aWQgc29tZSBwb3RlbnRpYWwgbWVkaWEgdGVzdCBmYWlsdXJlcy4nKQpAQCAtOTEsMTcgKzkyLDM3 IEBAIGNsYXNzIEd0a1BvcnQoV2ViS2l0UG9ydCk6CiAgICAgICAgIG1vZHVsZXNfbGlzdCA9IHBh Y3RsX3Byb2Nlc3MuY29tbXVuaWNhdGUoKVswXQogICAgICAgICBmb3IgbW9kdWxlIGluIG1vZHVs ZXNfbGlzdC5zcGxpdGxpbmVzKCk6CiAgICAgICAgICAgICBpZiBtb2R1bGUuZmluZCgibW9kdWxl LXN0cmVhbS1yZXN0b3JlIikgPj0gMDoKLSAgICAgICAgICAgICAgICBzZWxmLl9wYV9tb2R1bGVf aW5kZXggPSBtb2R1bGUuc3BsaXQoJ1x0JylbMF0KLSAgICAgICAgICAgICAgICBicmVhawotICAg ICAgICBpZiBpbnQoc2VsZi5fcGFfbW9kdWxlX2luZGV4KSAhPSAtMToKLSAgICAgICAgICAgIHN1 YnByb2Nlc3MuUG9wZW4oWyJwYWN0bCIsICJ1bmxvYWQtbW9kdWxlIiwgc2VsZi5fcGFfbW9kdWxl X2luZGV4XSkKKyAgICAgICAgICAgICAgICAjIFNvbWUgcHVsc2VhdWRpby11dGlscyB2ZXJzaW9u cyBkb24ndCBwcm92aWRlCisgICAgICAgICAgICAgICAgIyB0aGUgaW5kZXgsIGp1c3QgYW4gZW1w dHkgc3RyaW5nCisgICAgICAgICAgICAgICAgc2VsZi5fcGFfbW9kdWxlX2luZGV4ID0gbW9kdWxl LnNwbGl0KCdcdCcpWzBdIG9yIC0xCisgICAgICAgICAgICAgICAgdHJ5OgorICAgICAgICAgICAg ICAgICAgICAjIFNpbmNlIHRoZXkgY291bGQgcHJvdmlkZSBvdGhlciBzdHVmZiAobm90IGFuIGlu ZGV4CisgICAgICAgICAgICAgICAgICAgICMgbm9yIGFuIGVtcHR5IHN0cmluZywgbGV0J3MgbWFr ZSBzdXJlIHRoaXMgaXMgYW4gaW50LgorICAgICAgICAgICAgICAgICAgICBpZiBpbnQoc2VsZi5f cGFfbW9kdWxlX2luZGV4KSAhPSAtMToKKyAgICAgICAgICAgICAgICAgICAgICAgIHBhY3RsX3By b2Nlc3MgPSBzdWJwcm9jZXNzLlBvcGVuKFsicGFjdGwiLCAidW5sb2FkLW1vZHVsZSIsIHNlbGYu X3BhX21vZHVsZV9pbmRleF0pCisgICAgICAgICAgICAgICAgICAgICAgICBwYWN0bF9wcm9jZXNz LndhaXQoKQorICAgICAgICAgICAgICAgICAgICAgICAgaWYgcGFjdGxfcHJvY2Vzcy5yZXR1cm5j b2RlID09IDA6CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgX2xvZy5kZWJ1ZygnVW5sb2Fk ZWQgbW9kdWxlLXN0cmVhbS1yZXN0b3JlIHN1Y2Nlc3NmdWxseScpCisgICAgICAgICAgICAgICAg ICAgICAgICBlbHNlOgorICAgICAgICAgICAgICAgICAgICAgICAgICAgIF9sb2cuZGVidWcoJ1Vu bG9hZGluZyBtb2R1bGUtc3RyZWFtLXJlc3RvcmUgZmFpbGVkJykKKyAgICAgICAgICAgICAgICBl eGNlcHQgVmFsdWVFcnJvcjoKKyAgICAgICAgICAgICAgICAgICAgICAgICMgcGFjdGwgc2hvdWxk IGhhdmUgcmV0dXJuZWQgYW4gaW5kZXggaWYgdGhlIG1vZHVsZSBpcyBmb3VuZAorICAgICAgICAg ICAgICAgICAgICAgICAgX2xvZy5kZWJ1ZygnVW5hYmxlIHRvIHBhcnNlIG1vZHVsZSBpbmRleC4g UGxlYXNlIGNoZWNrIGlmIHlvdXIgcHVsc2VhdWRpby11dGlscyB2ZXJzaW9uIGlzIHRvbyBvbGQu JykKKyAgICAgICAgICAgICAgICByZXR1cm4KIAogICAgIGRlZiBfcmVzdG9yZV9wdWxzZWF1ZGlv X21vZHVsZShzZWxmKToKICAgICAgICAgIyBJZiBwdWxzZWF1ZGlvJ3MgbW9kdWxlLXN0cmVhbS1y ZXN0b3JlIHdhcyBwcmV2aW91c2x5IHVubG9hZGVkLAotICAgICAgICAjIHJlc3RvcmUgaXQgYmFj ay4KKyAgICAgICAgIyByZXN0b3JlIGl0IGJhY2suIFdlIHNob3VsZG4ndCBuZWVkIGV4dHJhIGNo ZWNrcyBoZXJlLCBzaW5jZSBhbgorICAgICAgICAjIGluZGV4ICE9IC0xIGhlcmUgbWVhbnMgd2Ug c3VjY2Vzc2Z1bGx5IHVubG9hZGVkIGl0IHByZXZpb3VzbHkuCiAgICAgICAgIGlmIHNlbGYuX3Bh X21vZHVsZV9pbmRleCAhPSAtMToKICAgICAgICAgICAgIHdpdGggb3Blbihvcy5kZXZudWxsLCAn dycpIGFzIGRldm51bGw6Ci0gICAgICAgICAgICAgICAgc3VicHJvY2Vzcy5Qb3BlbihbInBhY3Rs IiwgImxvYWQtbW9kdWxlIiwgIm1vZHVsZS1zdHJlYW0tcmVzdG9yZSJdLCBzdGRvdXQ9ZGV2bnVs bCwgc3RkZXJyPWRldm51bGwpCisgICAgICAgICAgICAgICAgcGFjdGxfcHJvY2VzcyA9IHN1YnBy b2Nlc3MuUG9wZW4oWyJwYWN0bCIsICJsb2FkLW1vZHVsZSIsICJtb2R1bGUtc3RyZWFtLXJlc3Rv cmUiXSwgc3Rkb3V0PWRldm51bGwsIHN0ZGVycj1kZXZudWxsKQorICAgICAgICAgICAgICAgIHBh Y3RsX3Byb2Nlc3Mud2FpdCgpCisgICAgICAgICAgICAgICAgaWYgcGFjdGxfcHJvY2Vzcy5yZXR1 cm5jb2RlID09IDA6CisgICAgICAgICAgICAgICAgICAgIF9sb2cuZGVidWcoJ1Jlc3RvcmVkIG1v ZHVsZS1zdHJlYW0tcmVzdG9yZSBzdWNjZXNzZnVsbHknKQorICAgICAgICAgICAgICAgIGVsc2U6 CisgICAgICAgICAgICAgICAgICAgIF9sb2cuZGVidWcoJ1Jlc3RvcmluZyBtb2R1bGUtc3RyZWFt LXJlc3RvcmUgZmFpbGVkJykKKwogCiAgICAgZGVmIHNldHVwX3Rlc3RfcnVuKHNlbGYpOgogICAg ICAgICBzZWxmLl91bmxvYWRfcHVsc2VhdWRpb19tb2R1bGUoKQo=