83758 2012-04-12 01:20:04 -0700 Web Inspector: Node Value should not get corrupt while jump over different matches in search. 2012-04-12 06:40:17 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 dsam2912 webkit-unassigned apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 600985 0 dsam2912 2012-04-12 01:20:04 -0700 Steps to reproduce : 1). Open html file, as an attachment. 2). Get to the inspect element view/ 3). Try for searching "we". 4). Jump over different search matches. 5). Observe the text value getting misplaced for anchor node. Expected Behavior: text value should not get misplacd 601003 1 dsam2912 2012-04-12 01:34:19 -0700 Constructing highlight node for a matched element requires 2 modes of operations. "added" -> for adding new span element for matched value with highlight class. "changed" -> for appending/manipulating prefix/suffix node to highlight node. There are cases were there will be multiple instances of matches in a node. This will follow the same mode of operations for other matches in a node, but now on manipulated nodes. While exec updateSearchHighlight, for hiding the highlights for cached results, the order in which updateEntryHide is called should then work in rev order to preserve the semantic of node. I am creating a patch for it. I will upload it soon!! 601004 2 136851 dsam2912 2012-04-12 01:36:18 -0700 Created attachment 136851 sample.html for reproducing the bug. 601043 3 136861 dsam2912 2012-04-12 02:55:49 -0700 Created attachment 136861 Patch 601059 4 136861 apavlov 2012-04-12 03:11:02 -0700 Comment on attachment 136861 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136861&action=review > Source/WebCore/inspector/front-end/ElementsTreeOutline.js:640 > + if (show) { Since this now falls into two branches, it would be better to remove the |updater| var (which was introduced to avoid branching) altogether and call updateEntryShow and updateEntryHide directly in the branches instead. 601079 5 136872 dsam2912 2012-04-12 03:45:39 -0700 Created attachment 136872 Patch 601081 6 dsam2912 2012-04-12 03:47:35 -0700 (In reply to comment #4) > (From update of attachment 136861 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=136861&action=review > > > Source/WebCore/inspector/front-end/ElementsTreeOutline.js:640 > > + if (show) { > > Since this now falls into two branches, it would be better to remove the |updater| var (which was introduced to avoid branching) altogether and call updateEntryShow and updateEntryHide directly in the branches instead. Thank you Alexander for review! I have uploaded the patch. 601094 7 136872 apavlov 2012-04-12 04:27:04 -0700 Comment on attachment 136872 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136872&action=review I believe it's ready for landing! > Source/WebCore/ChangeLog:7 > + highlightResults is changed in "last changed first corrected" order to preserve the semantic of node. optional: I'd replace the word "semantic" by "structure" for clarity. > Source/WebCore/inspector/front-end/ElementsTreeOutline.js:637 > + // Preserve the semantic of node by following the order of updates for hide and show. Ditto. 601166 8 136872 webkit.review.bot 2012-04-12 06:40:11 -0700 Comment on attachment 136872 Patch Clearing flags on attachment: 136872 Committed r113970: <http://trac.webkit.org/changeset/113970> 601167 9 webkit.review.bot 2012-04-12 06:40:17 -0700 All reviewed patches have been landed. Closing bug. 136851 2012-04-12 01:36:18 -0700 2012-04-12 01:36:18 -0700 sample.html for reproducing the bug. sample.html text/html 119 dsam2912 PGh0bWw+Cjxib2R5Pgo8YSBocmVmPSJodHRwOi8vd2Via2l0Lm9yZy8gIj4gd2VsY29tZSB0byB3 ZWIgd29ybGQgb2Ygd2ViIGtpdCA8L2E+CjxwPlBsYW5ldCB3ZWJraXQ8L3A+CjwvYm9keT4KPC9o dG1sPgo= 136861 2012-04-12 02:55:49 -0700 2012-04-12 03:45:21 -0700 Patch bug-83758-20120412152526.patch text/plain 1949 dsam2912 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMzk1NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA0LTEyICBTYW0gRCAg PGRzYW0yOTEyQGdtYWlsLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBOb2RlIFZhbHVl IHNob3VsZCBub3QgZ2V0IGNvcnJ1cHQgd2hpbGUganVtcCBvdmVyIGRpZmZlcmVudCBtYXRjaGVz IGluIHNlYXJjaC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTgzNzU4CisgICAgICAgIAorICAgICAgICBUaGUgb3JkZXIgaW4gd2hpY2ggdXBkYXRlRW50 cnlIaWRlIGlzIGNhbGxlZCBmb3IgY2FjaGVkCisgICAgICAgIGhpZ2hsaWdodFJlc3VsdHMgaXMg Y2hhbmdlZCBpbiAibGFzdCBjaGFuZ2VkIGZpcnN0IGNvcnJlY3RlZCIgb3JkZXIgdG8gcHJlc2Vy dmUgdGhlIHNlbWFudGljIG9mIG5vZGUuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIHJlcXVpcmVkLgorCisgICAgICAgICogaW5z cGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzOgorICAgICAgICAoV2ViSW5z cGVjdG9yLkVsZW1lbnRzVHJlZUVsZW1lbnQucHJvdG90eXBlLl91cGRhdGVTZWFyY2hIaWdobGln aHQpOgorCiAyMDEyLTA0LTEyICBDaGFybGVzIFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxl LmNvbS5jbj4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gVXBzdHJlYW1pbmcgQmxhY2tCZXJyeS1z cGVjaWZpYyBjaGFuZ2VzIHRvIFBsdWdpblZpZXcgLS0gcmVtb3ZlIHVudXNlZCBmdW5jdGlvbnMK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0 bGluZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L0VsZW1lbnRzVHJlZU91dGxpbmUuanMJKHJldmlzaW9uIDExMzcxMSkKKysrIFNvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcwkod29ya2luZyBj b3B5KQpAQCAtNjM2LDggKzYzNiwxNCBAQCBXZWJJbnNwZWN0b3IuRWxlbWVudHNUcmVlRWxlbWVu dC5wcm90b3R5CiAKICAgICAgICAgdmFyIHVwZGF0ZXIgPSBzaG93ID8gdXBkYXRlRW50cnlTaG93 IDogdXBkYXRlRW50cnlIaWRlOwogCi0gICAgICAgIGZvciAodmFyIGkgPSAwLCBzaXplID0gdGhp cy5faGlnaGxpZ2h0UmVzdWx0Lmxlbmd0aDsgaSA8IHNpemU7ICsraSkKLSAgICAgICAgICAgIHVw ZGF0ZXIodGhpcy5faGlnaGxpZ2h0UmVzdWx0W2ldKTsKKyAgICAgICAgLy8gUHJlc2VydmUgdGhl IHNlbWFudGljIG9mIG5vZGUgYnkgZm9sbG93aW5nIHRoZSBvcmRlciBvZiB1cGRhdGVzIGZvciBo aWRlIGFuZCBzaG93LgorICAgICAgICBpZiAoc2hvdykgeworICAgICAgICAgICAgZm9yICh2YXIg aSA9IDAsIHNpemUgPSB0aGlzLl9oaWdobGlnaHRSZXN1bHQubGVuZ3RoOyBpIDwgc2l6ZTsgKytp KQorICAgICAgICAgICAgICAgIHVwZGF0ZXIodGhpcy5faGlnaGxpZ2h0UmVzdWx0W2ldKTsKKyAg ICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIGZvciAodmFyIGkgPSAodGhpcy5faGlnaGxpZ2h0 UmVzdWx0Lmxlbmd0aCAtIDEpOyBpID49IDA7IC0taSkKKyAgICAgICAgICAgICAgICB1cGRhdGVy KHRoaXMuX2hpZ2hsaWdodFJlc3VsdFtpXSk7CisgICAgICAgIH0KICAgICB9LAogCiAgICAgZ2V0 IGhvdmVyZWQoKQo= 136872 2012-04-12 03:45:39 -0700 2012-04-12 06:40:11 -0700 Patch bug-83758-20120412161517.patch text/plain 1992 dsam2912 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMzk1NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA0LTEyICBTYW0gRCAg PGRzYW0yOTEyQGdtYWlsLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBOb2RlIFZhbHVl IHNob3VsZCBub3QgZ2V0IGNvcnJ1cHQgd2hpbGUganVtcCBvdmVyIGRpZmZlcmVudCBtYXRjaGVz IGluIHNlYXJjaC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTgzNzU4CisgICAgICAgIAorICAgICAgICBUaGUgb3JkZXIgaW4gd2hpY2ggdXBkYXRlRW50 cnlIaWRlIGlzIGNhbGxlZCBmb3IgY2FjaGVkCisgICAgICAgIGhpZ2hsaWdodFJlc3VsdHMgaXMg Y2hhbmdlZCBpbiAibGFzdCBjaGFuZ2VkIGZpcnN0IGNvcnJlY3RlZCIgb3JkZXIgdG8gcHJlc2Vy dmUgdGhlIHNlbWFudGljIG9mIG5vZGUuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIHJlcXVpcmVkLgorCisgICAgICAgICogaW5z cGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzOgorICAgICAgICAoV2ViSW5z cGVjdG9yLkVsZW1lbnRzVHJlZUVsZW1lbnQucHJvdG90eXBlLl91cGRhdGVTZWFyY2hIaWdobGln aHQpOgorCiAyMDEyLTA0LTEyICBDaGFybGVzIFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxl LmNvbS5jbj4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gVXBzdHJlYW1pbmcgQmxhY2tCZXJyeS1z cGVjaWZpYyBjaGFuZ2VzIHRvIFBsdWdpblZpZXcgLS0gcmVtb3ZlIHVudXNlZCBmdW5jdGlvbnMK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0 bGluZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L0VsZW1lbnRzVHJlZU91dGxpbmUuanMJKHJldmlzaW9uIDExMzcxMSkKKysrIFNvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcwkod29ya2luZyBj b3B5KQpAQCAtNjM0LDEwICs2MzQsMTQgQEAgV2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJlZUVsZW1l bnQucHJvdG90eQogICAgICAgICAgICAgfQogICAgICAgICB9CiAKLSAgICAgICAgdmFyIHVwZGF0 ZXIgPSBzaG93ID8gdXBkYXRlRW50cnlTaG93IDogdXBkYXRlRW50cnlIaWRlOwotCi0gICAgICAg IGZvciAodmFyIGkgPSAwLCBzaXplID0gdGhpcy5faGlnaGxpZ2h0UmVzdWx0Lmxlbmd0aDsgaSA8 IHNpemU7ICsraSkKLSAgICAgICAgICAgIHVwZGF0ZXIodGhpcy5faGlnaGxpZ2h0UmVzdWx0W2ld KTsKKyAgICAgICAgLy8gUHJlc2VydmUgdGhlIHNlbWFudGljIG9mIG5vZGUgYnkgZm9sbG93aW5n IHRoZSBvcmRlciBvZiB1cGRhdGVzIGZvciBoaWRlIGFuZCBzaG93LgorICAgICAgICBpZiAoc2hv dykgeworICAgICAgICAgICAgZm9yICh2YXIgaSA9IDAsIHNpemUgPSB0aGlzLl9oaWdobGlnaHRS ZXN1bHQubGVuZ3RoOyBpIDwgc2l6ZTsgKytpKQorICAgICAgICAgICAgICAgIHVwZGF0ZUVudHJ5 U2hvdyh0aGlzLl9oaWdobGlnaHRSZXN1bHRbaV0pOworICAgICAgICB9IGVsc2UgeworICAgICAg ICAgICAgZm9yICh2YXIgaSA9ICh0aGlzLl9oaWdobGlnaHRSZXN1bHQubGVuZ3RoIC0gMSk7IGkg Pj0gMDsgLS1pKQorICAgICAgICAgICAgICAgIHVwZGF0ZUVudHJ5SGlkZSh0aGlzLl9oaWdobGln aHRSZXN1bHRbaV0pOworICAgICAgICB9CiAgICAgfSwKIAogICAgIGdldCBob3ZlcmVkKCkK