<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>83753</bug_id>
          
          <creation_ts>2012-04-12 00:54:19 -0700</creation_ts>
          <short_desc>[GTK] Enable WebKit2 by default in configure</short_desc>
          <delta_ts>2012-04-16 12:36:37 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Garcia Campos">cgarcia</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>gustavo</cc>
    
    <cc>mrobinson</cc>
    
    <cc>pnormand</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>600960</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2012-04-12 00:54:19 -0700</bug_when>
    <thetext>It&apos;s currently enabled by default by webkit-build, but disabled in configure. We should enable it in configure so that unstable releases will build webkit2 by default.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>600962</commentid>
    <comment_count>1</comment_count>
      <attachid>136841</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2012-04-12 00:55:53 -0700</bug_when>
    <thetext>Created attachment 136841
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>601238</commentid>
    <comment_count>2</comment_count>
      <attachid>136841</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2012-04-12 08:11:53 -0700</bug_when>
    <thetext>Comment on attachment 136841
Patch

Exciting! We need to take care of the library versioning before the next release though.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>601842</commentid>
    <comment_count>3</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2012-04-12 23:00:29 -0700</bug_when>
    <thetext>Committed r114084: &lt;http://trac.webkit.org/changeset/114084&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>603169</commentid>
    <comment_count>4</comment_count>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2012-04-16 08:24:50 -0700</bug_when>
    <thetext>Does this mean we want distributions to start shipping webkit2? I think it would be good to make sure we state it&apos;s still unstable API-wise, but I&apos;ll be happy to ship webkit2 packages in Debian =)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>603171</commentid>
    <comment_count>5</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2012-04-16 08:26:59 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; Does this mean we want distributions to start shipping webkit2? I think it would be good to make sure we state it&apos;s still unstable API-wise, but I&apos;ll be happy to ship webkit2 packages in Debian =)

That&apos;s a good point. Perhaps we should wait to do this until the last moment. The versions of WebKit2 before the next stable release are not API stable.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>603173</commentid>
    <comment_count>6</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2012-04-16 08:30:49 -0700</bug_when>
    <thetext>I think it&apos;s up to distros to decide, we have only enabled webkit2 option in configure by default in current trunk, not in the stable branch. That means that unstable releases will build webkit2 by default, but like any other unstable release cycle, the API might change.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>603217</commentid>
    <comment_count>7</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2012-04-16 09:39:02 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; I think it&apos;s up to distros to decide, we have only enabled webkit2 option in configure by default in current trunk, not in the stable branch. That means that unstable releases will build webkit2 by default, but like any other unstable release cycle, the API might change.

We&apos;ll have to be pretty clear about this in release notes and elsewhere, becuase up to this point, we rarely break API even in unstable branches.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>603287</commentid>
    <comment_count>8</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2012-04-16 11:11:36 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; (In reply to comment #6)
&gt; &gt; I think it&apos;s up to distros to decide, we have only enabled webkit2 option in configure by default in current trunk, not in the stable branch. That means that unstable releases will build webkit2 by default, but like any other unstable release cycle, the API might change.
&gt; 
&gt; We&apos;ll have to be pretty clear about this in release notes and elsewhere, becuase up to this point, we rarely break API even in unstable branches.

Ok, I thought it was clear that the backwards compatibility guarantee only affects stable releases.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>603339</commentid>
    <comment_count>9</comment_count>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2012-04-16 12:36:37 -0700</bug_when>
    <thetext>It might just be me worrying too much. I guess it is hint enough that it&apos;s only in unstable releases.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>136841</attachid>
            <date>2012-04-12 00:55:53 -0700</date>
            <delta_ts>2012-04-12 08:11:53 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>wk-enable-webkit2-configure.diff</filename>
            <type>text/plain</type>
            <size>1005</size>
            <attacher name="Carlos Garcia Campos">cgarcia</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBhNjlmNTM1Li4wOTZlZmU3
IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK
KzIwMTItMDQtMTIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgor
CisgICAgICAgIFtHVEtdIEVuYWJsZSBXZWJLaXQyIGJ5IGRlZmF1bHQgaW4gY29uZmlndXJlCisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04Mzc1MworCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogY29uZmlndXJl
LmFjOgorCiAyMDEyLTAzLTE1ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNv
bT4KIAogICAgICAgICBbQ0FJUk9dIE1ha2UgR0xDb250ZXh0R0xYIGEgc3ViY2xhc3Mgb2YgR0xD
b250ZXh0CmRpZmYgLS1naXQgYS9jb25maWd1cmUuYWMgYi9jb25maWd1cmUuYWMKaW5kZXggN2Iz
NjVmMC4uOTg4MjhhZiAxMDA2NDQKLS0tIGEvY29uZmlndXJlLmFjCisrKyBiL2NvbmZpZ3VyZS5h
YwpAQCAtMTI1Myw4ICsxMjUzLDggQEAgZmkKICMgV2ViS2l0MgogQUNfTVNHX0NIRUNLSU5HKFt3
aGV0aGVyIHRvIGJ1aWxkIFdlYmtpdDJdKQogQUNfQVJHX0VOQUJMRSh3ZWJraXQyLAotICAgIEFD
X0hFTFBfU1RSSU5HKFstLWVuYWJsZS13ZWJraXQyXSwgW2J1aWxkIHdlYmtpdDIgW2RlZmF1bHQ9
bm9dXSksCi0gICAgW10sIFtlbmFibGVfd2Via2l0Mj0ibm8iXSkKKyAgICBBQ19IRUxQX1NUUklO
RyhbLS1lbmFibGUtd2Via2l0Ml0sIFtidWlsZCB3ZWJraXQyIFtkZWZhdWx0PXllc11dKSwKKyAg
ICBbXSwgW2VuYWJsZV93ZWJraXQyPSJ5ZXMiXSkKIEFDX01TR19SRVNVTFQoWyRlbmFibGVfd2Vi
a2l0Ml0pCiBpZiB0ZXN0ICIkZW5hYmxlX3dlYmtpdDIiID0gInllcyI7IHRoZW4KICAgIGlmIHRl
c3QgIiRHVEtfQVBJX1ZFUlNJT04iID0gIjIuMCI7IHRoZW4K
</data>
<flag name="review"
          id="141753"
          type_id="1"
          status="+"
          setter="mrobinson"
    />
          </attachment>
      

    </bug>

</bugzilla>