83744 2012-04-11 20:55:46 -0700 It is incorrect to short-circuit Branch(LogicalNot(@a)) if boolean speculations on @a may fail 2012-04-11 21:19:34 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 fpizlo webkit-unassigned oldest_to_newest 600854 0 fpizlo 2012-04-11 20:55:46 -0700 Since that would mean that the branch will OSR exit to a bytecode branch that expects the LogicalNot to already have been performed. <rdar://problem/11206946> 600856 1 136821 fpizlo 2012-04-11 20:57:18 -0700 Created attachment 136821 the patch 600861 2 fpizlo 2012-04-11 21:19:34 -0700 Landed in http://trac.webkit.org/changeset/113941 136821 2012-04-11 20:57:18 -0700 2012-04-11 21:01:12 -0700 the patch fixbranchnot_patch_1.diff text/plain 2328 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTEzOTQwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDEyLTA0LTExICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg SXQgaXMgaW5jb3JyZWN0IHRvIHNob3J0LWNpcmN1aXQgQnJhbmNoKExvZ2ljYWxOb3QoQGEpKSBp ZiBib29sZWFuIHNwZWN1bGF0aW9ucyBvbiBAYSBtYXkgZmFpbAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODM3NDQKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzExMjA2OTQ2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAg ICAgICAKKyAgICAgICAgVGhpcyBkb2VzIHRoZSBjb25zZXJ2YXRpdmUgdGhpbmc6IGl0IG9ubHkg c2hvcnQtY2lyY3VpdHMgQnJhbmNoKExvZ2ljYWxOb3QoQGEpKSBpZiBAYSBpcyBhIG5vZGUKKyAg ICAgICAgdGhhdCBpcyBzdGF0aWNhbGx5IGtub3duIHRvIHJldHVybiBib29sZWFuIHJlc3VsdHMu CisKKyAgICAgICAgKiBkZmcvREZHRml4dXBQaGFzZS5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6 Rml4dXBQaGFzZTo6Zml4dXBOb2RlKToKKwogMjAxMi0wNC0xMSAgTWljaGFlbCBTYWJvZmYgIDxt c2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBJbnZhbGlkIFVuaW9uIFJlZmVyZW5jZSBpbiBT dHJ1Y3R1cmVTdHViSW5mby57Y3BwLmh9CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZn L0RGR0ZpeHVwUGhhc2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHRml4dXBQaGFzZS5jcHAJKHJldmlzaW9uIDExMzkzNykKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHRml4dXBQaGFzZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE5NywxNCAr MTk3LDE2IEBAIHByaXZhdGU6CiAgICAgICAgICAgICBpZiAobG9naWNhbE5vdC5vcCgpID09IExv Z2ljYWxOb3QKICAgICAgICAgICAgICAgICAmJiBsb2dpY2FsTm90LmFkanVzdGVkUmVmQ291bnQo KSA9PSAxKSB7CiAgICAgICAgICAgICAgICAgRWRnZSBuZXdDaGlsZEVkZ2UgPSBsb2dpY2FsTm90 LmNoaWxkMSgpOwotICAgICAgICAgICAgICAgIG1fZ3JhcGgucmVmKG5ld0NoaWxkRWRnZSk7Ci0g ICAgICAgICAgICAgICAgbV9ncmFwaC5kZXJlZihsb2dpY2FsTm90RWRnZSk7Ci0gICAgICAgICAg ICAgICAgbXlOb2RlLmNoaWxkcmVuLnNldENoaWxkMShuZXdDaGlsZEVkZ2UpOwotICAgICAgICAg ICAgICAgIAotICAgICAgICAgICAgICAgIEJsb2NrSW5kZXggdG9CZVRha2VuID0gbXlOb2RlLm5v dFRha2VuQmxvY2tJbmRleCgpOwotICAgICAgICAgICAgICAgIEJsb2NrSW5kZXggdG9CZU5vdFRh a2VuID0gbXlOb2RlLnRha2VuQmxvY2tJbmRleCgpOwotICAgICAgICAgICAgICAgIG15Tm9kZS5z ZXRUYWtlbkJsb2NrSW5kZXgodG9CZVRha2VuKTsKLSAgICAgICAgICAgICAgICBteU5vZGUuc2V0 Tm90VGFrZW5CbG9ja0luZGV4KHRvQmVOb3RUYWtlbik7CisgICAgICAgICAgICAgICAgaWYgKG1f Z3JhcGhbbmV3Q2hpbGRFZGdlXS5oYXNCb29sZWFuUmVzdWx0KCkpIHsKKyAgICAgICAgICAgICAg ICAgICAgbV9ncmFwaC5yZWYobmV3Q2hpbGRFZGdlKTsKKyAgICAgICAgICAgICAgICAgICAgbV9n cmFwaC5kZXJlZihsb2dpY2FsTm90RWRnZSk7CisgICAgICAgICAgICAgICAgICAgIG15Tm9kZS5j aGlsZHJlbi5zZXRDaGlsZDEobmV3Q2hpbGRFZGdlKTsKKyAgICAgICAgICAgICAgICAgICAgCisg ICAgICAgICAgICAgICAgICAgIEJsb2NrSW5kZXggdG9CZVRha2VuID0gbXlOb2RlLm5vdFRha2Vu QmxvY2tJbmRleCgpOworICAgICAgICAgICAgICAgICAgICBCbG9ja0luZGV4IHRvQmVOb3RUYWtl biA9IG15Tm9kZS50YWtlbkJsb2NrSW5kZXgoKTsKKyAgICAgICAgICAgICAgICAgICAgbXlOb2Rl LnNldFRha2VuQmxvY2tJbmRleCh0b0JlVGFrZW4pOworICAgICAgICAgICAgICAgICAgICBteU5v ZGUuc2V0Tm90VGFrZW5CbG9ja0luZGV4KHRvQmVOb3RUYWtlbik7CisgICAgICAgICAgICAgICAg fQogICAgICAgICAgICAgfQogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0K