83740 2012-04-11 19:44:44 -0700 Remove style sheet argument from StyleRuleImport constructor 2015-09-11 01:52:49 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto koivisto eric glenn kling macpherson menard webkit.review.bot oldest_to_newest 600818 0 koivisto 2012-04-11 19:44:44 -0700 The styles sheet should be set when the rule is added to one. Parser should not need to know about it. 600829 1 136814 koivisto 2012-04-11 20:09:41 -0700 Created attachment 136814 patch 710303 2 glenn 2012-09-01 19:32:59 -0700 Is there a reason this is waiting for CQ+ ? 800025 3 eric 2013-01-04 00:52:42 -0800 Attachment 136814 was posted by a committer and has review+, assigning to Antti Koivisto for commit. 1125154 4 kling 2015-09-11 01:52:49 -0700 This change appears to have been landed as part of some other commit. 136814 2012-04-11 20:09:41 -0700 2012-04-12 05:17:53 -0700 patch styleruleimport-constructor.patch text/plain 5454 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMzkzNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA0LTExICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgc3R5bGUgc2hlZXQg YXJndW1lbnQgZnJvbSBTdHlsZVJ1bGVJbXBvcnQgY29uc3RydWN0b3IgCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04Mzc0MAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBzdHlsZSBzaGVldCBpcyBzZXQg d2hlbiB0aGUgcnVsZSBpcyBhZGRlZCB0byBvbmUuIFRoZSBwYXJzZXIgZG9lcyBub3QgbmVlZCB0 byBrbm93IGFib3V0IGl0LgorCisgICAgICAgICogY3NzL0NTU0ltcG9ydFJ1bGUuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6U3R5bGVSdWxlSW1wb3J0OjpTdHlsZVJ1bGVJbXBvcnQpOgorICAgICAg ICAqIGNzcy9DU1NJbXBvcnRSdWxlLmg6CisgICAgICAgIChTdHlsZVJ1bGVJbXBvcnQpOgorICAg ICAgICAoV2ViQ29yZTo6U3R5bGVSdWxlSW1wb3J0OjpzZXRQYXJlbnRTdHlsZVNoZWV0KToKKyAg ICAgICAgKiBjc3MvQ1NTUGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1BhcnNlcjo6 Y3JlYXRlSW1wb3J0UnVsZSk6CisgICAgICAgICogY3NzL0NTU1N0eWxlU2hlZXQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6U3R5bGVTaGVldEludGVybmFsOjpwYXJzZXJBcHBlbmRSdWxlKToKKyAg ICAgICAgKFdlYkNvcmU6OlN0eWxlU2hlZXRJbnRlcm5hbDo6d3JhcHBlckluc2VydFJ1bGUpOgor CiAyMDEyLTA0LTExICBKb25hdGhhbiBEb25nICA8am9uYXRoYW4uZG9uZ0B0b3JjaG1vYmlsZS5j b20uY24+CiAKICAgICAgICAgW0JsYWNrQmVycnldIE1NUlBsYXllciB3aWxsIGhhbmcgd2Via2l0 IHRocmVhZCB3aGVuIHJldHJpZXZpbmcgbWVkaWEgbWV0YWRhdGEKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL2Nzcy9DU1NJbXBvcnRSdWxlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9j c3MvQ1NTSW1wb3J0UnVsZS5jcHAJKHJldmlzaW9uIDExMzkyMikKKysrIFNvdXJjZS9XZWJDb3Jl L2Nzcy9DU1NJbXBvcnRSdWxlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzMsMjEgKzMzLDIwIEBA CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotUGFzc1JlZlB0cjxTdHlsZVJ1bGVJbXBvcnQ+IFN0 eWxlUnVsZUltcG9ydDo6Y3JlYXRlKFN0eWxlU2hlZXRJbnRlcm5hbCogcGFyZW50LCBjb25zdCBT dHJpbmcmIGhyZWYsIFBhc3NSZWZQdHI8TWVkaWFRdWVyeVNldD4gbWVkaWEpCitQYXNzUmVmUHRy PFN0eWxlUnVsZUltcG9ydD4gU3R5bGVSdWxlSW1wb3J0OjpjcmVhdGUoY29uc3QgU3RyaW5nJiBo cmVmLCBQYXNzUmVmUHRyPE1lZGlhUXVlcnlTZXQ+IG1lZGlhKQogewotICAgIHJldHVybiBhZG9w dFJlZihuZXcgU3R5bGVSdWxlSW1wb3J0KHBhcmVudCwgaHJlZiwgbWVkaWEpKTsKKyAgICByZXR1 cm4gYWRvcHRSZWYobmV3IFN0eWxlUnVsZUltcG9ydChocmVmLCBtZWRpYSkpOwogfQogCi1TdHls ZVJ1bGVJbXBvcnQ6OlN0eWxlUnVsZUltcG9ydChTdHlsZVNoZWV0SW50ZXJuYWwqIHBhcmVudCwg Y29uc3QgU3RyaW5nJiBocmVmLCBQYXNzUmVmUHRyPE1lZGlhUXVlcnlTZXQ+IG1lZGlhKQorU3R5 bGVSdWxlSW1wb3J0OjpTdHlsZVJ1bGVJbXBvcnQoY29uc3QgU3RyaW5nJiBocmVmLCBQYXNzUmVm UHRyPE1lZGlhUXVlcnlTZXQ+IG1lZGlhKQogICAgIDogU3R5bGVSdWxlQmFzZShJbXBvcnQsIDAp Ci0gICAgLCBtX3BhcmVudFN0eWxlU2hlZXQocGFyZW50KQorICAgICwgbV9wYXJlbnRTdHlsZVNo ZWV0KDApCiAgICAgLCBtX3N0eWxlU2hlZXRDbGllbnQodGhpcykKICAgICAsIG1fc3RySHJlZiho cmVmKQogICAgICwgbV9tZWRpYVF1ZXJpZXMobWVkaWEpCiAgICAgLCBtX2NhY2hlZFNoZWV0KDAp CiAgICAgLCBtX2xvYWRpbmcoZmFsc2UpCiB7Ci0gICAgQVNTRVJUKHBhcmVudCk7CiAgICAgaWYg KCFtX21lZGlhUXVlcmllcykKICAgICAgICAgbV9tZWRpYVF1ZXJpZXMgPSBNZWRpYVF1ZXJ5U2V0 OjpjcmVhdGUoU3RyaW5nKCkpOwogfQpJbmRleDogU291cmNlL1dlYkNvcmUvY3NzL0NTU0ltcG9y dFJ1bGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTSW1wb3J0UnVsZS5o CShyZXZpc2lvbiAxMTM5MjIpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTSW1wb3J0UnVsZS5o CSh3b3JraW5nIGNvcHkpCkBAIC0zNywxMSArMzcsMTIgQEAgY2xhc3MgU3R5bGVTaGVldEludGVy bmFsOwogCiBjbGFzcyBTdHlsZVJ1bGVJbXBvcnQgOiBwdWJsaWMgU3R5bGVSdWxlQmFzZSB7CiBw dWJsaWM6Ci0gICAgc3RhdGljIFBhc3NSZWZQdHI8U3R5bGVSdWxlSW1wb3J0PiBjcmVhdGUoU3R5 bGVTaGVldEludGVybmFsKiBwYXJlbnQsIGNvbnN0IFN0cmluZyYgaHJlZiwgUGFzc1JlZlB0cjxN ZWRpYVF1ZXJ5U2V0Pik7CisgICAgc3RhdGljIFBhc3NSZWZQdHI8U3R5bGVSdWxlSW1wb3J0PiBj cmVhdGUoY29uc3QgU3RyaW5nJiBocmVmLCBQYXNzUmVmUHRyPE1lZGlhUXVlcnlTZXQ+KTsKIAog ICAgIH5TdHlsZVJ1bGVJbXBvcnQoKTsKICAgICAKICAgICBTdHlsZVNoZWV0SW50ZXJuYWwqIHBh cmVudFN0eWxlU2hlZXQoKSBjb25zdCB7IHJldHVybiBtX3BhcmVudFN0eWxlU2hlZXQ7IH0KKyAg ICB2b2lkIHNldFBhcmVudFN0eWxlU2hlZXQoU3R5bGVTaGVldEludGVybmFsKiBzaGVldCkgeyBB U1NFUlQoc2hlZXQpOyBtX3BhcmVudFN0eWxlU2hlZXQgPSBzaGVldDsgfQogICAgIHZvaWQgY2xl YXJQYXJlbnRTdHlsZVNoZWV0KCkgeyBtX3BhcmVudFN0eWxlU2hlZXQgPSAwOyB9CiAKICAgICBT dHJpbmcgaHJlZigpIGNvbnN0IHsgcmV0dXJuIG1fc3RySHJlZjsgfQpAQCAtNzEsNyArNzIsNyBA QCBwcml2YXRlOgogICAgIHZvaWQgc2V0Q1NTU3R5bGVTaGVldChjb25zdCBTdHJpbmcmIGhyZWYs IGNvbnN0IEtVUkwmIGJhc2VVUkwsIGNvbnN0IFN0cmluZyYgY2hhcnNldCwgY29uc3QgQ2FjaGVk Q1NTU3R5bGVTaGVldCopOwogICAgIGZyaWVuZCBjbGFzcyBJbXBvcnRlZFN0eWxlU2hlZXRDbGll bnQ7CiAKLSAgICBTdHlsZVJ1bGVJbXBvcnQoU3R5bGVTaGVldEludGVybmFsKiBwYXJlbnQsIGNv bnN0IFN0cmluZyYgaHJlZiwgUGFzc1JlZlB0cjxNZWRpYVF1ZXJ5U2V0Pik7CisgICAgU3R5bGVS dWxlSW1wb3J0KGNvbnN0IFN0cmluZyYgaHJlZiwgUGFzc1JlZlB0cjxNZWRpYVF1ZXJ5U2V0Pik7 CiAKICAgICBTdHlsZVNoZWV0SW50ZXJuYWwqIG1fcGFyZW50U3R5bGVTaGVldDsKIApJbmRleDog U291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvY3NzL0NTU1BhcnNlci5jcHAJKHJldmlzaW9uIDExMzkyMikKKysrIFNvdXJjZS9XZWJD b3JlL2Nzcy9DU1NQYXJzZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05MDAyLDkgKzkwMDIsOSBA QCBNZWRpYVF1ZXJ5U2V0KiBDU1NQYXJzZXI6OmNyZWF0ZU1lZGlhUXVlCiAKIFN0eWxlUnVsZUJh c2UqIENTU1BhcnNlcjo6Y3JlYXRlSW1wb3J0UnVsZShjb25zdCBDU1NQYXJzZXJTdHJpbmcmIHVy bCwgTWVkaWFRdWVyeVNldCogbWVkaWEpCiB7Ci0gICAgaWYgKCFtZWRpYSB8fCAhbV9zdHlsZVNo ZWV0IHx8ICFtX2FsbG93SW1wb3J0UnVsZXMpCisgICAgaWYgKCFtZWRpYSB8fCAhbV9hbGxvd0lt cG9ydFJ1bGVzKQogICAgICAgICByZXR1cm4gMDsKLSAgICBSZWZQdHI8U3R5bGVSdWxlSW1wb3J0 PiBydWxlID0gU3R5bGVSdWxlSW1wb3J0OjpjcmVhdGUobV9zdHlsZVNoZWV0LCB1cmwsIG1lZGlh KTsKKyAgICBSZWZQdHI8U3R5bGVSdWxlSW1wb3J0PiBydWxlID0gU3R5bGVSdWxlSW1wb3J0Ojpj cmVhdGUodXJsLCBtZWRpYSk7CiAgICAgU3R5bGVSdWxlSW1wb3J0KiByZXN1bHQgPSBydWxlLmdl dCgpOwogICAgIG1fcGFyc2VkUnVsZXMuYXBwZW5kKHJ1bGUucmVsZWFzZSgpKTsKICAgICByZXR1 cm4gcmVzdWx0OwpJbmRleDogU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2hlZXQuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNoZWV0LmNwcAkocmV2aXNp b24gMTEzOTIyKQorKysgU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2hlZXQuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xMTYsNiArMTE2LDcgQEAgdm9pZCBTdHlsZVNoZWV0SW50ZXJuYWw6OnBh cnNlckFwcGVuZFJ1bAogICAgICAgICAvLyBQYXJzZXIgZW5mb3JjZXMgdGhhdCBAaW1wb3J0IHJ1 bGVzIGNvbWUgYmVmb3JlIGFueXRoaW5nIGVsc2UgZXhjZXB0IEBjaGFyc2V0LgogICAgICAgICBB U1NFUlQobV9jaGlsZFJ1bGVzLmlzRW1wdHkoKSk7CiAgICAgICAgIG1faW1wb3J0UnVsZXMuYXBw ZW5kKHN0YXRpY19jYXN0PFN0eWxlUnVsZUltcG9ydCo+KHJ1bGUuZ2V0KCkpKTsKKyAgICAgICAg bV9pbXBvcnRSdWxlcy5sYXN0KCktPnNldFBhcmVudFN0eWxlU2hlZXQodGhpcyk7CiAgICAgICAg IG1faW1wb3J0UnVsZXMubGFzdCgpLT5yZXF1ZXN0U3R5bGVTaGVldCgpOwogICAgICAgICByZXR1 cm47CiAgICAgfQpAQCAtMTkyLDYgKzE5Myw3IEBAIGJvb2wgU3R5bGVTaGVldEludGVybmFsOjp3 cmFwcGVySW5zZXJ0UnUKICAgICAgICAgaWYgKCFydWxlLT5pc0ltcG9ydFJ1bGUoKSkKICAgICAg ICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgbV9pbXBvcnRSdWxlcy5pbnNlcnQoY2hpbGRW ZWN0b3JJbmRleCwgc3RhdGljX2Nhc3Q8U3R5bGVSdWxlSW1wb3J0Kj4ocnVsZS5nZXQoKSkpOwor ICAgICAgICBtX2ltcG9ydFJ1bGVzW2NoaWxkVmVjdG9ySW5kZXhdLT5zZXRQYXJlbnRTdHlsZVNo ZWV0KHRoaXMpOwogICAgICAgICBtX2ltcG9ydFJ1bGVzW2NoaWxkVmVjdG9ySW5kZXhdLT5yZXF1 ZXN0U3R5bGVTaGVldCgpOwogICAgICAgICAvLyBGSVhNRTogU3R5bGVzaGVldCBkb2Vzbid0IGFj dHVhbGx5IGNoYW5nZSBtZWFuaW5nZnVsbHkgYmVmb3JlIHRoZSBpbXBvcnRlZCBzaGVldHMgYXJl IGxvYWRlZC4KICAgICAgICAgc3R5bGVTaGVldENoYW5nZWQoKTsK