83735 2012-04-11 17:23:49 -0700 Invalid Union Reference in StructureStubInfo.{cpp.h} 2012-04-11 18:39:02 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff webkit.review.bot oldest_to_newest 600748 0 msaboff 2012-04-11 17:23:49 -0700 There are two places that u.getByIdProtoList and u.getByIdSelfList are mixed in StructureStubInfo.h and .cpp. Since these union members are copies, this doesn't cause any issues but should be cleaned up. 600750 1 136796 msaboff 2012-04-11 17:26:06 -0700 Created attachment 136796 Patch 600790 2 136796 webkit.review.bot 2012-04-11 18:38:58 -0700 Comment on attachment 136796 Patch Clearing flags on attachment: 136796 Committed r113935: <http://trac.webkit.org/changeset/113935> 600791 3 webkit.review.bot 2012-04-11 18:39:02 -0700 All reviewed patches have been landed. Closing bug. 136796 2012-04-11 17:26:06 -0700 2012-04-11 18:38:58 -0700 Patch 83735.patch text/plain 2276 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTEzOTI3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDEyLTA0LTExICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEludmFsaWQgVW5pb24gUmVmZXJlbmNlIGluIFN0cnVjdHVyZVN0dWJJbmZvLntjcHAuaH0K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzNzM1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlZCB0 aGUgcmVmZXJlbmNlcyB0byB1LmdldEJ5SWRQcm90b0xpc3QgYW5kIHUuZ2V0QnlJZFNlbGZMaXN0 CisgICAgICAgIHRvIGJlIGNvbnNpc3RlbnQuCisKKyAgICAgICAgKiBieXRlY29kZS9TdHJ1Y3R1 cmVTdHViSW5mby5jcHA6CisgICAgICAgIChKU0M6OlN0cnVjdHVyZVN0dWJJbmZvOjp2aXNpdFdl YWtSZWZlcmVuY2VzKToKKyAgICAgICAgKiBieXRlY29kZS9TdHJ1Y3R1cmVTdHViSW5mby5oOgor ICAgICAgICAoSlNDOjpTdHJ1Y3R1cmVTdHViSW5mbzo6aW5pdEdldEJ5SWRTZWxmTGlzdCk6CisK IDIwMTItMDQtMTEgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBT cGVjdWxhdGl2ZUpJVDo6ZmlsbFN0b3JhZ2UoKSBzaG91bGQgd29yayB3aXRoIGFsbCB0aGUgc3Rh dGVzIHRoYXQgYSBjZWxsIG1heSBiZSBpbgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5 dGVjb2RlL1N0cnVjdHVyZVN0dWJJbmZvLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvYnl0ZWNvZGUvU3RydWN0dXJlU3R1YkluZm8uY3BwCShyZXZpc2lvbiAxMTM5MDIp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvU3RydWN0dXJlU3R1YkluZm8uY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC05Miw3ICs5Miw3IEBAIGJvb2wgU3RydWN0dXJlU3R1YkluZm86 OnZpc2l0V2Vha1JlZmVyZW4KICAgICB9CiAgICAgY2FzZSBhY2Nlc3NfZ2V0X2J5X2lkX3Byb3Rv X2xpc3Q6IHsKICAgICAgICAgUG9seW1vcnBoaWNBY2Nlc3NTdHJ1Y3R1cmVMaXN0KiBwb2x5bW9y cGhpY1N0cnVjdHVyZXMgPSB1LmdldEJ5SWRQcm90b0xpc3Quc3RydWN0dXJlTGlzdDsKLSAgICAg ICAgaWYgKCFwb2x5bW9ycGhpY1N0cnVjdHVyZXMtPnZpc2l0V2Vhayh1LmdldEJ5SWRTZWxmTGlz dC5saXN0U2l6ZSkpCisgICAgICAgIGlmICghcG9seW1vcnBoaWNTdHJ1Y3R1cmVzLT52aXNpdFdl YWsodS5nZXRCeUlkUHJvdG9MaXN0Lmxpc3RTaXplKSkKICAgICAgICAgICAgIHJldHVybiBmYWxz ZTsKICAgICAgICAgYnJlYWs7CiAgICAgfQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5 dGVjb2RlL1N0cnVjdHVyZVN0dWJJbmZvLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL2J5dGVjb2RlL1N0cnVjdHVyZVN0dWJJbmZvLmgJKHJldmlzaW9uIDExMzkwMikKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9TdHJ1Y3R1cmVTdHViSW5mby5oCSh3b3Jr aW5nIGNvcHkpCkBAIC0xMjIsOCArMTIyLDggQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIHsK ICAgICAgICAgICAgIGFjY2Vzc1R5cGUgPSBhY2Nlc3NfZ2V0X2J5X2lkX3NlbGZfbGlzdDsKIAot ICAgICAgICAgICAgdS5nZXRCeUlkUHJvdG9MaXN0LnN0cnVjdHVyZUxpc3QgPSBzdHJ1Y3R1cmVM aXN0OwotICAgICAgICAgICAgdS5nZXRCeUlkUHJvdG9MaXN0Lmxpc3RTaXplID0gbGlzdFNpemU7 CisgICAgICAgICAgICB1LmdldEJ5SWRTZWxmTGlzdC5zdHJ1Y3R1cmVMaXN0ID0gc3RydWN0dXJl TGlzdDsKKyAgICAgICAgICAgIHUuZ2V0QnlJZFNlbGZMaXN0Lmxpc3RTaXplID0gbGlzdFNpemU7 CiAgICAgICAgIH0KIAogICAgICAgICB2b2lkIGluaXRHZXRCeUlkUHJvdG9MaXN0KFBvbHltb3Jw aGljQWNjZXNzU3RydWN0dXJlTGlzdCogc3RydWN0dXJlTGlzdCwgaW50IGxpc3RTaXplKQo=