83731 2012-04-11 16:59:44 -0700 [chromium] Fix Windows warnings in WebSocketDeflaterTest 2012-04-11 18:55:58 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enne bashi tkent webkit.review.bot oldest_to_newest 600724 0 enne 2012-04-11 16:59:44 -0700 When building webkit_unit_tests locally on Windows at ToT: 6>.\tests\WebSocketDeflaterTest.cpp(49) : warning C4309: 'initializing' : truncation of constant value 6>.\tests\WebSocketDeflaterTest.cpp(49) : warning C4309: 'initializing' : truncation of constant value 6>.\tests\WebSocketDeflaterTest.cpp(49) : warning C4309: 'initializing' : truncation of constant value 6>.\tests\WebSocketDeflaterTest.cpp(49) : warning C4309: 'initializing' : truncation of constant value 6>.\tests\WebSocketDeflaterTest.cpp(62) : warning C4309: 'initializing' : truncation of constant value 6>.\tests\WebSocketDeflaterTest.cpp(96) : warning C4309: 'initializing' : truncation of constant value 6>.\tests\WebSocketDeflaterTest.cpp(96) : warning C4309: 'initializing' : truncation of constant value 6>.\tests\WebSocketDeflaterTest.cpp(96) : warning C4309: 'initializing' : truncation of constant value 6>.\tests\WebSocketDeflaterTest.cpp(96) : warning C4309: 'initializing' : truncation of constant value 600762 1 136800 bashi 2012-04-11 17:44:53 -0700 Created attachment 136800 Patch 600764 2 bashi 2012-04-11 17:50:47 -0700 Kent-san, could you take a look? 600766 3 136800 tkent 2012-04-11 17:56:16 -0700 Comment on attachment 136800 Patch ok 600800 4 136800 webkit.review.bot 2012-04-11 18:55:54 -0700 Comment on attachment 136800 Patch Clearing flags on attachment: 136800 Committed r113936: <http://trac.webkit.org/changeset/113936> 600801 5 webkit.review.bot 2012-04-11 18:55:58 -0700 All reviewed patches have been landed. Closing bug. 136800 2012-04-11 17:44:53 -0700 2012-04-11 18:55:53 -0700 Patch bug-83731-20120412094451.patch text/plain 3292 bashi U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzOTI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDFiYmE5NTVjOTQxMzEzMjI0NDU3NTg0ZDFhMTgwMWFmYmJiYWFlMmMuLmE0NzVjNzcxNGNjMWYw YWMxOWFiODE3MTFiZmY4YWRiNTczNzYyMGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMDQtMTEgIEtlbmljaGkgSXNoaWJhc2hpICA8YmFzaGlAY2hy b21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gRml4IFdpbmRvd3Mgd2FybmluZ3MgaW4g V2ViU29ja2V0RGVmbGF0ZXJUZXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04MzczMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFVzZSBjb25zdCBjaGFyKiBpbnN0ZWFkIG9mIGNvbnN0IGNoYXJbXSB0byBz dXBwcmVzcyB3YXJuaW5ncyBvbgorICAgICAgICBXaW5kb3dzLgorCisgICAgICAgICogdGVzdHMv V2ViU29ja2V0RGVmbGF0ZXJUZXN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRFU1QpOgorCiAy MDEyLTA0LTExICBEYXZpZCBEb3J3aW4gIDxkZG9yd2luQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBBZGQga2V5U3lzdGVtIGF0dHJpYnV0ZSB0byBjYW5QbGF5VHlwZSgpIGZvciBFbmNyeXB0ZWQg TWVkaWEgRXh0ZW5zaW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0 cy9XZWJTb2NrZXREZWZsYXRlclRlc3QuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0 cy9XZWJTb2NrZXREZWZsYXRlclRlc3QuY3BwCmluZGV4IDQyM2E1OTY5ZmQyNWI3Nzc3NWUwYzUz YzdhODI2NzMzZjU2MTIwMzguLjFkNzgyNmE2OTNjMzAzZjVlM2NhOTBkNzJmY2ZkODFiYTA2OWY2 MTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvV2ViU29ja2V0RGVm bGF0ZXJUZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1dlYlNvY2tl dERlZmxhdGVyVGVzdC5jcHAKQEAgLTQ2LDggKzQ2LDggQEAgVEVTVChXZWJTb2NrZXREZWZsYXRl clRlc3QsIFRlc3RDb21wcmVzc0hlbGxvKQogCiAgICAgQVNTRVJUX1RSVUUoZGVmbGF0ZXItPmFk ZEJ5dGVzKGlucHV0RGF0YSwgaW5wdXRMZW5ndGgpKTsKICAgICBBU1NFUlRfVFJVRShkZWZsYXRl ci0+ZmluaXNoKCkpOwotICAgIGNvbnN0IGNoYXIgZXhwZWN0ZWRGaXJzdFtdID0gezB4ZjIsIDB4 NDgsIDB4Y2QsIDB4YzksIDB4YzksIDB4MDcsIDB4MDB9OwotICAgIEVYUEVDVF9FUShzaXplb2Yo ZXhwZWN0ZWRGaXJzdCksIGRlZmxhdGVyLT5zaXplKCkpOworICAgIGNvbnN0IGNoYXIqIGV4cGVj dGVkRmlyc3QgPSAiXHhmMlx4NDhceGNkXHhjOVx4YzlceDA3XHgwMCI7CisgICAgRVhQRUNUX0VR KDdVLCBkZWZsYXRlci0+c2l6ZSgpKTsKICAgICBFWFBFQ1RfRVEoMCwgbWVtY21wKGV4cGVjdGVk Rmlyc3QsIGRlZmxhdGVyLT5kYXRhKCksIGRlZmxhdGVyLT5zaXplKCkpKTsKICAgICBBU1NFUlRf VFJVRShpbmZsYXRlci0+YWRkQnl0ZXMoZGVmbGF0ZXItPmRhdGEoKSwgZGVmbGF0ZXItPnNpemUo KSkpOwogICAgIEFTU0VSVF9UUlVFKGluZmxhdGVyLT5maW5pc2goKSk7CkBAIC01OSw4ICs1OSw4 IEBAIFRFU1QoV2ViU29ja2V0RGVmbGF0ZXJUZXN0LCBUZXN0Q29tcHJlc3NIZWxsbykKIAogICAg IEFTU0VSVF9UUlVFKGRlZmxhdGVyLT5hZGRCeXRlcyhpbnB1dERhdGEsIGlucHV0TGVuZ3RoKSk7 CiAgICAgQVNTRVJUX1RSVUUoZGVmbGF0ZXItPmZpbmlzaCgpKTsKLSAgICBjb25zdCBjaGFyIGV4 cGVjdGVkU2Vjb25kW10gPSB7MHhmMiwgMHgwMCwgMHgxMSwgMHgwMCwgMHgwMH07Ci0gICAgRVhQ RUNUX0VRKHNpemVvZihleHBlY3RlZFNlY29uZCksIGRlZmxhdGVyLT5zaXplKCkpOworICAgIGNv bnN0IGNoYXIqIGV4cGVjdGVkU2Vjb25kID0gIlx4ZjJceDAwXHgxMVx4MDBceDAwIjsKKyAgICBF WFBFQ1RfRVEoNVUsIGRlZmxhdGVyLT5zaXplKCkpOwogICAgIEVYUEVDVF9FUSgwLCBtZW1jbXAo ZXhwZWN0ZWRTZWNvbmQsIGRlZmxhdGVyLT5kYXRhKCksIGRlZmxhdGVyLT5zaXplKCkpKTsKICAg ICBBU1NFUlRfVFJVRShpbmZsYXRlci0+YWRkQnl0ZXMoZGVmbGF0ZXItPmRhdGEoKSwgZGVmbGF0 ZXItPnNpemUoKSkpOwogICAgIEFTU0VSVF9UUlVFKGluZmxhdGVyLT5maW5pc2goKSk7CkBAIC05 Myw3ICs5Myw3IEBAIFRFU1QoV2ViU29ja2V0RGVmbGF0ZXJUZXN0LCBUZXN0Tm9Db250ZXh0VGFr ZU92ZXIpCiAgICAgQVNTRVJUX1RSVUUoZGVmbGF0ZXItPmluaXRpYWxpemUoKSk7CiAgICAgT3du UHRyPFdlYlNvY2tldEluZmxhdGVyPiBpbmZsYXRlciA9IFdlYlNvY2tldEluZmxhdGVyOjpjcmVh dGUoKTsKICAgICBBU1NFUlRfVFJVRShpbmZsYXRlci0+aW5pdGlhbGl6ZSgpKTsKLSAgICBjb25z dCBjaGFyIGV4cGVjdGVkW10gPSB7MHhmMiwgMHg0OCwgMHhjZCwgMHhjOSwgMHhjOSwgMHgwNywg MHgwMH07CisgICAgY29uc3QgY2hhciogZXhwZWN0ZWQgPSAiXHhmMlx4NDhceGNkXHhjOVx4Yzlc eDA3XHgwMCI7CiAgICAgY29uc3QgY2hhciogaW5wdXREYXRhID0gIkhlbGxvIjsKICAgICBjb25z dCBzaXplX3QgaW5wdXRMZW5ndGggPSBzdHJsZW4oaW5wdXREYXRhKTsKIApAQCAtMTAyLDcgKzEw Miw3IEBAIFRFU1QoV2ViU29ja2V0RGVmbGF0ZXJUZXN0LCBUZXN0Tm9Db250ZXh0VGFrZU92ZXIp CiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCAyOyArK2kpIHsKICAgICAgICAgQVNTRVJUX1RS VUUoZGVmbGF0ZXItPmFkZEJ5dGVzKGlucHV0RGF0YSwgaW5wdXRMZW5ndGgpKTsKICAgICAgICAg QVNTRVJUX1RSVUUoZGVmbGF0ZXItPmZpbmlzaCgpKTsKLSAgICAgICAgRVhQRUNUX0VRKHNpemVv ZihleHBlY3RlZCksIGRlZmxhdGVyLT5zaXplKCkpOworICAgICAgICBFWFBFQ1RfRVEoN1UsIGRl ZmxhdGVyLT5zaXplKCkpOwogICAgICAgICBFWFBFQ1RfRVEoMCwgbWVtY21wKGV4cGVjdGVkLCBk ZWZsYXRlci0+ZGF0YSgpLCBkZWZsYXRlci0+c2l6ZSgpKSk7CiAgICAgICAgIEFTU0VSVF9UUlVF KGluZmxhdGVyLT5hZGRCeXRlcyhkZWZsYXRlci0+ZGF0YSgpLCBkZWZsYXRlci0+c2l6ZSgpKSk7 CiAgICAgICAgIEFTU0VSVF9UUlVFKGluZmxhdGVyLT5maW5pc2goKSk7Cg==