83725 2012-04-11 15:28:29 -0700 ThreadingWin: Mutex::unlock() can be "over-unlocked". 2012-04-12 13:35:40 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble levin+threading webkit.review.bot oldest_to_newest 600639 0 jer.noble 2012-04-11 15:28:29 -0700 Unlocking a Mutex more times than it's m_recursionCount will result in the m_recursionCount wrapping around to MAX_INT. There should be at least an ASSERT(m_recursionCount) in Mutex::unlock(), if not an explicit: "if (m_recursionCount) --resursionCount;" 601409 1 136949 jer.noble 2012-04-12 11:59:22 -0700 Created attachment 136949 Patch 601492 2 136949 webkit.review.bot 2012-04-12 13:35:36 -0700 Comment on attachment 136949 Patch Clearing flags on attachment: 136949 Committed r114028: <http://trac.webkit.org/changeset/114028> 601493 3 webkit.review.bot 2012-04-12 13:35:40 -0700 All reviewed patches have been landed. Closing bug. 136949 2012-04-12 11:59:22 -0700 2012-04-12 13:35:36 -0700 Patch bug-83725-20120412115921.patch text/plain 1593 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0MDA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDJhMTQ1NzgxYTU4YTdkNjE4ZmI5MDMw NWYyMDNmYWQ2Y2EyZmYxMGQuLmFjOTA0MzU0OWE3MGViNzgxOWMyMzc0MDIxMjg5NDIxZGQyNWMx MTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMDQtMTIgIEplciBOb2JsZSAgPGplci5ub2Js ZUBhcHBsZS5jb20+CisKKyAgICAgICAgVGhyZWFkaW5nV2luOiBNdXRleDo6dW5sb2NrKCkgY2Fu IGJlICJvdmVyLXVubG9ja2VkIi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTgzNzI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgSW4gb3JkZXIgdG8gc3VwcG9ydCB0aGUgYmVoYXZpb3Igb2YgcHRocmVhZF9t dXRleF90cnlsb2NrKCksIHRoZSBXaW5kb3dzIE11dGV4IGNsYXNzIGluY2x1ZGVzCisgICAgICAg IGEgcmVjdXJzaW9uIGNvdW50ZXIgd2hpY2ggaXMgaW5jcmVtZW50ZWQgaW4gTXV0ZXg6OmxvY2so KSwgZGVjcmVtZW50ZWQgaW4gTXV0ZXg6OnVubG9jaygpLAorICAgICAgICBhbmQgY2hlY2tlZCBp biBNdXRleDo6dHJ5TG9jaygpLiAgSWYgdGhlIG11dGV4IGlzICJvdmVyLXVubG9ja2VkIiwgdGhl IGNvdW50ZXIgd3JhcHMgYXJvdW5kIHRvCisgICAgICAgIE1BWF9JTlQsIGFuZCBzdWJzZXF1ZW50 IGNhbGxzIHRvIE11dGV4Ojp0cnlsb2NrKCkgd2lsbCBmYWlsLiBSYWlzZSBhbiBBU1NFUlQgaW4g dGhpcyBzaXR1YXRpb24KKyAgICAgICAgc28gdGhlICJvdmVyLXVubG9jayIgd2lsbCBiZSBjYXVn aHQuCisKKyAgICAgICAgKiB3dGYvVGhyZWFkaW5nV2luLmNwcDoKKyAgICAgICAgKFdURjo6TXV0 ZXg6OnVubG9jayk6IEFTU0VSVCBpZiB1bmxvY2tpbmcgYSBub24tbG9ja2VkIG11dGV4LgorCiAy MDEyLTA0LTEwICBNYXJrIFJvd2UgIDxtcm93ZUBhcHBsZS5jb20+CiAKICAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzEwNTgzNzQ5PiBXZWJLaXQyIHNob3VsZCBsb2cgdG8gYm90aCBBU0wgYW5kIHN0 ZGVycgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvVGhyZWFkaW5nV2luLmNwcCBiL1NvdXJj ZS9XVEYvd3RmL1RocmVhZGluZ1dpbi5jcHAKaW5kZXggYmMzMjI2MmNlMDc3MGNhY2I0OTNiZGU3 N2ZiZDAyOTdkZDA2ODE5Yi4uNDQ0NDgyN2QzYjIxZGQ5NzZhMzQ4N2ZhNWQ1OGNlZWUwMDY0ODRm NyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvVGhyZWFkaW5nV2luLmNwcAorKysgYi9Tb3Vy Y2UvV1RGL3d0Zi9UaHJlYWRpbmdXaW4uY3BwCkBAIC0zMzUsNiArMzM1LDcgQEAgYm9vbCBNdXRl eDo6dHJ5TG9jaygpCiAKIHZvaWQgTXV0ZXg6OnVubG9jaygpCiB7CisgICAgQVNTRVJUKG1fbXV0 ZXgubV9yZWN1cnNpb25Db3VudCk7CiAgICAgLS1tX211dGV4Lm1fcmVjdXJzaW9uQ291bnQ7CiAg ICAgTGVhdmVDcml0aWNhbFNlY3Rpb24oJm1fbXV0ZXgubV9pbnRlcm5hbE11dGV4KTsKIH0K