83708 2012-04-11 11:48:00 -0700 Crash in CSSStyleSheet::deleteRule 2012-04-11 13:04:12 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned kling macpherson menard webkit.review.bot oldest_to_newest 600455 0 koivisto 2012-04-11 11:48:00 -0700 The wrapper needs to be null checked before calling setParentStyleSheet(0). 600518 1 136732 koivisto 2012-04-11 12:58:33 -0700 Created attachment 136732 patch 600519 2 136732 kling 2012-04-11 12:59:45 -0700 Comment on attachment 136732 patch View in context: https://bugs.webkit.org/attachment.cgi?id=136732&action=review > Source/WebCore/ChangeLog:8 > + Andreas spotted that the wrapper needs to be null checked before calling setParentStyleSheet(0). Sounds like a clever guy! 600524 3 koivisto 2012-04-11 13:04:12 -0700 http://trac.webkit.org/changeset/113898 136732 2012-04-11 12:58:33 -0700 2012-04-11 12:59:45 -0700 patch delete-rule-crash.patch text/plain 2790 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMzg4NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA0LTExICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCBpbiBDU1NTdHlsZVNo ZWV0OjpkZWxldGVSdWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04MzcwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAg ICAgICAKKyAgICAgICAgQW5kcmVhcyBzcG90dGVkIHRoYXQgdGhlIHdyYXBwZXIgbmVlZHMgdG8g YmUgbnVsbCBjaGVja2VkIGJlZm9yZSBjYWxsaW5nIHNldFBhcmVudFN0eWxlU2hlZXQoMCkuCisK KyAgICAgICAgVGVzdDogZmFzdC9jc3MvZGVsZXRlLXJ1bGUtY3Jhc2guaHRtbAorCisgICAgICAg ICogY3NzL0NTU1N0eWxlU2hlZXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTU3R5bGVTaGVl dDo6ZGVsZXRlUnVsZSk6CisKIDIwMTItMDQtMTEgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUu Y29tPgogCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 MzYxNApJbmRleDogU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2hlZXQuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNoZWV0LmNwcAkocmV2aXNpb24gMTEz ODUxKQorKysgU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2hlZXQuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0zMTcsNyArMzE3LDggQEAgdm9pZCBDU1NTdHlsZVNoZWV0OjpkZWxldGVSdWxlKHVu c2lnbmVkIAogCiBzdWNjZXNzOgogICAgIGlmICghbV9jaGlsZFJ1bGVDU1NPTVdyYXBwZXJzLmlz RW1wdHkoKSkgewotICAgICAgICBtX2NoaWxkUnVsZUNTU09NV3JhcHBlcnNbaW5kZXhdLT5zZXRQ YXJlbnRTdHlsZVNoZWV0KDApOworICAgICAgICBpZiAobV9jaGlsZFJ1bGVDU1NPTVdyYXBwZXJz W2luZGV4XSkKKyAgICAgICAgICAgIG1fY2hpbGRSdWxlQ1NTT01XcmFwcGVyc1tpbmRleF0tPnNl dFBhcmVudFN0eWxlU2hlZXQoMCk7CiAgICAgICAgIG1fY2hpbGRSdWxlQ1NTT01XcmFwcGVycy5y ZW1vdmUoaW5kZXgpOwogICAgIH0KIApJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTEzODg1KQorKysgTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTIt MDQtMTEgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgorCisgICAgICAgIENyYXNo IGluIENTU1N0eWxlU2hlZXQ6OmRlbGV0ZVJ1bGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTgzNzA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2Nzcy9kZWxldGUtcnVsZS1jcmFzaC5odG1sOiBB ZGRlZC4KKyAgICAgICAgKiBmYXN0L2Nzcy9kZWxldGUtcnVsZS1jcmFzaC1leHBlY3RlZC50eHQ6 IEFkZGVkLgorCiAyMDEyLTA0LTExICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAog ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODM2MTQKSW5k ZXg6IExheW91dFRlc3RzL2Zhc3QvY3NzL2RlbGV0ZS1ydWxlLWNyYXNoLWV4cGVjdGVkLnR4dAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9kZWxldGUtcnVsZS1jcmFzaC1leHBl Y3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9kZWxldGUtcnVs ZS1jcmFzaC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEgQEAKK1RoaXMgdGVz dCBwYXNzZXMgaWYgaXQgZG9lc24ndCBjcmFzaC4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvY3Nz L2RlbGV0ZS1ydWxlLWNyYXNoLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9j c3MvZGVsZXRlLXJ1bGUtY3Jhc2guaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zh c3QvY3NzL2RlbGV0ZS1ydWxlLWNyYXNoLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTMg QEAKKzxzY3JpcHQ+CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgIGxheW91 dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKzwvc2NyaXB0PgorPHN0eWxlPgorLnJ1bGUx IHt9CisucnVsZTIge30KKzwvc3R5bGU+Cis8c2NyaXB0PgorZG9jdW1lbnQuc3R5bGVTaGVldHNb MF0uY3NzUnVsZXMuaXRlbSgwKTsKK2RvY3VtZW50LnN0eWxlU2hlZXRzWzBdLmRlbGV0ZVJ1bGUo MSk7Cis8L3NjcmlwdD4KK1RoaXMgdGVzdCBwYXNzZXMgaWYgaXQgZG9lc24ndCBjcmFzaC4K