83690 2012-04-11 07:32:26 -0700 webkit-tools-completion: Support bugzilla email completion for webkit-patch upload --cc 2012-04-16 04:26:31 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jturcotte jturcotte hausmann levin ossy oldest_to_newest 600246 0 jturcotte 2012-04-11 07:32:26 -0700 webkit-tools-completion: Support bugzilla email completion for webkit-patch upload --cc 600247 1 136667 jturcotte 2012-04-11 07:35:28 -0700 Created attachment 136667 Patch 601115 2 136880 jturcotte 2012-04-12 05:11:49 -0700 Created attachment 136880 Patch - Use print() instead of print_ - Use COMP_WORDS directly in __webkit-patch_upload_cc_generate_reply like __webkit-patch_generate_reply does 601980 3 136880 vestbo 2012-04-13 04:59:30 -0700 Comment on attachment 136880 Patch lgtm, minus the comment thing 602001 4 jturcotte 2012-04-13 06:02:26 -0700 Committed r114120: <http://trac.webkit.org/changeset/114120> 602008 5 ossy 2012-04-13 06:17:19 -0700 The title of the bug and the committ log is incorrect, because it only completes options, not email addresses now. Otherwise the idea is very good, email competion in bash is cool. ;) 602024 6 jturcotte 2012-04-13 06:42:00 -0700 (In reply to comment #5) Well it should, so if it doesn't then it's broken in some cases. Did you try to re- source Tools/Scripts/webkit-tools-completion.sh ? 603009 7 ossy 2012-04-16 02:57:04 -0700 (In reply to comment #6) > (In reply to comment #5) > Well it should, so if it doesn't then it's broken in some cases. > Did you try to re- source Tools/Scripts/webkit-tools-completion.sh ? I made some digging, and there were two problems here: - I copied this script to /etc/bash_completion.d to make it system wide, but unfortunaly it doesn't work, because the search path of committers.py is relative to webkit-tools-completion.sh. - I thought that completion works similar to cc field on bugzilla and I tried to use it with real names and nicknames. But it seems it understands only email addressess. 603037 8 jturcotte 2012-04-16 04:26:31 -0700 (In reply to comment #7) > I made some digging, and there were two problems here: > - I copied this script to /etc/bash_completion.d to make it system wide, > but unfortunaly it doesn't work, because the search path of committers.py > is relative to webkit-tools-completion.sh. Ah ok, do you know if many people use it that way? Using an environment variable to point to committers.py would be pretty crappy, but maybe it would be possible to extract the path from the first token in $COMP_WORDS. What I mean is to try finding committers.py relatively to webkit-patch instead of webkit-tools-completion.sh. > - I thought that completion works similar to cc field on bugzilla and I > tried to use it with real names and nicknames. But it seems it understands > only email addressess. I talked with Tor Arne about it too but bash haven't designed their completion extension to make this work reliably. It works better with completing than replacing text. So from my point of view it's better to keep it limited and reliable. 136667 2012-04-11 07:35:28 -0700 2012-04-12 05:11:42 -0700 Patch bug-83690-20120411163224.patch text/plain 2815 jturcotte U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzODU3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWZhODA2MGZlYmNiOWIzYjg2MjJmNTAzYjM0N2ZmNGFj NjhhOWNhOS4uYTI3ZGY1MmYzMmZiZDNmZTBmMDRhZmUxNzliNzJlMTA5NTQzNGU3NiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTA0LTExICBKb2NlbHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBub2tp YS5jb20+CisKKyAgICAgICAgd2Via2l0LXRvb2xzLWNvbXBsZXRpb246IFN1cHBvcnQgYnVnemls bGEgZW1haWwgY29tcGxldGlvbiBmb3Igd2Via2l0LXBhdGNoIHVwbG9hZCAtLWNjCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzY5MAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFR5cGluZyBwYXJ0IG9mIGFu IGVtYWlsIGFuZCBwcmVzc2luZyA8VEFCPiB3aWxsIGJhc2gtY29tcGxldGUgaXQgdXNpbmcgdGhl IGxpc3QgaW4KKyAgICAgICAgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL2Nv bW1pdHRlcnMucHkKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0LXRvb2xzLWNvbXBsZXRpb24u c2g6CisKIDIwMTItMDQtMTEgIE5vJ2FtIFJvc2VudGhhbCAgPG5vYW0ucm9zZW50aGFsQG5va2lh LmNvbT4KIAogICAgICAgICBbUXRdW1dLMl0gTWFuYWdlIGdyYXBoaWNzIGJ1ZmZlcnMgaW4gdGhl IHdlYiBwcm9jZXNzCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdC10b29scy1jb21w bGV0aW9uLnNoIGIvVG9vbHMvU2NyaXB0cy93ZWJraXQtdG9vbHMtY29tcGxldGlvbi5zaAppbmRl eCA3NGZiNzMxNDYwOTFhOTI1ZDQ0OGUwMTRkODI3YzQ2M2FlNTc5ZTg1Li42ZjE5YzY2YTI2ODI0 NjliOTZhMGI0MjhiMTI0YzA0ODcxMTVkNTRjIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dl YmtpdC10b29scy1jb21wbGV0aW9uLnNoCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0LXRvb2xz LWNvbXBsZXRpb24uc2gKQEAgLTM3LDYgKzM3LDIwIEBAIF9fd2Via2l0LXBhdGNoX2dlbmVyYXRl X3JlcGx5KCkKICAgICBDT01QUkVQTFk9KCAkKGNvbXBnZW4gLVcgIiQxIiAtLSAiJHtDT01QX1dP UkRTW0NPTVBfQ1dPUkRdfSIpICkKIH0KIAorX193ZWJraXQtcGF0Y2hfdXBsb2FkX2NjX2dlbmVy YXRlX3JlcGx5KCkKK3sKKyAgICAjIENvbXBsZXRpb24gaXMgZG9uZSBvbiB0b2tlbnMgYW5kIG91 ciBjb21tYS1zZXBhcmF0ZWQgbGlzdCBpcyBvbmUgc2luZ2xlIHRva2VuLCBzbyB3ZSBoYXZlIHRv IGRvIGNvbXBsZXRpb24gb24gdGhlIHdob2xlIGxpc3QgZWFjaCB0aW1lLgorICAgICMgUmV0dXJu IGEgXG4gc2VwYXJhdGVkIGxpc3QgZm9yIGVhY2ggcG9zc2libGUgYnVnemlsbGEgZW1haWwgY29t cGxldGlvbiBvZiB0aGUgc3Vic3RyaW5nIGZvbGxvd2luZyB0aGUgbGFzdCBjb21tYS4KKyAgICAj IFJlZGlyZWN0IHN0cmVyciB0byAvZGV2L251bGwgdG8gcHJldmVudCBub2lzZSBpbiB0aGUgc2hl bGwgaWYgdGhpcyBldmVyIGJyZWFrcyBzb21laG93LgorICAgIENPTVBSRVBMWT0oICQoUFlUSE9O UEFUSD0kKGRpcm5hbWUgIiR7QkFTSF9TT1VSQ0VbMF19IikgcHl0aG9uIC1jICIKK2ltcG9ydCBz eXMscmUKK2Zyb20gd2Via2l0cHkuY29tbW9uLmNvbmZpZy5jb21taXR0ZXJzIGltcG9ydCBDb21t aXR0ZXJMaXN0CittID0gcmUubWF0Y2goJygoLiosKSopKC4qKScsIHN5cy5hcmd2WzFdKQordW50 aWxMYXN0Q29tbWEgPSBtLmdyb3VwKDEpCithZnRlckxhc3RDb21tYSA9IG0uZ3JvdXAoMykKK3By aW50ICdcbicuam9pbihbdW50aWxMYXN0Q29tbWEgKyBjLmJ1Z3ppbGxhX2VtYWlsKCkgKyAnLCcg Zm9yIGMgaW4gQ29tbWl0dGVyTGlzdCgpLmNvbnRyaWJ1dG9ycygpIGlmIGMuYnVnemlsbGFfZW1h aWwoKS5zdGFydHN3aXRoKGFmdGVyTGFzdENvbW1hKV0pIiAiJDEiIDI+L2Rldi9udWxsICkgKQor fQorCiBfd2Via2l0LXBhdGNoX2NvbXBsZXRlKCkKIHsKICAgICBsb2NhbCBjb21tYW5kIGN1cnJl bnRfY29tbWFuZD0iJHtDT01QX1dPUkRTWzFdfSIKQEAgLTc4LDcgKzkyLDExIEBAIF93ZWJraXQt cGF0Y2hfY29tcGxldGUoKQogICAgICAgICAgICAgcmV0dXJuCiAgICAgICAgICAgICA7OwogICAg ICAgICB1cGxvYWQpCi0gICAgICAgICAgICBfX3dlYmtpdC1wYXRjaF9nZW5lcmF0ZV9yZXBseSAi LS1kZXNjcmlwdGlvbiAtLW5vLW9ic29sZXRlIC0tbm8tcmV2aWV3IC0tcmVxdWVzdC1jb21taXQg LS1jYyAtbSAtLW9wZW4tYnVnIgorICAgICAgICAgICAgaWYgW1sgJHtDT01QX1dPUkRTW0NPTVBf Q1dPUkQtMV19ID09ICItLWNjIiB8fCAke0NPTVBfV09SRFNbQ09NUF9DV09SRC0xXX0gPT0gIj0i ICYmICR7Q09NUF9XT1JEU1tDT01QX0NXT1JELTJdfSA9PSAiLS1jYyIgXV07IHRoZW4KKyAgICAg ICAgICAgICAgICBfX3dlYmtpdC1wYXRjaF91cGxvYWRfY2NfZ2VuZXJhdGVfcmVwbHkgJHtDT01Q X1dPUkRTW0NPTVBfQ1dPUkRdfQorICAgICAgICAgICAgICAgIHJldHVybgorICAgICAgICAgICAg ZmkKKyAgICAgICAgICAgIF9fd2Via2l0LXBhdGNoX2dlbmVyYXRlX3JlcGx5ICItLWRlc2NyaXB0 aW9uIC0tbm8tb2Jzb2xldGUgLS1uby1yZXZpZXcgLS1yZXF1ZXN0LWNvbW1pdCAtLWNvbW1lbnQg LS1jYyAtbSAtLW9wZW4tYnVnIgogICAgICAgICAgICAgcmV0dXJuCiAgICAgICAgICAgICA7Owog ICAgICAgICBwb3N0LWNvbW1pdHMpCg== 136880 2012-04-12 05:11:49 -0700 2012-04-13 04:59:30 -0700 Patch bug-83690-20120412140841.patch text/plain 2813 jturcotte U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzODYxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWZhODA2MGZlYmNiOWIzYjg2MjJmNTAzYjM0N2ZmNGFj NjhhOWNhOS4uYTI3ZGY1MmYzMmZiZDNmZTBmMDRhZmUxNzliNzJlMTA5NTQzNGU3NiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTA0LTExICBKb2NlbHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBub2tp YS5jb20+CisKKyAgICAgICAgd2Via2l0LXRvb2xzLWNvbXBsZXRpb246IFN1cHBvcnQgYnVnemls bGEgZW1haWwgY29tcGxldGlvbiBmb3Igd2Via2l0LXBhdGNoIHVwbG9hZCAtLWNjCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzY5MAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFR5cGluZyBwYXJ0IG9mIGFu IGVtYWlsIGFuZCBwcmVzc2luZyA8VEFCPiB3aWxsIGJhc2gtY29tcGxldGUgaXQgdXNpbmcgdGhl IGxpc3QgaW4KKyAgICAgICAgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL2Nv bW1pdHRlcnMucHkKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0LXRvb2xzLWNvbXBsZXRpb24u c2g6CisKIDIwMTItMDQtMTEgIE5vJ2FtIFJvc2VudGhhbCAgPG5vYW0ucm9zZW50aGFsQG5va2lh LmNvbT4KIAogICAgICAgICBbUXRdW1dLMl0gTWFuYWdlIGdyYXBoaWNzIGJ1ZmZlcnMgaW4gdGhl IHdlYiBwcm9jZXNzCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdC10b29scy1jb21w bGV0aW9uLnNoIGIvVG9vbHMvU2NyaXB0cy93ZWJraXQtdG9vbHMtY29tcGxldGlvbi5zaAppbmRl eCA3NGZiNzMxNDYwOTFhOTI1ZDQ0OGUwMTRkODI3YzQ2M2FlNTc5ZTg1Li5jNjJkMDA1ZTM4MGMw YWNhZTQwYzllNzBiMTRiNTJhZGFjZThjMmIwIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dl YmtpdC10b29scy1jb21wbGV0aW9uLnNoCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0LXRvb2xz LWNvbXBsZXRpb24uc2gKQEAgLTM3LDYgKzM3LDIwIEBAIF9fd2Via2l0LXBhdGNoX2dlbmVyYXRl X3JlcGx5KCkKICAgICBDT01QUkVQTFk9KCAkKGNvbXBnZW4gLVcgIiQxIiAtLSAiJHtDT01QX1dP UkRTW0NPTVBfQ1dPUkRdfSIpICkKIH0KIAorX193ZWJraXQtcGF0Y2hfdXBsb2FkX2NjX2dlbmVy YXRlX3JlcGx5KCkKK3sKKyAgICAjIENvbXBsZXRpb24gaXMgZG9uZSBvbiB0b2tlbnMgYW5kIG91 ciBjb21tYS1zZXBhcmF0ZWQgbGlzdCBpcyBvbmUgc2luZ2xlIHRva2VuLCBzbyB3ZSBoYXZlIHRv IGRvIGNvbXBsZXRpb24gb24gdGhlIHdob2xlIGxpc3QgZWFjaCB0aW1lLgorICAgICMgUmV0dXJu IGEgXG4gc2VwYXJhdGVkIGxpc3QgZm9yIGVhY2ggcG9zc2libGUgYnVnemlsbGEgZW1haWwgY29t cGxldGlvbiBvZiB0aGUgc3Vic3RyaW5nIGZvbGxvd2luZyB0aGUgbGFzdCBjb21tYS4KKyAgICAj IFJlZGlyZWN0IHN0cmVyciB0byAvZGV2L251bGwgdG8gcHJldmVudCBub2lzZSBpbiB0aGUgc2hl bGwgaWYgdGhpcyBldmVyIGJyZWFrcyBzb21laG93LgorICAgIENPTVBSRVBMWT0oICQoUFlUSE9O UEFUSD0kKGRpcm5hbWUgIiR7QkFTSF9TT1VSQ0VbMF19IikgcHl0aG9uIC1jICIKK2ltcG9ydCBz eXMscmUKK2Zyb20gd2Via2l0cHkuY29tbW9uLmNvbmZpZy5jb21taXR0ZXJzIGltcG9ydCBDb21t aXR0ZXJMaXN0CittID0gcmUubWF0Y2goJygoLiosKSopKC4qKScsIHN5cy5hcmd2WzFdKQordW50 aWxMYXN0Q29tbWEgPSBtLmdyb3VwKDEpCithZnRlckxhc3RDb21tYSA9IG0uZ3JvdXAoMykKK3By aW50KCdcbicuam9pbihbdW50aWxMYXN0Q29tbWEgKyBjLmJ1Z3ppbGxhX2VtYWlsKCkgKyAnLCcg Zm9yIGMgaW4gQ29tbWl0dGVyTGlzdCgpLmNvbnRyaWJ1dG9ycygpIGlmIGMuYnVnemlsbGFfZW1h aWwoKS5zdGFydHN3aXRoKGFmdGVyTGFzdENvbW1hKV0pKSIgIiR7Q09NUF9XT1JEU1tDT01QX0NX T1JEXX0iIDI+L2Rldi9udWxsICkgKQorfQorCiBfd2Via2l0LXBhdGNoX2NvbXBsZXRlKCkKIHsK ICAgICBsb2NhbCBjb21tYW5kIGN1cnJlbnRfY29tbWFuZD0iJHtDT01QX1dPUkRTWzFdfSIKQEAg LTc4LDcgKzkyLDExIEBAIF93ZWJraXQtcGF0Y2hfY29tcGxldGUoKQogICAgICAgICAgICAgcmV0 dXJuCiAgICAgICAgICAgICA7OwogICAgICAgICB1cGxvYWQpCi0gICAgICAgICAgICBfX3dlYmtp dC1wYXRjaF9nZW5lcmF0ZV9yZXBseSAiLS1kZXNjcmlwdGlvbiAtLW5vLW9ic29sZXRlIC0tbm8t cmV2aWV3IC0tcmVxdWVzdC1jb21taXQgLS1jYyAtbSAtLW9wZW4tYnVnIgorICAgICAgICAgICAg aWYgW1sgJHtDT01QX1dPUkRTW0NPTVBfQ1dPUkQtMV19ID09ICItLWNjIiB8fCAke0NPTVBfV09S RFNbQ09NUF9DV09SRC0xXX0gPT0gIj0iICYmICR7Q09NUF9XT1JEU1tDT01QX0NXT1JELTJdfSA9 PSAiLS1jYyIgXV07IHRoZW4KKyAgICAgICAgICAgICAgICBfX3dlYmtpdC1wYXRjaF91cGxvYWRf Y2NfZ2VuZXJhdGVfcmVwbHkKKyAgICAgICAgICAgICAgICByZXR1cm4KKyAgICAgICAgICAgIGZp CisgICAgICAgICAgICBfX3dlYmtpdC1wYXRjaF9nZW5lcmF0ZV9yZXBseSAiLS1kZXNjcmlwdGlv biAtLW5vLW9ic29sZXRlIC0tbm8tcmV2aWV3IC0tcmVxdWVzdC1jb21taXQgLS1jb21tZW50IC0t Y2MgLW0gLS1vcGVuLWJ1ZyIKICAgICAgICAgICAgIHJldHVybgogICAgICAgICAgICAgOzsKICAg ICAgICAgcG9zdC1jb21taXRzKQo=