83685 2012-04-11 03:14:17 -0700 Calendar Picker: remove unnecessary code from calendarPicker.{css,js} 2012-04-12 23:34:36 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 53961 1 tkent tkent haraken morrita oldest_to_newest 600177 0 tkent 2012-04-11 03:14:17 -0700 Calendar Picker: remove unnecessary code from calendarPicker.{css,js} 600178 1 136651 tkent 2012-04-11 03:19:58 -0700 Created attachment 136651 Patch 600192 2 136651 haraken 2012-04-11 04:09:29 -0700 Comment on attachment 136651 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136651&action=review > Source/WebCore/ChangeLog:12 > + - leading adn trailing whitespace (.js and .css) Nit: *and* > Source/WebCore/make-file-arrays.py:59 > + leading_space = re.compile(r"^ ", re.MULTILINE) This regular expression is assuming that repeating_space.sub() runs before leading_space.sub(). To remove the assumption, r"^[ \t]+" might be better. > Source/WebCore/make-file-arrays.py:60 > + trailing_space = re.compile(r" $", re.MULTILINE) Ditto. r"[ \t]+$" might be better. > Source/WebCore/make-file-arrays.py:75 > + print content Remove this 601854 3 tkent 2012-04-12 23:33:30 -0700 Committed r114090: <http://trac.webkit.org/changeset/114090> 601855 4 tkent 2012-04-12 23:34:36 -0700 (In reply to comment #2) > > Source/WebCore/ChangeLog:12 > > + - leading adn trailing whitespace (.js and .css) > > Nit: *and* Fixed. > > Source/WebCore/make-file-arrays.py:59 > > + leading_space = re.compile(r"^ ", re.MULTILINE) > > This regular expression is assuming that repeating_space.sub() runs before leading_space.sub(). To remove the assumption, r"^[ \t]+" might be better. Fixed. > > Source/WebCore/make-file-arrays.py:60 > > + trailing_space = re.compile(r" $", re.MULTILINE) > > Ditto. r"[ \t]+$" might be better. Fixed. > > Source/WebCore/make-file-arrays.py:75 > > + print content > > Remove this Removed. 136651 2012-04-11 03:19:58 -0700 2012-04-11 04:09:29 -0700 Patch bug-83685-20120411191957.patch text/plain 3286 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzODQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDQ3MDVlYjU4MWYwOGQw OGU5NGZmMmM0ZjNmMDViNDFjNjYyNDBhMy4uNGY3Y2M0M2U5ZDUxYjdmYjkxZDQwMGE0ZDAyMGNl NjQxYzM3ODAxZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA0LTExICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBDYWxlbmRhciBQaWNrZXI6 IHJlbW92ZSB1bm5lY2Vzc2FyeSBjb2RlIGZyb20gY2FsZW5kYXJQaWNrZXIue2Nzcyxqc30KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzNjg1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHRoZSBm b2xsb3dpbmdzIGZyb20gaW5wdXQgZmlsZXM6CisgICAgICAgICAtIG11bHRpIGxpbmUgY29tbWVu dHMgLyouLi4qLyAoLmpzIGFuZCAuY3NzKQorICAgICAgICAgLSBzaW5nbGUgbGluZSBjb21tZW50 IC8vLi4uICguanMpCisgICAgICAgICAtIHJlcGVhdGluZyB3aGl0ZXNwYWNlICguanMgYW5kIC5j c3MpCisgICAgICAgICAtIGxlYWRpbmcgYWRuIHRyYWlsaW5nIHdoaXRlc3BhY2UgKC5qcyBhbmQg LmNzcykKKyAgICAgICAgIC0gZW1wdHkgbGluZXMgKC5qcyBhbmQgLmNzcykKKworICAgICAgICBU aGlzIGRvZXNuJ3Qgd29yayBmb3IgYXJiaXRyYXJ5IEphdmFTY3JpcHQgb3IgQ1NTIGlucHV0cywg YnV0CisgICAgICAgIHdvcmtzIHdlbGwgZm9yIGV4cGVjdGVkIGlucHV0IGZpbGVzIGxpa2UKKyAg ICAgICAgY3NzL21ha2UtY3NzLWZpbGUtYXJyYXlzLnBsCisKKyAgICAgICAgKiBtYWtlLWZpbGUt YXJyYXlzLnB5OgorICAgICAgICAoc3RyaXBfd2hpdGVzcGFjZV9hbmRfY29tbWVudHMpOgorICAg ICAgICAobWFpbik6CisKIDIwMTItMDQtMTEgIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9i ZS5jb20+CiAKICAgICAgICAgW0NTUyBSZWdpb25zXUFkZCBoZWxwZXIgY2xhc3MgZm9yIGZsb3cg dGhyZWFkcyBpbmZvIGluIFJlbmRlclZpZXcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL21h a2UtZmlsZS1hcnJheXMucHkgYi9Tb3VyY2UvV2ViQ29yZS9tYWtlLWZpbGUtYXJyYXlzLnB5Cmlu ZGV4IDk5YjRkYmUxNzk5MTlmNmI4Y2FiMGM5Mjc0MTI4YTdkMGVkOTU4N2YuLmMwYWFhMzQzZTQ3 N2MzNzU3YWE0ZDk5OTA3YjM5YmVmZDg1ZDc5MzAgMTAwNzU1Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L21ha2UtZmlsZS1hcnJheXMucHkKKysrIGIvU291cmNlL1dlYkNvcmUvbWFrZS1maWxlLWFycmF5 cy5weQpAQCAtNDcsNiArNDcsMzUgQEAgZGVmIG1ha2VfdmFyaWFibGVfbmFtZV9hbmRfcmVhZChm aWxlX25hbWUpOgogICAgIHJldHVybiAodmFyaWFibGVfbmFtZSwgY29udGVudCkKIAogCitkZWYg c3RyaXBfd2hpdGVzcGFjZV9hbmRfY29tbWVudHMoZmlsZV9uYW1lLCBjb250ZW50KToKKyAgICBy ZXN1bHQgPSByZS5tYXRjaChyIi4qXC4oW14uXSspIiwgZmlsZV9uYW1lKQorICAgIGlmIG5vdCBy ZXN1bHQ6CisgICAgICAgIHByaW50ICJUaGUgZmlsZSBuYW1lIGhhcyBubyBleHRlbnNpb246Iiwg ZmlsZV9uYW1lCisgICAgICAgIHN5cy5leGl0KDEpCisgICAgZXh0ZW5zaW9uID0gcmVzdWx0Lmdy b3VwKDEpLmxvd2VyKCkKKyAgICBtdWx0aV9saW5lX2NvbW1lbnQgPSByZS5jb21waWxlKHIiL1wq Lio/XCovIiwgcmUuTVVMVElMSU5FIHwgcmUuRE9UQUxMKQorICAgIHNpbmdsZV9saW5lX2NvbW1l bnQgPSByZS5jb21waWxlKHIiLy8uKiQiLCByZS5NVUxUSUxJTkUpCisgICAgcmVwZWF0aW5nX3Nw YWNlID0gcmUuY29tcGlsZShyIlsgXHRdKyIsIHJlLk1VTFRJTElORSkKKyAgICBsZWFkaW5nX3Nw YWNlID0gcmUuY29tcGlsZShyIl4gIiwgcmUuTVVMVElMSU5FKQorICAgIHRyYWlsaW5nX3NwYWNl ID0gcmUuY29tcGlsZShyIiAkIiwgcmUuTVVMVElMSU5FKQorICAgIGVtcHR5X2xpbmUgPSByZS5j b21waWxlKHIiXG4rIikKKyAgICBpZiBleHRlbnNpb24gPT0gImpzIjoKKyAgICAgICAgY29udGVu dCA9IG11bHRpX2xpbmVfY29tbWVudC5zdWIoIiIsIGNvbnRlbnQpCisgICAgICAgIGNvbnRlbnQg PSBzaW5nbGVfbGluZV9jb21tZW50LnN1YigiIiwgY29udGVudCkKKyAgICAgICAgY29udGVudCA9 IHJlcGVhdGluZ19zcGFjZS5zdWIoIiAiLCBjb250ZW50KQorICAgICAgICBjb250ZW50ID0gbGVh ZGluZ19zcGFjZS5zdWIoIiIsIGNvbnRlbnQpCisgICAgICAgIGNvbnRlbnQgPSB0cmFpbGluZ19z cGFjZS5zdWIoIiIsIGNvbnRlbnQpCisgICAgICAgIGNvbnRlbnQgPSBlbXB0eV9saW5lLnN1Yigi XG4iLCBjb250ZW50KQorICAgIGVsaWYgZXh0ZW5zaW9uID09ICJjc3MiOgorICAgICAgICBjb250 ZW50ID0gbXVsdGlfbGluZV9jb21tZW50LnN1YigiIiwgY29udGVudCkKKyAgICAgICAgY29udGVu dCA9IHJlcGVhdGluZ19zcGFjZS5zdWIoIiAiLCBjb250ZW50KQorICAgICAgICBjb250ZW50ID0g bGVhZGluZ19zcGFjZS5zdWIoIiIsIGNvbnRlbnQpCisgICAgICAgIGNvbnRlbnQgPSB0cmFpbGlu Z19zcGFjZS5zdWIoIiIsIGNvbnRlbnQpCisgICAgICAgIGNvbnRlbnQgPSBlbXB0eV9saW5lLnN1 YigiXG4iLCBjb250ZW50KQorICAgICAgICBwcmludCBjb250ZW50CisgICAgcmV0dXJuIGNvbnRl bnQKKworCiBkZWYgbWFpbigpOgogICAgIHBhcnNlciA9IE9wdGlvblBhcnNlcigpCiAgICAgcGFy c2VyLmFkZF9vcHRpb24oIi0tb3V0LWgiLCBkZXN0PSJvdXRfaGVhZGVyIikKQEAgLTc0LDYgKzEw Myw3IEBAIGRlZiBtYWluKCk6CiAKICAgICBmb3IgZmlsZV9uYW1lIGluIGFyZ3M6CiAgICAgICAg ICh2YXJpYWJsZV9uYW1lLCBjb250ZW50KSA9IG1ha2VfdmFyaWFibGVfbmFtZV9hbmRfcmVhZChm aWxlX25hbWUpCisgICAgICAgIGNvbnRlbnQgPSBzdHJpcF93aGl0ZXNwYWNlX2FuZF9jb21tZW50 cyhmaWxlX25hbWUsIGNvbnRlbnQpCiAgICAgICAgIHNpemUgPSBsZW4oY29udGVudCkKICAgICAg ICAgaGVhZGVyX2ZpbGUud3JpdGUoImV4dGVybiBjb25zdCBjaGFyICVzWyVkXTtcbiIgJSAodmFy aWFibGVfbmFtZSwgc2l6ZSkpCiAgICAgICAgIGNwcF9maWxlLndyaXRlKCJjb25zdCBjaGFyICVz WyVkXSA9IHtcbiIgJSAodmFyaWFibGVfbmFtZSwgc2l6ZSkpCg==