83683 2012-04-11 02:33:39 -0700 WebTextCheckerClient doesn't initialize output arguments. 2013-07-03 11:06:49 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand spena andersca ap commit-queue dcheng spena zan oldest_to_newest 600161 0 pnormand 2012-04-11 02:33:39 -0700 Diff: --- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/editing/pasteboard/pasting-empty-html-falls-back-to-text-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/editing/pasteboard/pasting-empty-html-falls-back-to-text-actual.txt @@ -1,5 +1,1 @@ This test requires DRT. It verifies that pasting in a richly editable area falls back to text if the HTML content is an empty string. - - - -PASS I'll mark it in test_expectations. 904573 1 spena 2013-06-28 05:13:57 -0700 This test now passes in Debug and Release in WebKitGTK, but crashes on Debug in WebKit2GTK. 905378 2 spena 2013-07-02 06:03:40 -0700 I am investigating this. 905463 3 spena 2013-07-02 09:26:18 -0700 The crash in GTK-WK2 happens in ASSERT(misspellingLocation < len), in TextCheckingHelper.cpp. I investigated how it happens, and it turned out that the values coming out of the IPC calls to checkSpellingOfString are wrong, and have not been initialized. I am renaming this bug to something more appropriate and will upload a patch that fixes this. 905467 4 205922 spena 2013-07-02 09:32:17 -0700 Created attachment 205922 Patch 905473 5 spena 2013-07-02 09:48:07 -0700 I am also taking a look at other places where this could be happening. 905739 6 spena 2013-07-03 01:27:18 -0700 CCing an OWNER for review as well. 905907 7 ap 2013-07-03 10:21:41 -0700 Looks good to me. 905933 8 205922 commit-queue 2013-07-03 11:06:45 -0700 Comment on attachment 205922 Patch Clearing flags on attachment: 205922 Committed r152369: <http://trac.webkit.org/changeset/152369> 905934 9 commit-queue 2013-07-03 11:06:49 -0700 All reviewed patches have been landed. Closing bug. 205922 2013-07-02 09:32:17 -0700 2013-07-03 11:06:45 -0700 Patch bug-83683-20130702173107.patch text/plain 4296 spena U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMjkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTM5YTI5NjJjOGMzMjNl Y2JiM2M4ZmUxYWQzYTJhMzUxMzdkYTAzYS4uZDEwMDMyYzRmMDc1Yjg3OTRhNzY1M2ExZjM0MTQx M2VlY2U0Y2E2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDEzLTA3LTAyICBTaW1v biBQZW5hICA8c2ltb24ucGVuYUBzYW1zdW5nLmNvbT4KKworICAgICAgICBXZWJUZXh0Q2hlY2tl ckNsaWVudCBkb2Vzbid0IGluaXRpYWxpemUgb3V0cHV0IGFyZ3VtZW50cy4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzNjgzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2FsbGVycyBvZiBjaGVja1NwZWxs aW5nT2ZTdHJpbmcgYW5kIGNoZWNrR3JhbW1hck9mU3RyaW5nIGV4cGVjdAorICAgICAgICBjZXJ0 YWluIGRlZmF1bHQgdmFsdWVzIHdoZW4gbm8gbWlzc3BlbGxlZCAob3IgYmFkIGdyYW1tYXIpIHN0 cmluZworICAgICAgICBpcyBmb3VuZC4gVGhleSB0cnkgdG8gZG8gdGhhdCBieSBpbml0aWFsaXNp bmcgdGhlIHJlcGx5IGFyZ3VtZW50cworICAgICAgICB0aGF0IGdvIGludG8gdGhlIElQQyBjYWxs cywgYnV0IHRoZXNlIHZhbHVlcyBhcmUgdWx0aW1hdGVseSBpZ25vcmVkIChzZWUKKyAgICAgICAg SGFuZGxlTWVzc2FnZS5oLCB3aGVyZSB0aGUgcmVwbHlBcmd1bWVudHMgYXJlIGRlY2xhcmVkKS4K KworICAgICAgICBJbiB0aGUgcGFzdCwgdGhpcyBzZWVtcyB0byBoYXZlIGxlZCB0byB2YXJpb3Vz IGlzc3VlcywgKHNlZQorICAgICAgICBUZXh0Q2hlY2tpbmdIZWxwZXI6OmZpbmRGaXJzdE1pc3Nw ZWxsaW5nIGluIFRleHRDaGVja2luZ0hlbHBlci5jcHApLAorICAgICAgICB3aGVyZSB0aGVzZSBy ZXR1cm4gdmFsdWVzIGFyZSBhc3NlcnRlZCBhbmQgY2hlY2tlZCB0byBiZSBpbiB0aGUgcmlnaHQg cmFuZ2UuCisKKyAgICAgICAgVGhpcyBwYXRjaCBpbml0aWFsaXNlcyB0aGUgdmFsdWVzLCBzbyBl dmVuIGlmIG5vIGF2YWlsYWJsZSBjbGllbnQKKyAgICAgICAgaW1wbGVtZW50cyB0aGUgbWV0aG9k cyAob3IgaWYgdGhlIGltcGxlbWVudGF0aW9uIGZvcmdldHMgdG8gZG8gaXQpIHRoZSBjYWxsZXJz CisgICAgICAgIHdpbGwgaGF2ZSB0aGVpciBleHBlY3RlZCBvdXRwdXQuCisKKyAgICAgICAgSG93 ZXZlciwgYW5kIGZvciBhIGdlbmVyYWwgY2FzZSwgd2UgcHJvYmFibHkgbmVlZCBhIHdheSB0byB0 ZWxsIHRoZSBjYWxsZXIKKyAgICAgICAgdGhhdCBhbnkgZXhpc3RpbmcgdmFsdWUgaW4gdGhlIG91 dHB1dCBhcmd1bWVudHMgd2lsbCBiZSBpZ25vcmVkLgorCisgICAgICAgICogVUlQcm9jZXNzL1dl YlRleHRDaGVja2VyQ2xpZW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVGV4dENoZWNrZXJD bGllbnQ6OmNoZWNrU3BlbGxpbmdPZlN0cmluZyk6CisgICAgICAgIChXZWJLaXQ6OldlYlRleHRD aGVja2VyQ2xpZW50OjpjaGVja0dyYW1tYXJPZlN0cmluZyk6CisKIDIwMTMtMDctMDEgIEFsZXhl eSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgQ2xlYW4gdXAgcHJpdmF0 ZSBicm93c2luZyBzZXNzaW9uIHRyYWNraW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvV2ViVGV4dENoZWNrZXJDbGllbnQuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL1dlYlRleHRDaGVja2VyQ2xpZW50LmNwcAppbmRleCA4NmU1MmM2MzczNGQ2ODUyNmY1ZmEw OWFmNzZjN2FmMTE2ZjU5ZWI3Li5jYzY5ZDVlNjlhMjM0OTNmY2ZmYzliYjg2MDM4Njk2MmI0MWVh MzUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViVGV4dENoZWNrZXJD bGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJUZXh0Q2hlY2tlckNs aWVudC5jcHAKQEAgLTkzLDYgKzkzLDkgQEAgdm9pZCBXZWJUZXh0Q2hlY2tlckNsaWVudDo6Y2xv c2VTcGVsbERvY3VtZW50V2l0aFRhZyh1aW50NjRfdCB0YWcpCiAKIHZvaWQgV2ViVGV4dENoZWNr ZXJDbGllbnQ6OmNoZWNrU3BlbGxpbmdPZlN0cmluZyh1aW50NjRfdCB0YWcsIGNvbnN0IFN0cmlu ZyYgdGV4dCwgaW50MzJfdCYgbWlzc3BlbGxpbmdMb2NhdGlvbiwgaW50MzJfdCYgbWlzc3BlbGxp bmdMZW5ndGgpCiB7CisgICAgbWlzc3BlbGxpbmdMb2NhdGlvbiA9IC0xOworICAgIG1pc3NwZWxs aW5nTGVuZ3RoID0gMDsKKwogICAgIGlmICghbV9jbGllbnQuY2hlY2tTcGVsbGluZ09mU3RyaW5n KQogICAgICAgICByZXR1cm47CiAKQEAgLTEwMSw2ICsxMDQsOSBAQCB2b2lkIFdlYlRleHRDaGVj a2VyQ2xpZW50OjpjaGVja1NwZWxsaW5nT2ZTdHJpbmcodWludDY0X3QgdGFnLCBjb25zdCBTdHJp bmcmIHRleAogCiB2b2lkIFdlYlRleHRDaGVja2VyQ2xpZW50OjpjaGVja0dyYW1tYXJPZlN0cmlu Zyh1aW50NjRfdCB0YWcsIGNvbnN0IFN0cmluZyYgdGV4dCwgVmVjdG9yPFdlYkNvcmU6OkdyYW1t YXJEZXRhaWw+JiBncmFtbWFyRGV0YWlscywgaW50MzJfdCYgYmFkR3JhbW1hckxvY2F0aW9uLCBp bnQzMl90JiBiYWRHcmFtbWFyTGVuZ3RoKQogeworICAgIGJhZEdyYW1tYXJMb2NhdGlvbiA9IC0x OworICAgIGJhZEdyYW1tYXJMZW5ndGggPSAwOworCiAgICAgaWYgKCFtX2NsaWVudC5jaGVja0dy YW1tYXJPZlN0cmluZykKICAgICAgICAgcmV0dXJuOwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOTM3NzcyNTI2OWNhMzNh NDJmNTlhNzlhNmM0NmM4N2IzZjBjOWIyNi4uNDc2ZWIwNWE4YjYwOTNkYTk5NjczYzBjNzAwNGY2 MDk1ZGI0YjIxZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91 dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA3LTAyICBTaW1vbiBQZW5h ICA8c2ltb24ucGVuYUBzYW1zdW5nLmNvbT4KKworICAgICAgICBXZWJUZXh0Q2hlY2tlckNsaWVu dCBkb2Vzbid0IGluaXRpYWxpemUgb3V0cHV0IGFyZ3VtZW50cy4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzNjgzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVW5za2lwIGVkaXRpbmcvcGFzdGVib2FyZC9w YXN0aW5nLWVtcHR5LWh0bWwtZmFsbHMtYmFjay10by10ZXh0Lmh0bWwsIHdoaWNoIG5vIGxvbmdl cgorICAgICAgICBjcmFzaGVzIGFmdGVyIHRoZSBmaXguCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n dGstd2syL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTMtMDctMDIgIE1paGFpIFRpY2EgIDxtaXRp Y2FAYWRvYmUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgZ2FyZGVuaW5nLiBSZWJhc2VsaW5l IGJhY2tncm91bmQgYmxlbmQgbW9kZSBkZWZhdWx0IHRlc3QgcmVzdWx0LgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrLXdrMi9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vZ3RrLXdrMi9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDQyZjM0ZjQ1MTMzNzY1 MGQ3M2I5NmE4MWI4OTIwOWFkNDRjMGJmMDAuLjc4MmUwNzdlMGFhNmQzZDJhNWRlZGUwOWRhOWFm ZTVhYTg0YTM2NmYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay13azIvVGVz dEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGstd2syL1Rlc3RFeHBl Y3RhdGlvbnMKQEAgLTIyOSw4ICsyMjksNiBAQCBCdWcoR1RLKSBwbHVnaW5zL2RvY3VtZW50LW9w ZW4uaHRtbCBbIENyYXNoIF0KIAogd2Via2l0Lm9yZy9iLzExNjk3NCBhY2Nlc3NpYmlsaXR5L3Rp dGxlLXVpLWVsZW1lbnQtY29ycmVjdG5lc3MuaHRtbCBbIENyYXNoIF0KIAotd2Via2l0Lm9yZy9i LzgzNjgzIFsgRGVidWcgXSBlZGl0aW5nL3Bhc3RlYm9hcmQvcGFzdGluZy1lbXB0eS1odG1sLWZh bGxzLWJhY2stdG8tdGV4dC5odG1sIFsgQ3Jhc2ggXQotCiB3ZWJraXQub3JnL2IvMTA4MzYzIGZ1 bGxzY3JlZW4vZnVsbC1zY3JlZW4taWZyYW1lLWxlZ2FjeS5odG1sIFsgQ3Jhc2ggXQogCiAjIEV2 ZW50U2VuZGVyJ3MgY29udGV4dENsaWNrIHNob3VsZCByZXR1cm4gb2JqZWN0cyB0aGF0IGltcGxl bWVudHMgY2xpY2soKSBtZXRob2QK