83670 2012-04-11 00:04:11 -0700 [BlackBerry] There shouldn't be two or more Accept-Language in platformRequest's headerList. 2012-04-11 20:06:43 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 jasonliuwebkit webkit-unassigned charles.wei leo.yang rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 600082 0 jasonliuwebkit 2012-04-11 00:04:11 -0700 We add Accept-Language to platformRequest in initializePlatformRequest. But need to make sure there aren't two or more Accecpt-Language in headerList. 600098 1 136637 jasonliuwebkit 2012-04-11 00:42:03 -0700 Created attachment 136637 Patch 600169 2 136637 charles.wei 2012-04-11 02:44:44 -0700 Comment on attachment 136637 Patch Looks good to me. Need a reviewer to approve though. 600195 3 136637 rwlbuis 2012-04-11 04:22:38 -0700 Comment on attachment 136637 Patch Looks good. But why is this called twice? Can't the state be checked before calling twice? 600806 4 jasonliuwebkit 2012-04-11 19:08:23 -0700 (In reply to comment #3) > (From update of attachment 136637 [details]) > Looks good. But why is this called twice? Can't the state be checked before calling twice? It is called to add custom headers to resourceRequest first. Accept-Language is in header list. When we create a platformRequest, it is called again. 600809 5 136807 jasonliuwebkit 2012-04-11 19:12:49 -0700 Created attachment 136807 Patch 600817 6 136807 leo.yang 2012-04-11 19:34:47 -0700 Comment on attachment 136807 Patch Since you addressed Rob's comments when he gave you r+, I cq+ your patch. 600825 7 136807 webkit.review.bot 2012-04-11 20:06:39 -0700 Comment on attachment 136807 Patch Clearing flags on attachment: 136807 Committed r113938: <http://trac.webkit.org/changeset/113938> 600826 8 webkit.review.bot 2012-04-11 20:06:43 -0700 All reviewed patches have been landed. Closing bug. 136637 2012-04-11 00:42:03 -0700 2012-04-11 19:12:33 -0700 Patch bug-83670-20120411154200.patch text/plain 3030 jasonliuwebkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNjc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTI2ZGQwYmRjYzk2OTQy YmI4ZTYyZjE4OTQ1MzFhNTNlY2M2NGI0OS4uMDkyNTVhM2MxNmU3NzU5YTNjMWY2OTQ2ZGE0NTZm NTI3ZWU1NWMzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA0LTExICBKYXNv biBMaXUgIDxqYXNvbi5saXVAdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja0Jl cnJ5XSBUaGVyZSBzaG91bGRuJ3QgYmUgdHdvIG9yIG1vcmUgQWNjZXB0LUxhbmd1YWdlIGluIHBs YXRmb3JtUmVxdWVzdCdzIGhlYWRlckxpc3QuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD04MzY3MAorCisgICAgICAgIEZyYW1lTG9hZGVyQ2xpZW50Qmxh Y2tCZXJyeTo6ZGlzcGF0Y2hXaWxsU2VuZFJlcXVlc3QgYW5kIE5ldHdvcmtNYW5hZ2VyOjpzdGFy dEpvYiB3aWxsIGNhbGwKKyAgICAgICAgUmVzb3VyY2VSZXF1ZXN0Ojppbml0aWFsaXplUGxhdGZv cm1SZXF1ZXN0LiBBY2NlcHQtTGFuZ3VhZ2UgaXMgYWRkZWQgdHdvIHRpbWVzLgorICAgICAgICBX ZSBzaG91bGQgYXZvaWQgdGhlIHNlY29uZCBhZGRpbmcgdG8gaW1wcm92ZSBwZXJmb3JtYW5jZS4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcg dGVzdHMuIFJlZmFjdG9yLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5 L1Jlc291cmNlUmVxdWVzdEJsYWNrQmVycnkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3Vy Y2VSZXF1ZXN0Ojppbml0aWFsaXplUGxhdGZvcm1SZXF1ZXN0KToKKwogMjAxMi0wNC0wOSAgTm8n YW0gUm9zZW50aGFsICA8bm9hbS5yb3NlbnRoYWxAbm9raWEuY29tPgogCiAgICAgICAgIFtXSzJd IEVuYWJsZSB1c2luZyBhIHNpbmdsZSBTaGFyZWFibGVCaXRtYXAgZm9yIG11bHRpcGxlIHVwZGF0 ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJy eS9SZXNvdXJjZVJlcXVlc3RCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvYmxhY2tiZXJyeS9SZXNvdXJjZVJlcXVlc3RCbGFja0JlcnJ5LmNwcAppbmRleCA2 YTc4OTBiZmI3M2IzNTgxMTE4NDQ1MDE2MGE4ZTY3OWUxOGYxYjEwLi4yMThjMjcyYTI5ZWJmZTIw ZWY5ZDA0NGJhMWI2M2RkNTdmODllMGM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvUmVzb3VyY2VSZXF1ZXN0QmxhY2tCZXJyeS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L1Jlc291cmNlUmVx dWVzdEJsYWNrQmVycnkuY3BwCkBAIC0yMTIsMTUgKzIxMiwxNyBAQCB2b2lkIFJlc291cmNlUmVx dWVzdDo6aW5pdGlhbGl6ZVBsYXRmb3JtUmVxdWVzdChOZXR3b3JrUmVxdWVzdCYgcGxhdGZvcm1S ZXF1ZXN0LAogICAgICAgICAgICAgICAgIHBsYXRmb3JtUmVxdWVzdC5hZGRIZWFkZXIoIkNvb2tp ZSIsIGNvb2tpZVBhaXJzLmNvbnRhaW5zT25seUxhdGluMSgpID8gY29va2llUGFpcnMubGF0aW4x KCkuZGF0YSgpIDogY29va2llUGFpcnMudXRmOCgpLmRhdGEoKSk7CiAgICAgICAgIH0KIAotICAg ICAgICAvLyBMb2NhbGUgaGFzIHRoZSBmb3JtICJlbi1VUyIuIENvbnN0cnVjdCBhY2NlcHQgbGFu Z3VhZ2UgbGlrZSAiZW4tVVMsIGVuO3E9MC44Ii4KLSAgICAgICAgc3RkOjpzdHJpbmcgbG9jYWxl ID0gQmxhY2tCZXJyeTo6UGxhdGZvcm06OkNsaWVudDo6Z2V0KCktPmdldExvY2FsZSgpOwotICAg ICAgICAvLyBQT1NJWCBsb2NhbGUgaGFzICdfJyBpbnN0ZWFkIG9mICctJy4KLSAgICAgICAgLy8g UmVwbGFjZSB0byBjb25mb3JtIHRvIEhUVFAgc3BlYy4KLSAgICAgICAgc2l6ZV90IHVuZGVyc2Nv cmUgPSBsb2NhbGUuZmluZCgnXycpOwotICAgICAgICBpZiAodW5kZXJzY29yZSAhPSBzdGQ6OnN0 cmluZzo6bnBvcykKLSAgICAgICAgICAgIGxvY2FsZS5yZXBsYWNlKHVuZGVyc2NvcmUsIDEsICIt Iik7Ci0gICAgICAgIHN0ZDo6c3RyaW5nIGFjY2VwdExhbmd1YWdlID0gbG9jYWxlICsgIiwgIiAr IGxvY2FsZS5zdWJzdHIoMCwgMikgKyAiO3E9MC44IjsKLSAgICAgICAgcGxhdGZvcm1SZXF1ZXN0 LmFkZEhlYWRlcigiQWNjZXB0LUxhbmd1YWdlIiwgYWNjZXB0TGFuZ3VhZ2UuY19zdHIoKSk7Cisg ICAgICAgIGlmICghaHR0cEhlYWRlckZpZWxkcygpLmNvbnRhaW5zKCJBY2NlcHQtTGFuZ3VhZ2Ui KSkgeworICAgICAgICAgICAgLy8gTG9jYWxlIGhhcyB0aGUgZm9ybSAiZW4tVVMiLiBDb25zdHJ1 Y3QgYWNjZXB0IGxhbmd1YWdlIGxpa2UgImVuLVVTLCBlbjtxPTAuOCIuCisgICAgICAgICAgICBz dGQ6OnN0cmluZyBsb2NhbGUgPSBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6Q2xpZW50OjpnZXQoKS0+ Z2V0TG9jYWxlKCk7CisgICAgICAgICAgICAvLyBQT1NJWCBsb2NhbGUgaGFzICdfJyBpbnN0ZWFk IG9mICctJy4KKyAgICAgICAgICAgIC8vIFJlcGxhY2UgdG8gY29uZm9ybSB0byBIVFRQIHNwZWMu CisgICAgICAgICAgICBzaXplX3QgdW5kZXJzY29yZSA9IGxvY2FsZS5maW5kKCdfJyk7CisgICAg ICAgICAgICBpZiAodW5kZXJzY29yZSAhPSBzdGQ6OnN0cmluZzo6bnBvcykKKyAgICAgICAgICAg ICAgICBsb2NhbGUucmVwbGFjZSh1bmRlcnNjb3JlLCAxLCAiLSIpOworICAgICAgICAgICAgc3Rk OjpzdHJpbmcgYWNjZXB0TGFuZ3VhZ2UgPSBsb2NhbGUgKyAiLCAiICsgbG9jYWxlLnN1YnN0cigw LCAyKSArICI7cT0wLjgiOworICAgICAgICAgICAgcGxhdGZvcm1SZXF1ZXN0LmFkZEhlYWRlcigi QWNjZXB0LUxhbmd1YWdlIiwgYWNjZXB0TGFuZ3VhZ2UuY19zdHIoKSk7CisgICAgICAgIH0KICAg ICB9CiB9CiAK 136807 2012-04-11 19:12:49 -0700 2012-04-11 20:06:39 -0700 Patch bug-83670-20120412101245.patch text/plain 3024 jasonliuwebkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNjc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTI2ZGQwYmRjYzk2OTQy YmI4ZTYyZjE4OTQ1MzFhNTNlY2M2NGI0OS4uZTljMjE2NTRjMDRhNWExYzRmNDhkM2Q2NTRlYTEz MTczYWRmY2UyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA0LTExICBKYXNv biBMaXUgIDxqYXNvbi5saXVAdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja0Jl cnJ5XSBUaGVyZSBzaG91bGRuJ3QgYmUgdHdvIG9yIG1vcmUgQWNjZXB0LUxhbmd1YWdlIGluIHBs YXRmb3JtUmVxdWVzdCdzIGhlYWRlckxpc3QuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD04MzY3MAorCisgICAgICAgIEZyYW1lTG9hZGVyQ2xpZW50Qmxh Y2tCZXJyeTo6ZGlzcGF0Y2hXaWxsU2VuZFJlcXVlc3QgYW5kIE5ldHdvcmtNYW5hZ2VyOjpzdGFy dEpvYiB3aWxsIGNhbGwKKyAgICAgICAgUmVzb3VyY2VSZXF1ZXN0Ojppbml0aWFsaXplUGxhdGZv cm1SZXF1ZXN0LiBBY2NlcHQtTGFuZ3VhZ2UgaXMgYWRkZWQgdHdvIHRpbWVzLgorICAgICAgICBX ZSBzaG91bGQgYXZvaWQgdGhlIHNlY29uZCBhZGRpbmcgdG8gaW1wcm92ZSBwZXJmb3JtYW5jZS4K KworICAgICAgICBSZXZpZXdlZCBieSBSb2IgQnVpcy4KKworICAgICAgICBObyBuZXcgdGVzdHMu IFJlZmFjdG9yLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L1Jlc291 cmNlUmVxdWVzdEJsYWNrQmVycnkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VSZXF1 ZXN0Ojppbml0aWFsaXplUGxhdGZvcm1SZXF1ZXN0KToKKwogMjAxMi0wNC0wOSAgTm8nYW0gUm9z ZW50aGFsICA8bm9hbS5yb3NlbnRoYWxAbm9raWEuY29tPgogCiAgICAgICAgIFtXSzJdIEVuYWJs ZSB1c2luZyBhIHNpbmdsZSBTaGFyZWFibGVCaXRtYXAgZm9yIG11bHRpcGxlIHVwZGF0ZXMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9SZXNv dXJjZVJlcXVlc3RCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvYmxhY2tiZXJyeS9SZXNvdXJjZVJlcXVlc3RCbGFja0JlcnJ5LmNwcAppbmRleCA2YTc4OTBi ZmI3M2IzNTgxMTE4NDQ1MDE2MGE4ZTY3OWUxOGYxYjEwLi4yMThjMjcyYTI5ZWJmZTIwZWY5ZDA0 NGJhMWI2M2RkNTdmODllMGM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL2JsYWNrYmVycnkvUmVzb3VyY2VSZXF1ZXN0QmxhY2tCZXJyeS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L1Jlc291cmNlUmVxdWVzdEJs YWNrQmVycnkuY3BwCkBAIC0yMTIsMTUgKzIxMiwxNyBAQCB2b2lkIFJlc291cmNlUmVxdWVzdDo6 aW5pdGlhbGl6ZVBsYXRmb3JtUmVxdWVzdChOZXR3b3JrUmVxdWVzdCYgcGxhdGZvcm1SZXF1ZXN0 LAogICAgICAgICAgICAgICAgIHBsYXRmb3JtUmVxdWVzdC5hZGRIZWFkZXIoIkNvb2tpZSIsIGNv b2tpZVBhaXJzLmNvbnRhaW5zT25seUxhdGluMSgpID8gY29va2llUGFpcnMubGF0aW4xKCkuZGF0 YSgpIDogY29va2llUGFpcnMudXRmOCgpLmRhdGEoKSk7CiAgICAgICAgIH0KIAotICAgICAgICAv LyBMb2NhbGUgaGFzIHRoZSBmb3JtICJlbi1VUyIuIENvbnN0cnVjdCBhY2NlcHQgbGFuZ3VhZ2Ug bGlrZSAiZW4tVVMsIGVuO3E9MC44Ii4KLSAgICAgICAgc3RkOjpzdHJpbmcgbG9jYWxlID0gQmxh Y2tCZXJyeTo6UGxhdGZvcm06OkNsaWVudDo6Z2V0KCktPmdldExvY2FsZSgpOwotICAgICAgICAv LyBQT1NJWCBsb2NhbGUgaGFzICdfJyBpbnN0ZWFkIG9mICctJy4KLSAgICAgICAgLy8gUmVwbGFj ZSB0byBjb25mb3JtIHRvIEhUVFAgc3BlYy4KLSAgICAgICAgc2l6ZV90IHVuZGVyc2NvcmUgPSBs b2NhbGUuZmluZCgnXycpOwotICAgICAgICBpZiAodW5kZXJzY29yZSAhPSBzdGQ6OnN0cmluZzo6 bnBvcykKLSAgICAgICAgICAgIGxvY2FsZS5yZXBsYWNlKHVuZGVyc2NvcmUsIDEsICItIik7Ci0g ICAgICAgIHN0ZDo6c3RyaW5nIGFjY2VwdExhbmd1YWdlID0gbG9jYWxlICsgIiwgIiArIGxvY2Fs ZS5zdWJzdHIoMCwgMikgKyAiO3E9MC44IjsKLSAgICAgICAgcGxhdGZvcm1SZXF1ZXN0LmFkZEhl YWRlcigiQWNjZXB0LUxhbmd1YWdlIiwgYWNjZXB0TGFuZ3VhZ2UuY19zdHIoKSk7CisgICAgICAg IGlmICghaHR0cEhlYWRlckZpZWxkcygpLmNvbnRhaW5zKCJBY2NlcHQtTGFuZ3VhZ2UiKSkgewor ICAgICAgICAgICAgLy8gTG9jYWxlIGhhcyB0aGUgZm9ybSAiZW4tVVMiLiBDb25zdHJ1Y3QgYWNj ZXB0IGxhbmd1YWdlIGxpa2UgImVuLVVTLCBlbjtxPTAuOCIuCisgICAgICAgICAgICBzdGQ6OnN0 cmluZyBsb2NhbGUgPSBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6Q2xpZW50OjpnZXQoKS0+Z2V0TG9j YWxlKCk7CisgICAgICAgICAgICAvLyBQT1NJWCBsb2NhbGUgaGFzICdfJyBpbnN0ZWFkIG9mICct Jy4KKyAgICAgICAgICAgIC8vIFJlcGxhY2UgdG8gY29uZm9ybSB0byBIVFRQIHNwZWMuCisgICAg ICAgICAgICBzaXplX3QgdW5kZXJzY29yZSA9IGxvY2FsZS5maW5kKCdfJyk7CisgICAgICAgICAg ICBpZiAodW5kZXJzY29yZSAhPSBzdGQ6OnN0cmluZzo6bnBvcykKKyAgICAgICAgICAgICAgICBs b2NhbGUucmVwbGFjZSh1bmRlcnNjb3JlLCAxLCAiLSIpOworICAgICAgICAgICAgc3RkOjpzdHJp bmcgYWNjZXB0TGFuZ3VhZ2UgPSBsb2NhbGUgKyAiLCAiICsgbG9jYWxlLnN1YnN0cigwLCAyKSAr ICI7cT0wLjgiOworICAgICAgICAgICAgcGxhdGZvcm1SZXF1ZXN0LmFkZEhlYWRlcigiQWNjZXB0 LUxhbmd1YWdlIiwgYWNjZXB0TGFuZ3VhZ2UuY19zdHIoKSk7CisgICAgICAgIH0KICAgICB9CiB9 CiAK