83665 2012-04-10 23:18:05 -0700 [TexmapGL] Reduce the number of glTexSubImage2D calls 2012-06-16 09:16:40 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 igor.oliveira igor.oliveira dongseong.hwang noam webkit.review.bot oldest_to_newest 600055 0 igor.oliveira 2012-04-10 23:18:05 -0700 When the OpenGLES driver does not support GL_EXT_unpack_subimage, BitmapTextureGL::updateContents is transfering the pixels row by row, sometimes calling glTexSubImage2D more than 40 times. This approach is ok for almost all drivers, however for some low end drivers can be a problem. 600059 1 136630 igor.oliveira 2012-04-10 23:24:24 -0700 Created attachment 136630 Patch Proposed patch. 600204 2 136630 noam 2012-04-11 05:07:06 -0700 Comment on attachment 136630 Patch Any idea if this is actually faster? 600395 3 136695 igor.oliveira 2012-04-11 10:41:13 -0700 Created attachment 136695 Patch Proposed patch v2. 600406 4 igor.oliveira 2012-04-11 10:47:07 -0700 i did some tests using callgrind and it shows improvements. But it also depends of the graphics driver, in mali drivers i believe the memory is shared between the cpu and gpu so the old code can be fast. (In reply to comment #2) > (From update of attachment 136630 [details]) > Any idea if this is actually faster? 600424 5 136695 noam 2012-04-11 11:02:37 -0700 Comment on attachment 136695 Patch This still feels a bit like a micro-optimization that might have different results on different graphics drivers... I'd rather come back to this after we know the pros/cons better. 650737 6 dongseong.hwang 2012-06-15 22:24:47 -0700 I think less glTexSubImage2D call is better, although I have no clue to convince you. http://origin-developer.nvidia.com/docs/IO/8230/BatchBatchBatch.pdf?q=docs/IO/8230/BatchBatchBatch.pdf It is be widely known that less drawing call, better performance. So, I think the fact may apply glTexSubImage2D, also, because glTexSubImage2D causes data transfer from cpu to gpu like drawing call. 650789 7 136695 noam 2012-06-16 06:57:55 -0700 Comment on attachment 136695 Patch OK, I think you have some merit. 650805 8 136695 webkit.review.bot 2012-06-16 09:16:36 -0700 Comment on attachment 136695 Patch Clearing flags on attachment: 136695 Committed r120527: <http://trac.webkit.org/changeset/120527> 650806 9 webkit.review.bot 2012-06-16 09:16:40 -0700 All reviewed patches have been landed. Closing bug. 136630 2012-04-10 23:24:24 -0700 2012-04-11 10:41:13 -0700 Patch 0001-TexmapGL-Reduce-the-number-of-glTexSubImage2D-calls.patch text/plain 2870 igor.oliveira RnJvbSAzNTJkMDk0OWU5YzEzNGIzY2I3OTJmZGVlZTc1ZGYzNjMzMzIwY2RlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBJZ29yIE9saXZlaXJhIDxpZ29yLm9Ac2lzYS5zYW1zdW5nLmNv bT4KRGF0ZTogVHVlLCAxMCBBcHIgMjAxMiAyMzoxODozNCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hd IFtUZXhtYXBHTF0gUmVkdWNlIHRoZSBudW1iZXIgb2YgZ2xUZXhTdWJJbWFnZTJEIGNhbGxzCgot LS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwg ICAxMyArKysrKysrKysrKysrCiAuLi4vcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVN YXBwZXJHTC5jcHAgICB8ICAgMTYgKysrKysrKysrKysrKy0tLQogMiBmaWxlcyBjaGFuZ2VkLCAy NiBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzYjNlOWRlLi5k OWIzNjgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDQtMTAgIElnb3IgT2xp dmVpcmEgIDxpZ29yLm9Ac2lzYS5zYW1zdW5nLmNvbT4KKworICAgICAgICBbVGV4bWFwR0xdIFJl ZHVjZSB0aGUgbnVtYmVyIG9mIGdsVGV4U3ViSW1hZ2UyRCBjYWxscworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODM2NjUKKworICAgICAgICBJbnN0ZWFk IG9mIGNvcHkgdGhlIHBpeGVscyByb3cgYnkgcm93LCBwdXQgdGhlIHBpeGVscyBpbiBhIGJ1ZmZl ciBhbmQKKyAgICAgICAgY2FsbCBnbFRleFN1YkltYWdlMkQganVzdCBvbmNlLgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvdGV4bWFwL1RleHR1cmVNYXBwZXJHTC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpCaXRtYXBU ZXh0dXJlR0w6OnVwZGF0ZUNvbnRlbnRzKToKKwogMjAxMi0wNC0xMCAgUGV0ZXIgUnliaW4gIDxw ZXRlci5yeWJpbkBnbWFpbC5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogQ29kZUdlbmVy YXRvckluc3BlY3Rvci5weTogZG8gbm90IGV4cG9zZSByYXcgbWV0aG9kcyBmcm9tIGdlbmVyYXRl ZCB0eXBlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4 bWFwL1RleHR1cmVNYXBwZXJHTC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy90ZXhtYXAvVGV4dHVyZU1hcHBlckdMLmNwcAppbmRleCBjMzRmMmM0Li41OGI5ZmZiIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1h cHBlckdMLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAv VGV4dHVyZU1hcHBlckdMLmNwcApAQCAtNDU0LDEzICs0NTQsMjMgQEAgdm9pZCBCaXRtYXBUZXh0 dXJlR0w6OnVwZGF0ZUNvbnRlbnRzKGNvbnN0IHZvaWQqIGRhdGEsIGNvbnN0IEludFJlY3QmIHRh cmdldFJlY3QKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAgIC8vIEZvciBFUyBkcml2ZXJz IHRoYXQgZG9uJ3Qgc3VwcG9ydCBzdWItaW1hZ2VzLCB0cmFuc2ZlciB0aGUgcGl4ZWxzIHJvdy1i eS1yb3cuCisgICAgLy8gRm9yIEVTIGRyaXZlcnMgdGhhdCBkb24ndCBzdXBwb3J0IHN1Yi1pbWFn ZXMuCiAgICAgaWYgKCFkcml2ZXJTdXBwb3J0c1N1YkltYWdlKCkpIHsKICAgICAgICAgY29uc3Qg Y2hhciogYml0cyA9IHN0YXRpY19jYXN0PGNvbnN0IGNoYXIqPihkYXRhKTsKKyAgICAgICAgY29u c3QgY2hhciogc3JjID0gYml0cyArIHNvdXJjZU9mZnNldC55KCkgKiBieXRlc1BlckxpbmUgKyBz b3VyY2VPZmZzZXQueCgpICogNDsKKyAgICAgICAgY2hhciogdGVtcG9yYXJ5RGF0YSA9IG5ldyBj aGFyW3RhcmdldFJlY3Qud2lkdGgoKSAqIHRhcmdldFJlY3QuaGVpZ2h0KCkgKiA0XTsKKyAgICAg ICAgY2hhciogZHN0ID0gdGVtcG9yYXJ5RGF0YTsKKworICAgICAgICBjb25zdCBpbnQgdGFyZ2V0 Qnl0ZXNQZXJMaW5lID0gdGFyZ2V0UmVjdC53aWR0aCgpICogNDsKICAgICAgICAgZm9yIChpbnQg eSA9IDA7IHkgPCB0YXJnZXRSZWN0LmhlaWdodCgpOyArK3kpIHsKLSAgICAgICAgICAgIGNvbnN0 IGNoYXIgKnJvdyA9IGJpdHMgKyAoKHNvdXJjZU9mZnNldC55KCkgKyB5KSAqIGJ5dGVzUGVyTGlu ZSArIHNvdXJjZU9mZnNldC54KCkgKiA0KTsKLSAgICAgICAgICAgIEdMX0NNRChnbFRleFN1Yklt YWdlMkQoR0xfVEVYVFVSRV8yRCwgMCwgdGFyZ2V0UmVjdC54KCksIHRhcmdldFJlY3QueSgpICsg eSwgdGFyZ2V0UmVjdC53aWR0aCgpLCAxLCBnbEZvcm1hdCwgREVGQVVMVF9URVhUVVJFX1BJWEVM X1RSQU5TRkVSX1RZUEUsIHJvdykpOworICAgICAgICAgICAgbWVtY3B5KGRzdCwgc3JjLCB0YXJn ZXRCeXRlc1BlckxpbmUpOworICAgICAgICAgICAgc3JjICs9IGJ5dGVzUGVyTGluZTsKKyAgICAg ICAgICAgIGRzdCArPSB0YXJnZXRCeXRlc1BlckxpbmU7CiAgICAgICAgIH0KKworICAgICAgICBH TF9DTUQoZ2xUZXhTdWJJbWFnZTJEKEdMX1RFWFRVUkVfMkQsIDAsIHRhcmdldFJlY3QueCgpLCB0 YXJnZXRSZWN0LnkoKSwgdGFyZ2V0UmVjdC53aWR0aCgpLCB0YXJnZXRSZWN0LmhlaWdodCgpLCBn bEZvcm1hdCwgREVGQVVMVF9URVhUVVJFX1BJWEVMX1RSQU5TRkVSX1RZUEUsIHRlbXBvcmFyeURh dGEpKTsKKworICAgICAgICBmcmVlKHRlbXBvcmFyeURhdGEpOwogICAgICAgICByZXR1cm47CiAg ICAgfQogCi0tIAoxLjcuNS40Cgo= 136695 2012-04-11 10:41:13 -0700 2012-06-16 09:16:35 -0700 Patch 0001-TexmapGL-Reduce-the-number-of-glTexSubImage2D-calls.patch text/plain 2846 igor.oliveira RnJvbSAxMjM4MmU4NzQxNGQ5NzdkZmI3MzU2NmU2OGIzM2M1ZDQ3Yzc5NDQ0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBJZ29yIE9saXZlaXJhIDxpZ29yLm9Ac2lzYS5zYW1zdW5nLmNv bT4KRGF0ZTogVHVlLCAxMCBBcHIgMjAxMiAyMzoxODozNCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hd IFtUZXhtYXBHTF0gUmVkdWNlIHRoZSBudW1iZXIgb2YgZ2xUZXhTdWJJbWFnZTJEIGNhbGxzCgot LS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwg ICAxMyArKysrKysrKysrKysrCiAuLi4vcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVN YXBwZXJHTC5jcHAgICB8ICAgMTQgKysrKysrKysrKystLS0KIDIgZmlsZXMgY2hhbmdlZCwgMjQg aW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2IzZTlkZS4uZDli MzY4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA0LTEwICBJZ29yIE9saXZl aXJhICA8aWdvci5vQHNpc2Euc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW1RleG1hcEdMXSBSZWR1 Y2UgdGhlIG51bWJlciBvZiBnbFRleFN1YkltYWdlMkQgY2FsbHMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzNjY1CisKKyAgICAgICAgSW5zdGVhZCBv ZiBjb3B5IHRoZSBwaXhlbHMgcm93IGJ5IHJvdywgcHV0IHRoZSBwaXhlbHMgaW4gYSBidWZmZXIg YW5kCisgICAgICAgIGNhbGwgZ2xUZXhTdWJJbWFnZTJEIGp1c3Qgb25jZS4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L3RleG1hcC9UZXh0dXJlTWFwcGVyR0wuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Qml0bWFwVGV4 dHVyZUdMOjp1cGRhdGVDb250ZW50cyk6CisKIDIwMTItMDQtMTAgIFBldGVyIFJ5YmluICA8cGV0 ZXIucnliaW5AZ21haWwuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IENvZGVHZW5lcmF0 b3JJbnNwZWN0b3IucHk6IGRvIG5vdCBleHBvc2UgcmF3IG1ldGhvZHMgZnJvbSBnZW5lcmF0ZWQg dHlwZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1h cC9UZXh0dXJlTWFwcGVyR0wuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv dGV4bWFwL1RleHR1cmVNYXBwZXJHTC5jcHAKaW5kZXggYzM0ZjJjNC4uMTJmNjEyMiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBw ZXJHTC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1Rl eHR1cmVNYXBwZXJHTC5jcHAKQEAgLTQ1NCwxMyArNDU0LDIxIEBAIHZvaWQgQml0bWFwVGV4dHVy ZUdMOjp1cGRhdGVDb250ZW50cyhjb25zdCB2b2lkKiBkYXRhLCBjb25zdCBJbnRSZWN0JiB0YXJn ZXRSZWN0CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICAvLyBGb3IgRVMgZHJpdmVycyB0 aGF0IGRvbid0IHN1cHBvcnQgc3ViLWltYWdlcywgdHJhbnNmZXIgdGhlIHBpeGVscyByb3ctYnkt cm93LgorICAgIC8vIEZvciBFUyBkcml2ZXJzIHRoYXQgZG9uJ3Qgc3VwcG9ydCBzdWItaW1hZ2Vz LgogICAgIGlmICghZHJpdmVyU3VwcG9ydHNTdWJJbWFnZSgpKSB7CiAgICAgICAgIGNvbnN0IGNo YXIqIGJpdHMgPSBzdGF0aWNfY2FzdDxjb25zdCBjaGFyKj4oZGF0YSk7CisgICAgICAgIGNvbnN0 IGNoYXIqIHNyYyA9IGJpdHMgKyBzb3VyY2VPZmZzZXQueSgpICogYnl0ZXNQZXJMaW5lICsgc291 cmNlT2Zmc2V0LngoKSAqIDQ7CisgICAgICAgIFZlY3RvcjxjaGFyPiB0ZW1wb3JhcnlEYXRhKHRh cmdldFJlY3Qud2lkdGgoKSAqIHRhcmdldFJlY3QuaGVpZ2h0KCkgKiA0KTsKKyAgICAgICAgY2hh ciogZHN0ID0gdGVtcG9yYXJ5RGF0YS5kYXRhKCk7CisKKyAgICAgICAgY29uc3QgaW50IHRhcmdl dEJ5dGVzUGVyTGluZSA9IHRhcmdldFJlY3Qud2lkdGgoKSAqIDQ7CiAgICAgICAgIGZvciAoaW50 IHkgPSAwOyB5IDwgdGFyZ2V0UmVjdC5oZWlnaHQoKTsgKyt5KSB7Ci0gICAgICAgICAgICBjb25z dCBjaGFyICpyb3cgPSBiaXRzICsgKChzb3VyY2VPZmZzZXQueSgpICsgeSkgKiBieXRlc1Blckxp bmUgKyBzb3VyY2VPZmZzZXQueCgpICogNCk7Ci0gICAgICAgICAgICBHTF9DTUQoZ2xUZXhTdWJJ bWFnZTJEKEdMX1RFWFRVUkVfMkQsIDAsIHRhcmdldFJlY3QueCgpLCB0YXJnZXRSZWN0LnkoKSAr IHksIHRhcmdldFJlY3Qud2lkdGgoKSwgMSwgZ2xGb3JtYXQsIERFRkFVTFRfVEVYVFVSRV9QSVhF TF9UUkFOU0ZFUl9UWVBFLCByb3cpKTsKKyAgICAgICAgICAgIG1lbWNweShkc3QsIHNyYywgdGFy Z2V0Qnl0ZXNQZXJMaW5lKTsKKyAgICAgICAgICAgIHNyYyArPSBieXRlc1BlckxpbmU7CisgICAg ICAgICAgICBkc3QgKz0gdGFyZ2V0Qnl0ZXNQZXJMaW5lOwogICAgICAgICB9CisKKyAgICAgICAg R0xfQ01EKGdsVGV4U3ViSW1hZ2UyRChHTF9URVhUVVJFXzJELCAwLCB0YXJnZXRSZWN0LngoKSwg dGFyZ2V0UmVjdC55KCksIHRhcmdldFJlY3Qud2lkdGgoKSwgdGFyZ2V0UmVjdC5oZWlnaHQoKSwg Z2xGb3JtYXQsIERFRkFVTFRfVEVYVFVSRV9QSVhFTF9UUkFOU0ZFUl9UWVBFLCB0ZW1wb3JhcnlE YXRhLmRhdGEoKSkpOwogICAgICAgICByZXR1cm47CiAgICAgfQogCi0tIAoxLjcuNS40Cgo=