83642 2012-04-10 17:39:43 -0700 [chromium] Signedness issue with code informing v8 of PatternSkia memory use 2012-04-10 23:29:43 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pkasting enne enne jamesr webkit.review.bot oldest_to_newest 599845 0 pkasting 2012-04-10 17:39:43 -0700 http://trac.webkit.org/changeset/109171 added code to inform v8 about memory used in PatternSkia. However, there's a signedness problem with this code: 62>..\platform\graphics\skia\PatternSkia.cpp(50) : warning C4146: unary minus operator applied to unsigned type, result still unsigned It seems like the result of this will be that v8 gets an increasingly distorted picture of memory use as these pattern objects are destroyed. P.S. Is there some way we could build WebKit with warnings=errors? 599856 1 jamesr 2012-04-10 17:47:37 -0700 (In reply to comment #0) > P.S. Is there some way we could build WebKit with warnings=errors? Yes. Set the compile setting to warning=error, fix all the warnings that show up, and then check that in. 599908 2 136600 enne 2012-04-10 18:38:41 -0700 Created attachment 136600 Patch 599912 3 136600 jamesr 2012-04-10 18:40:41 -0700 Comment on attachment 136600 Patch OK 599913 4 136603 enne 2012-04-10 18:42:57 -0700 Created attachment 136603 Using using for std 599914 5 136603 pkasting 2012-04-10 18:45:23 -0700 Comment on attachment 136603 Using using for std Really? We can't just std::-qualify things? I have so much hatred for "using namespace". 599920 6 136603 jamesr 2012-04-10 18:49:54 -0700 Comment on attachment 136603 Using using for std Right: http://www.webkit.org/coding/coding-style.html#using-in-cpp 599932 7 enne 2012-04-10 19:09:01 -0700 (In reply to comment #5) > (From update of attachment 136603 [details]) > Really? We can't just std::-qualify things? > > I have so much hatred for "using namespace". Tell me about it. 600016 8 pkasting 2012-04-10 21:45:45 -0700 You guys know more than I do, but I read that as forbidding "using std::XYZ" rather than forbidding just std::-qualifying the actual usages (and avoiding "using" altogether). 600060 9 136603 webkit.review.bot 2012-04-10 23:29:39 -0700 Comment on attachment 136603 Using using for std Clearing flags on attachment: 136603 Committed r113830: <http://trac.webkit.org/changeset/113830> 600061 10 webkit.review.bot 2012-04-10 23:29:43 -0700 All reviewed patches have been landed. Closing bug. 136600 2012-04-10 18:38:41 -0700 2012-04-10 18:42:54 -0700 Patch bug-83642-20120410183840.patch text/plain 2420 enne U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2IzZTlkZTM4ZDA0NGNk M2RmNTJiMzQ2ZDQ1YjQ5OThlNWZiM2JmOC4uNDhjMWY2YTViMDdmYjJhN2U1ZDIxNzgwMTg4MjZm NTM2NTBmNWU2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA0LTEwICBBZHJp ZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5jb20+CisKKyAgICAgICAgW2Nocm9taXVtXSBTaWdu ZWRuZXNzIGlzc3VlIHdpdGggY29kZSBpbmZvcm1pbmcgdjggb2YgUGF0dGVyblNraWEgbWVtb3J5 IHVzZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODM2 NDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUg dW5hcnkgbmVnYXRpb24gb2Ygc2l6ZV90IGlzIHN0aWxsIGEgc2l6ZV90LCBzbyBjbGFtcCBhbmQg Y2FzdCB0bworICAgICAgICBhbiBpbnQgaW5zdGVhZCB3aGVuIGFkanVzdGluZyB2OCBtZW1vcnkg bGltaXRzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvUGF0dGVybi5oOgorICAgICAg ICAoUGF0dGVybik6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QYXR0ZXJuU2tp YS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYXR0ZXJuOjpwbGF0Zm9ybVBhdHRlcm4pOgorCiAy MDEyLTA0LTEwICBQZXRlciBSeWJpbiAgPHBldGVyLnJ5YmluQGdtYWlsLmNvbT4KIAogICAgICAg ICBXZWIgSW5zcGVjdG9yOiBDb2RlR2VuZXJhdG9ySW5zcGVjdG9yLnB5OiBkbyBub3QgZXhwb3Nl IHJhdyBtZXRob2RzIGZyb20gZ2VuZXJhdGVkIHR5cGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9QYXR0ZXJuLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9QYXR0ZXJuLmgKaW5kZXggMDkwOTU4NGEwNDA5OGEzNjhmMjE5MDMwYWI5ODg1 YTE2MDk4ZjY4OC4uN2VkNWMwZjQ3YTE0OTgxMDE4MGMwYThmNmQ0YmUwYzMzODg4MDJhOSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvUGF0dGVybi5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1BhdHRlcm4uaApAQCAtOTYsNyArOTYs NyBAQCBwcml2YXRlOgogICAgIEFmZmluZVRyYW5zZm9ybSBtX3BhdHRlcm5TcGFjZVRyYW5zZm9y bWF0aW9uOwogICAgIFBsYXRmb3JtUGF0dGVyblB0ciBtX3BhdHRlcm47CiAjaWYgVVNFKFNLSUEp Ci0gICAgc2l6ZV90IG1fZXh0ZXJuYWxNZW1vcnlBbGxvY2F0ZWQ7CisgICAgaW50IG1fZXh0ZXJu YWxNZW1vcnlBbGxvY2F0ZWQ7CiAjZW5kaWYKIH07CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGF0dGVyblNraWEuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QYXR0ZXJuU2tpYS5jcHAKaW5kZXggY2M5MWM2M2Rh Y2U4ZTFiNTE4NDI4Zjg2YWE0YmEyMzU2N2I3N2UyMi4uMTQ4MzhmZmYzYzg3ZWMzOWQ5OWQ5NTRm ZWRhZDQ0ZWM0NGU2YjY4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3Mvc2tpYS9QYXR0ZXJuU2tpYS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3Mvc2tpYS9QYXR0ZXJuU2tpYS5jcHAKQEAgLTk2LDcgKzk2LDggQEAgUGxhdGZvcm1Q YXR0ZXJuUHRyIFBhdHRlcm46OnBsYXRmb3JtUGF0dGVybihjb25zdCBBZmZpbmVUcmFuc2Zvcm0m IHBhdHRlcm5UcmFuc2YKICAgICAgICAgY2FudmFzLmRyYXdCaXRtYXAoaW1hZ2UtPmJpdG1hcCgp LCAwLCAwKTsKICAgICAgICAgbV9wYXR0ZXJuID0gU2tTaGFkZXI6OkNyZWF0ZUJpdG1hcFNoYWRl cihibTIsIHRpbGVNb2RlWCwgdGlsZU1vZGVZKTsKIAotICAgICAgICBtX2V4dGVybmFsTWVtb3J5 QWxsb2NhdGVkID0gYm0yLmdldFNhZmVTaXplKCk7CisgICAgICAgIC8vIENsYW1wIHRvIGludCwg c2luY2UgdGhhdCdzIHdoYXQgdGhlIGFkanVzdCBmdW5jdGlvbiB0YWtlcy4KKyAgICAgICAgbV9l eHRlcm5hbE1lbW9yeUFsbG9jYXRlZCA9IHN0YXRpY19jYXN0PGludD4oc3RkOjptaW4oc3RhdGlj X2Nhc3Q8c2l6ZV90PihJTlRfTUFYKSwgYm0yLmdldFNhZmVTaXplKCkpKTsKICAgICAgICAgdjg6 OlY4OjpBZGp1c3RBbW91bnRPZkV4dGVybmFsQWxsb2NhdGVkTWVtb3J5KG1fZXh0ZXJuYWxNZW1v cnlBbGxvY2F0ZWQpOwogICAgIH0KICAgICBtX3BhdHRlcm4tPnNldExvY2FsTWF0cml4KG1fcGF0 dGVyblNwYWNlVHJhbnNmb3JtYXRpb24pOwo= 136603 2012-04-10 18:42:57 -0700 2012-04-10 23:29:39 -0700 Using using for std bug-83642-20120410184256.patch text/plain 2534 enne U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2IzZTlkZTM4ZDA0NGNk M2RmNTJiMzQ2ZDQ1YjQ5OThlNWZiM2JmOC4uNDhjMWY2YTViMDdmYjJhN2U1ZDIxNzgwMTg4MjZm NTM2NTBmNWU2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA0LTEwICBBZHJp ZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5jb20+CisKKyAgICAgICAgW2Nocm9taXVtXSBTaWdu ZWRuZXNzIGlzc3VlIHdpdGggY29kZSBpbmZvcm1pbmcgdjggb2YgUGF0dGVyblNraWEgbWVtb3J5 IHVzZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODM2 NDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUg dW5hcnkgbmVnYXRpb24gb2Ygc2l6ZV90IGlzIHN0aWxsIGEgc2l6ZV90LCBzbyBjbGFtcCBhbmQg Y2FzdCB0bworICAgICAgICBhbiBpbnQgaW5zdGVhZCB3aGVuIGFkanVzdGluZyB2OCBtZW1vcnkg bGltaXRzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvUGF0dGVybi5oOgorICAgICAg ICAoUGF0dGVybik6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QYXR0ZXJuU2tp YS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYXR0ZXJuOjpwbGF0Zm9ybVBhdHRlcm4pOgorCiAy MDEyLTA0LTEwICBQZXRlciBSeWJpbiAgPHBldGVyLnJ5YmluQGdtYWlsLmNvbT4KIAogICAgICAg ICBXZWIgSW5zcGVjdG9yOiBDb2RlR2VuZXJhdG9ySW5zcGVjdG9yLnB5OiBkbyBub3QgZXhwb3Nl IHJhdyBtZXRob2RzIGZyb20gZ2VuZXJhdGVkIHR5cGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9QYXR0ZXJuLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9QYXR0ZXJuLmgKaW5kZXggMDkwOTU4NGEwNDA5OGEzNjhmMjE5MDMwYWI5ODg1 YTE2MDk4ZjY4OC4uN2VkNWMwZjQ3YTE0OTgxMDE4MGMwYThmNmQ0YmUwYzMzODg4MDJhOSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvUGF0dGVybi5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1BhdHRlcm4uaApAQCAtOTYsNyArOTYs NyBAQCBwcml2YXRlOgogICAgIEFmZmluZVRyYW5zZm9ybSBtX3BhdHRlcm5TcGFjZVRyYW5zZm9y bWF0aW9uOwogICAgIFBsYXRmb3JtUGF0dGVyblB0ciBtX3BhdHRlcm47CiAjaWYgVVNFKFNLSUEp Ci0gICAgc2l6ZV90IG1fZXh0ZXJuYWxNZW1vcnlBbGxvY2F0ZWQ7CisgICAgaW50IG1fZXh0ZXJu YWxNZW1vcnlBbGxvY2F0ZWQ7CiAjZW5kaWYKIH07CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGF0dGVyblNraWEuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QYXR0ZXJuU2tpYS5jcHAKaW5kZXggY2M5MWM2M2Rh Y2U4ZTFiNTE4NDI4Zjg2YWE0YmEyMzU2N2I3N2UyMi4uODg5NWZhZmI3YzlhMzcwNmFiZjE4OWVk ZGVkYzdmOWVlNTFmYjA2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3Mvc2tpYS9QYXR0ZXJuU2tpYS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3Mvc2tpYS9QYXR0ZXJuU2tpYS5jcHAKQEAgLTQwLDYgKzQwLDggQEAKIAogI2luY2x1 ZGUgPHY4Lmg+CiAKK3VzaW5nIG5hbWVzcGFjZSBzdGQ7CisKIG5hbWVzcGFjZSBXZWJDb3JlIHsK IAogdm9pZCBQYXR0ZXJuOjpwbGF0Zm9ybURlc3Ryb3koKQpAQCAtOTYsNyArOTgsOCBAQCBQbGF0 Zm9ybVBhdHRlcm5QdHIgUGF0dGVybjo6cGxhdGZvcm1QYXR0ZXJuKGNvbnN0IEFmZmluZVRyYW5z Zm9ybSYgcGF0dGVyblRyYW5zZgogICAgICAgICBjYW52YXMuZHJhd0JpdG1hcChpbWFnZS0+Yml0 bWFwKCksIDAsIDApOwogICAgICAgICBtX3BhdHRlcm4gPSBTa1NoYWRlcjo6Q3JlYXRlQml0bWFw U2hhZGVyKGJtMiwgdGlsZU1vZGVYLCB0aWxlTW9kZVkpOwogCi0gICAgICAgIG1fZXh0ZXJuYWxN ZW1vcnlBbGxvY2F0ZWQgPSBibTIuZ2V0U2FmZVNpemUoKTsKKyAgICAgICAgLy8gQ2xhbXAgdG8g aW50LCBzaW5jZSB0aGF0J3Mgd2hhdCB0aGUgYWRqdXN0IGZ1bmN0aW9uIHRha2VzLgorICAgICAg ICBtX2V4dGVybmFsTWVtb3J5QWxsb2NhdGVkID0gc3RhdGljX2Nhc3Q8aW50PihtaW4oc3RhdGlj X2Nhc3Q8c2l6ZV90PihJTlRfTUFYKSwgYm0yLmdldFNhZmVTaXplKCkpKTsKICAgICAgICAgdjg6 OlY4OjpBZGp1c3RBbW91bnRPZkV4dGVybmFsQWxsb2NhdGVkTWVtb3J5KG1fZXh0ZXJuYWxNZW1v cnlBbGxvY2F0ZWQpOwogICAgIH0KICAgICBtX3BhdHRlcm4tPnNldExvY2FsTWF0cml4KG1fcGF0 dGVyblNwYWNlVHJhbnNmb3JtYXRpb24pOwo=