83641 2012-04-10 17:35:57 -0700 Chromium perf bots should not build 2012-04-15 16:15:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77037 1 rniwa rniwa abarth dpranke eric lforschler tony oldest_to_newest 599839 0 rniwa 2012-04-10 17:35:57 -0700 Chromium perf bots should not build 599840 1 136582 rniwa 2012-04-10 17:37:02 -0700 Created attachment 136582 Patch 599844 2 rniwa 2012-04-10 17:39:42 -0700 e.g. on this Chromium Mac build, we could reduce the cycle time by as much as 38 minutes (out of 88 minutes): http://build.webkit.org/builders/Chromium%20Mac%20Release%20%28Perf%29/builds/1465 599848 3 rniwa 2012-04-10 17:41:43 -0700 (In reply to comment #2) > e.g. on this Chromium Mac build, we could reduce the cycle time by as much as 38 minutes (out of 88 minutes): > http://build.webkit.org/builders/Chromium%20Mac%20Release%20%28Perf%29/builds/1465 Ugh... actually 45 minutes - (whatever takes to download the archive; roughly one minute on http://build.webkit.org/builders/Chromium%20Mac%20Release%20%28Tests%29/builds/15116). 601796 4 136582 eric 2012-04-12 20:43:10 -0700 Comment on attachment 136582 Patch I can rubber-stamp this, but I'm not useful for a real review. 602806 5 rniwa 2012-04-15 16:15:22 -0700 Committed r114214: <http://trac.webkit.org/changeset/114214> 136582 2012-04-10 17:37:02 -0700 2012-04-12 20:43:10 -0700 Patch bug-83641-20120410173701.patch text/plain 5325 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDExMzc5NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDEyLTA0LTEwICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIENocm9taXVtIHBlcmYgYm90cyBzaG91bGQgbm90IGJ1aWxkCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzY0MQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvbid0IGJ1aWxkIG9uIHBlcmYg Ym90cyB0byBpbXByb3ZlIHRoZSBjeWNsZSB0aW1lLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1 cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvY29uZmlnLmpzb246CisKIDIwMTItMDQtMTAg IE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBBZGQgYSBjaHJvbWVs ZXNzIHZpZXcgdG8gdGhlIGluZGl2aWR1YWwgdGVzdHMgdmlldwpJbmRleDogVG9vbHMvQnVpbGRT bGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvY29uZmlnLmpzb24KPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvY29u ZmlnLmpzb24JKHJldmlzaW9uIDExMzA5NCkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1 aWxkLndlYmtpdC5vcmctY29uZmlnL2NvbmZpZy5qc29uCSh3b3JraW5nIGNvcHkpCkBAIC0yMjcs NyArMjI3LDcgQEAKICAgICAgICAgICAgICAgICAgICAgewogICAgICAgICAgICAgICAgICAgICAg ICJuYW1lIjogIkNocm9taXVtIFdpbiBSZWxlYXNlIiwgInR5cGUiOiAiQnVpbGQiLCAiYnVpbGRk aXIiOiAiY2hyb21pdW0td2luLXJlbGVhc2UiLAogICAgICAgICAgICAgICAgICAgICAgICJwbGF0 Zm9ybSI6ICJjaHJvbWl1bS13aW4iLCAiY29uZmlndXJhdGlvbiI6ICJyZWxlYXNlIiwgImFyY2hp dGVjdHVyZXMiOiBbImkzODYiXSwKLSAgICAgICAgICAgICAgICAgICAgICAidHJpZ2dlcnMiOiBb ImNocm9taXVtLXdpbi1yZWxlYXNlLXRlc3RzIl0sCisgICAgICAgICAgICAgICAgICAgICAgInRy aWdnZXJzIjogWyJjaHJvbWl1bS13aW4tcmVsZWFzZS10ZXN0cyIsICJjaHJvbWl1bS13aW4tcGVy Zi10ZXN0cyJdLAogICAgICAgICAgICAgICAgICAgICAgICJzbGF2ZW5hbWVzIjogWyJnb29nbGUt d2luZG93cy0xIl0KICAgICAgICAgICAgICAgICAgICAgfSwKICAgICAgICAgICAgICAgICAgICAg ewpAQCAtMjM2LDE0ICsyMzYsMTQgQEAKICAgICAgICAgICAgICAgICAgICAgICAic2xhdmVuYW1l cyI6IFsiZ29vZ2xlLXdpbmRvd3MtMiJdCiAgICAgICAgICAgICAgICAgICAgIH0sCiAgICAgICAg ICAgICAgICAgICAgIHsKLSAgICAgICAgICAgICAgICAgICAgICAibmFtZSI6ICJDaHJvbWl1bSBX aW4gUmVsZWFzZSAoUGVyZikiLCAidHlwZSI6ICJCdWlsZEFuZFBlcmZUZXN0IiwgImJ1aWxkZGly IjogImNocm9taXVtLXdpbi1wZXJmLXRlc3RzIiwKKyAgICAgICAgICAgICAgICAgICAgICAibmFt ZSI6ICJDaHJvbWl1bSBXaW4gUmVsZWFzZSAoUGVyZikiLCAidHlwZSI6ICJEb3dubG9hZEFuZFBl cmZUZXN0IiwgImJ1aWxkZGlyIjogImNocm9taXVtLXdpbi1wZXJmLXRlc3RzIiwKICAgICAgICAg ICAgICAgICAgICAgICAicGxhdGZvcm0iOiAiY2hyb21pdW0td2luIiwgImNvbmZpZ3VyYXRpb24i OiAicmVsZWFzZSIsICJhcmNoaXRlY3R1cmVzIjogWyJpMzg2Il0sCiAgICAgICAgICAgICAgICAg ICAgICAgInNsYXZlbmFtZXMiOiBbImdvb2dsZS13aW5kb3dzLXBlcmYiXQogICAgICAgICAgICAg ICAgICAgICB9LAogICAgICAgICAgICAgICAgICAgICB7CiAgICAgICAgICAgICAgICAgICAgICAg Im5hbWUiOiAiQ2hyb21pdW0gTWFjIFJlbGVhc2UiLCAidHlwZSI6ICJCdWlsZCIsICJidWlsZGRp ciI6ICJjaHJvbWl1bS1tYWMtcmVsZWFzZSIsCiAgICAgICAgICAgICAgICAgICAgICAgInBsYXRm b3JtIjogImNocm9taXVtLW1hYyIsICJjb25maWd1cmF0aW9uIjogInJlbGVhc2UiLCAiYXJjaGl0 ZWN0dXJlcyI6IFsiaTM4NiJdLAotICAgICAgICAgICAgICAgICAgICAgICJ0cmlnZ2VycyI6IFsi Y2hyb21pdW0tbWFjLXJlbGVhc2UtdGVzdHMiXSwKKyAgICAgICAgICAgICAgICAgICAgICAidHJp Z2dlcnMiOiBbImNocm9taXVtLW1hYy1yZWxlYXNlLXRlc3RzIiwgImNocm9taXVtLW1hYy1wZXJm LXRlc3RzIl0sCiAgICAgICAgICAgICAgICAgICAgICAgInNsYXZlbmFtZXMiOiBbImdvb2dsZS1t YWMtMSIsICJnb29nbGUtbWFjLTMiXQogICAgICAgICAgICAgICAgICAgICB9LAogICAgICAgICAg ICAgICAgICAgICB7CkBAIC0yNTIsMTQgKzI1MiwxNCBAQAogICAgICAgICAgICAgICAgICAgICAg ICJzbGF2ZW5hbWVzIjogWyJnb29nbGUtbWFjLTIiLCAiZ29vZ2xlLW1hYy00Il0KICAgICAgICAg ICAgICAgICAgICAgfSwKICAgICAgICAgICAgICAgICAgICAgewotICAgICAgICAgICAgICAgICAg ICAgICJuYW1lIjogIkNocm9taXVtIE1hYyBSZWxlYXNlIChQZXJmKSIsICJ0eXBlIjogIkJ1aWxk QW5kUGVyZlRlc3QiLCAiYnVpbGRkaXIiOiAiY2hyb21pdW0tbWFjLXBlcmYtdGVzdHMiLAorICAg ICAgICAgICAgICAgICAgICAgICJuYW1lIjogIkNocm9taXVtIE1hYyBSZWxlYXNlIChQZXJmKSIs ICJ0eXBlIjogIkRvd25sb2FkQW5kUGVyZlRlc3QiLCAiYnVpbGRkaXIiOiAiY2hyb21pdW0tbWFj LXBlcmYtdGVzdHMiLAogICAgICAgICAgICAgICAgICAgICAgICJwbGF0Zm9ybSI6ICJjaHJvbWl1 bS1tYWMiLCAiY29uZmlndXJhdGlvbiI6ICJyZWxlYXNlIiwgImFyY2hpdGVjdHVyZXMiOiBbImkz ODYiXSwKICAgICAgICAgICAgICAgICAgICAgICAic2xhdmVuYW1lcyI6IFsiZ29vZ2xlLW1hYy1w ZXJmIl0KICAgICAgICAgICAgICAgICAgICAgfSwKICAgICAgICAgICAgICAgICAgICAgewogICAg ICAgICAgICAgICAgICAgICAgICJuYW1lIjogIkNocm9taXVtIExpbnV4IFJlbGVhc2UiLCAidHlw ZSI6ICJCdWlsZCIsICJidWlsZGRpciI6ICJjaHJvbWl1bS1saW51eC1yZWxlYXNlIiwKICAgICAg ICAgICAgICAgICAgICAgICAicGxhdGZvcm0iOiAiY2hyb21pdW0tbGludXgiLCAiY29uZmlndXJh dGlvbiI6ICJyZWxlYXNlIiwgImFyY2hpdGVjdHVyZXMiOiBbImkzODYiXSwKLSAgICAgICAgICAg ICAgICAgICAgICAidHJpZ2dlcnMiOiBbImNocm9taXVtLWxpbnV4LXJlbGVhc2UtdGVzdHMiXSwK KyAgICAgICAgICAgICAgICAgICAgICAidHJpZ2dlcnMiOiBbImNocm9taXVtLWxpbnV4LXJlbGVh c2UtdGVzdHMiLCAiY2hyb21pdW0tbGludXgtcGVyZi10ZXN0cyJdLAogICAgICAgICAgICAgICAg ICAgICAgICJzbGF2ZW5hbWVzIjogWyJnb29nbGUtbGludXgtMSJdCiAgICAgICAgICAgICAgICAg ICAgIH0sCiAgICAgICAgICAgICAgICAgICAgIHsKQEAgLTI2OCw3ICsyNjgsNyBAQAogICAgICAg ICAgICAgICAgICAgICAgICJzbGF2ZW5hbWVzIjogWyJnb29nbGUtbGludXgtMiJdCiAgICAgICAg ICAgICAgICAgICAgIH0sCiAgICAgICAgICAgICAgICAgICAgIHsKLSAgICAgICAgICAgICAgICAg ICAgICAibmFtZSI6ICJDaHJvbWl1bSBMaW51eCBSZWxlYXNlIChQZXJmKSIsICJ0eXBlIjogIkJ1 aWxkQW5kUGVyZlRlc3QiLCAiYnVpbGRkaXIiOiAiY2hyb21pdW0tbGludXgtcGVyZi10ZXN0cyIs CisgICAgICAgICAgICAgICAgICAgICAgIm5hbWUiOiAiQ2hyb21pdW0gTGludXggUmVsZWFzZSAo UGVyZikiLCAidHlwZSI6ICJEb3dubG9hZEFuZFBlcmZUZXN0IiwgImJ1aWxkZGlyIjogImNocm9t aXVtLWxpbnV4LXBlcmYtdGVzdHMiLAogICAgICAgICAgICAgICAgICAgICAgICJwbGF0Zm9ybSI6 ICJjaHJvbWl1bS1saW51eCIsICJjb25maWd1cmF0aW9uIjogInJlbGVhc2UiLCAiYXJjaGl0ZWN0 dXJlcyI6IFsiaTM4NiJdLAogICAgICAgICAgICAgICAgICAgICAgICJzbGF2ZW5hbWVzIjogWyJn b29nbGUtbGludXgtcGVyZiJdCiAgICAgICAgICAgICAgICAgICAgIH0sCkBAIC0zNTksMTEgKzM1 OSwyMCBAQAogICAgICAgICAgICAgICAgICAgICB7ICJ0eXBlIjogIlRyaWdnZXJhYmxlIiwgIm5h bWUiOiAiY2hyb21pdW0td2luLXJlbGVhc2UtdGVzdHMiLAogICAgICAgICAgICAgICAgICAgICAg ICJidWlsZGVyTmFtZXMiOiBbIkNocm9taXVtIFdpbiBSZWxlYXNlIChUZXN0cykiXQogICAgICAg ICAgICAgICAgICAgICB9LAorICAgICAgICAgICAgICAgICAgICB7ICJ0eXBlIjogIlRyaWdnZXJh YmxlIiwgIm5hbWUiOiAiY2hyb21pdW0td2luLXBlcmYtdGVzdHMiLAorICAgICAgICAgICAgICAg ICAgICAgICJidWlsZGVyTmFtZXMiOiBbIkNocm9taXVtIFdpbiBSZWxlYXNlIChQZXJmKSJdCisg ICAgICAgICAgICAgICAgICAgIH0sCiAgICAgICAgICAgICAgICAgICAgIHsgInR5cGUiOiAiVHJp Z2dlcmFibGUiLCAibmFtZSI6ICJjaHJvbWl1bS1tYWMtcmVsZWFzZS10ZXN0cyIsCiAgICAgICAg ICAgICAgICAgICAgICAgImJ1aWxkZXJOYW1lcyI6IFsiQ2hyb21pdW0gTWFjIFJlbGVhc2UgKFRl c3RzKSJdCiAgICAgICAgICAgICAgICAgICAgIH0sCisgICAgICAgICAgICAgICAgICAgIHsgInR5 cGUiOiAiVHJpZ2dlcmFibGUiLCAibmFtZSI6ICJjaHJvbWl1bS1tYWMtcGVyZi10ZXN0cyIsCisg ICAgICAgICAgICAgICAgICAgICAgImJ1aWxkZXJOYW1lcyI6IFsiQ2hyb21pdW0gTWFjIFJlbGVh c2UgKFBlcmYpIl0KKyAgICAgICAgICAgICAgICAgICAgfSwKICAgICAgICAgICAgICAgICAgICAg eyAidHlwZSI6ICJUcmlnZ2VyYWJsZSIsICJuYW1lIjogImNocm9taXVtLWxpbnV4LXJlbGVhc2Ut dGVzdHMiLAogICAgICAgICAgICAgICAgICAgICAgICJidWlsZGVyTmFtZXMiOiBbIkNocm9taXVt IExpbnV4IFJlbGVhc2UgKFRlc3RzKSJdCisgICAgICAgICAgICAgICAgICAgIH0sCisgICAgICAg ICAgICAgICAgICAgIHsgInR5cGUiOiAiVHJpZ2dlcmFibGUiLCAibmFtZSI6ICJjaHJvbWl1bS1s aW51eC1wZXJmLXRlc3RzIiwKKyAgICAgICAgICAgICAgICAgICAgICAiYnVpbGRlck5hbWVzIjog WyJDaHJvbWl1bSBMaW51eCBSZWxlYXNlIChQZXJmKSJdCiAgICAgICAgICAgICAgICAgICAgIH0K ICAgICAgICAgICAgICAgICAgIF0KIH0K