83625 2012-04-10 15:07:40 -0700 Remove unused WebVideoFrame::Format values 2012-04-11 08:49:31 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 fischman fischman abarth cc-bugs dglazkov eric.carlson feature-media-reviews fishd jamesr tkent webkit.review.bot oldest_to_newest 599689 0 fischman 2012-04-10 15:07:40 -0700 http://code.google.com/p/chromium/issues/detail?id=108306 removes RGB555/RGB565/RGB24/RGBA/NV12/ASCII from media::VideoFrame::Format because they were unused (except for test code, sometimes). IWBN to drop these formats from webkit, as well. 599716 1 136556 fischman 2012-04-10 15:27:07 -0700 Created attachment 136556 Patch 599720 2 webkit.review.bot 2012-04-10 15:29:34 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 599721 3 136556 kbr 2012-04-10 15:30:03 -0700 Comment on attachment 136556 Patch Looks fine. r=me 599723 4 136556 fischman 2012-04-10 15:31:15 -0700 Comment on attachment 136556 Patch (removed cq? b/c the chromium side needs to land first; I'll cq+ when that happens assuming the API review doesn't snag up) 599739 5 136556 abarth 2012-04-10 15:43:47 -0700 Comment on attachment 136556 Patch LGTM2 599825 6 136556 fischman 2012-04-10 17:20:33 -0700 Comment on attachment 136556 Patch Chromium-side landed in http://crrev.com/131682 599827 7 136556 fischman 2012-04-10 17:21:48 -0700 Comment on attachment 136556 Patch ...err, except landing in chromium isn't enough, it also needs to roll into webkit's chromium DEPS. Putting back on hold. 599982 8 136556 webkit.review.bot 2012-04-10 20:23:35 -0700 Comment on attachment 136556 Patch Attachment 136556 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12379814 599996 9 136556 fischman 2012-04-10 20:46:59 -0700 Comment on attachment 136556 Patch cr-ews failure was due to being kicked off before the roll. Should be good now. 600022 10 136556 webkit.review.bot 2012-04-10 21:56:09 -0700 Comment on attachment 136556 Patch Rejecting attachment 136556 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Frame' Source/WebKit/chromium/webkit/media/webvideoframe_impl.cc:45: error: template argument 1 is invalid Source/WebKit/chromium/webkit/media/webvideoframe_impl.cc:45: error: 'FormatASCII' is not a member of 'WebKit::WebVideoFrame' Source/WebKit/chromium/webkit/media/webvideoframe_impl.cc:45: error: invalid type in declaration before ';' token make: *** [out/Debug/obj.target/webkit_media/Source/WebKit/chromium/webkit/media/webvideoframe_impl.o] Error 1 make: *** Waiting for unfinished jobs.... Full output: http://queues.webkit.org/results/12383625 600051 11 136556 fischman 2012-04-10 23:07:50 -0700 Comment on attachment 136556 Patch Roll actually landed now... 600105 12 136556 webkit.review.bot 2012-04-11 00:49:59 -0700 Comment on attachment 136556 Patch Rejecting attachment 136556 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: webkit-commit-queue/Source/WebKit/chromium/webkit --revision 131684 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 48>At revision 131684. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/12379924 600273 13 136556 fischman 2012-04-11 08:09:51 -0700 Comment on attachment 136556 Patch If at first you don't succeed (connecting to svn.webkit.org) try, try again! 600296 14 136556 webkit.review.bot 2012-04-11 08:49:26 -0700 Comment on attachment 136556 Patch Clearing flags on attachment: 136556 Committed r113865: <http://trac.webkit.org/changeset/113865> 600297 15 webkit.review.bot 2012-04-11 08:49:31 -0700 All reviewed patches have been landed. Closing bug. 136556 2012-04-10 15:27:07 -0700 2012-04-11 08:49:26 -0700 Patch bug-83625-20120410152706.patch text/plain 6124 fischman U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNjcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmJiYWY4MDk2ZjljOWE4 N2E5NjhkYzRhM2ZlYWQxNDc5OWZhMGJmZi4uNWE2NTdlZWIxMTk2ZTcxMTZmZmU4YjBjZTQyZmQy MTRhZTlmMDVhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA0LTEwICBBbWkg RmlzY2htYW4gIDxmaXNjaG1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmVtb3ZlIHVudXNl ZCBXZWJWaWRlb0ZyYW1lOjpGb3JtYXQgdmFsdWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzYyNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9WaWRlb0ZyYW1lQ2hyb21pdW0uaDoKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1ZpZGVvTGF5ZXJJbXBsLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OmNvbnZlcnRWRkNGb3JtYXRUb0dDM0RGb3JtYXQpOgorCiAy MDEyLTA0LTA5ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAog ICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTEzNjU2LgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0No YW5nZUxvZwppbmRleCBlYWU1NWVmNjI5YjcwMDVmMzQwNTdjOWQxMmI5Y2NkYzk0MGM5YTRjLi5j MWE0MTk2MDdlZTJjYTJjZWYxM2FhNTA4N2FhN2EyMjUyNjE4Yjg1IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA0LTEwICBBbWkgRmlzY2htYW4gIDxm aXNjaG1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmVtb3ZlIHVudXNlZCBXZWJWaWRlb0Zy YW1lOjpGb3JtYXQgdmFsdWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04MzYyNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogcHVibGljL1dlYlZpZGVvRnJhbWUuaDoKKyAgICAgICAgKFdlYktpdCk6Cisg ICAgICAgICogc3JjL0Fzc2VydE1hdGNoaW5nRW51bXMuY3BwOgorCiAyMDEyLTA0LTA5ICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMTEzNjU2LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVmlkZW9GcmFtZUNocm9taXVtLmggYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9WaWRlb0ZyYW1lQ2hyb21pdW0uaAppbmRl eCAyZDc2YzQ3NTU4ZTBiOGI0YzRlODRkMDRjODA0MzkyY2RhNTQ2YzU0Li43N2FmMDdjYzM5NWUz YTUxNmVmZmVmMGQ3YzExNDRmZDczMzNkYjc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9WaWRlb0ZyYW1lQ2hyb21pdW0uaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9WaWRlb0ZyYW1lQ2hyb21pdW0u aApAQCAtNDgsMTkgKzQ4LDEzIEBAIHB1YmxpYzoKIAogICAgIC8vIFRoZXNlIGVudW1zIG11c3Qg YmUga2VwdCBpbiBzeW5jIHdpdGggV2ViS2l0OjpXZWJWaWRlb0ZyYW1lLgogICAgIGVudW0gRm9y bWF0IHsKLSAgICAgICAgSW52YWxpZCwKLSAgICAgICAgUkdCNTU1LAotICAgICAgICBSR0I1NjUs Ci0gICAgICAgIFJHQjI0LAotICAgICAgICBSR0IzMiwKLSAgICAgICAgUkdCQSwKLSAgICAgICAg WVYxMiwKLSAgICAgICAgWVYxNiwKLSAgICAgICAgTlYxMiwKLSAgICAgICAgRW1wdHksCi0gICAg ICAgIEFTQ0lJLAotICAgICAgICBJNDIwLAotICAgICAgICBOYXRpdmVUZXh0dXJlLAorICAgICAg ICBJbnZhbGlkID0gMCwKKyAgICAgICAgUkdCMzIgPSA0LAorICAgICAgICBZVjEyID0gNiwKKyAg ICAgICAgWVYxNiA9IDcsCisgICAgICAgIEVtcHR5ID0gOSwKKyAgICAgICAgSTQyMCA9IDExLAor ICAgICAgICBOYXRpdmVUZXh0dXJlID0gMTIsCiAgICAgfTsKIAogICAgIHZpcnR1YWwgflZpZGVv RnJhbWVDaHJvbWl1bSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2hyb21pdW0vY2MvQ0NWaWRlb0xheWVySW1wbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1ZpZGVvTGF5ZXJJbXBsLmNwcAppbmRleCBh NTZjZjU4OTEzZDU0ZDYyZWY4YzM0MDE2ZTgwN2JhODZhODQxOWIxLi4wZTZkY2E3ZThlNThlNmMz NzQxN2ZmM2VlZThhNGZhNzcyMGZjNzczIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1ZpZGVvTGF5ZXJJbXBsLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1ZpZGVvTGF5ZXJJbXBs LmNwcApAQCAtMTA2LDE4ICsxMDYsMTEgQEAgc3RhdGljIEdDM0RlbnVtIGNvbnZlcnRWRkNGb3Jt YXRUb0dDM0RGb3JtYXQoY29uc3QgVmlkZW9GcmFtZUNocm9taXVtKiBmcmFtZSkKICAgICBjYXNl IFZpZGVvRnJhbWVDaHJvbWl1bTo6WVYxMjoKICAgICBjYXNlIFZpZGVvRnJhbWVDaHJvbWl1bTo6 WVYxNjoKICAgICAgICAgcmV0dXJuIEdyYXBoaWNzQ29udGV4dDNEOjpMVU1JTkFOQ0U7Ci0gICAg Y2FzZSBWaWRlb0ZyYW1lQ2hyb21pdW06OlJHQkE6Ci0gICAgICAgIHJldHVybiBHcmFwaGljc0Nv bnRleHQzRDo6UkdCQTsKICAgICBjYXNlIFZpZGVvRnJhbWVDaHJvbWl1bTo6TmF0aXZlVGV4dHVy ZToKICAgICAgICAgcmV0dXJuIGZyYW1lLT50ZXh0dXJlVGFyZ2V0KCk7CiAgICAgY2FzZSBWaWRl b0ZyYW1lQ2hyb21pdW06OkludmFsaWQ6Ci0gICAgY2FzZSBWaWRlb0ZyYW1lQ2hyb21pdW06OlJH QjU1NToKLSAgICBjYXNlIFZpZGVvRnJhbWVDaHJvbWl1bTo6UkdCNTY1OgotICAgIGNhc2UgVmlk ZW9GcmFtZUNocm9taXVtOjpSR0IyNDoKICAgICBjYXNlIFZpZGVvRnJhbWVDaHJvbWl1bTo6UkdC MzI6Ci0gICAgY2FzZSBWaWRlb0ZyYW1lQ2hyb21pdW06Ok5WMTI6CiAgICAgY2FzZSBWaWRlb0Zy YW1lQ2hyb21pdW06OkVtcHR5OgotICAgIGNhc2UgVmlkZW9GcmFtZUNocm9taXVtOjpBU0NJSToK ICAgICBjYXNlIFZpZGVvRnJhbWVDaHJvbWl1bTo6STQyMDoKICAgICAgICAgbm90SW1wbGVtZW50 ZWQoKTsKICAgICB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJWaWRlb0ZyYW1lLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWRlb0Zy YW1lLmgKaW5kZXggNzg3OTA2MjdkMTllMTk3ZTkzZmIxN2U4NDliYzIxNTU4NDRhNDNkMi4uNGZh YjFmMjE5MDBjMzgwMDVmZjQ4YTQ0ODI0MDA5N2FlMWEyZWVlZCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlkZW9GcmFtZS5oCisrKyBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vcHVibGljL1dlYlZpZGVvRnJhbWUuaApAQCAtMzUsMjIgKzM1LDE3IEBAIG5h bWVzcGFjZSBXZWJLaXQgewogCiAvLyBBIHByb3h5IHZpZGVvIGZyYW1lIGludGVyZmFjZSB0byBj b21tdW5pY2F0ZSBmcmFtZSBkYXRhIGJldHdlZW4gY2hyb21pdW0KIC8vIGFuZCBXZWJLaXQuCisv LyBLZWVwIGluIHN5bmMgd2l0aCBWaWRlb0ZyYW1lQ2hyb21pdW0gYW5kIGNocm9taXVtJ3MgbWVk aWE6OlZpZGVvRnJhbWU6OkZvcm1hdC4KIGNsYXNzIFdlYlZpZGVvRnJhbWUgewogcHVibGljOgog ICAgIGVudW0gRm9ybWF0IHsKLSAgICAgICAgRm9ybWF0SW52YWxpZCwKLSAgICAgICAgRm9ybWF0 UkdCNTU1LAotICAgICAgICBGb3JtYXRSR0I1NjUsCi0gICAgICAgIEZvcm1hdFJHQjI0LAotICAg ICAgICBGb3JtYXRSR0IzMiwKLSAgICAgICAgRm9ybWF0UkdCQSwKLSAgICAgICAgRm9ybWF0WVYx MiwKLSAgICAgICAgRm9ybWF0WVYxNiwKLSAgICAgICAgRm9ybWF0TlYxMiwKLSAgICAgICAgRm9y bWF0RW1wdHksCi0gICAgICAgIEZvcm1hdEFTQ0lJLAotICAgICAgICBGb3JtYXRJNDIwLAotICAg ICAgICBGb3JtYXROYXRpdmVUZXh0dXJlLAorICAgICAgICBGb3JtYXRJbnZhbGlkID0gMCwKKyAg ICAgICAgRm9ybWF0UkdCMzIgPSA0LAorICAgICAgICBGb3JtYXRZVjEyID0gNiwKKyAgICAgICAg Rm9ybWF0WVYxNiA9IDcsCisgICAgICAgIEZvcm1hdEVtcHR5ID0gOSwKKyAgICAgICAgRm9ybWF0 STQyMCA9IDExLAorICAgICAgICBGb3JtYXROYXRpdmVUZXh0dXJlID0gMTIsCiAgICAgfTsKIAog ICAgIHZpcnR1YWwgfldlYlZpZGVvRnJhbWUoKSB7IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL0Fzc2VydE1hdGNoaW5nRW51bXMuY3BwIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvQXNzZXJ0TWF0Y2hpbmdFbnVtcy5jcHAKaW5kZXggZTIyZGRiNmMzYTliMTNk MDdiYWRkOTczZDZlMzcxZTRkY2RlMjdkYy4uZmFkNzcyZDNlNjdhNWQxNzU5ZDVlNDIxMzNiNWVi Yjk1MTMxZGViZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQXNzZXJ0 TWF0Y2hpbmdFbnVtcy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQXNzZXJ0 TWF0Y2hpbmdFbnVtcy5jcHAKQEAgLTM4OSwxNiArMzg5LDEwIEBAIENPTVBJTEVfQVNTRVJUX01B VENISU5HX0VOVU0oV2ViTWVkaWFQbGF5ZXI6OlN0b3JlZFN0cmVhbSwgTWVkaWFQbGF5ZXI6OlN0 b3JlZFN0CiBDT01QSUxFX0FTU0VSVF9NQVRDSElOR19FTlVNKFdlYk1lZGlhUGxheWVyOjpMaXZl U3RyZWFtLCBNZWRpYVBsYXllcjo6TGl2ZVN0cmVhbSk7CiAKIENPTVBJTEVfQVNTRVJUX01BVENI SU5HX0VOVU0oV2ViVmlkZW9GcmFtZTo6Rm9ybWF0SW52YWxpZCwgVmlkZW9GcmFtZUNocm9taXVt OjpJbnZhbGlkKTsKLUNPTVBJTEVfQVNTRVJUX01BVENISU5HX0VOVU0oV2ViVmlkZW9GcmFtZTo6 Rm9ybWF0UkdCNTU1LCBWaWRlb0ZyYW1lQ2hyb21pdW06OlJHQjU1NSk7Ci1DT01QSUxFX0FTU0VS VF9NQVRDSElOR19FTlVNKFdlYlZpZGVvRnJhbWU6OkZvcm1hdFJHQjU2NSwgVmlkZW9GcmFtZUNo cm9taXVtOjpSR0I1NjUpOwotQ09NUElMRV9BU1NFUlRfTUFUQ0hJTkdfRU5VTShXZWJWaWRlb0Zy YW1lOjpGb3JtYXRSR0IyNCwgVmlkZW9GcmFtZUNocm9taXVtOjpSR0IyNCk7CiBDT01QSUxFX0FT U0VSVF9NQVRDSElOR19FTlVNKFdlYlZpZGVvRnJhbWU6OkZvcm1hdFJHQjMyLCBWaWRlb0ZyYW1l Q2hyb21pdW06OlJHQjMyKTsKLUNPTVBJTEVfQVNTRVJUX01BVENISU5HX0VOVU0oV2ViVmlkZW9G cmFtZTo6Rm9ybWF0UkdCQSwgVmlkZW9GcmFtZUNocm9taXVtOjpSR0JBKTsKIENPTVBJTEVfQVNT RVJUX01BVENISU5HX0VOVU0oV2ViVmlkZW9GcmFtZTo6Rm9ybWF0WVYxMiwgVmlkZW9GcmFtZUNo cm9taXVtOjpZVjEyKTsKIENPTVBJTEVfQVNTRVJUX01BVENISU5HX0VOVU0oV2ViVmlkZW9GcmFt ZTo6Rm9ybWF0WVYxNiwgVmlkZW9GcmFtZUNocm9taXVtOjpZVjE2KTsKLUNPTVBJTEVfQVNTRVJU X01BVENISU5HX0VOVU0oV2ViVmlkZW9GcmFtZTo6Rm9ybWF0TlYxMiwgVmlkZW9GcmFtZUNocm9t aXVtOjpOVjEyKTsKIENPTVBJTEVfQVNTRVJUX01BVENISU5HX0VOVU0oV2ViVmlkZW9GcmFtZTo6 Rm9ybWF0RW1wdHksIFZpZGVvRnJhbWVDaHJvbWl1bTo6RW1wdHkpOwotQ09NUElMRV9BU1NFUlRf TUFUQ0hJTkdfRU5VTShXZWJWaWRlb0ZyYW1lOjpGb3JtYXRBU0NJSSwgVmlkZW9GcmFtZUNocm9t aXVtOjpBU0NJSSk7CiAjZW5kaWYKIAogI2lmIEVOQUJMRShOT1RJRklDQVRJT05TKSB8fCBFTkFC TEUoTEVHQUNZX05PVElGSUNBVElPTlMpCg==