83621 2012-04-10 14:41:19 -0700 Correct pixel snapping error in RenderBox::pixelSnappedClientWidth/Height 2012-04-11 18:11:24 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 leviw leviw eae eric jchaffraix webkit.review.bot oldest_to_newest 599656 0 leviw 2012-04-10 14:41:19 -0700 These pixel snapping convenience functions were failing to take the Box's location into account, which could result in reporting bad values. Thanks to Julien for catching this. 599679 1 136547 leviw 2012-04-10 14:54:40 -0700 Created attachment 136547 Patch 600362 2 136547 jchaffraix 2012-04-11 10:20:25 -0700 Comment on attachment 136547 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136547&action=review > Source/WebCore/ChangeLog:13 > + No new tests. Untestable until we switch to FractionalLayoutUnits. Did this show a difference once we switch to FractionalLayoutUnit? If not, it really sounds like we should try to land a test that would show the difference. 600576 3 leviw 2012-04-11 13:59:12 -0700 (In reply to comment #2) > (From update of attachment 136547 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=136547&action=review > > > Source/WebCore/ChangeLog:13 > > + No new tests. Untestable until we switch to FractionalLayoutUnits. > > Did this show a difference once we switch to FractionalLayoutUnit? If not, it really sounds like we should try to land a test that would show the difference. This is easy to test for once we've cut over to FractionalLayoutUnits. Currently though, the parameter that was changed is unused :p I've uploaded a test case to our sub-pixel branch that will be included when we "flip the switch." You can see it here: http://trac.webkit.org/browser/branches/subpixellayout/LayoutTests/fast/sub-pixel/client-width-height-snapping.html 600603 4 136547 eric 2012-04-11 14:42:39 -0700 Comment on attachment 136547 Patch OK. 600708 5 136787 leviw 2012-04-11 16:42:25 -0700 Created attachment 136787 Patch for landing 600710 6 leviw 2012-04-11 16:42:50 -0700 (In reply to comment #5) > Created an attachment (id=136787) [details] > Patch for landing Added a comment in the changelog explicitly stating that the test is forthcoming. 600781 7 136787 webkit.review.bot 2012-04-11 18:11:20 -0700 Comment on attachment 136787 Patch for landing Clearing flags on attachment: 136787 Committed r113932: <http://trac.webkit.org/changeset/113932> 600782 8 webkit.review.bot 2012-04-11 18:11:24 -0700 All reviewed patches have been landed. Closing bug. 136547 2012-04-10 14:54:40 -0700 2012-04-11 16:42:21 -0700 Patch bug-83621-20120410145439.patch text/plain 2468 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMzc3MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA0LTEwICBMZXZpIFdl aW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICBDb3JyZWN0IHBpeGVsIHNu YXBwaW5nIGVycm9yIGluIFJlbmRlckJveDo6cGl4ZWxTbmFwcGVkQ2xpZW50V2lkdGgvSGVpZ2h0 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzYyMQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRob3VnaCB0 aGUgcHJvYmxlbSB3b3VsZG4ndCB5ZXQgbWFuaWZlc3QgaXRzZWxmIHNpbmNlIHdlIGhhdmVuJ3Qg ZmxpcHBlZCB0aGUgc3dpdGNoIG9uIHN1Yi1waXhlbAorICAgICAgICBsYXlvdXQsIGNsaWVudFdp ZHRoIGFuZCBjbGllbnRIZWlnaHQsIHdoZW4gcGl4ZWwgc25hcHBlZCwgbmVlZCB0byB0YWtlIHRo ZSBSZW5kZXJCb3gncyBsb2NhdGlvbgorICAgICAgICBpbnRvIGFjY291bnQuIFByZXZpb3VzbHks IENsaWVudExlZnQvVG9wIHdlcmUgdXNlZCwgYnV0IHRoZXNlIGFyZSBzaW1wbHkgdGhlIHdpZHRo IG9mIHRoZSBib3JkZXJzLAorICAgICAgICBhbmQgZG9uJ3QgaW5jbHVkZSB0aGUgYm94J3Mgc3Vi LXBpeGVsIGxvY2F0aW9uLCB3aGljaCBpcyBuZWVkZWQgdG8gcHJvcGVybHkgc25hcCB0aGUgd2lk dGgvaGVpZ2h0LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVW50ZXN0YWJsZSB1bnRpbCB3ZSBz d2l0Y2ggdG8gRnJhY3Rpb25hbExheW91dFVuaXRzLgorCisgICAgICAgICogcmVuZGVyaW5nL1Jl bmRlckJveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCb3g6OnBpeGVsU25hcHBlZENs aWVudFdpZHRoKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJveDo6cGl4ZWxTbmFwcGVkQ2xp ZW50SGVpZ2h0KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJveDo6c2Nyb2xsV2lkdGgpOiBS ZXBsYWNpbmcgYSByYXcgemVybyB3aXRoIFpFUk9fTEFZT1VUX1VOSVQuCisKIDIwMTItMDQtMTAg IERhdmUgVGhhcnAgIDxkdGhhcnBAY29kZWF1cm9yYS5vcmc+CiAKICAgICAgICAgQ1NTIGJveC1z aGFkb3cgZGVmYXVsdCBjb2xvciBzaG91bGQgYmUgc29tZXRoaW5nIG90aGVyIHRoYW4gdHJhbnNw YXJlbnQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwCShyZXZpc2lv biAxMTM3NjcpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAkod29y a2luZyBjb3B5KQpAQCAtNDg3LDEyICs0ODcsMTIgQEAgTGF5b3V0VW5pdCBSZW5kZXJCb3g6OmNs aWVudEhlaWdodCgpIGNvbgogCiBpbnQgUmVuZGVyQm94OjpwaXhlbFNuYXBwZWRDbGllbnRXaWR0 aCgpIGNvbnN0CiB7Ci0gICAgcmV0dXJuIHNuYXBTaXplVG9QaXhlbChjbGllbnRXaWR0aCgpLCBj bGllbnRMZWZ0KCkpOworICAgIHJldHVybiBzbmFwU2l6ZVRvUGl4ZWwoY2xpZW50V2lkdGgoKSwg eCgpICsgY2xpZW50TGVmdCgpKTsKIH0KIAogaW50IFJlbmRlckJveDo6cGl4ZWxTbmFwcGVkQ2xp ZW50SGVpZ2h0KCkgY29uc3QKIHsKLSAgICByZXR1cm4gc25hcFNpemVUb1BpeGVsKGNsaWVudEhl aWdodCgpLCBjbGllbnRUb3AoKSk7CisgICAgcmV0dXJuIHNuYXBTaXplVG9QaXhlbChjbGllbnRI ZWlnaHQoKSwgeSgpICsgY2xpZW50VG9wKCkpOwogfQogCiBpbnQgUmVuZGVyQm94OjpzY3JvbGxX aWR0aCgpIGNvbnN0CkBAIC01MDMsNyArNTAzLDcgQEAgaW50IFJlbmRlckJveDo6c2Nyb2xsV2lk dGgoKSBjb25zdAogICAgIC8vIEZJWE1FOiBOZWVkIHRvIHdvcmsgcmlnaHQgd2l0aCB3cml0aW5n IG1vZGVzLgogICAgIGlmIChzdHlsZSgpLT5pc0xlZnRUb1JpZ2h0RGlyZWN0aW9uKCkpCiAgICAg ICAgIHJldHVybiBzbmFwU2l6ZVRvUGl4ZWwobWF4KGNsaWVudFdpZHRoKCksIG1heFhMYXlvdXRP dmVyZmxvdygpIC0gYm9yZGVyTGVmdCgpKSwgY2xpZW50TGVmdCgpKTsKLSAgICByZXR1cm4gY2xp ZW50V2lkdGgoKSAtIG1pbigwLCBtaW5YTGF5b3V0T3ZlcmZsb3coKSAtIGJvcmRlckxlZnQoKSk7 CisgICAgcmV0dXJuIGNsaWVudFdpZHRoKCkgLSBtaW4oWkVST19MQVlPVVRfVU5JVCwgbWluWExh eW91dE92ZXJmbG93KCkgLSBib3JkZXJMZWZ0KCkpOwogfQogCiBpbnQgUmVuZGVyQm94OjpzY3Jv bGxIZWlnaHQoKSBjb25zdAo= 136787 2012-04-11 16:42:25 -0700 2012-04-11 18:11:20 -0700 Patch for landing bug-83621-20120411164224.patch text/plain 2554 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMzkyNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA0LTExICBMZXZpIFdl aW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICBDb3JyZWN0IHBpeGVsIHNu YXBwaW5nIGVycm9yIGluIFJlbmRlckJveDo6cGl4ZWxTbmFwcGVkQ2xpZW50V2lkdGgvSGVpZ2h0 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzYyMQor CisgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgorCisgICAgICAgIFRob3VnaCB0aGUg cHJvYmxlbSB3b3VsZG4ndCB5ZXQgbWFuaWZlc3QgaXRzZWxmIHNpbmNlIHdlIGhhdmVuJ3QgZmxp cHBlZCB0aGUgc3dpdGNoIG9uIHN1Yi1waXhlbAorICAgICAgICBsYXlvdXQsIGNsaWVudFdpZHRo IGFuZCBjbGllbnRIZWlnaHQsIHdoZW4gcGl4ZWwgc25hcHBlZCwgbmVlZCB0byB0YWtlIHRoZSBS ZW5kZXJCb3gncyBsb2NhdGlvbgorICAgICAgICBpbnRvIGFjY291bnQuIFByZXZpb3VzbHksIENs aWVudExlZnQvVG9wIHdlcmUgdXNlZCwgYnV0IHRoZXNlIGFyZSBzaW1wbHkgdGhlIHdpZHRoIG9m IHRoZSBib3JkZXJzLAorICAgICAgICBhbmQgZG9uJ3QgaW5jbHVkZSB0aGUgYm94J3Mgc3ViLXBp eGVsIGxvY2F0aW9uLCB3aGljaCBpcyBuZWVkZWQgdG8gcHJvcGVybHkgc25hcCB0aGUgd2lkdGgv aGVpZ2h0LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVW50ZXN0YWJsZSB1bnRpbCB3ZSBzd2l0 Y2ggdG8gRnJhY3Rpb25hbExheW91dFVuaXRzLiBBIHRlc3QgY2FzZSB0aGF0IGNvdmVycyB0aGlz CisgICAgICAgIGlzIGluIHRoZSBzdWJwaXhlbGxheW91dCBicmFuY2ggYW5kIHdpbGwgbGFuZCB3 aXRoIHRoZSBzd2l0Y2guCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlckJveDo6cGl4ZWxTbmFwcGVkQ2xpZW50V2lkdGgpOgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyQm94OjpwaXhlbFNuYXBwZWRDbGllbnRIZWlnaHQpOgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyQm94OjpzY3JvbGxXaWR0aCk6IFJlcGxhY2luZyBhIHJhdyB6 ZXJvIHdpdGggWkVST19MQVlPVVRfVU5JVC4KKwogMjAxMi0wNC0xMSAgRXJpayBBcnZpZHNzb24g IDxhcnZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEZpbGUgQVBJIGRvZXMgbm90IHN1cHBvcnQg RE9NIGV2ZW50cyAobGlrZSBhZGRFdmVudExpc3RlbmVyKQpJbmRleDogU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckJveC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckJveC5jcHAJKHJldmlzaW9uIDExMzkyNCkKKysrIFNvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJCb3guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00ODcsMTIgKzQ4Nywx MiBAQCBMYXlvdXRVbml0IFJlbmRlckJveDo6Y2xpZW50SGVpZ2h0KCkgY29uCiAKIGludCBSZW5k ZXJCb3g6OnBpeGVsU25hcHBlZENsaWVudFdpZHRoKCkgY29uc3QKIHsKLSAgICByZXR1cm4gc25h cFNpemVUb1BpeGVsKGNsaWVudFdpZHRoKCksIGNsaWVudExlZnQoKSk7CisgICAgcmV0dXJuIHNu YXBTaXplVG9QaXhlbChjbGllbnRXaWR0aCgpLCB4KCkgKyBjbGllbnRMZWZ0KCkpOwogfQogCiBp bnQgUmVuZGVyQm94OjpwaXhlbFNuYXBwZWRDbGllbnRIZWlnaHQoKSBjb25zdAogewotICAgIHJl dHVybiBzbmFwU2l6ZVRvUGl4ZWwoY2xpZW50SGVpZ2h0KCksIGNsaWVudFRvcCgpKTsKKyAgICBy ZXR1cm4gc25hcFNpemVUb1BpeGVsKGNsaWVudEhlaWdodCgpLCB5KCkgKyBjbGllbnRUb3AoKSk7 CiB9CiAKIGludCBSZW5kZXJCb3g6OnNjcm9sbFdpZHRoKCkgY29uc3QKQEAgLTUwMyw3ICs1MDMs NyBAQCBpbnQgUmVuZGVyQm94OjpzY3JvbGxXaWR0aCgpIGNvbnN0CiAgICAgLy8gRklYTUU6IE5l ZWQgdG8gd29yayByaWdodCB3aXRoIHdyaXRpbmcgbW9kZXMuCiAgICAgaWYgKHN0eWxlKCktPmlz TGVmdFRvUmlnaHREaXJlY3Rpb24oKSkKICAgICAgICAgcmV0dXJuIHNuYXBTaXplVG9QaXhlbCht YXgoY2xpZW50V2lkdGgoKSwgbWF4WExheW91dE92ZXJmbG93KCkgLSBib3JkZXJMZWZ0KCkpLCBj bGllbnRMZWZ0KCkpOwotICAgIHJldHVybiBjbGllbnRXaWR0aCgpIC0gbWluKDAsIG1pblhMYXlv dXRPdmVyZmxvdygpIC0gYm9yZGVyTGVmdCgpKTsKKyAgICByZXR1cm4gY2xpZW50V2lkdGgoKSAt IG1pbihaRVJPX0xBWU9VVF9VTklULCBtaW5YTGF5b3V0T3ZlcmZsb3coKSAtIGJvcmRlckxlZnQo KSk7CiB9CiAKIGludCBSZW5kZXJCb3g6OnNjcm9sbEhlaWdodCgpIGNvbnN0Cg==