83598 2012-04-10 11:13:18 -0700 Remove unnecessary calls to RenderSVGShape::createShape 2012-04-10 15:37:10 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pdr pdr rhodovan.u-szeged schenney webkit.review.bot zimmermann oldest_to_newest 599431 0 pdr 2012-04-10 11:13:18 -0700 We call RenderSVGShape::createShape unnecessarily in RenderSVGShape::strokeContains. In the case of styled elements (Rect/RenderSVGRect and Ellipse/RenderSVGEllipse, for example), we will always call RenderSVGShape::createShape. 599446 1 136494 pdr 2012-04-10 11:30:37 -0700 Created attachment 136494 Remove unnecessary calls to RenderSVGShape::createShape() 599453 2 136494 rwlbuis 2012-04-10 11:53:55 -0700 Comment on attachment 136494 Remove unnecessary calls to RenderSVGShape::createShape() Looks redundant indeed. 599732 3 136494 webkit.review.bot 2012-04-10 15:37:06 -0700 Comment on attachment 136494 Remove unnecessary calls to RenderSVGShape::createShape() Clearing flags on attachment: 136494 Committed r113781: <http://trac.webkit.org/changeset/113781> 599733 4 webkit.review.bot 2012-04-10 15:37:10 -0700 All reviewed patches have been landed. Closing bug. 136494 2012-04-10 11:30:37 -0700 2012-04-10 15:37:06 -0700 Remove unnecessary calls to RenderSVGShape::createShape() 83598.1.patch text/plain 1923 pdr SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMzczOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA0LTEwICBQaGlsaXAg Um9nZXJzICA8cGRyQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHVubmVjZXNzYXJ5IGNh bGxzIHRvIFJlbmRlclNWR1NoYXBlOjpjcmVhdGVTaGFwZSgpCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzU5OAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbmRlclNWR1NoYXBlOjpzdHJva2VDb250YWlu cyBjb250YWlucyBjYWxscyB0byBmYWxsIGJhY2sgdG8gcGF0aCBzdHJva2UgaGl0IGRldGVjdGlv bgorICAgICAgICBpbiBzZXZlcmFsIGNhc2VzIChkYXNoZWQgc3Ryb2tlcywgZm9yIGV4YW1wbGUp LiBPbmUgb2YgdGhlc2UgY2FzZXMsIGEgY2hlY2sgZm9yIGlzU3R5bGVkLAorICAgICAgICBpcyBu b3QgbmVlZGVkIGFuZCBpcyBhbHdheXMgdHJ1ZSBmb3IgRWxsaXBzZXMsIENpcmNsZXMsIGFuZCBS ZWN0cyAoYWxsIHN0eWxlZCBlbGVtZW50cykuCisgICAgICAgIFRoaXMgY2hhbmdlIHJlbW92ZXMg dGhlIGNoZWNrIGZvciBpc1N0eWxlZC4KKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgdGhpcyBv bmx5IGFmZmVjdHMgcGVyZm9ybWFuY2UsIG5vdCB0ZXN0IHJlc3VsdHMuCisKKyAgICAgICAgKiBy ZW5kZXJpbmcvc3ZnL1JlbmRlclNWR1NoYXBlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRl clNWR1NoYXBlOjpzdHJva2VDb250YWlucyk6CisKIDIwMTItMDQtMTAgIERhdmlkIEh5YXR0ICA8 aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04MzU5NQpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5k ZXJTVkdTaGFwZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2 Zy9SZW5kZXJTVkdTaGFwZS5jcHAJKHJldmlzaW9uIDExMzczNSkKKysrIFNvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9zdmcvUmVuZGVyU1ZHU2hhcGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNTIs NyArMTUyLDcgQEAgYm9vbCBSZW5kZXJTVkdTaGFwZTo6c3Ryb2tlQ29udGFpbnMoY29ucwogICAg IH0KIAogICAgIGlmICghc3ZnU3R5bGUtPnN0cm9rZURhc2hBcnJheSgpLmlzRW1wdHkoKSB8fCBz dmdTdHlsZS0+c3Ryb2tlTWl0ZXJMaW1pdCgpICE9IHN2Z1N0eWxlLT5pbml0aWFsU3Ryb2tlTWl0 ZXJMaW1pdCgpCi0gICAgICAgIHx8IHN2Z1N0eWxlLT5qb2luU3R5bGUoKSAhPSBzdmdTdHlsZS0+ aW5pdGlhbEpvaW5TdHlsZSgpIHx8IHN2Z1N0eWxlLT5jYXBTdHlsZSgpICE9IHN2Z1N0eWxlLT5p bml0aWFsQ2FwU3R5bGUoKSB8fCBzdGF0aWNfY2FzdDxTVkdFbGVtZW50Kj4obm9kZSgpKS0+aXNT dHlsZWQoKSkgeworICAgICAgICB8fCBzdmdTdHlsZS0+am9pblN0eWxlKCkgIT0gc3ZnU3R5bGUt PmluaXRpYWxKb2luU3R5bGUoKSB8fCBzdmdTdHlsZS0+Y2FwU3R5bGUoKSAhPSBzdmdTdHlsZS0+ aW5pdGlhbENhcFN0eWxlKCkpIHsKICAgICAgICAgaWYgKCFtX3BhdGgpCiAgICAgICAgICAgICBS ZW5kZXJTVkdTaGFwZTo6Y3JlYXRlU2hhcGUoKTsKICAgICAgICAgcmV0dXJuIFJlbmRlclNWR1No YXBlOjpzaGFwZURlcGVuZGVudFN0cm9rZUNvbnRhaW5zKHBvaW50KTsK