83592 2012-04-10 10:22:33 -0700 [Qt] InspectorServer: Improve the page list's parameter names 2012-04-11 07:52:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jturcotte jturcotte hausmann kenneth menard webkit.review.bot zoltan oldest_to_newest 599375 0 jturcotte 2012-04-10 10:22:33 -0700 [Qt] InspectorServer: Improve the page list's parameter names 599380 1 136484 jturcotte 2012-04-10 10:27:59 -0700 Created attachment 136484 Patch 600128 2 136484 hausmann 2012-04-11 01:23:56 -0700 Comment on attachment 136484 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136484&action=review > Source/WebKit2/qt/Resources/inspectorPageIndex.html:14 > + var description = pages[i].title ? pages[i].title : ("Page " + (Number(pages[i].id))); Wouldn't it make sense to rename the local description variable to title, too? 600165 3 jturcotte 2012-04-11 02:40:21 -0700 (In reply to comment #2) > Wouldn't it make sense to rename the local description variable to title, too? Oh I thought the url was in it too, it's only added later, yep I'll do. Thx! 600262 4 jturcotte 2012-04-11 07:52:42 -0700 Committed r113860: <http://trac.webkit.org/changeset/113860> 136484 2012-04-10 10:27:59 -0700 2012-04-11 01:23:56 -0700 Patch bug-83592-20120410192459.patch text/plain 3557 jturcotte U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNzA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzYwZWY1ODFiNTBhNmQy NDYzMGQ3ZWY1ZTY1NWZkNzc2N2Q4NWFkYy4uNzRhMzVhNDI3MzEzMzk5MGEzODBmOWYyNDg3ZmRm OWQ2M2Y1MzkwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDEyLTA0LTEwICBKb2Nl bHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBub2tpYS5jb20+CiAKKyAgICAgICAgW1F0 XSBJbnNwZWN0b3JTZXJ2ZXI6IEltcHJvdmUgdGhlIEpTT04gcGFnZSBsaXN0J3MgcGFyYW1ldGVy IG5hbWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 MzU5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0g QWRkICJpZCIgdGhhdCB3b3VsZCBiZSBuZWVkZWQgdG8gYnVpbGQgdGhlIFVSTCB3aGVuIHVzaW5n IGxvY2FsIGZyb250LWVuZCByZXNvdXJjZXMKKyAgICAgICAgICAoYW5kIHdpbGwgYmUgdXNlZCBi eSB0ZXN0cykKKyAgICAgICAgLSBSZW5hbWUgZGVzY3JpcHRpb24gdG8gInRpdGxlIiwgdGhlIGRl c2NyaXB0aW9uIGNvbnRhaW5zIGJvdGggdGhlIHRpdGxlIGFuZCBVUkwgb24gdGhlIGZpbmFsIGxp c3QKKyAgICAgICAgLSBSZW5hbWUgaW5zcGVjdG9yTG9jYXRpb24gdG8gImluc3BlY3RvclVybCIg dG8gbWF0Y2ggd2l0aCB0aGUgdXJsIHBhcmFtZXRlci4KKworICAgICAgICAqIFVJUHJvY2Vzcy9J bnNwZWN0b3JTZXJ2ZXIvcXQvV2ViSW5zcGVjdG9yU2VydmVyUXQuY3BwOgorICAgICAgICAoV2Vi S2l0OjpXZWJJbnNwZWN0b3JTZXJ2ZXI6OmJ1aWxkUGFnZUxpc3QpOgorICAgICAgICAqIHF0L1Jl c291cmNlcy9pbnNwZWN0b3JQYWdlSW5kZXguaHRtbDoKKworMjAxMi0wNC0xMCAgSm9jZWx5biBU dXJjb3R0ZSAgPGpvY2VseW4udHVyY290dGVAbm9raWEuY29tPgorCiAgICAgICAgIFtRdF0gRml4 IGlzc3VlcyB3aGVuIHVzaW5nIHRoZSBXZWJWaWV3IGFzIFNoYWRlckVmZmVjdFNvdXJjZQogICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODM1ODcKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0luc3BlY3RvclNlcnZlci9xdC9XZWJJ bnNwZWN0b3JTZXJ2ZXJRdC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvSW5zcGVjdG9y U2VydmVyL3F0L1dlYkluc3BlY3RvclNlcnZlclF0LmNwcAppbmRleCBhODZmYWQ5MjRjZThmYjdi NjI4YTk5ZDM1ODc1NDRkMTk3ZTg2YzU5Li45Zjg0YTY1NmJlZTBhYzViNGVjM2U5NTIxY2MxZTY4 M2FlM2FmOTZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvSW5zcGVjdG9y U2VydmVyL3F0L1dlYkluc3BlY3RvclNlcnZlclF0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvSW5zcGVjdG9yU2VydmVyL3F0L1dlYkluc3BlY3RvclNlcnZlclF0LmNwcApAQCAt NjUsMTEgKzY1LDEyIEBAIHZvaWQgV2ViSW5zcGVjdG9yU2VydmVyOjpidWlsZFBhZ2VMaXN0KFZl Y3RvcjxjaGFyPiYgZGF0YSwgU3RyaW5nJiBjb250ZW50VHlwZSkKICAgICAgICAgV2ViUGFnZVBy b3h5KiB3ZWJQYWdlID0gaXQtPnNlY29uZC0+cGFnZSgpOwogICAgICAgICBpZiAoaXQgIT0gbV9j bGllbnRNYXAuYmVnaW4oKSkKICAgICAgICAgICAgIGJ1aWxkZXIuYXBwZW5kKCIsICIpOwotICAg ICAgICBidWlsZGVyLmFwcGVuZCgieyBcImRlc2NyaXB0aW9uXCI6IFwiIik7CisgICAgICAgIGJ1 aWxkZXIuYXBwZW5kKCJ7IFwiaWRcIjogIiArIFN0cmluZzo6bnVtYmVyKGl0LT5maXJzdCkpOwor ICAgICAgICBidWlsZGVyLmFwcGVuZCgiLCBcInRpdGxlXCI6IFwiIik7CiAgICAgICAgIGJ1aWxk ZXIuYXBwZW5kKHdlYlBhZ2UtPnBhZ2VUaXRsZSgpKTsKICAgICAgICAgYnVpbGRlci5hcHBlbmQo IlwiLCBcInVybFwiOiBcIiIpOwogICAgICAgICBidWlsZGVyLmFwcGVuZCh3ZWJQYWdlLT5hY3Rp dmVVUkwoKSk7Ci0gICAgICAgIGJ1aWxkZXIuYXBwZW5kKCJcIiwgXCJpbnNwZWN0b3JMb2NhdGlv blwiOiBcIiIpOworICAgICAgICBidWlsZGVyLmFwcGVuZCgiXCIsIFwiaW5zcGVjdG9yVXJsXCI6 IFwiIik7CiAgICAgICAgIGJ1aWxkZXIuYXBwZW5kKCIvd2Via2l0L2luc3BlY3Rvci9pbnNwZWN0 b3IuaHRtbD9wYWdlPSIgKyBTdHJpbmc6Om51bWJlcihpdC0+Zmlyc3QpKTsKICAgICAgICAgYnVp bGRlci5hcHBlbmQoIlwiIH0iKTsKICAgICB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9x dC9SZXNvdXJjZXMvaW5zcGVjdG9yUGFnZUluZGV4Lmh0bWwgYi9Tb3VyY2UvV2ViS2l0Mi9xdC9S ZXNvdXJjZXMvaW5zcGVjdG9yUGFnZUluZGV4Lmh0bWwKaW5kZXggZDA3NDU0MTI3NzRhNDg0Yjg3 YTgxZWExOTJkZmY0NWZjNzU1NzI1OC4uM2UxYmU5MmU3MWRiMGMzYTExODNkZWMyYmQ2M2Y0YWMx MjE4MzM2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvcXQvUmVzb3VyY2VzL2luc3BlY3Rv clBhZ2VJbmRleC5odG1sCisrKyBiL1NvdXJjZS9XZWJLaXQyL3F0L1Jlc291cmNlcy9pbnNwZWN0 b3JQYWdlSW5kZXguaHRtbApAQCAtMTEsMTAgKzExLDEwIEBAIGZ1bmN0aW9uIGNyZWF0ZVBhZ2VM aXN0KCkgewogICAgICAgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJub1BhZ2VO b3RpY2UiKS5zdHlsZS5kaXNwbGF5ID0gIm5vbmUiOwogICAgICAgICAgICAgZm9yICh2YXIgaSBp biBwYWdlcykgewogICAgICAgICAgICAgICAgIHZhciBsaW5rID0gZG9jdW1lbnQuY3JlYXRlRWxl bWVudCgiYSIpOwotICAgICAgICAgICAgICAgIHZhciBkZXNjcmlwdGlvbiA9IHBhZ2VzW2ldLmRl c2NyaXB0aW9uID8gcGFnZXNbaV0uZGVzY3JpcHRpb24gOiAoIlBhZ2UgIiArIChOdW1iZXIoaSkr MSkpOworICAgICAgICAgICAgICAgIHZhciBkZXNjcmlwdGlvbiA9IHBhZ2VzW2ldLnRpdGxlID8g cGFnZXNbaV0udGl0bGUgOiAoIlBhZ2UgIiArIChOdW1iZXIocGFnZXNbaV0uaWQpKSk7CiAgICAg ICAgICAgICAgICAgdmFyIHVybCA9IHBhZ2VzW2ldLnVybDsKICAgICAgICAgICAgICAgICBsaW5r LmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKGRlc2NyaXB0aW9uICsgKHVybCA/ ICgiIFsiICsgdXJsICsgIl0iKSA6ICIiICkpKTsKLSAgICAgICAgICAgICAgICBsaW5rLnNldEF0 dHJpYnV0ZSgiaHJlZiIsIHBhZ2VzW2ldLmluc3BlY3RvckxvY2F0aW9uKTsKKyAgICAgICAgICAg ICAgICBsaW5rLnNldEF0dHJpYnV0ZSgiaHJlZiIsIHBhZ2VzW2ldLmluc3BlY3RvclVybCk7CiAg ICAgICAgICAgICAgICAgZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChsaW5rKTsKICAgICAgICAg ICAgICAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQo ImJyIikpOwogICAgICAgICAgICAgfQo=