83578 2012-04-10 06:47:29 -0700 [Qt][WK2] fast/loader/create-frame-in-DOMContentLoaded.html crashes 2012-05-15 08:15:16 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Critical --- 79668 1 ossy dinu.jacob dinu.jacob menard ossy webkit.review.bot zoltan oldest_to_newest 599229 0 ossy 2012-04-10 06:47:29 -0700 This test was skipped long long time ago, and was unskipped by http://trac.webkit.org/changeset/113427, but unfortunately it crashes on Qt5-WK2 platform (pass with Qt4.8-WK1 and Qt5-WK2) crash log for WebProcess (pid <unknown>): STDOUT: <empty> STDERR: 1 0x7f8e51a15048 /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libWTRInjectedBundle.so(+0x34048) [0x7f8e51a15048] STDERR: 2 0x7f8e9dde7420 /lib/x86_64-linux-gnu/libc.so.6(+0x36420) [0x7f8e9dde7420] STDERR: 3 0x7f8ea02c33cd /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(WebCore::WebFrameNetworkingContext::WebFrameNetworkingContext(WebKit::WebFrame*)+0x5d) [0x7f8ea02c33cd] STDERR: 4 0x7f8ea02c3491 /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(WebCore::WebFrameNetworkingContext::create(WebKit::WebFrame*)+0x31) [0x7f8ea02c3491] STDERR: 5 0x7f8ea02b2964 /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(WebKit::WebFrameLoaderClient::createNetworkingContext()+0x14) [0x7f8ea02b2964] STDERR: 6 0x7f8ea0881df1 /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(WebCore::FrameLoader::init()+0x7f1) [0x7f8ea0881df1] STDERR: 7 0x7f8ea02cf1a2 /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(WebKit::WebFrame::init(WebKit::WebPage*, WTF::String const&, WebCore::HTMLFrameOwnerElement*)+0xe2) [0x7f8ea02cf1a2] STDERR: 8 0x7f8ea02cfc2f /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(WebKit::WebFrame::createSubframe(WebKit::WebPage*, WTF::String const&, WebCore::HTMLFrameOwnerElement*)+0xef) [0x7f8ea02cfc2f] STDERR: 9 0x7f8ea02b22ee /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(WebKit::WebFrameLoaderClient::createFrame(WebCore::KURL const&, WTF::String const&, WebCore::HTMLFrameOwnerElement*, WTF::String const&, bool, int, int)+0x4e) [0x7f8ea02b22ee] STDERR: 10 0x7f8ea08b6171 /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(WebCore::SubframeLoader::loadSubframe(WebCore::HTMLFrameOwnerElement*, WebCore::KURL const&, WTF::String const&, WTF::String const&)+0x181) [0x7f8ea08b6171] STDERR: 11 0x7f8ea08b648f /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(WebCore::SubframeLoader::loadOrRedirectSubframe(WebCore::HTMLFrameOwnerElement*, WebCore::KURL const&, WTF::AtomicString const&, bool, bool)+0xff) [0x7f8ea08b648f] STDERR: 12 0x7f8ea08b69c7 /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(WebCore::SubframeLoader::requestFrame(WebCore::HTMLFrameOwnerElement*, WTF::String const&, WTF::AtomicString const&, bool, bool)+0x207) [0x7f8ea08b69c7] STDERR: 13 0x7f8ea06e9022 /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(WebCore::HTMLFrameElementBase::openURL(bool, bool)+0xe2) [0x7f8ea06e9022] STDERR: 14 0x7f8ea0544202 /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0xfc7202) [0x7f8ea0544202] STDERR: 15 0x7f8ea05443d9 /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0xfc73d9) [0x7f8ea05443d9] STDERR: 16 0x7f8ea05479cc /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(WebCore::ContainerNode::appendChild(WTF::PassRefPtr<WebCore::Node>, int&, bool)+0x19c) [0x7f8ea05479cc] STDERR: 17 0x7f8ea059c87c /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(WebCore::Node::appendChild(WTF::PassRefPtr<WebCore::Node>, int&, bool)+0x3c) [0x7f8ea059c87c] STDERR: 18 0x7f8ea03fbabb /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(WebCore::JSNode::appendChild(JSC::ExecState*)+0x4b) [0x7f8ea03fbabb] STDERR: 19 0x7f8ea0f35a0b /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(WebCore::jsNodePrototypeFunctionAppendChild(JSC::ExecState*)+0x5b) [0x7f8ea0f35a0b] STDERR: 20 0x7f8e52431258 [0x7f8e52431258] 599232 1 ossy 2012-04-10 06:53:42 -0700 Skipped by http://trac.webkit.org/changeset/113712 Please unskip it with the proper fix. 623537 2 dinu.jacob 2012-05-14 18:19:44 -0700 DOMContentLoaded event handler adds an iframe. loadEvent handler removes this iframe and this causes the page to be detached from the frame. WebFrameNetworkingContext constructor tries to access the page of the frame resulting in the crash. 623543 3 141833 dinu.jacob 2012-05-14 18:27:44 -0700 Created attachment 141833 Patch 623547 4 141834 dinu.jacob 2012-05-14 18:34:13 -0700 Created attachment 141834 Patch 623558 5 141839 dinu.jacob 2012-05-14 18:55:51 -0700 Created attachment 141839 Patch 623890 6 141839 zalan 2012-05-15 04:25:46 -0700 Comment on attachment 141839 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141839&action=review > Source/WebKit2/WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp:39 > + m_originatingObject->setProperty("pageID", qulonglong(frame->page()->pageID())); I think it's better to not to initiate the m_originatingObject, if we can't set the property on it. the caller, QtNetworkAccessManager::obtainOriginatingWebPage(), looks to handle the NULL case properly, while we would be querying an invalid pageID on the webprocess. Also if you check for frame here (and expecting it to be NULL), you should also be checking it a few lines above, when the parent c'tor is called with WebCore::Frame. However I think it's only the WebKit::WebPage which could be NULL (detached) here and not the WebKit::WebFrame. So if(frame->page()) should just do. 623916 7 141839 hausmann 2012-05-15 05:05:02 -0700 Comment on attachment 141839 Patch I agree with Zalan, it's better to avoid constructing m_originatingObject. Otherwise it seems like a valid case/situation. 623976 8 141946 dinu.jacob 2012-05-15 06:24:51 -0700 Created attachment 141946 Patch 623982 9 dinu.jacob 2012-05-15 06:29:31 -0700 Thanks for the reviews. New patch attached. 624017 10 141946 hausmann 2012-05-15 06:51:55 -0700 Comment on attachment 141946 Patch Thanks :) 624101 11 141946 webkit.review.bot 2012-05-15 08:15:07 -0700 Comment on attachment 141946 Patch Clearing flags on attachment: 141946 Committed r117070: <http://trac.webkit.org/changeset/117070> 624102 12 webkit.review.bot 2012-05-15 08:15:16 -0700 All reviewed patches have been landed. Closing bug. 141833 2012-05-14 18:27:44 -0700 2012-05-14 18:34:13 -0700 Patch 83578.patch text/plain 1680 dinu.jacob ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwMmNiYzNiLi5lOTE2NDU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMDUtMTQgIERpbnUgSmFjb2IgIDxkaW51LmphY29iQG5va2lhLmNvbT4KKworICAg ICAgICBbUXRdW1dLMl0gZmFzdC9sb2FkZXIvY3JlYXRlLWZyYW1lLWluLURPTUNvbnRlbnRMb2Fk ZWQuaHRtbCBjcmFzaGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04MzU3OAorCisgICAgICAgIENoZWNrIHdoZXRoZXIgcGFnZSBpcyBudWxsIGJlZm9y ZSBhdHRlbXB0aW5nIHRvIHJldHJpZXZlIHRoZSBwYWdlSUQKKyAgICAgICAgaW4gV2ViRnJhbWVO ZXR3b3JraW5nQ29udGV4dC4gVGhlIHBhZ2Ugd2lsbCBiZSBudWxsIGlmIHRoZSBmcmFtZSAKKyAg ICAgICAgd2FzIGRldGFjaGVkIGZyb20gdGhlIHBhZ2UuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L3F0 L1dlYkZyYW1lTmV0d29ya2luZ0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2ViRnJh bWVOZXR3b3JraW5nQ29udGV4dDo6V2ViRnJhbWVOZXR3b3JraW5nQ29udGV4dCk6CisKIDIwMTIt MDUtMDIgIE1haGVzaCBLdWxrYXJuaSAgPG1haGVzaC5rdWxrYXJuaUBub2tpYS5jb20+CiAKICAg ICAgICAgVW5yZXZpZXdlZC4gQnVpbGQgZml4IGZvciBRdCBwb3J0IG9uIG1hYy4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvcXQvV2ViRnJhbWVO ZXR3b3JraW5nQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVT dXBwb3J0L3F0L1dlYkZyYW1lTmV0d29ya2luZ0NvbnRleHQuY3BwCmluZGV4IDA3MGQ0NzkuLmFj NmE1MWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBv cnQvcXQvV2ViRnJhbWVOZXR3b3JraW5nQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9xdC9XZWJGcmFtZU5ldHdvcmtpbmdDb250ZXh0LmNw cApAQCAtMzUsNyArMzUsOCBAQCBXZWJGcmFtZU5ldHdvcmtpbmdDb250ZXh0OjpXZWJGcmFtZU5l dHdvcmtpbmdDb250ZXh0KFdlYktpdDo6V2ViRnJhbWUqIGZyYW1lKQogICAgICwgbV9taW1lU25p ZmZpbmdFbmFibGVkKHRydWUpCiB7CiAgICAgLy8gVGhlIHBhZ2UgSUQgaXMgbmVlZGVkIGxhdGVy IGZvciBIVFRQIGF1dGhlbnRpY2F0aW9uIGFuZCBTU0wgZXJyb3JzLgotICAgIG1fb3JpZ2luYXRp bmdPYmplY3QtPnNldFByb3BlcnR5KCJwYWdlSUQiLCBxdWxvbmdsb25nKGZyYW1lLT5wYWdlKCkt PnBhZ2VJRCgpKSk7CisgICAgaWYgKGZyYW1lICYmIGZyYW1lLT5wYWdlKCkpCisgICAgICAgIG1f b3JpZ2luYXRpbmdPYmplY3QtPnNldFByb3BlcnR5KCJwYWdlSUQiLCBxdWxvbmdsb25nKGZyYW1l LT5wYWdlKCktPnBhZ2VJRCgpKSk7CiB9CiAKIFdlYkZyYW1lTmV0d29ya2luZ0NvbnRleHQ6On5X ZWJGcmFtZU5ldHdvcmtpbmdDb250ZXh0KCkK 141834 2012-05-14 18:34:13 -0700 2012-05-14 18:55:51 -0700 Patch 83578.patch text/plain 2440 dinu.jacob ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0LTUuMC13azIvU2tpcHBlZCBiL0xh eW91dFRlc3RzL3BsYXRmb3JtL3F0LTUuMC13azIvU2tpcHBlZAppbmRleCA5NWY3Yjg0Li43ZjY5 MmQzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC01LjAtd2syL1NraXBwZWQK KysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQtNS4wLXdrMi9Ta2lwcGVkCkBAIC01NzksMTAg KzU3OSw2IEBAIGZhc3QvZnJhbWVzL2lmcmFtZS13aW5kb3ctZm9jdXMuaHRtbAogIyBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODM1NzYKIGh0dHAvdGVzdHMvbmF2aWdh dGlvbi9odHRwcy1pbi1wYWdlLWNhY2hlLmh0bWwKIAotIyBbUXRdW1dLMl0gZmFzdC9sb2FkZXIv Y3JlYXRlLWZyYW1lLWluLURPTUNvbnRlbnRMb2FkZWQuaHRtbCBjcmFzaGVzCi0jIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzU3OAotZmFzdC9sb2FkZXIvY3JlYXRl LWZyYW1lLWluLURPTUNvbnRlbnRMb2FkZWQuaHRtbAotCiAjIFtRdF1bV0syXSBSRUdSRVNTSU9O KHIxMTM2NzgpOkFmdGVyIHRoaXMgY2hhbmdlIGZhc3QvdGV4dC90ZXh0LXN0cm9rZS13aWR0aC1j YWlyby1kb3MuaHRtbCBtYWtlcyB0aGUgbmV4dCB0ZXN0IGNyYXNoCiAjIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzU4MgogZmFzdC90ZXh0L3RleHQtc3Ryb2tlLXdp ZHRoLWNhaXJvLWRvcy5odG1sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cg Yi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMDJjYmMzYi4uZTkxNjQ1OCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA1LTE0ICBEaW51IEphY29iICA8ZGludS5qYWNv YkBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XVtXSzJdIGZhc3QvbG9hZGVyL2NyZWF0ZS1mcmFt ZS1pbi1ET01Db250ZW50TG9hZGVkLmh0bWwgY3Jhc2hlcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODM1NzgKKworICAgICAgICBDaGVjayB3aGV0aGVy IHBhZ2UgaXMgbnVsbCBiZWZvcmUgYXR0ZW1wdGluZyB0byByZXRyaWV2ZSB0aGUgcGFnZUlECisg ICAgICAgIGluIFdlYkZyYW1lTmV0d29ya2luZ0NvbnRleHQuIFRoZSBwYWdlIHdpbGwgYmUgbnVs bCBpZiB0aGUgZnJhbWUgCisgICAgICAgIHdhcyBkZXRhY2hlZCBmcm9tIHRoZSBwYWdlLgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vz cy9XZWJDb3JlU3VwcG9ydC9xdC9XZWJGcmFtZU5ldHdvcmtpbmdDb250ZXh0LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OldlYkZyYW1lTmV0d29ya2luZ0NvbnRleHQ6OldlYkZyYW1lTmV0d29ya2lu Z0NvbnRleHQpOgorCiAyMDEyLTA1LTAyICBNYWhlc2ggS3Vsa2FybmkgIDxtYWhlc2gua3Vsa2Fy bmlAbm9raWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIEJ1aWxkIGZpeCBmb3IgUXQgcG9y dCBvbiBtYWMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVT dXBwb3J0L3F0L1dlYkZyYW1lTmV0d29ya2luZ0NvbnRleHQuY3BwIGIvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9xdC9XZWJGcmFtZU5ldHdvcmtpbmdDb250ZXh0LmNw cAppbmRleCAwNzBkNDc5Li5hYzZhNTFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYkNvcmVTdXBwb3J0L3F0L1dlYkZyYW1lTmV0d29ya2luZ0NvbnRleHQuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvcXQvV2ViRnJhbWVO ZXR3b3JraW5nQ29udGV4dC5jcHAKQEAgLTM1LDcgKzM1LDggQEAgV2ViRnJhbWVOZXR3b3JraW5n Q29udGV4dDo6V2ViRnJhbWVOZXR3b3JraW5nQ29udGV4dChXZWJLaXQ6OldlYkZyYW1lKiBmcmFt ZSkKICAgICAsIG1fbWltZVNuaWZmaW5nRW5hYmxlZCh0cnVlKQogewogICAgIC8vIFRoZSBwYWdl IElEIGlzIG5lZWRlZCBsYXRlciBmb3IgSFRUUCBhdXRoZW50aWNhdGlvbiBhbmQgU1NMIGVycm9y cy4KLSAgICBtX29yaWdpbmF0aW5nT2JqZWN0LT5zZXRQcm9wZXJ0eSgicGFnZUlEIiwgcXVsb25n bG9uZyhmcmFtZS0+cGFnZSgpLT5wYWdlSUQoKSkpOworICAgIGlmIChmcmFtZSAmJiBmcmFtZS0+ cGFnZSgpKQorICAgICAgICBtX29yaWdpbmF0aW5nT2JqZWN0LT5zZXRQcm9wZXJ0eSgicGFnZUlE IiwgcXVsb25nbG9uZyhmcmFtZS0+cGFnZSgpLT5wYWdlSUQoKSkpOwogfQogCiBXZWJGcmFtZU5l dHdvcmtpbmdDb250ZXh0Ojp+V2ViRnJhbWVOZXR3b3JraW5nQ29udGV4dCgpCg== 141839 2012-05-14 18:55:51 -0700 2012-05-15 06:24:51 -0700 Patch 83578.patch text/plain 2984 dinu.jacob ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyMzkzYTBhLi5kMGI5M2UxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDUt MTQgIERpbnUgSmFjb2IgIDxkaW51LmphY29iQG5va2lhLmNvbT4KKworICAgICAgICBbUXRdW1dL Ml0gZmFzdC9sb2FkZXIvY3JlYXRlLWZyYW1lLWluLURPTUNvbnRlbnRMb2FkZWQuaHRtbCBjcmFz aGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzU3 OAorCisgICAgICAgIFVuc2tpcCBwYXNzaW5nIHRlc3QuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC01LjAtd2syL1NraXBwZWQ6 CisKIDIwMTItMDUtMTQgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgZmFzdC9sb2FkZXIvamF2YXNjcmlwdC11cmwtaW4tZW1iZWQuaHRtbCBpcyBmYWlsaW5n IGFmdGVyIHIxMTU2NDYKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0LTUuMC13 azIvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0LTUuMC13azIvU2tpcHBlZAppbmRl eCA4ODlkODk4Li41MzQyOTNmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC01 LjAtd2syL1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQtNS4wLXdrMi9Ta2lw cGVkCkBAIC01NzgsMTAgKzU3OCw2IEBAIGZhc3QvZnJhbWVzL2lmcmFtZS13aW5kb3ctZm9jdXMu aHRtbAogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODM1NzYKIGh0 dHAvdGVzdHMvbmF2aWdhdGlvbi9odHRwcy1pbi1wYWdlLWNhY2hlLmh0bWwKIAotIyBbUXRdW1dL Ml0gZmFzdC9sb2FkZXIvY3JlYXRlLWZyYW1lLWluLURPTUNvbnRlbnRMb2FkZWQuaHRtbCBjcmFz aGVzCi0jIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzU3OAotZmFz dC9sb2FkZXIvY3JlYXRlLWZyYW1lLWluLURPTUNvbnRlbnRMb2FkZWQuaHRtbAotCiAjIE1pc3Np bmcgbGF5b3V0VGVzdENvbnRyb2xsZXIubnVtYmVyT2ZQZW5kaW5nR2VvbG9jYXRpb25QZXJtaXNz aW9uUmVxdWVzdHMoKSBpbXBsZW1lbnRhdGlvbgogZmFzdC9kb20vR2VvbG9jYXRpb24vcGFnZS1y ZWxvYWQtY2FuY2VsLXBlcm1pc3Npb24tcmVxdWVzdHMuaHRtbAogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODZh YmEyZC4uM2JkNDEwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA1LTE0ICBE aW51IEphY29iICA8ZGludS5qYWNvYkBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XVtXSzJdIGZh c3QvbG9hZGVyL2NyZWF0ZS1mcmFtZS1pbi1ET01Db250ZW50TG9hZGVkLmh0bWwgY3Jhc2hlcwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODM1NzgKKwor ICAgICAgICBDaGVjayB3aGV0aGVyIHBhZ2UgaXMgbnVsbCBiZWZvcmUgYXR0ZW1wdGluZyB0byBy ZXRyaWV2ZSB0aGUgcGFnZUlECisgICAgICAgIGluIFdlYkZyYW1lTmV0d29ya2luZ0NvbnRleHQu IFRoZSBwYWdlIHdpbGwgYmUgbnVsbCBpZiB0aGUgZnJhbWUgCisgICAgICAgIHdhcyBkZXRhY2hl ZCBmcm9tIHRoZSBwYWdlLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9xdC9XZWJGcmFtZU5ldHdvcmtp bmdDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYkZyYW1lTmV0d29ya2luZ0NvbnRl eHQ6OldlYkZyYW1lTmV0d29ya2luZ0NvbnRleHQpOgorCiAyMDEyLTA1LTE0ICBNaWNoYWVsIFNh Ym9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgogCiAgICAgICAgIEVuaDogQWRkIHRoZSBBYmlsaXR5 IHRvIERpc2FibGUgLyBFbmFibGUgSmF2YVNjcmlwdCBHQyBUaW1lcgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9xdC9XZWJGcmFtZU5ldHdvcmtp bmdDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQv cXQvV2ViRnJhbWVOZXR3b3JraW5nQ29udGV4dC5jcHAKaW5kZXggMDcwZDQ3OS4uYWM2YTUxZSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9xdC9X ZWJGcmFtZU5ldHdvcmtpbmdDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYkNvcmVTdXBwb3J0L3F0L1dlYkZyYW1lTmV0d29ya2luZ0NvbnRleHQuY3BwCkBAIC0z NSw3ICszNSw4IEBAIFdlYkZyYW1lTmV0d29ya2luZ0NvbnRleHQ6OldlYkZyYW1lTmV0d29ya2lu Z0NvbnRleHQoV2ViS2l0OjpXZWJGcmFtZSogZnJhbWUpCiAgICAgLCBtX21pbWVTbmlmZmluZ0Vu YWJsZWQodHJ1ZSkKIHsKICAgICAvLyBUaGUgcGFnZSBJRCBpcyBuZWVkZWQgbGF0ZXIgZm9yIEhU VFAgYXV0aGVudGljYXRpb24gYW5kIFNTTCBlcnJvcnMuCi0gICAgbV9vcmlnaW5hdGluZ09iamVj dC0+c2V0UHJvcGVydHkoInBhZ2VJRCIsIHF1bG9uZ2xvbmcoZnJhbWUtPnBhZ2UoKS0+cGFnZUlE KCkpKTsKKyAgICBpZiAoZnJhbWUgJiYgZnJhbWUtPnBhZ2UoKSkKKyAgICAgICAgbV9vcmlnaW5h dGluZ09iamVjdC0+c2V0UHJvcGVydHkoInBhZ2VJRCIsIHF1bG9uZ2xvbmcoZnJhbWUtPnBhZ2Uo KS0+cGFnZUlEKCkpKTsKIH0KIAogV2ViRnJhbWVOZXR3b3JraW5nQ29udGV4dDo6fldlYkZyYW1l TmV0d29ya2luZ0NvbnRleHQoKQo= 141946 2012-05-15 06:24:51 -0700 2012-05-15 08:15:07 -0700 Patch 83578.patch text/plain 3237 dinu.jacob ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyMzkzYTBhLi40MDgxYjE1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDUt MTUgIERpbnUgSmFjb2IgIDxkaW51LmphY29iQG5va2lhLmNvbT4KKworICAgICAgICBbUXRdW1dL Ml0gZmFzdC9sb2FkZXIvY3JlYXRlLWZyYW1lLWluLURPTUNvbnRlbnRMb2FkZWQuaHRtbCBjcmFz aGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzU3 OAorCisgICAgICAgIFVuc2tpcCBwYXNzaW5nIHRlc3QuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC01LjAtd2syL1NraXBwZWQ6 CisKIDIwMTItMDUtMTQgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgZmFzdC9sb2FkZXIvamF2YXNjcmlwdC11cmwtaW4tZW1iZWQuaHRtbCBpcyBmYWlsaW5n IGFmdGVyIHIxMTU2NDYKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0LTUuMC13 azIvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0LTUuMC13azIvU2tpcHBlZAppbmRl eCA4ODlkODk4Li41MzQyOTNmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC01 LjAtd2syL1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQtNS4wLXdrMi9Ta2lw cGVkCkBAIC01NzgsMTAgKzU3OCw2IEBAIGZhc3QvZnJhbWVzL2lmcmFtZS13aW5kb3ctZm9jdXMu aHRtbAogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODM1NzYKIGh0 dHAvdGVzdHMvbmF2aWdhdGlvbi9odHRwcy1pbi1wYWdlLWNhY2hlLmh0bWwKIAotIyBbUXRdW1dL Ml0gZmFzdC9sb2FkZXIvY3JlYXRlLWZyYW1lLWluLURPTUNvbnRlbnRMb2FkZWQuaHRtbCBjcmFz aGVzCi0jIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzU3OAotZmFz dC9sb2FkZXIvY3JlYXRlLWZyYW1lLWluLURPTUNvbnRlbnRMb2FkZWQuaHRtbAotCiAjIE1pc3Np bmcgbGF5b3V0VGVzdENvbnRyb2xsZXIubnVtYmVyT2ZQZW5kaW5nR2VvbG9jYXRpb25QZXJtaXNz aW9uUmVxdWVzdHMoKSBpbXBsZW1lbnRhdGlvbgogZmFzdC9kb20vR2VvbG9jYXRpb24vcGFnZS1y ZWxvYWQtY2FuY2VsLXBlcm1pc3Npb24tcmVxdWVzdHMuaHRtbAogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODZh YmEyZC4uNmM2MGRkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA1LTE1ICBE aW51IEphY29iICA8ZGludS5qYWNvYkBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XVtXSzJdIGZh c3QvbG9hZGVyL2NyZWF0ZS1mcmFtZS1pbi1ET01Db250ZW50TG9hZGVkLmh0bWwgY3Jhc2hlcwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODM1NzgKKwor ICAgICAgICBSZXRyaWV2ZSBhbmQgc2F2ZSBwYWdlIElEIG9ubHkgZm9yIGEgdmFsaWQgcGFnZSBp biBXZWJGcmFtZU5ldHdvcmtpbmdDb250ZXh0LgorICAgICAgICBUaGUgcGFnZSB3aWxsIGJlIG51 bGwgaWYgdGhlIGZyYW1lIHdhcyBkZXRhY2hlZCBmcm9tIHRoZSBwYWdlLgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJDb3Jl U3VwcG9ydC9xdC9XZWJGcmFtZU5ldHdvcmtpbmdDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OldlYkZyYW1lTmV0d29ya2luZ0NvbnRleHQ6OldlYkZyYW1lTmV0d29ya2luZ0NvbnRleHQp OgorCiAyMDEyLTA1LTE0ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgogCiAg ICAgICAgIEVuaDogQWRkIHRoZSBBYmlsaXR5IHRvIERpc2FibGUgLyBFbmFibGUgSmF2YVNjcmlw dCBHQyBUaW1lcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3Jl U3VwcG9ydC9xdC9XZWJGcmFtZU5ldHdvcmtpbmdDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvcXQvV2ViRnJhbWVOZXR3b3JraW5nQ29udGV4dC5j cHAKaW5kZXggMDcwZDQ3OS4uMzg3MzA0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9xdC9XZWJGcmFtZU5ldHdvcmtpbmdDb250ZXh0LmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L3F0L1dlYkZyYW1l TmV0d29ya2luZ0NvbnRleHQuY3BwCkBAIC0zMSwxMSArMzEsMTMgQEAgbmFtZXNwYWNlIFdlYkNv cmUgewogCiBXZWJGcmFtZU5ldHdvcmtpbmdDb250ZXh0OjpXZWJGcmFtZU5ldHdvcmtpbmdDb250 ZXh0KFdlYktpdDo6V2ViRnJhbWUqIGZyYW1lKQogICAgIDogRnJhbWVOZXR3b3JraW5nQ29udGV4 dChmcmFtZS0+Y29yZUZyYW1lKCkpCi0gICAgLCBtX29yaWdpbmF0aW5nT2JqZWN0KGFkb3B0UHRy KG5ldyBRT2JqZWN0KSkKICAgICAsIG1fbWltZVNuaWZmaW5nRW5hYmxlZCh0cnVlKQogewotICAg IC8vIFRoZSBwYWdlIElEIGlzIG5lZWRlZCBsYXRlciBmb3IgSFRUUCBhdXRoZW50aWNhdGlvbiBh bmQgU1NMIGVycm9ycy4KLSAgICBtX29yaWdpbmF0aW5nT2JqZWN0LT5zZXRQcm9wZXJ0eSgicGFn ZUlEIiwgcXVsb25nbG9uZyhmcmFtZS0+cGFnZSgpLT5wYWdlSUQoKSkpOworICAgIC8vIFNhdmUg dGhlIHBhZ2UgSUQgZm9yIGEgdmFsaWQgcGFnZSBhcyBpdCBpcyBuZWVkZWQgbGF0ZXIgZm9yIEhU VFAgYXV0aGVudGljYXRpb24gYW5kIFNTTCBlcnJvcnMuCisgICAgaWYgKGZyYW1lLT5wYWdlKCkp IHsKKyAgICAgICAgbV9vcmlnaW5hdGluZ09iamVjdCA9IGFkb3B0UHRyKG5ldyBRT2JqZWN0KTsK KyAgICAgICAgbV9vcmlnaW5hdGluZ09iamVjdC0+c2V0UHJvcGVydHkoInBhZ2VJRCIsIHF1bG9u Z2xvbmcoZnJhbWUtPnBhZ2UoKS0+cGFnZUlEKCkpKTsKKyAgICB9CiB9CiAKIFdlYkZyYW1lTmV0 d29ya2luZ0NvbnRleHQ6On5XZWJGcmFtZU5ldHdvcmtpbmdDb250ZXh0KCkK