83574 2012-04-10 06:35:55 -0700 [CMake] Add WEBKIT_CREATE_FORWARDING_HEADERS macro 2012-07-30 06:06:11 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 83579 1 paroga paroga dbates rakuco rwlbuis tmpsantos webkit.review.bot oldest_to_newest 599218 0 paroga 2012-04-10 06:35:55 -0700 [CMake] Add WEBKIT_CREATE_FORWARDING_HEADERS macro 599221 1 136445 paroga 2012-04-10 06:40:42 -0700 Created attachment 136445 Patch 599260 2 136445 paroga 2012-04-10 07:33:45 -0700 Comment on attachment 136445 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136445&action=review > ChangeLog:9 > + It accepts a list of files and/or a list of directories as input. See CMake based build system for WinApple at https://bugs.webkit.org/show_bug.cgi?id=72816 for usage. 599411 3 136445 dbates 2012-04-10 10:48:57 -0700 Comment on attachment 136445 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136445&action=review > Source/cmake/WebKitMacros.cmake:192 > + SET(_doing_directories 0) > + SET(_doing_files 0) These names are OK as-as. Maybe the prefix "_processing_" would be somewhat more descriptive than the prefix "_doing_". That being said, both "processing" and "doing" are somewhat vague terms. > Source/cmake/WebKitMacros.cmake:198 > + STRING(REGEX MATCH "^#include \"(.*)\"" _matched ${_content}) Can we make this regular expression stronger? In particular, would substituting [^"] instead of (.*) help strengthen this? Can we also match the newline/end-of-line character '$'? 599413 4 dbates 2012-04-10 10:51:58 -0700 (In reply to comment #3) > > Source/cmake/WebKitMacros.cmake:198 > > + STRING(REGEX MATCH "^#include \"(.*)\"" _matched ${_content}) > > Can we make this regular expression stronger? In particular, would substituting [^"] instead of (.*) help strengthen this? Can we also match the newline/end-of-line character '$'? I meant ([^"]) instead of (.*). 600164 5 136445 paroga 2012-04-11 02:40:18 -0700 Comment on attachment 136445 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136445&action=review >> Source/cmake/WebKitMacros.cmake:198 >> + STRING(REGEX MATCH "^#include \"(.*)\"" _matched ${_content}) > > Can we make this regular expression stronger? In particular, would substituting [^"] instead of (.*) help strengthen this? Can we also match the newline/end-of-line character '$'? i added the [^"], but newline matching isn't possible (at least on windows) 600170 6 paroga 2012-04-11 02:46:22 -0700 Committed r113844: <http://trac.webkit.org/changeset/113844> 681941 7 tmpsantos 2012-07-30 06:06:11 -0700 I'm trying to understand: why using a CMake macro is better than using the existing script used by all platforms? 136445 2012-04-10 06:40:42 -0700 2012-04-11 02:40:18 -0700 Patch bug-83574-20120410154039.patch text/plain 2855 paroga U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNzA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0TWFjcm9zLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdE1hY3Jvcy5jbWFrZQppbmRleCAz YWJlMzQyYjdlNTNhMDgwOTJhNGE1ZTcwMDBlYjgwYWFmMGQwY2VjLi43ZjQ2Njk5ZDlhMzFmNTgy OWZkNjljNWEyMzNjZDAzNTUzMjZjYzNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0 TWFjcm9zLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRNYWNyb3MuY21ha2UKQEAgLTE3 MCwzICsxNzAsNTEgQEAgTUFDUk8gKFdFQktJVF9XUkFQX1NPVVJDRUxJU1QpCiAKICAgICBTT1VS Q0VfR1JPVVAoIkRlcml2ZWRTb3VyY2VzIiBSRUdVTEFSX0VYUFJFU1NJT04gIiR7REVSSVZFRF9T T1VSQ0VTX1dFQkNPUkVfRElSfSIpCiBFTkRNQUNSTyAoKQorCisKK01BQ1JPIChXRUJLSVRfQ1JF QVRFX0ZPUldBUkRJTkdfSEVBREVSIF90YXJnZXRfZGlyZWN0b3J5IF9maWxlKQorICAgIEdFVF9G SUxFTkFNRV9DT01QT05FTlQoX2Fic29sdXRlICIke19maWxlfSIgQUJTT0xVVEUpCisgICAgR0VU X0ZJTEVOQU1FX0NPTVBPTkVOVChfbmFtZSAiJHtfZmlsZX0iIE5BTUUpCisgICAgU0VUKF9jb250 ZW50ICIjaW5jbHVkZSBcIiR7X2Fic29sdXRlfVwiXG4iKQorICAgIFNFVChfZmlsZW5hbWUgIiR7 X3RhcmdldF9kaXJlY3Rvcnl9LyR7X25hbWV9IikKKworICAgIElGIChFWElTVFMgIiR7X2ZpbGVu YW1lfSIpCisgICAgICAgIEZJTEUoUkVBRCAiJHtfZmlsZW5hbWV9IiBfb2xkX2NvbnRlbnQpCisg ICAgRU5ESUYgKCkKKworICAgIElGIChOT1QgX29sZF9jb250ZW50IFNUUkVRVUFMIF9jb250ZW50 KQorICAgICAgICBGSUxFKFdSSVRFICIke19maWxlbmFtZX0iICIke19jb250ZW50fSIpCisgICAg RU5ESUYgKCkKK0VORE1BQ1JPICgpCisKK01BQ1JPIChXRUJLSVRfQ1JFQVRFX0ZPUldBUkRJTkdf SEVBREVSUyBfZnJhbWV3b3JrKQorICAgIFNFVChfZG9pbmdfZGlyZWN0b3JpZXMgMCkKKyAgICBT RVQoX2RvaW5nX2ZpbGVzIDApCisgICAgU0VUKF90YXJnZXRfZGlyZWN0b3J5ICIke0RFUklWRURf U09VUkNFU19ESVJ9L0ZvcndhcmRpbmdIZWFkZXJzLyR7X2ZyYW1ld29ya30iKQorCisgICAgRklM RShHTE9CIF9maWxlcyAiJHtfdGFyZ2V0X2RpcmVjdG9yeX0vKi5oIikKKyAgICBGT1JFQUNIIChf ZmlsZSAke19maWxlc30pCisgICAgICAgIEZJTEUoUkVBRCAiJHtfZmlsZX0iIF9jb250ZW50KQor ICAgICAgICBTVFJJTkcoUkVHRVggTUFUQ0ggIl4jaW5jbHVkZSBcIiguKilcIiIgX21hdGNoZWQg JHtfY29udGVudH0pCisgICAgICAgIElGIChfbWF0Y2hlZCBBTkQgTk9UIEVYSVNUUyAiJHtDTUFL RV9NQVRDSF8xfSIpCisgICAgICAgICAgIEZJTEUoUkVNT1ZFICIke19maWxlfSIpCisgICAgICAg IEVORElGKCkKKyAgICBFTkRGT1JFQUNIICgpCisKKyAgICBGT1JFQUNIIChfY3VycmVudEFyZyAk e0FSR059KQorICAgICAgICBJRiAoIiR7X2N1cnJlbnRBcmd9IiBTVFJFUVVBTCAiRElSRUNUT1JJ RVMiKQorICAgICAgICAgICAgU0VUKF9kb2luZ19kaXJlY3RvcmllcyAxKQorICAgICAgICAgICAg U0VUKF9kb2luZ19maWxlcyAwKQorICAgICAgICBFTFNFSUYgKCIke19jdXJyZW50QXJnfSIgU1RS RVFVQUwgIkZJTEVTIikKKyAgICAgICAgICAgIFNFVChfZG9pbmdfZGlyZWN0b3JpZXMgMCkKKyAg ICAgICAgICAgIFNFVChfZG9pbmdfZmlsZXMgMSkKKyAgICAgICAgRUxTRUlGIChfZG9pbmdfZGly ZWN0b3JpZXMpCisgICAgICAgICAgICBGSUxFKEdMT0IgX2ZpbGVzICIke19jdXJyZW50QXJnfS8q LmgiKQorICAgICAgICAgICAgRk9SRUFDSCAoX2ZpbGUgJHtfZmlsZXN9KQorICAgICAgICAgICAg ICAgIFdFQktJVF9DUkVBVEVfRk9SV0FSRElOR19IRUFERVIoJHtfdGFyZ2V0X2RpcmVjdG9yeX0g JHtfZmlsZX0pCisgICAgICAgICAgICBFTkRGT1JFQUNIICgpCisgICAgICAgIEVMU0VJRiAoX2Rv aW5nX2ZpbGVzKQorICAgICAgICAgICAgV0VCS0lUX0NSRUFURV9GT1JXQVJESU5HX0hFQURFUigk e190YXJnZXRfZGlyZWN0b3J5fSAke19jdXJyZW50QXJnfSkKKyAgICAgICAgRU5ESUYgKCkKKyAg ICBFTkRGT1JFQUNIICgpCitFTkRNQUNSTyAoKQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hh bmdlTG9nCmluZGV4IDE1ZTdkODBmYTY4NDhmNzk0OTg1MTEwMDdlYThmOWU5MTEwYjkyNzkuLjUz MDU2Yjc4ZjYxNGI3OWJlOWQ0MDNkYWMyMzZmZDE5M2M4MTA5NTUgMTAwNjQ0Ci0tLSBhL0NoYW5n ZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wNC0xMCAgUGF0cmlj ayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBbQ01ha2VdIEFkZCBX RUJLSVRfQ1JFQVRFX0ZPUldBUkRJTkdfSEVBREVSUyBtYWNybworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODM1NzQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIG5ldyBtYWNybyBnZW5lcmF0ZXMgZm9y d2FyZGluZyBoZWFkZXJzIHdpdGggYWJzb2x1dGUgcGF0aHMgdG8gdGhlIG9yaWdpbmFsIGZpbGVz LgorICAgICAgICBJdCBhY2NlcHRzIGEgbGlzdCBvZiBmaWxlcyBhbmQvb3IgYSBsaXN0IG9mIGRp cmVjdG9yaWVzIGFzIGlucHV0LgorCisgICAgICAgICogU291cmNlL2NtYWtlL1dlYktpdE1hY3Jv cy5jbWFrZToKKwogMjAxMi0wNC0wNiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4K IAogICAgICAgICBVcGRhdGUgcGVyZi1vLW1hdGljIGNvbmZpZy5qcyBwZXIgdXBzdHJlYW0gY2hh bmdlLgo=