83567 2012-04-10 05:32:44 -0700 [BlackBerry] Crash when tearing down web page rendered using WebPageCompositor 2012-04-10 12:55:39 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 anilsson webkit-unassigned rwlbuis tonikitoo webkit.review.bot oldest_to_newest 599182 0 anilsson 2012-04-10 05:32:44 -0700 This happens when the WebPage::setVisible(false) is called as part of tearing down a WebPage. This calls suspendRootLayerCommit() which schedules destroyLayerResources() on the UI thread. UI thread call stack: WebCore::LayerRenderer::releaseLayerResources (this=0x0) at /home/anilsson/dev/webkit/Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp:191 191 if (m_hardwareCompositing) { (gdb) p this $1 = (WebCore::LayerRenderer * const) 0x0 (gdb) bt #0 WebCore::LayerRenderer::releaseLayerResources (this=0x0) at /home/anilsson/dev/webkit/Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp:191 #1 0x7925dc2c in BlackBerry::WebKit::WebPageCompositorPrivate::releaseLayerResources (this=<optimized out>) at /home/anilsson/dev/webkit/Source/WebKit/blackberry/Api/WebPageCompositor.cpp:146 #2 0x7924c726 in BlackBerry::WebKit::WebPagePrivate::destroyLayerResources ( this=<optimized out>) at /home/anilsson/dev/webkit/Source/WebKit/blackberry/Api/WebPage.cpp:5566 #3 0x7925c3aa in BlackBerry::Platform::MethodDelegate0<void (BlackBerry::WebKit::WebPagePrivate::*)(), BlackBerry::WebKit::WebPagePrivate>::execute ( this=0xb7e980) at /home/anilsson/dev/staging/usr/include/browser/platform/BlackBerryPlatformMessageDelegate.h:770 #4 0x7a05ff98 in BlackBerry::Platform::ExecutableMessage::execute ( this=<optimized out>) at /home/anilsson/dev/platform/blackberryplatform/BlackBerryPlatformExecutableMessage.cpp:38 ... 599185 1 136435 anilsson 2012-04-10 05:37:10 -0700 Created attachment 136435 Patch 599198 2 136435 tonikitoo 2012-04-10 05:54:40 -0700 Comment on attachment 136435 Patch so if the mlayerRenderer is null, "resources" were already released? 599206 3 anilsson 2012-04-10 06:02:45 -0700 (In reply to comment #2) > (From update of attachment 136435 [details]) > so if the mlayerRenderer is null, "resources" were already released? Yes, or you could see it this way - the LayerRenderer owns the resources that should be released, so if there's no LayerRenderer, there are no resources to delete. Resources = textures right now, but could be more stuff in the future (for example shaders). 599246 4 136435 tonikitoo 2012-04-10 07:17:44 -0700 Comment on attachment 136435 Patch (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 136435 [details] [details]) > > so if the mlayerRenderer is null, "resources" were already released? > > Yes, or you could see it this way - the LayerRenderer owns the resources that should be released, so if there's no LayerRenderer, there are no resources to delete. Resources = textures right now, but could be more stuff in the future (for example shaders). Ok. I was wondering was would be the codepath be... 599521 5 anilsson 2012-04-10 12:39:54 -0700 (In reply to comment #4) > (From update of attachment 136435 [details]) > (In reply to comment #3) > > (In reply to comment #2) > > > (From update of attachment 136435 [details] [details] [details]) > > > so if the mlayerRenderer is null, "resources" were already released? > > > > Yes, or you could see it this way - the LayerRenderer owns the resources that should be released, so if there's no LayerRenderer, there are no resources to delete. Resources = textures right now, but could be more stuff in the future (for example shaders). > > Ok. I was wondering was would be the codepath be... Right now, it's probably due to an earlier call to WebPageCompositor::cleanup() that would clear the layer renderer. The layer rendrrer destructor then releases the resources. 599545 6 136435 webkit.review.bot 2012-04-10 12:55:34 -0700 Comment on attachment 136435 Patch Clearing flags on attachment: 136435 Committed r113757: <http://trac.webkit.org/changeset/113757> 599546 7 webkit.review.bot 2012-04-10 12:55:39 -0700 All reviewed patches have been landed. Closing bug. 136435 2012-04-10 05:37:10 -0700 2012-04-10 12:55:34 -0700 Patch bug-83567-20120410083707.patch text/plain 1508 anilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNzA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBlNDllMDdjZTMwZDQ4MDcxM2ZhYTlhNmIyYmMxOWUxNWUzZTNiZDljLi4xZjlmYjczYTgw MjE3ZmJmMTAzMDA3NGVkYzJjZWI4NzdmOTY4MTA3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wNC0wOSAgQXJ2aWQgTmlsc3NvbiAgPGFuaWxz c29uQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIENyYXNoIHdoZW4gdGVhcmluZyBk b3duIHdlYiBwYWdlIHJlbmRlcmVkIHVzaW5nIFdlYlBhZ2VDb21wb3NpdG9yCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzU2NworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVkIGJ5IGNoZWNraW5nIGlm IHRoZXJlJ3MgYSBsYXllciByZW5kZXJlciBiZWZvcmUgY2FsbGluZyBpbnRvIGl0LgorCisgICAg ICAgICogQXBpL1dlYlBhZ2VDb21wb3NpdG9yLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6Oldl YktpdDo6V2ViUGFnZUNvbXBvc2l0b3JQcml2YXRlOjpyZWxlYXNlTGF5ZXJSZXNvdXJjZXMpOgor CiAyMDEyLTA0LTA5ICBFbGkgRmlkbGVyICA8ZWZpZGxlckByaW0uY29tPgogCiAgICAgICAgIFtC bGFja0JlcnJ5XSBVcGRhdGUgYWJvdXQ6Y29uZmlnIHBhZ2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZUNvbXBvc2l0b3IuY3BwIGIvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlQ29tcG9zaXRvci5jcHAKaW5kZXggZTkyNjIxYzJjMGEw MjFkMGUxZDQ5ZTk2ZjA0N2Y4MmQ4YTM4NzliOS4uYTc0YjYzNzNjMGM2ZDI0ZGRlNDljMjhmNzg2 MTQ1YTMxYzYwMTE4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9X ZWJQYWdlQ29tcG9zaXRvci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9X ZWJQYWdlQ29tcG9zaXRvci5jcHAKQEAgLTE0Myw3ICsxNDMsOCBAQCBib29sIFdlYlBhZ2VDb21w b3NpdG9yUHJpdmF0ZTo6ZHJhd0xheWVycyhjb25zdCBJbnRSZWN0JiBkc3RSZWN0LCBjb25zdCBG bG9hdFJlYwogCiB2b2lkIFdlYlBhZ2VDb21wb3NpdG9yUHJpdmF0ZTo6cmVsZWFzZUxheWVyUmVz b3VyY2VzKCkKIHsKLSAgICBtX2xheWVyUmVuZGVyZXItPnJlbGVhc2VMYXllclJlc291cmNlcygp OworICAgIGlmIChtX2xheWVyUmVuZGVyZXIpCisgICAgICAgIG1fbGF5ZXJSZW5kZXJlci0+cmVs ZWFzZUxheWVyUmVzb3VyY2VzKCk7CiB9CiAKIHZvaWQgV2ViUGFnZUNvbXBvc2l0b3JQcml2YXRl OjphbmltYXRpb25GcmFtZUNoYW5nZWQoKQo=