83562 2012-04-10 04:20:00 -0700 [CMake] CMake SVG Code Generation fails to generate code for extra defines 2012-04-10 14:05:49 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 83564 1 d-r d-r eric gyuyoung.kim morrita paroga rakuco rwlbuis webkit.review.bot oldest_to_newest 599147 0 d-r 2012-04-10 04:20:00 -0700 Mapping e.g. from CMAKE ON/OFF to ENABLE_FILTERS=ON is incorrect since the string value ON is not mapped to enabling code inside #if ENABLE_FILTERS for example. See svgtags.in. We need to generate ENABLE_FILTERS=1 for this to work, compare: http://trac.webkit.org/browser/trunk/Source/WebCore/DerivedSources.make#L858 This should unskip a couple of SVG related tests on EFL. 599149 1 d-r 2012-04-10 04:20:52 -0700 Also, meant to say that this should fix a couple of currently failing SVG tests that rely on SVG filters. 599170 2 136431 d-r 2012-04-10 05:17:23 -0700 Created attachment 136431 Fixing CMake build wrt SVG code generation This should bring EFL test failures down by at least 17 cases. 599174 3 136431 rwlbuis 2012-04-10 05:25:07 -0700 Comment on attachment 136431 Fixing CMake build wrt SVG code generation View in context: https://bugs.webkit.org/attachment.cgi?id=136431&action=review I agree with this patch. If you can reupload the patch with typo fix I can r+. > Source/WebCore/CMakeLists.txt:2584 > +# SVG extra defines need to map to a numerical value for correct preprocessing of svtags.in. svgtags.in > Source/WebCore/CMakeLists.txt:2590 > + LIST(APPEND SVG_EXTRA_DEFINES "ENABLE_SVG_FONTS=1") Does this add a space separator between both defines? 599175 4 gyuyoung.kim 2012-04-10 05:26:26 -0700 CC'ing patrick. 599177 5 paroga 2012-04-10 05:27:49 -0700 LGTM, since I have no better idea ATM 599183 6 136434 d-r 2012-04-10 05:34:52 -0700 Created attachment 136434 Fixing CMake build wrt SVG code generation Thanks for the quick review, typo fixed. 599184 7 d-r 2012-04-10 05:35:29 -0700 (In reply to comment #3) > (From update of attachment 136431 [details]) > > > Source/WebCore/CMakeLists.txt:2590 > > + LIST(APPEND SVG_EXTRA_DEFINES "ENABLE_SVG_FONTS=1") > > Does this add a space separator between both defines? Yes it does. 599188 8 136434 paroga 2012-04-10 05:37:55 -0700 Comment on attachment 136434 Fixing CMake build wrt SVG code generation View in context: https://bugs.webkit.org/attachment.cgi?id=136434&action=review > Source/WebCore/CMakeLists.txt:2585 > +SET(SVG_EXTRA_DEFINES, "") missed a point: comma after SVG_EXTRA_DEFINES 599191 9 136436 d-r 2012-04-10 05:42:35 -0700 Created attachment 136436 Fixing CMake build wrt SVG code generation (In reply to comment #8) > (From update of attachment 136434 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=136434&action=review > > > Source/WebCore/CMakeLists.txt:2585 > > +SET(SVG_EXTRA_DEFINES, "") > > missed a point: comma after SVG_EXTRA_DEFINES Thanks. Fixed. 599252 10 136436 rwlbuis 2012-04-10 07:22:17 -0700 Comment on attachment 136436 Fixing CMake build wrt SVG code generation Looks fine. Should I cq+ too? 599253 11 d-r 2012-04-10 07:24:33 -0700 (In reply to comment #10) > (From update of attachment 136436 [details]) > Looks fine. Should I cq+ too? Yes please. 599255 12 136436 rwlbuis 2012-04-10 07:25:27 -0700 Comment on attachment 136436 Fixing CMake build wrt SVG code generation Looks fine. Should I cq+ too? 599257 13 d-r 2012-04-10 07:26:37 -0700 Thanks, Rob & Paroga! 599610 14 136436 webkit.review.bot 2012-04-10 14:05:43 -0700 Comment on attachment 136436 Fixing CMake build wrt SVG code generation Clearing flags on attachment: 136436 Committed r113763: <http://trac.webkit.org/changeset/113763> 599611 15 webkit.review.bot 2012-04-10 14:05:49 -0700 All reviewed patches have been landed. Closing bug. 136431 2012-04-10 05:17:23 -0700 2012-04-10 05:34:52 -0700 Fixing CMake build wrt SVG code generation bug83562.patch text/plain 1793 d-r ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dlYkNv cmUvQ01ha2VMaXN0cy50eHQKaW5kZXggNGVhOTAyOC4uNmRjNWEzYSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0 cy50eHQKQEAgLTI1ODEsOCArMjU4MSwxNiBAQCBJRiAoRU5BQkxFX01BVEhNTCkKICAgICBMSVNU KEFQUEVORCBXZWJDb3JlX1NPVVJDRVMgJHtERVJJVkVEX1NPVVJDRVNfV0VCQ09SRV9ESVJ9L01h dGhNTEVsZW1lbnRGYWN0b3J5LmNwcCkKIEVORElGICgpCiAKKyMgU1ZHIGV4dHJhIGRlZmluZXMg bmVlZCB0byBtYXAgdG8gYSBudW1lcmljYWwgdmFsdWUgZm9yIGNvcnJlY3QgcHJlcHJvY2Vzc2lu ZyBvZiBzdnRhZ3MuaW4uCitTRVQoU1ZHX0VYVFJBX0RFRklORVMsICIiKQorSUYgKEVOQUJMRV9G SUxURVJTKQorICAgIExJU1QoQVBQRU5EIFNWR19FWFRSQV9ERUZJTkVTICJFTkFCTEVfRklMVEVS Uz0xIikKK0VORElGICgpCitJRiAoRU5BQkxFX1NWR19GT05UUykKKyAgICBMSVNUKEFQUEVORCBT VkdfRVhUUkFfREVGSU5FUyAiRU5BQkxFX1NWR19GT05UUz0xIikKK0VORElGICgpCiAKLUdFTkVS QVRFX0RPTV9OQU1FUyhTVkcgJHtXRUJDT1JFX0RJUn0vc3ZnL3N2Z2F0dHJzLmluICR7V0VCQ09S RV9ESVJ9L3N2Zy9zdmd0YWdzLmluICJFTkFCTEVfRklMVEVSUz0ke0VOQUJMRV9GSUxURVJTfSBF TkFCTEVfU1ZHX0ZPTlRTPSR7RU5BQkxFX1NWR19GT05UU30iKQorR0VORVJBVEVfRE9NX05BTUVT KFNWRyAke1dFQkNPUkVfRElSfS9zdmcvc3ZnYXR0cnMuaW4gJHtXRUJDT1JFX0RJUn0vc3ZnL3N2 Z3RhZ3MuaW4gIiR7U1ZHX0VYVFJBX0RFRklORVN9IikKIExJU1QoQVBQRU5EIFdlYkNvcmVfU09V UkNFUyAke0RFUklWRURfU09VUkNFU19XRUJDT1JFX0RJUn0vU1ZHTmFtZXMuY3BwKQogSUYgKEVO QUJMRV9TVkcpCiAgICAgTElTVChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTICR7REVSSVZFRF9TT1VS Q0VTX1dFQkNPUkVfRElSfS9TVkdFbGVtZW50RmFjdG9yeS5jcHAgJHtERVJJVkVEX1NPVVJDRVNf V0VCQ09SRV9ESVJ9L0pTU1ZHRWxlbWVudFdyYXBwZXJGYWN0b3J5LmNwcCkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCAzOGUwMmU1Li45NTc4ZmQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDQt MTAgIERvbWluaWsgUsO2dHRzY2hlcyAgPGRvbWluaWsucm90dHNjaGVzQGxpbnV4LmludGVsLmNv bT4KKworICAgICAgICBbQ01ha2VdIENNYWtlIFNWRyBDb2RlIEdlbmVyYXRpb24gZmFpbHMgdG8g Z2VuZXJhdGUgY29kZSBmb3IgZXh0cmEgZGVmaW5lcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODM1NjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBGaXhpbmcgQ01ha2VMaXN0cy50eHQgdG8gZ2VuZXJhdGUg Y29ycmVjdCBleHRyYSBkZWZpbmVzIGZvciBTVkcgY29kZSBnZW5lcmF0b3IuCisKKyAgICAgICAg KiBDTWFrZUxpc3RzLnR4dDoKKwogMjAxMi0wNC0xMCAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gRml4ZWQgQXBwbGVXaW4gYW5kIENo cm9taXVtLXdpbiBidWlsZCBmYWlsdXJlLgo= 136434 2012-04-10 05:34:52 -0700 2012-04-10 05:42:35 -0700 Fixing CMake build wrt SVG code generation bug83562.patch text/plain 1794 d-r ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dlYkNv cmUvQ01ha2VMaXN0cy50eHQKaW5kZXggNGVhOTAyOC4uMWJmZDNjMiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0 cy50eHQKQEAgLTI1ODEsOCArMjU4MSwxNiBAQCBJRiAoRU5BQkxFX01BVEhNTCkKICAgICBMSVNU KEFQUEVORCBXZWJDb3JlX1NPVVJDRVMgJHtERVJJVkVEX1NPVVJDRVNfV0VCQ09SRV9ESVJ9L01h dGhNTEVsZW1lbnRGYWN0b3J5LmNwcCkKIEVORElGICgpCiAKKyMgU1ZHIGV4dHJhIGRlZmluZXMg bmVlZCB0byBtYXAgdG8gYSBudW1lcmljYWwgdmFsdWUgZm9yIGNvcnJlY3QgcHJlcHJvY2Vzc2lu ZyBvZiBzdmd0YWdzLmluLgorU0VUKFNWR19FWFRSQV9ERUZJTkVTLCAiIikKK0lGIChFTkFCTEVf RklMVEVSUykKKyAgICBMSVNUKEFQUEVORCBTVkdfRVhUUkFfREVGSU5FUyAiRU5BQkxFX0ZJTFRF UlM9MSIpCitFTkRJRiAoKQorSUYgKEVOQUJMRV9TVkdfRk9OVFMpCisgICAgTElTVChBUFBFTkQg U1ZHX0VYVFJBX0RFRklORVMgIkVOQUJMRV9TVkdfRk9OVFM9MSIpCitFTkRJRiAoKQogCi1HRU5F UkFURV9ET01fTkFNRVMoU1ZHICR7V0VCQ09SRV9ESVJ9L3N2Zy9zdmdhdHRycy5pbiAke1dFQkNP UkVfRElSfS9zdmcvc3ZndGFncy5pbiAiRU5BQkxFX0ZJTFRFUlM9JHtFTkFCTEVfRklMVEVSU30g RU5BQkxFX1NWR19GT05UUz0ke0VOQUJMRV9TVkdfRk9OVFN9IikKK0dFTkVSQVRFX0RPTV9OQU1F UyhTVkcgJHtXRUJDT1JFX0RJUn0vc3ZnL3N2Z2F0dHJzLmluICR7V0VCQ09SRV9ESVJ9L3N2Zy9z dmd0YWdzLmluICIke1NWR19FWFRSQV9ERUZJTkVTfSIpCiBMSVNUKEFQUEVORCBXZWJDb3JlX1NP VVJDRVMgJHtERVJJVkVEX1NPVVJDRVNfV0VCQ09SRV9ESVJ9L1NWR05hbWVzLmNwcCkKIElGIChF TkFCTEVfU1ZHKQogICAgIExJU1QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUyAke0RFUklWRURfU09V UkNFU19XRUJDT1JFX0RJUn0vU1ZHRWxlbWVudEZhY3RvcnkuY3BwICR7REVSSVZFRF9TT1VSQ0VT X1dFQkNPUkVfRElSfS9KU1NWR0VsZW1lbnRXcmFwcGVyRmFjdG9yeS5jcHApCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5k ZXggMzhlMDJlNS4uOTU3OGZkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA0 LTEwICBEb21pbmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BsaW51eC5pbnRlbC5j b20+CisKKyAgICAgICAgW0NNYWtlXSBDTWFrZSBTVkcgQ29kZSBHZW5lcmF0aW9uIGZhaWxzIHRv IGdlbmVyYXRlIGNvZGUgZm9yIGV4dHJhIGRlZmluZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzNTYyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRml4aW5nIENNYWtlTGlzdHMudHh0IHRvIGdlbmVyYXRl IGNvcnJlY3QgZXh0cmEgZGVmaW5lcyBmb3IgU1ZHIGNvZGUgZ2VuZXJhdG9yLgorCisgICAgICAg ICogQ01ha2VMaXN0cy50eHQ6CisKIDIwMTItMDQtMTAgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5A Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIEZpeGVkIEFwcGxlV2luIGFuZCBD aHJvbWl1bS13aW4gYnVpbGQgZmFpbHVyZS4K 136436 2012-04-10 05:42:35 -0700 2012-04-10 14:05:43 -0700 Fixing CMake build wrt SVG code generation bug83562_v3.patch text/plain 1793 d-r ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dlYkNv cmUvQ01ha2VMaXN0cy50eHQKaW5kZXggNGVhOTAyOC4uNjAyMTc1YSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0 cy50eHQKQEAgLTI1ODEsOCArMjU4MSwxNiBAQCBJRiAoRU5BQkxFX01BVEhNTCkKICAgICBMSVNU KEFQUEVORCBXZWJDb3JlX1NPVVJDRVMgJHtERVJJVkVEX1NPVVJDRVNfV0VCQ09SRV9ESVJ9L01h dGhNTEVsZW1lbnRGYWN0b3J5LmNwcCkKIEVORElGICgpCiAKKyMgU1ZHIGV4dHJhIGRlZmluZXMg bmVlZCB0byBtYXAgdG8gYSBudW1lcmljYWwgdmFsdWUgZm9yIGNvcnJlY3QgcHJlcHJvY2Vzc2lu ZyBvZiBzdmd0YWdzLmluLgorU0VUKFNWR19FWFRSQV9ERUZJTkVTICIiKQorSUYgKEVOQUJMRV9G SUxURVJTKQorICAgIExJU1QoQVBQRU5EIFNWR19FWFRSQV9ERUZJTkVTICJFTkFCTEVfRklMVEVS Uz0xIikKK0VORElGICgpCitJRiAoRU5BQkxFX1NWR19GT05UUykKKyAgICBMSVNUKEFQUEVORCBT VkdfRVhUUkFfREVGSU5FUyAiRU5BQkxFX1NWR19GT05UUz0xIikKK0VORElGICgpCiAKLUdFTkVS QVRFX0RPTV9OQU1FUyhTVkcgJHtXRUJDT1JFX0RJUn0vc3ZnL3N2Z2F0dHJzLmluICR7V0VCQ09S RV9ESVJ9L3N2Zy9zdmd0YWdzLmluICJFTkFCTEVfRklMVEVSUz0ke0VOQUJMRV9GSUxURVJTfSBF TkFCTEVfU1ZHX0ZPTlRTPSR7RU5BQkxFX1NWR19GT05UU30iKQorR0VORVJBVEVfRE9NX05BTUVT KFNWRyAke1dFQkNPUkVfRElSfS9zdmcvc3ZnYXR0cnMuaW4gJHtXRUJDT1JFX0RJUn0vc3ZnL3N2 Z3RhZ3MuaW4gIiR7U1ZHX0VYVFJBX0RFRklORVN9IikKIExJU1QoQVBQRU5EIFdlYkNvcmVfU09V UkNFUyAke0RFUklWRURfU09VUkNFU19XRUJDT1JFX0RJUn0vU1ZHTmFtZXMuY3BwKQogSUYgKEVO QUJMRV9TVkcpCiAgICAgTElTVChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTICR7REVSSVZFRF9TT1VS Q0VTX1dFQkNPUkVfRElSfS9TVkdFbGVtZW50RmFjdG9yeS5jcHAgJHtERVJJVkVEX1NPVVJDRVNf V0VCQ09SRV9ESVJ9L0pTU1ZHRWxlbWVudFdyYXBwZXJGYWN0b3J5LmNwcCkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCAzOGUwMmU1Li45NTc4ZmQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDQt MTAgIERvbWluaWsgUsO2dHRzY2hlcyAgPGRvbWluaWsucm90dHNjaGVzQGxpbnV4LmludGVsLmNv bT4KKworICAgICAgICBbQ01ha2VdIENNYWtlIFNWRyBDb2RlIEdlbmVyYXRpb24gZmFpbHMgdG8g Z2VuZXJhdGUgY29kZSBmb3IgZXh0cmEgZGVmaW5lcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODM1NjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBGaXhpbmcgQ01ha2VMaXN0cy50eHQgdG8gZ2VuZXJhdGUg Y29ycmVjdCBleHRyYSBkZWZpbmVzIGZvciBTVkcgY29kZSBnZW5lcmF0b3IuCisKKyAgICAgICAg KiBDTWFrZUxpc3RzLnR4dDoKKwogMjAxMi0wNC0xMCAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gRml4ZWQgQXBwbGVXaW4gYW5kIENo cm9taXVtLXdpbiBidWlsZCBmYWlsdXJlLgo=