83548 2012-04-09 22:10:43 -0700 Pass FontDescription as const reference instead of by value in CSSStyleSelector.h. 2012-04-10 12:31:27 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 macpherson macpherson haraken macpherson menard webkit.review.bot oldest_to_newest 599007 0 macpherson 2012-04-09 22:10:43 -0700 Pass FontDescription as const reference instead of by value in CSSStyleSelector.h. 599008 1 136397 macpherson 2012-04-09 22:12:08 -0700 Created attachment 136397 Patch 599506 2 136397 webkit.review.bot 2012-04-10 12:31:23 -0700 Comment on attachment 136397 Patch Clearing flags on attachment: 136397 Committed r113752: <http://trac.webkit.org/changeset/113752> 599507 3 webkit.review.bot 2012-04-10 12:31:27 -0700 All reviewed patches have been landed. Closing bug. 136397 2012-04-09 22:12:08 -0700 2012-04-10 12:31:23 -0700 Patch bug-83548-20120410151206.patch text/plain 2295 macpherson U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNjcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmJiYWY4MDk2ZjljOWE4 N2E5NjhkYzRhM2ZlYWQxNDc5OWZhMGJmZi4uYjM1NGIyM2ZiZWE0NTAyYzNkNGMxNzRiOWEwZjcz MDU4NjZiNDc4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA0LTA5ICBMdWtl IE1hY3BoZXJzb24gIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBQYXNzIEZv bnREZXNjcmlwdGlvbiBhcyBjb25zdCByZWZlcmVuY2UgaW5zdGVhZCBvZiBieSB2YWx1ZSBpbiBD U1NTdHlsZVNlbGVjdG9yLmguCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04MzU0OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEZvbnREZXNjcmlwdGlvbiBpcyByZWxhdGl2ZWx5IGxhcmdlLCBzbyBwYXNzLWJ5 LXJlZmVyZW5jZSBpcyBwcmVmZXJyZWQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIC8gY29kZSBj bGVhbnVwIG9ubHkuCisKKyAgICAgICAgKiBjc3MvQ1NTU3R5bGVTZWxlY3Rvci5oOgorICAgICAg ICAoV2ViQ29yZTo6Q1NTU3R5bGVTZWxlY3Rvcjo6Zm9udERlc2NyaXB0aW9uKToKKyAgICAgICAg KFdlYkNvcmU6OkNTU1N0eWxlU2VsZWN0b3I6OnBhcmVudEZvbnREZXNjcmlwdGlvbik6CisgICAg ICAgIChXZWJDb3JlOjpDU1NTdHlsZVNlbGVjdG9yOjpzZXRGb250RGVzY3JpcHRpb24pOgorCiAy MDEyLTA0LTA5ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAog ICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTEzNjU2LgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuaCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NTdHlsZVNlbGVjdG9yLmgKaW5kZXggNDYxZjQxMGI5OGRmZGNiYjQ3NjYxNjgwMWY4YzQyMWIx YmQyNTk1Zi4uZDcwM2JhNDFkNTUzZmYwNmViYmQ3ZDhhOTc5ZmZkNzlmMWJmYzYzZCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5oCkBAIC0xNDUsOSArMTQ1LDkgQEAgcHVibGlj OgogICAgIFJlbmRlclN0eWxlKiByb290RWxlbWVudFN0eWxlKCkgY29uc3QgeyByZXR1cm4gbV9y b290RWxlbWVudFN0eWxlOyB9CiAgICAgRWxlbWVudCogZWxlbWVudCgpIGNvbnN0IHsgcmV0dXJu IG1fZWxlbWVudDsgfQogICAgIERvY3VtZW50KiBkb2N1bWVudCgpIGNvbnN0IHsgcmV0dXJuIG1f Y2hlY2tlci5kb2N1bWVudCgpOyB9Ci0gICAgRm9udERlc2NyaXB0aW9uIGZvbnREZXNjcmlwdGlv bigpIHsgcmV0dXJuIHN0eWxlKCktPmZvbnREZXNjcmlwdGlvbigpOyB9Ci0gICAgRm9udERlc2Ny aXB0aW9uIHBhcmVudEZvbnREZXNjcmlwdGlvbigpIHtyZXR1cm4gcGFyZW50U3R5bGUoKS0+Zm9u dERlc2NyaXB0aW9uKCk7IH0KLSAgICB2b2lkIHNldEZvbnREZXNjcmlwdGlvbihGb250RGVzY3Jp cHRpb24gZm9udERlc2NyaXB0aW9uKSB7IG1fZm9udERpcnR5IHw9IHN0eWxlKCktPnNldEZvbnRE ZXNjcmlwdGlvbihmb250RGVzY3JpcHRpb24pOyB9CisgICAgY29uc3QgRm9udERlc2NyaXB0aW9u JiBmb250RGVzY3JpcHRpb24oKSB7IHJldHVybiBzdHlsZSgpLT5mb250RGVzY3JpcHRpb24oKTsg fQorICAgIGNvbnN0IEZvbnREZXNjcmlwdGlvbiYgcGFyZW50Rm9udERlc2NyaXB0aW9uKCkgeyBy ZXR1cm4gcGFyZW50U3R5bGUoKS0+Zm9udERlc2NyaXB0aW9uKCk7IH0KKyAgICB2b2lkIHNldEZv bnREZXNjcmlwdGlvbihjb25zdCBGb250RGVzY3JpcHRpb24mIGZvbnREZXNjcmlwdGlvbikgeyBt X2ZvbnREaXJ0eSB8PSBzdHlsZSgpLT5zZXRGb250RGVzY3JpcHRpb24oZm9udERlc2NyaXB0aW9u KTsgfQogICAgIHZvaWQgc2V0Wm9vbShmbG9hdCBmKSB7IG1fZm9udERpcnR5IHw9IHN0eWxlKCkt PnNldFpvb20oZik7IH0KICAgICB2b2lkIHNldEVmZmVjdGl2ZVpvb20oZmxvYXQgZikgeyBtX2Zv bnREaXJ0eSB8PSBzdHlsZSgpLT5zZXRFZmZlY3RpdmVab29tKGYpOyB9CiAgICAgdm9pZCBzZXRU ZXh0U2l6ZUFkanVzdChib29sIGIpIHsgbV9mb250RGlydHkgfD0gc3R5bGUoKS0+c2V0VGV4dFNp emVBZGp1c3QoYik7IH0K