83547 2012-04-09 21:52:04 -0700 Clean up CSSParser::parseFillRepeat(). 2012-04-17 15:17:21 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 macpherson macpherson haraken macpherson menard webkit.review.bot oldest_to_newest 598996 0 macpherson 2012-04-09 21:52:04 -0700 Clean up CSSParser::parseFillRepeat(). 598998 1 136395 macpherson 2012-04-09 21:54:30 -0700 Created attachment 136395 Patch 599123 2 136395 haraken 2012-04-10 03:10:51 -0700 Comment on attachment 136395 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136395&action=review > Source/WebCore/css/CSSParser.cpp:3306 > + > + // If only one value was specified, value2 is the same as value1. > + m_implicitShorthand = true; > + value2 = cssValuePool().createIdentifierValue(static_cast<CSSPrimitiveValue*>(value1.get())->getIdent()); Shouldn't this code be inside the else block of 'if (id == CSSValueRepeat || ...) { .... } else { /* here! */ }'? 599764 3 136395 macpherson 2012-04-10 16:13:13 -0700 Comment on attachment 136395 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136395&action=review >> Source/WebCore/css/CSSParser.cpp:3306 >> + value2 = cssValuePool().createIdentifierValue(static_cast<CSSPrimitiveValue*>(value1.get())->getIdent()); > > Shouldn't this code be inside the else block of 'if (id == CSSValueRepeat || ...) { .... } else { /* here! */ }'? You're basically right - I missed the early return statement there. 599765 4 136566 macpherson 2012-04-10 16:14:04 -0700 Created attachment 136566 Patch 604311 5 136566 haraken 2012-04-17 13:51:16 -0700 Comment on attachment 136566 Patch Looks OK. 604397 6 136566 webkit.review.bot 2012-04-17 15:17:12 -0700 Comment on attachment 136566 Patch Clearing flags on attachment: 136566 Committed r114444: <http://trac.webkit.org/changeset/114444> 604398 7 webkit.review.bot 2012-04-17 15:17:21 -0700 All reviewed patches have been landed. Closing bug. 136395 2012-04-09 21:54:30 -0700 2012-04-10 16:13:56 -0700 Patch bug-83547-20120410145428.patch text/plain 2968 macpherson U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNjcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmJiYWY4MDk2ZjljOWE4 N2E5NjhkYzRhM2ZlYWQxNDc5OWZhMGJmZi4uYWJjNzkwZGI1NWJiODc2OWQ3YmEwNDBjMzc1NDc2 ODAxNzcxMzA2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA0LTA5ICBMdWtl IE1hY3BoZXJzb24gIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBDbGVhbiB1 cCBDU1NQYXJzZXI6OnBhcnNlRmlsbFJlcGVhdCgpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODM1NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmVkIG11bHRpcGxlIHVubmVjZXNzYXJ5IGNhbGxz IHRvIG1fdmFsdWVMaXN0LT5jdXJyZW50KCkuCisgICAgICAgIFJlc3RydWN0dXJlZCBsb2dpYyBm b3IgcGFyc2luZyBzZWNvbmQgdmFsdWUgdG8gbWFrZSBpdCBjbGVhcmVyLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cyAvIGNvZGUgY2xlYW51cCBvbmx5LgorCisgICAgICAgICogY3NzL0NTU1BhcnNl ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6OnBhcnNlRmlsbFJlcGVhdCk6CisK IDIwMTItMDQtMDkgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMTM2NTYuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQ YXJzZXIuY3BwCmluZGV4IDEyNWU0NGEzNjI4NDIzOTBiYWUxMjAwMDU0MjAzYmZkNGMwNjZjNTMu LjgzMmJjZjBhNjFmYzA1ZDAxNWM1Mzk1NWIxZTM0YTk3YTRjZGEzZDMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NQYXJzZXIuY3BwCkBAIC0zMjY4LDggKzMyNjgsNiBAQCB2b2lkIENTU1BhcnNlcjo6cGFyc2VG aWxsUG9zaXRpb24oQ1NTUGFyc2VyVmFsdWVMaXN0KiB2YWx1ZUxpc3QsIFJlZlB0cjxDU1NWYWx1 ZQogCiB2b2lkIENTU1BhcnNlcjo6cGFyc2VGaWxsUmVwZWF0KFJlZlB0cjxDU1NWYWx1ZT4mIHZh bHVlMSwgUmVmUHRyPENTU1ZhbHVlPiYgdmFsdWUyKQogewotICAgIENTU1BhcnNlclZhbHVlKiB2 YWx1ZSA9IG1fdmFsdWVMaXN0LT5jdXJyZW50KCk7Ci0KICAgICBpbnQgaWQgPSBtX3ZhbHVlTGlz dC0+Y3VycmVudCgpLT5pZDsKICAgICBpZiAoaWQgPT0gQ1NTVmFsdWVSZXBlYXRYKSB7CiAgICAg ICAgIG1faW1wbGljaXRTaG9ydGhhbmQgPSB0cnVlOwpAQCAtMzI5MiwyMyArMzI5MCwyMCBAQCB2 b2lkIENTU1BhcnNlcjo6cGFyc2VGaWxsUmVwZWF0KFJlZlB0cjxDU1NWYWx1ZT4mIHZhbHVlMSwg UmVmUHRyPENTU1ZhbHVlPiYgdmFsdQogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgdmFs dWUgPSBtX3ZhbHVlTGlzdC0+bmV4dCgpOwotCi0gICAgLy8gRmlyc3QgY2hlY2sgZm9yIHRoZSBj b21tYS4gIElmIHNvLCB3ZSBhcmUgZmluaXNoZWQgcGFyc2luZyB0aGlzIHZhbHVlIG9yIHZhbHVl IHBhaXIuCi0gICAgaWYgKGlzQ29tbWEodmFsdWUpKQotICAgICAgICB2YWx1ZSA9IDA7Ci0KLSAg ICBpZiAodmFsdWUpCi0gICAgICAgIGlkID0gbV92YWx1ZUxpc3QtPmN1cnJlbnQoKS0+aWQ7Cisg ICAgQ1NTUGFyc2VyVmFsdWUqIHZhbHVlID0gbV92YWx1ZUxpc3QtPm5leHQoKTsKIAotICAgIGlm ICh2YWx1ZSAmJiAoaWQgPT0gQ1NTVmFsdWVSZXBlYXQgfHwgaWQgPT0gQ1NTVmFsdWVOb1JlcGVh dCB8fCBpZCA9PSBDU1NWYWx1ZVJvdW5kIHx8IGlkID09IENTU1ZhbHVlU3BhY2UpKSB7Ci0gICAg ICAgIHZhbHVlMiA9IGNzc1ZhbHVlUG9vbCgpLmNyZWF0ZUlkZW50aWZpZXJWYWx1ZShpZCk7Ci0g ICAgICAgIG1fdmFsdWVMaXN0LT5uZXh0KCk7Ci0gICAgfSBlbHNlIHsKLSAgICAgICAgLy8gSWYg b25seSBvbmUgdmFsdWUgd2FzIHNwZWNpZmllZCwgdmFsdWUyIGlzIHRoZSBzYW1lIGFzIHZhbHVl MS4KLSAgICAgICAgbV9pbXBsaWNpdFNob3J0aGFuZCA9IHRydWU7Ci0gICAgICAgIHZhbHVlMiA9 IGNzc1ZhbHVlUG9vbCgpLmNyZWF0ZUlkZW50aWZpZXJWYWx1ZShzdGF0aWNfY2FzdDxDU1NQcmlt aXRpdmVWYWx1ZSo+KHZhbHVlMS5nZXQoKSktPmdldElkZW50KCkpOworICAgIC8vIFBhcnNlIHRo ZSBzZWNvbmQgdmFsdWUgaWYgb25lIGlzIGF2YWlsYWJsZQorICAgIGlmICh2YWx1ZSAmJiAhaXND b21tYSh2YWx1ZSkpIHsKKyAgICAgICAgaWQgPSB2YWx1ZS0+aWQ7CisgICAgICAgIGlmIChpZCA9 PSBDU1NWYWx1ZVJlcGVhdCB8fCBpZCA9PSBDU1NWYWx1ZU5vUmVwZWF0IHx8IGlkID09IENTU1Zh bHVlUm91bmQgfHwgaWQgPT0gQ1NTVmFsdWVTcGFjZSkgeworICAgICAgICAgICAgdmFsdWUyID0g Y3NzVmFsdWVQb29sKCkuY3JlYXRlSWRlbnRpZmllclZhbHVlKGlkKTsKKyAgICAgICAgICAgIG1f dmFsdWVMaXN0LT5uZXh0KCk7CisgICAgICAgIH0KICAgICB9CisKKyAgICAvLyBJZiBvbmx5IG9u ZSB2YWx1ZSB3YXMgc3BlY2lmaWVkLCB2YWx1ZTIgaXMgdGhlIHNhbWUgYXMgdmFsdWUxLgorICAg IG1faW1wbGljaXRTaG9ydGhhbmQgPSB0cnVlOworICAgIHZhbHVlMiA9IGNzc1ZhbHVlUG9vbCgp LmNyZWF0ZUlkZW50aWZpZXJWYWx1ZShzdGF0aWNfY2FzdDxDU1NQcmltaXRpdmVWYWx1ZSo+KHZh bHVlMS5nZXQoKSktPmdldElkZW50KCkpOwogfQogCiBQYXNzUmVmUHRyPENTU1ZhbHVlPiBDU1NQ YXJzZXI6OnBhcnNlRmlsbFNpemUoQ1NTUHJvcGVydHlJRCBwcm9wSWQsIGJvb2wmIGFsbG93Q29t bWEpCg== 136566 2012-04-10 16:14:04 -0700 2012-04-17 15:17:11 -0700 Patch bug-83547-20120411091402.patch text/plain 3024 macpherson U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNzc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGJjMDBlNGYwN2I0NjZi ZmZkOWJmNDUyNDUyYTA0MDhkMjgyNmFkMS4uNzQ4MTdmNjA2OTI2ZDAzZjAyYWMyMTZkNDA5YzUy OGM5M2JiZjhmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA0LTA5ICBMdWtl IE1hY3BoZXJzb24gIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBDbGVhbiB1 cCBDU1NQYXJzZXI6OnBhcnNlRmlsbFJlcGVhdCgpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODM1NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmVkIG11bHRpcGxlIHVubmVjZXNzYXJ5IGNhbGxz IHRvIG1fdmFsdWVMaXN0LT5jdXJyZW50KCkuCisgICAgICAgIFJlc3RydWN0dXJlZCBsb2dpYyBm b3IgcGFyc2luZyBzZWNvbmQgdmFsdWUgdG8gbWFrZSBpdCBjbGVhcmVyLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cyAvIGNvZGUgY2xlYW51cCBvbmx5LgorCisgICAgICAgICogY3NzL0NTU1BhcnNl ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6OnBhcnNlRmlsbFJlcGVhdCk6CisK IDIwMTItMDQtMTAgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCiAgICAgICAg IFJFR1JFU1NJT04ocjExMzU4OCk6IDE1LTMwJSBwZXJmLiByZWdyZXNzaW9uIG9uIENTUy9DU1NQ cm9wZXJ0eVNldHRlckdldHRlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQ YXJzZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKaW5kZXggMTI1ZTQ0 YTM2Mjg0MjM5MGJhZTEyMDAwNTQyMDNiZmQ0YzA2NmM1My4uY2VhNGJlMTU0NGFmNmM4MzA0ZjQ3 ODljNTQ1N2E1NjYyNTEzMzIyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1Bh cnNlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKQEAgLTMyNjgs OCArMzI2OCw2IEBAIHZvaWQgQ1NTUGFyc2VyOjpwYXJzZUZpbGxQb3NpdGlvbihDU1NQYXJzZXJW YWx1ZUxpc3QqIHZhbHVlTGlzdCwgUmVmUHRyPENTU1ZhbHVlCiAKIHZvaWQgQ1NTUGFyc2VyOjpw YXJzZUZpbGxSZXBlYXQoUmVmUHRyPENTU1ZhbHVlPiYgdmFsdWUxLCBSZWZQdHI8Q1NTVmFsdWU+ JiB2YWx1ZTIpCiB7Ci0gICAgQ1NTUGFyc2VyVmFsdWUqIHZhbHVlID0gbV92YWx1ZUxpc3QtPmN1 cnJlbnQoKTsKLQogICAgIGludCBpZCA9IG1fdmFsdWVMaXN0LT5jdXJyZW50KCktPmlkOwogICAg IGlmIChpZCA9PSBDU1NWYWx1ZVJlcGVhdFgpIHsKICAgICAgICAgbV9pbXBsaWNpdFNob3J0aGFu ZCA9IHRydWU7CkBAIC0zMjkyLDIzICszMjkwLDIxIEBAIHZvaWQgQ1NTUGFyc2VyOjpwYXJzZUZp bGxSZXBlYXQoUmVmUHRyPENTU1ZhbHVlPiYgdmFsdWUxLCBSZWZQdHI8Q1NTVmFsdWU+JiB2YWx1 CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICB2YWx1ZSA9IG1fdmFsdWVMaXN0LT5uZXh0 KCk7Ci0KLSAgICAvLyBGaXJzdCBjaGVjayBmb3IgdGhlIGNvbW1hLiAgSWYgc28sIHdlIGFyZSBm aW5pc2hlZCBwYXJzaW5nIHRoaXMgdmFsdWUgb3IgdmFsdWUgcGFpci4KLSAgICBpZiAoaXNDb21t YSh2YWx1ZSkpCi0gICAgICAgIHZhbHVlID0gMDsKLQotICAgIGlmICh2YWx1ZSkKLSAgICAgICAg aWQgPSBtX3ZhbHVlTGlzdC0+Y3VycmVudCgpLT5pZDsKKyAgICBDU1NQYXJzZXJWYWx1ZSogdmFs dWUgPSBtX3ZhbHVlTGlzdC0+bmV4dCgpOwogCi0gICAgaWYgKHZhbHVlICYmIChpZCA9PSBDU1NW YWx1ZVJlcGVhdCB8fCBpZCA9PSBDU1NWYWx1ZU5vUmVwZWF0IHx8IGlkID09IENTU1ZhbHVlUm91 bmQgfHwgaWQgPT0gQ1NTVmFsdWVTcGFjZSkpIHsKLSAgICAgICAgdmFsdWUyID0gY3NzVmFsdWVQ b29sKCkuY3JlYXRlSWRlbnRpZmllclZhbHVlKGlkKTsKLSAgICAgICAgbV92YWx1ZUxpc3QtPm5l eHQoKTsKLSAgICB9IGVsc2UgewotICAgICAgICAvLyBJZiBvbmx5IG9uZSB2YWx1ZSB3YXMgc3Bl Y2lmaWVkLCB2YWx1ZTIgaXMgdGhlIHNhbWUgYXMgdmFsdWUxLgotICAgICAgICBtX2ltcGxpY2l0 U2hvcnRoYW5kID0gdHJ1ZTsKLSAgICAgICAgdmFsdWUyID0gY3NzVmFsdWVQb29sKCkuY3JlYXRl SWRlbnRpZmllclZhbHVlKHN0YXRpY19jYXN0PENTU1ByaW1pdGl2ZVZhbHVlKj4odmFsdWUxLmdl dCgpKS0+Z2V0SWRlbnQoKSk7CisgICAgLy8gUGFyc2UgdGhlIHNlY29uZCB2YWx1ZSBpZiBvbmUg aXMgYXZhaWxhYmxlCisgICAgaWYgKHZhbHVlICYmICFpc0NvbW1hKHZhbHVlKSkgeworICAgICAg ICBpZCA9IHZhbHVlLT5pZDsKKyAgICAgICAgaWYgKGlkID09IENTU1ZhbHVlUmVwZWF0IHx8IGlk ID09IENTU1ZhbHVlTm9SZXBlYXQgfHwgaWQgPT0gQ1NTVmFsdWVSb3VuZCB8fCBpZCA9PSBDU1NW YWx1ZVNwYWNlKSB7CisgICAgICAgICAgICB2YWx1ZTIgPSBjc3NWYWx1ZVBvb2woKS5jcmVhdGVJ ZGVudGlmaWVyVmFsdWUoaWQpOworICAgICAgICAgICAgbV92YWx1ZUxpc3QtPm5leHQoKTsKKyAg ICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQogICAgIH0KKworICAgIC8vIElmIG9ubHkgb25l IHZhbHVlIHdhcyBzcGVjaWZpZWQsIHZhbHVlMiBpcyB0aGUgc2FtZSBhcyB2YWx1ZTEuCisgICAg bV9pbXBsaWNpdFNob3J0aGFuZCA9IHRydWU7CisgICAgdmFsdWUyID0gY3NzVmFsdWVQb29sKCku Y3JlYXRlSWRlbnRpZmllclZhbHVlKHN0YXRpY19jYXN0PENTU1ByaW1pdGl2ZVZhbHVlKj4odmFs dWUxLmdldCgpKS0+Z2V0SWRlbnQoKSk7CiB9CiAKIFBhc3NSZWZQdHI8Q1NTVmFsdWU+IENTU1Bh cnNlcjo6cGFyc2VGaWxsU2l6ZShDU1NQcm9wZXJ0eUlEIHByb3BJZCwgYm9vbCYgYWxsb3dDb21t YSkK