83546 2012-04-09 21:43:12 -0700 Optimize String.split() for 1 character separator 2012-04-11 12:09:40 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin barraclough ggaren oldest_to_newest 598991 0 benjamin 2012-04-09 21:43:12 -0700 First stab at stringProtoFuncSplit(). 598997 1 136394 benjamin 2012-04-09 21:53:55 -0700 Created attachment 136394 Patch 599690 2 136394 barraclough 2012-04-10 15:08:25 -0700 Comment on attachment 136394 Patch Looks good, ooi is this a benchmark progression? 600030 3 benjamin 2012-04-10 22:11:32 -0700 (In reply to comment #2) > Looks good, ooi is this a benchmark progression? Yep, this helps in PeaceKeeper. I have the feeling I will need to improve the memory access to go further than this patch... 600473 4 benjamin 2012-04-11 12:09:40 -0700 Committed r113886: <http://trac.webkit.org/changeset/113886> 136394 2012-04-09 21:53:55 -0700 2012-04-10 15:08:25 -0700 Patch bug-83546-20120409215353.patch text/plain 7233 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNTk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh MjE2NzczMjJmODE4ZmRlZTQ0YmY3NmEwMmQ5YjljM2U4NzBlN2M4Li4wMDE4OTEyZTIwNmI0NDYx N2NjZTcxMzZjOGRjNDc3OTMyNDBlMjFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNyBAQAorMjAxMi0wNC0wOSAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBPcHRpbWl6ZSBTdHJpbmcuc3BsaXQoKSBmb3IgMSBjaGFyYWN0ZXIg c2VwYXJhdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD04MzU0NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRoaXMgcGF0Y2ggYWRkcyBhIHNlcmllIG9mIG9wdGltaXphdGlvbnMgdG8gbWFrZSBzdHJpbmdQ cm90b0Z1bmNTcGxpdCgpIGZhc3RlciBpbiB0aGUgY29tbW9uIGNhc2UKKyAgICAgICAgd2hlcmUg dGhlIHNlcGFyYXRvciBpcyBhIHNpbmdsZSBjaGFyYWN0ZXIuCisKKyAgICAgICAgVGhlIHR3byBt YWluIGdhaW5zIGFyZToKKyAgICAgICAgLVVzZSBvZiB0aGUgZmluZCgpIGZ1bmN0aW9uIHdpdGgg YSBzaW5nbGUgY2hhcmFjdGVyIGluc3RlYWQgb2YgZG9pbmcgYSBmdWxsIHN0cmluZyBtYXRjaGlu Zy4KKyAgICAgICAgLVVzZSBvZiBXVEY6OmZpbmQoKSBpbnN0ZWFkIG9mIFVTdHJpbmc6OmZpbmQo KSB0byBhdm9pZCBicmFuY2hpbmcgb24gaXM4Qml0KCkgYW5kIGhhdmUgYSBzaW1wbGVyIGlubGlu ZQorICAgICAgICAgZnVuY3Rpb24uCisKKyAgICAgICAgVGhlIGNvZGUgaXMgYWxzbyBjaGFuZ2Vk IHRvIGF2b2lkIG1ha2luZyB1bm5lY2Vzc2FyeSBhbGxvY2F0aW9ucyBieSBjb252ZXJ0aW5nIHRo ZSA4Yml0IHN0cmluZyB0byAxNmJpdHMuCisKKyAgICAgICAgVGhpcyBtYWtlcyBTdHJpbmcuc3Bs aXQoKSBmYXN0ZXIgYnkgYWJvdXQgMTMlIGluIHRoYXQgcGFydGljdWxhciBjYXNlLgorCisgICAg ICAgICogcnVudGltZS9TdHJpbmdQcm90b3R5cGUuY3BwOgorICAgICAgICAoSlNDKToKKyAgICAg ICAgKEpTQzo6c3BsaXRTdHJpbmdCeU9uZUNoYXJhY3RlckltcGwpOgorICAgICAgICAoSlNDOjpz dHJpbmdQcm90b0Z1bmNTcGxpdCk6CisKIDIwMTItMDQtMDkgIFBhdHJpY2sgR2Fuc3RlcmVyICA8 cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVtb3ZlIEhBVkVfU1RESU5UX0gKZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHAg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJpbmdQcm90b3R5cGUuY3BwCmluZGV4 IGI4NGEwZTQ1NWU0ZjNhYjczYTRiMzA5OWFmMWFlNjhiMjcxNWZjODIuLmViYmI3NDhlMmFjYjk3 YmQzMzU5NjE1MzRlYjU3ZDJjZTAwMzM0ODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNwcApAQCAtOTEwLDYgKzkxMCwzNSBAQCBFbmNv ZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIHN0cmluZ1Byb3RvRnVuY1NsaWNlKEV4ZWNTdGF0ZSog ZXhlYykKICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzRW1wdHlTdHJpbmcoZXhlYykpOwog fQogCisvLyBSZXR1cm4gdHJ1ZSBpbiBjYXNlIG9mIGVhcmx5IHJldHVybiAocmVzdWx0TGVuZ3Ro IGdvdCB0byBsaW1pdExlbmd0aCkuCit0ZW1wbGF0ZTx0eXBlbmFtZSBDaGFyYWN0ZXJUeXBlPgor c3RhdGljIEFMV0FZU19JTkxJTkUgYm9vbCBzcGxpdFN0cmluZ0J5T25lQ2hhcmFjdGVySW1wbChF eGVjU3RhdGUqIGV4ZWMsIEpTQXJyYXkqIHJlc3VsdCwgY29uc3QgVVN0cmluZyYgaW5wdXQsIFN0 cmluZ0ltcGwqIHN0cmluZywgVUNoYXIgc2VwYXJhdG9yQ2hhcmFjdGVyLCBzaXplX3QmIHBvc2l0 aW9uLCB1bnNpZ25lZCYgcmVzdWx0TGVuZ3RoLCB1bnNpZ25lZCBsaW1pdExlbmd0aCkKK3sKKyAg ICAvLyAxMi4gTGV0IHEgPSBwLgorICAgIHNpemVfdCBtYXRjaFBvc2l0aW9uOworICAgIGNvbnN0 IENoYXJhY3RlclR5cGUqIGNoYXJhY3RlcnMgPSBzdHJpbmctPmdldENoYXJhY3RlcnM8Q2hhcmFj dGVyVHlwZT4oKTsKKyAgICAvLyAxMy4gUmVwZWF0LCB3aGlsZSBxICE9IHMKKyAgICAvLyAgIGEu IENhbGwgU3BsaXRNYXRjaChTLCBxLCBSKSBhbmQgbGV0IHogYmUgaXRzIE1hdGNoUmVzdWx0IHJl c3VsdC4KKyAgICAvLyAgIGIuIElmIHogaXMgZmFpbHVyZSwgdGhlbiBsZXQgcSA9IHErMS4KKyAg ICAvLyAgIGMuIEVsc2UsIHogaXMgbm90IGZhaWx1cmUKKyAgICB3aGlsZSAoKG1hdGNoUG9zaXRp b24gPSBXVEY6OmZpbmQoY2hhcmFjdGVycywgc3RyaW5nLT5sZW5ndGgoKSwgc2VwYXJhdG9yQ2hh cmFjdGVyLCBwb3NpdGlvbikpICE9IG5vdEZvdW5kKSB7CisgICAgICAgIC8vIDEuIExldCBUIGJl IGEgU3RyaW5nIHZhbHVlIGVxdWFsIHRvIHRoZSBzdWJzdHJpbmcgb2YgUyBjb25zaXN0aW5nIG9m IHRoZSBjaGFyYWN0ZXJzIGF0IHBvc2l0aW9ucyBwIChpbmNsdXNpdmUpCisgICAgICAgIC8vICAg IHRocm91Z2ggcSAoZXhjbHVzaXZlKS4KKyAgICAgICAgLy8gMi4gQ2FsbCB0aGUgW1tEZWZpbmVP d25Qcm9wZXJ0eV1dIGludGVybmFsIG1ldGhvZCBvZiBBIHdpdGggYXJndW1lbnRzIFRvU3RyaW5n KGxlbmd0aEEpLAorICAgICAgICAvLyAgICBQcm9wZXJ0eSBEZXNjcmlwdG9yIHtbW1ZhbHVlXV06 IFQsIFtbV3JpdGFibGVdXTogdHJ1ZSwgW1tFbnVtZXJhYmxlXV06IHRydWUsIFtbQ29uZmlndXJh YmxlXV06IHRydWV9LCBhbmQgZmFsc2UuCisgICAgICAgIHJlc3VsdC0+cHV0RGlyZWN0SW5kZXgo ZXhlYywgcmVzdWx0TGVuZ3RoLCBqc1N1YnN0cmluZyhleGVjLCBpbnB1dCwgcG9zaXRpb24sIG1h dGNoUG9zaXRpb24gLSBwb3NpdGlvbiksIGZhbHNlKTsKKyAgICAgICAgLy8gMy4gSW5jcmVtZW50 IGxlbmd0aEEgYnkgMS4KKyAgICAgICAgLy8gNC4gSWYgbGVuZ3RoQSA9PSBsaW0sIHJldHVybiBB LgorICAgICAgICBpZiAoKytyZXN1bHRMZW5ndGggPT0gbGltaXRMZW5ndGgpCisgICAgICAgICAg ICByZXR1cm4gdHJ1ZTsKKworICAgICAgICAvLyA1LiBMZXQgcCA9IGUuCisgICAgICAgIC8vIDgu IExldCBxID0gcC4KKyAgICAgICAgcG9zaXRpb24gPSBtYXRjaFBvc2l0aW9uICsgMTsKKyAgICB9 CisgICAgcmV0dXJuIGZhbHNlOworfQorCiAvLyBFUyA1LjEgLSAxNS41LjQuMTQgU3RyaW5nLnBy b3RvdHlwZS5zcGxpdCAoc2VwYXJhdG9yLCBsaW1pdCkKIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NU X0NBTEwgc3RyaW5nUHJvdG9GdW5jU3BsaXQoRXhlY1N0YXRlKiBleGVjKQogewpAQCAtMTA2Mywy NiArMTA5Miw1MCBAQCBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIHN0cmluZ1Byb3RvRnVu Y1NwbGl0KEV4ZWNTdGF0ZSogZXhlYykKICAgICAgICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNv ZGUocmVzdWx0KTsKICAgICAgICAgfQogCi0gICAgICAgIC8vIDEyLiBMZXQgcSA9IHAuCi0gICAg ICAgIHNpemVfdCBtYXRjaFBvc2l0aW9uOwotICAgICAgICAvLyAxMy4gUmVwZWF0LCB3aGlsZSBx ICE9IHMKLSAgICAgICAgLy8gICBhLiBDYWxsIFNwbGl0TWF0Y2goUywgcSwgUikgYW5kIGxldCB6 IGJlIGl0cyBNYXRjaFJlc3VsdCByZXN1bHQuCi0gICAgICAgIC8vICAgYi4gSWYgeiBpcyBmYWls dXJlLCB0aGVuIGxldCBxID0gcSsxLgotICAgICAgICAvLyAgIGMuIEVsc2UsIHogaXMgbm90IGZh aWx1cmUKLSAgICAgICAgd2hpbGUgKChtYXRjaFBvc2l0aW9uID0gaW5wdXQuZmluZChzZXBhcmF0 b3IsIHBvc2l0aW9uKSkgIT0gbm90Rm91bmQpIHsKLSAgICAgICAgICAgIC8vIDEuIExldCBUIGJl IGEgU3RyaW5nIHZhbHVlIGVxdWFsIHRvIHRoZSBzdWJzdHJpbmcgb2YgUyBjb25zaXN0aW5nIG9m IHRoZSBjaGFyYWN0ZXJzIGF0IHBvc2l0aW9ucyBwIChpbmNsdXNpdmUpCi0gICAgICAgICAgICAv LyAgICB0aHJvdWdoIHEgKGV4Y2x1c2l2ZSkuCi0gICAgICAgICAgICAvLyAyLiBDYWxsIHRoZSBb W0RlZmluZU93blByb3BlcnR5XV0gaW50ZXJuYWwgbWV0aG9kIG9mIEEgd2l0aCBhcmd1bWVudHMg VG9TdHJpbmcobGVuZ3RoQSksCi0gICAgICAgICAgICAvLyAgICBQcm9wZXJ0eSBEZXNjcmlwdG9y IHtbW1ZhbHVlXV06IFQsIFtbV3JpdGFibGVdXTogdHJ1ZSwgW1tFbnVtZXJhYmxlXV06IHRydWUs IFtbQ29uZmlndXJhYmxlXV06IHRydWV9LCBhbmQgZmFsc2UuCi0gICAgICAgICAgICByZXN1bHQt PnB1dERpcmVjdEluZGV4KGV4ZWMsIHJlc3VsdExlbmd0aCwganNTdWJzdHJpbmcoZXhlYywgaW5w dXQsIHBvc2l0aW9uLCBtYXRjaFBvc2l0aW9uIC0gcG9zaXRpb24pLCBmYWxzZSk7Ci0gICAgICAg ICAgICAvLyAzLiBJbmNyZW1lbnQgbGVuZ3RoQSBieSAxLgotICAgICAgICAgICAgLy8gNC4gSWYg bGVuZ3RoQSA9PSBsaW0sIHJldHVybiBBLgotICAgICAgICAgICAgaWYgKCsrcmVzdWx0TGVuZ3Ro ID09IGxpbWl0KQotICAgICAgICAgICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUocmVzdWx0 KTsKKyAgICAgICAgLy8gMyBjYXNlczoKKyAgICAgICAgLy8gLXNlcGFyYXRvciBsZW5ndGggPT0g MSwgOCBiaXRzCisgICAgICAgIC8vIC1zZXBhcmF0b3IgbGVuZ3RoID09IDEsIDE2IGJpdHMKKyAg ICAgICAgLy8gLXNlcGFyYXRvciBsZW5ndGggPiAxCisgICAgICAgIFN0cmluZ0ltcGwqIHN0cmlu Z0ltcGwgPSBpbnB1dC5pbXBsKCk7CisgICAgICAgIFN0cmluZ0ltcGwqIHNlcGFyYXRvckltcGwg PSBzZXBhcmF0b3IuaW1wbCgpOworICAgICAgICBzaXplX3Qgc2VwYXJhdG9yTGVuZ3RoID0gc2Vw YXJhdG9ySW1wbC0+bGVuZ3RoKCk7CiAKLSAgICAgICAgICAgIC8vIDUuIExldCBwID0gZS4KLSAg ICAgICAgICAgIC8vIDguIExldCBxID0gcC4KLSAgICAgICAgICAgIHBvc2l0aW9uID0gbWF0Y2hQ b3NpdGlvbiArIHNlcGFyYXRvci5sZW5ndGgoKTsKKyAgICAgICAgaWYgKHNlcGFyYXRvckxlbmd0 aCA9PSAxKSB7CisgICAgICAgICAgICBVQ2hhciBzZXBhcmF0b3JDaGFyYWN0ZXI7CisgICAgICAg ICAgICBpZiAoc2VwYXJhdG9ySW1wbC0+aXM4Qml0KCkpCisgICAgICAgICAgICAgICAgc2VwYXJh dG9yQ2hhcmFjdGVyID0gc2VwYXJhdG9ySW1wbC0+Y2hhcmFjdGVyczgoKVswXTsKKyAgICAgICAg ICAgIGVsc2UKKyAgICAgICAgICAgICAgICBzZXBhcmF0b3JDaGFyYWN0ZXIgPSBzZXBhcmF0b3JJ bXBsLT5jaGFyYWN0ZXJzMTYoKVswXTsKKworICAgICAgICAgICAgaWYgKHN0cmluZ0ltcGwtPmlz OEJpdCgpKSB7CisgICAgICAgICAgICAgICAgaWYgKHNwbGl0U3RyaW5nQnlPbmVDaGFyYWN0ZXJJ bXBsPExDaGFyPihleGVjLCByZXN1bHQsIGlucHV0LCBzdHJpbmdJbXBsLCBzZXBhcmF0b3JDaGFy YWN0ZXIsIHBvc2l0aW9uLCByZXN1bHRMZW5ndGgsIGxpbWl0KSkKKyAgICAgICAgICAgICAgICAg ICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShyZXN1bHQpOworICAgICAgICAgICAgfSBlbHNlIHsK KyAgICAgICAgICAgICAgICBpZiAoc3BsaXRTdHJpbmdCeU9uZUNoYXJhY3RlckltcGw8VUNoYXI+ KGV4ZWMsIHJlc3VsdCwgaW5wdXQsIHN0cmluZ0ltcGwsIHNlcGFyYXRvckNoYXJhY3RlciwgcG9z aXRpb24sIHJlc3VsdExlbmd0aCwgbGltaXQpKQorICAgICAgICAgICAgICAgICAgICByZXR1cm4g SlNWYWx1ZTo6ZW5jb2RlKHJlc3VsdCk7CisgICAgICAgICAgICB9CisgICAgICAgIH0gZWxzZSB7 CisgICAgICAgICAgICAvLyAxMi4gTGV0IHEgPSBwLgorICAgICAgICAgICAgc2l6ZV90IG1hdGNo UG9zaXRpb247CisgICAgICAgICAgICAvLyAxMy4gUmVwZWF0LCB3aGlsZSBxICE9IHMKKyAgICAg ICAgICAgIC8vICAgYS4gQ2FsbCBTcGxpdE1hdGNoKFMsIHEsIFIpIGFuZCBsZXQgeiBiZSBpdHMg TWF0Y2hSZXN1bHQgcmVzdWx0LgorICAgICAgICAgICAgLy8gICBiLiBJZiB6IGlzIGZhaWx1cmUs IHRoZW4gbGV0IHEgPSBxKzEuCisgICAgICAgICAgICAvLyAgIGMuIEVsc2UsIHogaXMgbm90IGZh aWx1cmUKKyAgICAgICAgICAgIHdoaWxlICgobWF0Y2hQb3NpdGlvbiA9IHN0cmluZ0ltcGwtPmZp bmQoc2VwYXJhdG9ySW1wbCwgcG9zaXRpb24pKSAhPSBub3RGb3VuZCkgeworICAgICAgICAgICAg ICAgIC8vIDEuIExldCBUIGJlIGEgU3RyaW5nIHZhbHVlIGVxdWFsIHRvIHRoZSBzdWJzdHJpbmcg b2YgUyBjb25zaXN0aW5nIG9mIHRoZSBjaGFyYWN0ZXJzIGF0IHBvc2l0aW9ucyBwIChpbmNsdXNp dmUpCisgICAgICAgICAgICAgICAgLy8gICAgdGhyb3VnaCBxIChleGNsdXNpdmUpLgorICAgICAg ICAgICAgICAgIC8vIDIuIENhbGwgdGhlIFtbRGVmaW5lT3duUHJvcGVydHldXSBpbnRlcm5hbCBt ZXRob2Qgb2YgQSB3aXRoIGFyZ3VtZW50cyBUb1N0cmluZyhsZW5ndGhBKSwKKyAgICAgICAgICAg ICAgICAvLyAgICBQcm9wZXJ0eSBEZXNjcmlwdG9yIHtbW1ZhbHVlXV06IFQsIFtbV3JpdGFibGVd XTogdHJ1ZSwgW1tFbnVtZXJhYmxlXV06IHRydWUsIFtbQ29uZmlndXJhYmxlXV06IHRydWV9LCBh bmQgZmFsc2UuCisgICAgICAgICAgICAgICAgcmVzdWx0LT5wdXREaXJlY3RJbmRleChleGVjLCBy ZXN1bHRMZW5ndGgsIGpzU3Vic3RyaW5nKGV4ZWMsIGlucHV0LCBwb3NpdGlvbiwgbWF0Y2hQb3Np dGlvbiAtIHBvc2l0aW9uKSwgZmFsc2UpOworICAgICAgICAgICAgICAgIC8vIDMuIEluY3JlbWVu dCBsZW5ndGhBIGJ5IDEuCisgICAgICAgICAgICAgICAgLy8gNC4gSWYgbGVuZ3RoQSA9PSBsaW0s IHJldHVybiBBLgorICAgICAgICAgICAgICAgIGlmICgrK3Jlc3VsdExlbmd0aCA9PSBsaW1pdCkK KyAgICAgICAgICAgICAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShyZXN1bHQpOworCisg ICAgICAgICAgICAgICAgLy8gNS4gTGV0IHAgPSBlLgorICAgICAgICAgICAgICAgIC8vIDguIExl dCBxID0gcC4KKyAgICAgICAgICAgICAgICBwb3NpdGlvbiA9IG1hdGNoUG9zaXRpb24gKyBzZXBh cmF0b3IubGVuZ3RoKCk7CisgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICB9CiAK