83534 2012-04-09 18:38:28 -0700 If a callback function returns a C++ null, convert to undefined. 2012-04-09 18:41:41 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 barraclough barraclough oldest_to_newest 598846 0 barraclough 2012-04-09 18:38:28 -0700 Previously we didn't check for NULL return values here, recently we hardened the API to throw an error, but this is too restrictive for some clients. Instead just promote to a JS undefined. 598847 1 136364 barraclough 2012-04-09 18:39:12 -0700 Created attachment 136364 Fix 598849 2 136364 ggaren 2012-04-09 18:40:13 -0700 Comment on attachment 136364 Fix r=me 598852 3 barraclough 2012-04-09 18:41:41 -0700 Fixed in r113654 136364 2012-04-09 18:39:12 -0700 2012-04-09 18:40:13 -0700 Fix 83534.patch text/plain 3093 barraclough SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTEzNjUzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDEyLTA0LTA5ICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4K KworICAgICAgICBJZiBhIGNhbGxiYWNrIGZ1bmN0aW9uIHJldHVybnMgYSBDKysgbnVsbCwgY29u dmVydCB0byB1bmRlZmluZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04MzUzNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogQVBJL0pTQ2FsbGJhY2tGdW5jdGlvbi5jcHA6CisgICAgICAgICAgICAtIElm IGEgY2FsbGJhY2sgZnVuY3Rpb24gcmV0dXJucyBhIEMrKyBudWxsLCBjb252ZXJ0IHRvIHVuZGVm aW5lZC4KKyAgICAgICAgKEpTQzo6SlNDYWxsYmFja0Z1bmN0aW9uOjpjYWxsKToKKyAgICAgICAg KiBBUEkvdGVzdHMvdGVzdGFwaS5jOgorICAgICAgICAoQmFzZV9yZXR1cm5IYXJkTnVsbCk6Cisg ICAgICAgICogQVBJL3Rlc3RzL3Rlc3RhcGkuanM6CisgICAgICAgICAgICAtIEFkZCBhIHRlc3Qg Y2FzZSBmb3IgY2FsbGJhY2sgZnVuY3Rpb25zIHRoYXQgcmV0dXJuIGEgQysrIG51bGwuCisKIDIw MTItMDQtMDkgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBDbGFz c2ljIGludGVycHJldGVyJ3MgR0MgaG9va3Mgc2hvdWxkbid0IGF0dGVtcHQgdG8gc2NhbiBpbnN0 cnVjdGlvbnMgZm9yIGNvZGUgYmxvY2tzIHRoYXQKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9BUEkvSlNDYWxsYmFja0Z1bmN0aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvQVBJL0pTQ2FsbGJhY2tGdW5jdGlvbi5jcHAJKHJldmlzaW9uIDExMzYyNCkKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNDYWxsYmFja0Z1bmN0aW9uLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNzcsNyArNzcsNyBAQCBFbmNvZGVkSlNWYWx1ZSBKU0NhbGxiYWNrRnVuY3Rp b246OmNhbGwoCiAKICAgICAvLyByZXN1bHQgbXVzdCBiZSBhIHZhbGlkIEpTVmFsdWUuCiAgICAg aWYgKCFyZXN1bHQpCi0gICAgICAgIHJldHVybiB0aHJvd1ZNVHlwZUVycm9yKGV4ZWMpOworICAg ICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzVW5kZWZpbmVkKCkpOwogCiAgICAgcmV0dXJu IEpTVmFsdWU6OmVuY29kZSh0b0pTKGV4ZWMsIHJlc3VsdCkpOwogfQpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL0FQSS90ZXN0cy90ZXN0YXBpLmMKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL0FQSS90ZXN0cy90ZXN0YXBpLmMJKHJldmlzaW9uIDExMzYyNCkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvdGVzdHMvdGVzdGFwaS5jCSh3b3JraW5nIGNvcHkpCkBA IC02NzgsOSArNjc4LDIyIEBAIHN0YXRpYyBKU1ZhbHVlUmVmIEJhc2VfY2FsbEFzRnVuY3Rpb24o SlMKICAgICByZXR1cm4gSlNWYWx1ZU1ha2VOdW1iZXIoY3R4LCAxKTsgLy8gZGlzdGluZ3Vpc2gg YmFzZSBjYWxsIGZyb20gZGVyaXZlZCBjYWxsCiB9CiAKK3N0YXRpYyBKU1ZhbHVlUmVmIEJhc2Vf cmV0dXJuSGFyZE51bGwoSlNDb250ZXh0UmVmIGN0eCwgSlNPYmplY3RSZWYgZnVuY3Rpb24sIEpT T2JqZWN0UmVmIHRoaXNPYmplY3QsIHNpemVfdCBhcmd1bWVudENvdW50LCBjb25zdCBKU1ZhbHVl UmVmIGFyZ3VtZW50c1tdLCBKU1ZhbHVlUmVmKiBleGNlcHRpb24pCit7CisgICAgVU5VU0VEX1BB UkFNKGN0eCk7CisgICAgVU5VU0VEX1BBUkFNKGZ1bmN0aW9uKTsKKyAgICBVTlVTRURfUEFSQU0o dGhpc09iamVjdCk7CisgICAgVU5VU0VEX1BBUkFNKGFyZ3VtZW50Q291bnQpOworICAgIFVOVVNF RF9QQVJBTShhcmd1bWVudHMpOworICAgIFVOVVNFRF9QQVJBTShleGNlcHRpb24pOworICAgIAor ICAgIHJldHVybiAwOyAvLyBzaG91bGQgY29udmVydCB0byB1bmRlZmluZWQhCit9CisKIHN0YXRp YyBKU1N0YXRpY0Z1bmN0aW9uIEJhc2Vfc3RhdGljRnVuY3Rpb25zW10gPSB7CiAgICAgeyAiYmFz ZVByb3RvRHVwIiwgTlVMTCwga0pTUHJvcGVydHlBdHRyaWJ1dGVOb25lIH0sCiAgICAgeyAiYmFz ZVByb3RvIiwgQmFzZV9jYWxsQXNGdW5jdGlvbiwga0pTUHJvcGVydHlBdHRyaWJ1dGVOb25lIH0s CisgICAgeyAiYmFzZUhhcmROdWxsIiwgQmFzZV9yZXR1cm5IYXJkTnVsbCwga0pTUHJvcGVydHlB dHRyaWJ1dGVOb25lIH0sCiAgICAgeyAwLCAwLCAwIH0KIH07CiAKSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9BUEkvdGVzdHMvdGVzdGFwaS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvQVBJL3Rlc3RzL3Rlc3RhcGkuanMJKHJldmlzaW9uIDExMzYyNCkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvdGVzdHMvdGVzdGFwaS5qcwkod29ya2luZyBjb3B5KQpA QCAtMTg2LDYgKzE4Niw4IEBAIHNob3VsZEJlKCJkZXJpdmVkLnByb3RvT25seSgpIiwgMik7CiBz aG91bGRCZSgiZGVyaXZlZC5wcm90b0R1cCIsIDIpOwogc2hvdWxkQmUoImRlcml2ZWQuZGVyaXZl ZE9ubHkiLCAyKQogCitzaG91bGRCZSgiZGVyaXZlZC5iYXNlSGFyZE51bGwoKSIsIHVuZGVmaW5l ZCkKKwogLy8gYmFzZSBwcm9wZXJ0aWVzIHRocm93IDEgd2hlbiBzZXQ7IGRlcml2ZWQsIDIKIHNo b3VsZEJlKCJkZXJpdmVkLmJhc2VEdXAgPSAwIiwgMik7CiBzaG91bGRCZSgiZGVyaXZlZC5iYXNl T25seSA9IDAiLCAxKTsK