83532 2012-04-09 18:12:47 -0700 run-perf-tests fail intermittently with an exception 2012-04-23 16:13:30 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77037 1 rniwa dpranke abarth bdakin dpranke ojan simon.fraser webkit.review.bot oldest_to_newest 598827 0 rniwa 2012-04-09 18:12:47 -0700 Lion Release (Perf) fails intermittently with the following error: http://build.webkit.org/builders/Lion%20Release%20%28Perf%29/builds/2080/steps/perf-test/logs/stdio Traceback (most recent call last): File "./Tools/Scripts/run-perf-tests", line 41, in <module> sys.exit(PerfTestsRunner().run()) File "/Volumes/Data/slave/lion-release-perf-tests/build/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py", line 141, in run unexpected = self._run_tests_set(sorted(list(tests)), self._port) File "/Volumes/Data/slave/lion-release-perf-tests/build/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py", line 234, in _run_tests_set if self._run_single_test(test, driver, is_chromium_style): File "/Volumes/Data/slave/lion-release-perf-tests/build/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py", line 317, in _run_single_test output = driver.run_test(DriverInput(test, self._options.time_out_ms, None, False)) File "/Volumes/Data/slave/lion-release-perf-tests/build/Tools/Scripts/webkitpy/layout_tests/port/driver.py", line 219, in run_test return self._running_drivers[cmd_line_key].run_test(driver_input) File "/Volumes/Data/slave/lion-release-perf-tests/build/Tools/Scripts/webkitpy/layout_tests/port/webkit.py", line 571, in run_test crash_log = self._port._get_crash_log(self._crashed_process_name, self._crashed_pid, text, self.error_from_test) File "/Volumes/Data/slave/lion-release-perf-tests/build/Tools/Scripts/webkitpy/layout_tests/port/mac.py", line 188, in _get_crash_log deadline = now + 5 * int(self.get_option('child_processes')) TypeError: int() argument must be a string or a number, not 'NoneType' program finished with exit code 1 elapsedTime=1367.658724 Maybe this is related to mac ports' tests intermittently fail? 598831 1 dpranke 2012-04-09 18:19:34 -0700 i think this is probably an unrelated bug; I'm guessing it happens every time you get a crash, but you probably don't see crashes very often in the perf tests? 598840 2 rniwa 2012-04-09 18:28:04 -0700 (In reply to comment #1) > i think this is probably an unrelated bug; I'm guessing it happens every time you get a crash, but you probably don't see crashes very often in the perf tests? Right, we rarely add new perf tests and they aren't supposed to crash. In fact, perf bots turn red if any one of them crash. 608065 3 138433 dpranke 2012-04-23 15:17:09 -0700 Created attachment 138433 Patch 608123 4 138433 rniwa 2012-04-23 15:48:54 -0700 Comment on attachment 138433 Patch rs=me. 608155 5 dpranke 2012-04-23 16:13:30 -0700 Committed r114960: <http://trac.webkit.org/changeset/114960> 138433 2012-04-23 15:17:09 -0700 2012-04-23 15:48:53 -0700 Patch bug-83532-20120423151708.patch text/plain 3817 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0OTM3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzlmZWY5ODIxNjAyM2U2NjE5ODQzNzdjOWVjZmU5ZGFl ZGQxMzkzNS4uNmY1YTM1ODViNDY1MzE2Yzk2ZjQ0NGVlOGNmYmE0OTZlY2NkMjdkOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIx IEBACiAyMDEyLTA0LTIzICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIHJ1bi1wZXJmLXRlc3RzIGZhaWwgaW50ZXJtaXR0ZW50bHkgd2l0aCBhbiBleGNlcHRp b24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzNTMy CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBi dWxsZXRwcm9vZnMgcG9ydC5nZXRfb3B0aW9uKCdjaGlsZF9wcm9jZXNzZXMnKQorICAgICAgICBh Z2FpbnN0IHRoZSBjYXNlIHdoZXJlIHRoZSBvcHRpb24gd2Fzbid0IHNldC4KKworICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvbWFjLnB5OgorICAgICAgICAoTWFj UG9ydC5fZ2V0X2NyYXNoX2xvZyk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC9tYWNfdW5pdHRlc3QucHk6CisgICAgICAgICh0ZXN0X2dldF9jcmFzaF9sb2cp OgorICAgICAgICAodGVzdF9nZXRfY3Jhc2hfbG9nLmZha2VfdGltZV9jYik6CisKKzIwMTItMDQt MjMgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgdGVzdC13 ZWJraXRweSBpcyBmYWlsaW5nCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04NDYxNwogCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9wb3J0L21hYy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3BvcnQvbWFjLnB5CmluZGV4IGMwYWNkMjc3N2E2MTM5ODhhMzk1NGJjYjE3NzJkZjliNDE1 ZjBmNTcuLmE2MTE0NThlZGI3MTcyNzQ3ZGM2MzViMDAxZTJiZjRmOGNhMTY1N2YgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvbWFjLnB5CisrKyBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvbWFjLnB5CkBAIC0xNzUs MjIgKzE3NSwyNCBAQCBjbGFzcyBNYWNQb3J0KEFwcGxlUG9ydCk6CiAgICAgZGVmIHJlbGVhc2Vf aHR0cF9sb2NrKHNlbGYpOgogICAgICAgICBwYXNzCiAKLSAgICBkZWYgX2dldF9jcmFzaF9sb2co c2VsZiwgbmFtZSwgcGlkLCBzdGRvdXQsIHN0ZGVyciwgbmV3ZXJfdGhhbik6CisgICAgZGVmIF9n ZXRfY3Jhc2hfbG9nKHNlbGYsIG5hbWUsIHBpZCwgc3Rkb3V0LCBzdGRlcnIsIG5ld2VyX3RoYW4s IHRpbWVfZm49Tm9uZSwgc2xlZXBfZm49Tm9uZSk6CiAgICAgICAgICMgTm90ZSB0aGF0IHdlIGRv IHNsb3ctc3BpbiBoZXJlIGFuZCB3YWl0LCBzaW5jZSBpdCBhcHBlYXJzIHRoZSB0aW1lCiAgICAg ICAgICMgUmVwb3J0Q3Jhc2ggdGFrZXMgdG8gYWN0dWFsbHkgd3JpdGUgYW5kIGZsdXNoIHRoZSBm aWxlIHZhcmllcyB3aGVuIHRoZXJlIGFyZQogICAgICAgICAjIGxvdHMgb2Ygc2ltdWx0YW5lb3Vz IGNyYXNoZXMgZ29pbmcgb24uCiAgICAgICAgICMgRklYTUU6IFNob3VsZCBtb3N0IG9mIHRoaXMg YmUgbW92ZWQgaW50byBDcmFzaExvZ3MoKT8KKyAgICAgICAgdGltZV9mbiA9IHRpbWVfZm4gb3Ig dGltZS50aW1lCisgICAgICAgIHNsZWVwX2ZuID0gc2xlZXBfZm4gb3IgdGltZS5zbGVlcAogICAg ICAgICBjcmFzaF9sb2cgPSAnJwogICAgICAgICBjcmFzaF9sb2dzID0gQ3Jhc2hMb2dzKHNlbGYu X2ZpbGVzeXN0ZW0pCi0gICAgICAgIG5vdyA9IHRpbWUudGltZSgpCisgICAgICAgIG5vdyA9IHRp bWVfZm4oKQogICAgICAgICAjIEZJWE1FOiBkZWxldGUgdGhpcyBhZnRlciB3ZSdyZSBzdXJlIHRo aXMgY29kZSBpcyB3b3JraW5nIC4uLgogICAgICAgICBfbG9nLmRlYnVnKCdsb29raW5nIGZvciBj cmFzaCBsb2cgZm9yICVzOiVzJyAlIChuYW1lLCBzdHIocGlkKSkpCi0gICAgICAgIGRlYWRsaW5l ID0gbm93ICsgNSAqIGludChzZWxmLmdldF9vcHRpb24oJ2NoaWxkX3Byb2Nlc3NlcycpKQorICAg ICAgICBkZWFkbGluZSA9IG5vdyArIDUgKiBpbnQoc2VsZi5nZXRfb3B0aW9uKCdjaGlsZF9wcm9j ZXNzZXMnLCAxKSkKICAgICAgICAgd2hpbGUgbm90IGNyYXNoX2xvZyBhbmQgbm93IDw9IGRlYWRs aW5lOgogICAgICAgICAgICAgY3Jhc2hfbG9nID0gY3Jhc2hfbG9ncy5maW5kX25ld2VzdF9sb2co bmFtZSwgcGlkLCBpbmNsdWRlX2Vycm9ycz1UcnVlLCBuZXdlcl90aGFuPW5ld2VyX3RoYW4pCiAg ICAgICAgICAgICBpZiBub3QgY3Jhc2hfbG9nIG9yIG5vdCBbbGluZSBmb3IgbGluZSBpbiBjcmFz aF9sb2cuc3BsaXRsaW5lcygpIGlmIG5vdCBsaW5lLnN0YXJ0c3dpdGgoJ0VSUk9SJyldOgotICAg ICAgICAgICAgICAgIHRpbWUuc2xlZXAoMC4xKQotICAgICAgICAgICAgICAgIG5vdyA9IHRpbWUu dGltZSgpCisgICAgICAgICAgICAgICAgc2xlZXBfZm4oMC4xKQorICAgICAgICAgICAgICAgIG5v dyA9IHRpbWVfZm4oKQogICAgICAgICBpZiBub3QgY3Jhc2hfbG9nOgogICAgICAgICAgICAgY3Jh c2hfbG9nID0gJ25vIGNyYXNoIGxvZyBmb3VuZCBmb3IgJXM6JWQnICUgKG5hbWUsIHBpZCkKICAg ICAgICAgICAgIF9sb2cud2FybmluZyhjcmFzaF9sb2cpCmRpZmYgLS1naXQgYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L21hY191bml0dGVzdC5weSBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvbWFjX3VuaXR0ZXN0LnB5CmluZGV4IDIx MWZiYzk5MTAwZDI3ZGYxMDEyOGE1YmE0ZGU0MTEyNDI3ZGM1MmIuLmFlMmVlZTUyZTUzNWE4Mjk4 NmU0ZDcwN2Y3YmRhZjE4OTkxYmI5NDkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3BvcnQvbWFjX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvbWFjX3VuaXR0ZXN0LnB5CkBAIC0xOTAsOCArMTkw LDEzIEBAIGphdmEvCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoY2hpbGRfcHJvY2Vzc2VzLCAx KQogCiAgICAgZGVmIHRlc3RfZ2V0X2NyYXNoX2xvZyhzZWxmKToKLSAgICAgICAgIyBNYWMgY3Jh c2ggbG9ncyBhcmUgdGVzdGVkIGVsc2V3aGVyZQotICAgICAgICBwYXNzCisgICAgICAgICMgTWFj IGNyYXNoIGxvZ3MgYXJlIHRlc3RlZCBlbHNld2hlcmUsIHNvIGhlcmUgd2UganVzdCBtYWtlIHN1 cmUgd2UgZG9uJ3QgY3Jhc2guCisgICAgICAgIGRlZiBmYWtlX3RpbWVfY2IoKToKKyAgICAgICAg ICAgIHRpbWVzID0gWzAsIDIwLCA0MF0KKyAgICAgICAgICAgIHJldHVybiBsYW1iZGE6IHRpbWVz LnBvcCgwKQorICAgICAgICBwb3J0ID0gc2VsZi5tYWtlX3BvcnQocG9ydF9uYW1lPSdtYWMtc25v d2xlb3BhcmQnKQorICAgICAgICBwb3J0Ll9nZXRfY3Jhc2hfbG9nKCdEdW1wUmVuZGVyVHJlZScs IDEyMzQsICcnLCAnJywgMCwKKyAgICAgICAgICAgIHRpbWVfZm49ZmFrZV90aW1lX2NiKCksIHNs ZWVwX2ZuPWxhbWJkYSBkZWxheTogTm9uZSkKIAogICAgIGRlZiB0ZXN0X2hlbHBlcl9zdGFydHMo c2VsZik6CiAgICAgICAgIGhvc3QgPSBNb2NrU3lzdGVtSG9zdChNb2NrRXhlY3V0aXZlKCkpCg==