83521 2012-04-09 16:14:23 -0700 platform/graphics/skia/GlyphPageTreeNodeSkia.cpp mis-use 'continue' for 'break' 2012-04-16 16:32:37 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 xji webkit-unassigned abarth webkit.review.bot oldest_to_newest 598720 0 xji 2012-04-09 16:14:23 -0700 In function GlyphPage::fill(), Line 103, "continue" should be changed to 'break". 600369 1 136692 xji 2012-04-11 10:28:03 -0700 Created attachment 136692 patch 600373 2 webkit.review.bot 2012-04-11 10:30:55 -0700 Attachment 136692 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 600410 3 136699 xji 2012-04-11 10:49:14 -0700 Created attachment 136699 patch 600941 4 136836 xji 2012-04-11 23:51:38 -0700 Created attachment 136836 patch 603413 5 137397 xji 2012-04-16 14:02:18 -0700 Created attachment 137397 patch 603504 6 137416 xji 2012-04-16 15:26:48 -0700 Created attachment 137416 patch sync and resolve conflict for ews and cq. 603551 7 137416 webkit.review.bot 2012-04-16 16:32:32 -0700 Comment on attachment 137416 patch Clearing flags on attachment: 137416 Committed r114316: <http://trac.webkit.org/changeset/114316> 603552 8 webkit.review.bot 2012-04-16 16:32:37 -0700 All reviewed patches have been landed. Closing bug. 136692 2012-04-11 10:28:03 -0700 2012-04-11 10:49:14 -0700 patch 83521.v1 text/plain 1299 xji SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMzg3NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA0LTExICBYaWFvbWVp IEppICA8eGppQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIHBsYXRmb3JtL2dy YXBoaWNzL3NraWEvR2x5cGhQYWdlVHJlZU5vZGVTa2lhLmNwcCBtaXMtdXNlICdjb250aW51ZScg Zm9yICdicmVhaycKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBObyBmdW5jdGlvbmFsaXR5IGNoYW5nZSwgc28gbm8gbmV3IHRlc3RzLgorCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HbHlwaFBhZ2VUcmVlTm9kZVNraWEuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6R2x5cGhQYWdlOjpmaWxsKToKKwogMjAxMi0wNC0xMSAgTm8nYW0gUm9z ZW50aGFsICA8bm9hbS5yb3NlbnRoYWxAbm9raWEuY29tPgogCiAgICAgICAgIFNpbmdsZSBTaGFy ZWFibGVCaXRtYXAgcmV2aXNpb24gYmxhY2tzIG91dCBXZWJWaWV3IG9uIEhhcm1hdHRhbgpJbmRl eDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HbHlwaFBhZ2VUcmVlTm9k ZVNraWEuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3NraWEvR2x5cGhQYWdlVHJlZU5vZGVTa2lhLmNwcAkocmV2aXNpb24gMTEzNzkyKQorKysgU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HbHlwaFBhZ2VUcmVlTm9kZVNraWEu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDAsNyArMTAwLDcgQEAgYm9vbCBHbHlwaFBhZ2U6OmZp bGwodW5zaWduZWQgb2Zmc2V0LCB1bgogICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwg YnVmZmVyTGVuZ3RoOyArK2kpIHsKICAgICAgICAgICAgIGlmICghRm9udDo6aXNDSktJZGVvZ3Jh cGgoYnVmZmVyW2ldKSkgewogICAgICAgICAgICAgICAgIGxvb2tWYXJpYW50cyA9IHRydWU7Ci0g ICAgICAgICAgICAgICAgY29udGludWU7CisgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAg ICAgICB9CiAgICAgICAgIH0KICAgICAgICAgaWYgKGxvb2tWYXJpYW50cykK 136699 2012-04-11 10:49:14 -0700 2012-04-11 23:51:38 -0700 patch 83521.v1 text/plain 1354 xji SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMzg3NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA0LTExICBYaWFvbWVp IEppICA8eGppQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIHBsYXRmb3JtL2dy YXBoaWNzL3NraWEvR2x5cGhQYWdlVHJlZU5vZGVTa2lhLmNwcCBtaXMtdXNlICdjb250aW51ZScg Zm9yICdicmVhaycKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTgzNTIxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgTm8gZnVuY3Rpb25hbGl0eSBjaGFuZ2UsIHNvIG5vIG5ldyB0ZXN0cy4KKworICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL3NraWEvR2x5cGhQYWdlVHJlZU5vZGVTa2lhLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkdseXBoUGFnZTo6ZmlsbCk6CisKIDIwMTItMDQtMTEgIE5vJ2FtIFJvc2Vu dGhhbCAgPG5vYW0ucm9zZW50aGFsQG5va2lhLmNvbT4KIAogICAgICAgICBTaW5nbGUgU2hhcmVh YmxlQml0bWFwIHJldmlzaW9uIGJsYWNrcyBvdXQgV2ViVmlldyBvbiBIYXJtYXR0YW4KSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvR2x5cGhQYWdlVHJlZU5vZGVT a2lhLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9z a2lhL0dseXBoUGFnZVRyZWVOb2RlU2tpYS5jcHAJKHJldmlzaW9uIDExMzc5MikKKysrIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvR2x5cGhQYWdlVHJlZU5vZGVTa2lhLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTAwLDcgKzEwMCw3IEBAIGJvb2wgR2x5cGhQYWdlOjpmaWxs KHVuc2lnbmVkIG9mZnNldCwgdW4KICAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IGJ1 ZmZlckxlbmd0aDsgKytpKSB7CiAgICAgICAgICAgICBpZiAoIUZvbnQ6OmlzQ0pLSWRlb2dyYXBo KGJ1ZmZlcltpXSkpIHsKICAgICAgICAgICAgICAgICBsb29rVmFyaWFudHMgPSB0cnVlOwotICAg ICAgICAgICAgICAgIGNvbnRpbnVlOworICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAg ICAgfQogICAgICAgICB9CiAgICAgICAgIGlmIChsb29rVmFyaWFudHMpCg== 136836 2012-04-11 23:51:38 -0700 2012-04-16 14:02:18 -0700 patch 83521.v1 text/plain 1343 xji SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMzg3NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA0LTExICBYaWFvbWVp IEppICA8eGppQGNocm9taXVtLm9yZz4KKworICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9za2lh L0dseXBoUGFnZVRyZWVOb2RlU2tpYS5jcHAgbWlzLXVzZSAnY29udGludWUnIGZvciAnYnJlYWsn CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzUyMQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIGZ1bmN0 aW9uYWxpdHkgY2hhbmdlLCBzbyBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9za2lhL0dseXBoUGFnZVRyZWVOb2RlU2tpYS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpHbHlwaFBhZ2U6OmZpbGwpOgorCiAyMDEyLTA0LTExICBObydhbSBSb3NlbnRoYWwgIDxub2Ft LnJvc2VudGhhbEBub2tpYS5jb20+CiAKICAgICAgICAgU2luZ2xlIFNoYXJlYWJsZUJpdG1hcCBy ZXZpc2lvbiBibGFja3Mgb3V0IFdlYlZpZXcgb24gSGFybWF0dGFuCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dseXBoUGFnZVRyZWVOb2RlU2tpYS5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HbHlwaFBh Z2VUcmVlTm9kZVNraWEuY3BwCShyZXZpc2lvbiAxMTM3OTIpCisrKyBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9za2lhL0dseXBoUGFnZVRyZWVOb2RlU2tpYS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTEwMCw3ICsxMDAsNyBAQCBib29sIEdseXBoUGFnZTo6ZmlsbCh1bnNpZ25lZCBv ZmZzZXQsIHVuCiAgICAgICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBidWZmZXJMZW5ndGg7 ICsraSkgewogICAgICAgICAgICAgaWYgKCFGb250Ojppc0NKS0lkZW9ncmFwaChidWZmZXJbaV0p KSB7CiAgICAgICAgICAgICAgICAgbG9va1ZhcmlhbnRzID0gdHJ1ZTsKLSAgICAgICAgICAgICAg ICBjb250aW51ZTsKKyAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIH0KICAgICAg ICAgfQogICAgICAgICBpZiAobG9va1ZhcmlhbnRzKQo= 137397 2012-04-16 14:02:18 -0700 2012-04-16 15:26:48 -0700 patch 83521.v2 text/plain 1667 xji SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMzg3NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA0LTExICBYaWFvbWVp IEppICA8eGppQGNocm9taXVtLm9yZz4KKworICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9za2lh L0dseXBoUGFnZVRyZWVOb2RlU2tpYS5jcHAgbWlzLXVzZSAnY29udGludWUnIGZvciAnYnJlYWsn CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzUyMQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIGZ1bmN0 aW9uYWxpdHkgY2hhbmdlLCBzbyBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9za2lhL0dseXBoUGFnZVRyZWVOb2RlU2tpYS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpHbHlwaFBhZ2U6OmZpbGwpOgorCiAyMDEyLTA0LTExICBObydhbSBSb3NlbnRoYWwgIDxub2Ft LnJvc2VudGhhbEBub2tpYS5jb20+CiAKICAgICAgICAgU2luZ2xlIFNoYXJlYWJsZUJpdG1hcCBy ZXZpc2lvbiBibGFja3Mgb3V0IFdlYlZpZXcgb24gSGFybWF0dGFuCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dseXBoUGFnZVRyZWVOb2RlU2tpYS5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HbHlwaFBh Z2VUcmVlTm9kZVNraWEuY3BwCShyZXZpc2lvbiAxMTM3OTIpCisrKyBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9za2lhL0dseXBoUGFnZVRyZWVOb2RlU2tpYS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTk2LDE1ICs5NiwxMiBAQCBib29sIEdseXBoUGFnZTo6ZmlsbCh1bnNpZ25lZCBv ZmZzZXQsIHVuCiAgICAgfQogCiAgICAgaWYgKGZvbnREYXRhLT5oYXNWZXJ0aWNhbEdseXBocygp KSB7Ci0gICAgICAgIGJvb2wgbG9va1ZhcmlhbnRzID0gZmFsc2U7CiAgICAgICAgIGZvciAodW5z aWduZWQgaSA9IDA7IGkgPCBidWZmZXJMZW5ndGg7ICsraSkgewogICAgICAgICAgICAgaWYgKCFG b250Ojppc0NKS0lkZW9ncmFwaChidWZmZXJbaV0pKSB7Ci0gICAgICAgICAgICAgICAgbG9va1Zh cmlhbnRzID0gdHJ1ZTsKLSAgICAgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgICAgICAg ICBzdWJzdGl0dXRlV2l0aFZlcnRpY2FsR2x5cGhzKGZvbnREYXRhLCBnbHlwaHMsIGJ1ZmZlckxl bmd0aCk7CisgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0K LSAgICAgICAgaWYgKGxvb2tWYXJpYW50cykKLSAgICAgICAgICAgIHN1YnN0aXR1dGVXaXRoVmVy dGljYWxHbHlwaHMoZm9udERhdGEsIGdseXBocywgYnVmZmVyTGVuZ3RoKTsKICAgICB9CiAKICAg ICB1bnNpZ25lZCBhbGxHbHlwaHMgPSAwOyAvLyB0cmFjayBpZiBhbnkgb2YgdGhlIGdseXBoSURz IGFyZSBub24temVybwo= 137416 2012-04-16 15:26:48 -0700 2012-04-16 16:32:32 -0700 patch 83521.v3 text/plain 1641 xji SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNDMwNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA0LTExICBYaWFvbWVp IEppICA8eGppQGNocm9taXVtLm9yZz4KKworICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9za2lh L0dseXBoUGFnZVRyZWVOb2RlU2tpYS5jcHAgbWlzLXVzZSAnY29udGludWUnIGZvciAnYnJlYWsn CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzUyMQor CisgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmluLgorCisgICAgICAgIE5vIGZ1bmN0aW9u YWxpdHkgY2hhbmdlLCBzbyBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9za2lhL0dseXBoUGFnZVRyZWVOb2RlU2tpYS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpH bHlwaFBhZ2U6OmZpbGwpOgorCiAyMDEyLTA0LTE2ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFz ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbmFtZSB0byB1cGRhdGVaT3JkZXJMaXN0c1Nsb3dD YXNlIHRvIHJlYnVpbGRaT3JkZXJMaXN0cwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3Mvc2tpYS9HbHlwaFBhZ2VUcmVlTm9kZVNraWEuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvR2x5cGhQYWdlVHJlZU5vZGVTa2lh LmNwcAkocmV2aXNpb24gMTE0MzA0KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3Mvc2tpYS9HbHlwaFBhZ2VUcmVlTm9kZVNraWEuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05Niwx NSArOTYsMTIgQEAgYm9vbCBHbHlwaFBhZ2U6OmZpbGwodW5zaWduZWQgb2Zmc2V0LCB1bgogICAg IH0KIAogICAgIGlmIChmb250RGF0YS0+aGFzVmVydGljYWxHbHlwaHMoKSkgewotICAgICAgICBi b29sIGxvb2tWYXJpYW50cyA9IGZhbHNlOwogICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBp IDwgYnVmZmVyTGVuZ3RoOyArK2kpIHsKICAgICAgICAgICAgIGlmICghRm9udDo6aXNDSktJZGVv Z3JhcGgoYnVmZmVyW2ldKSkgewotICAgICAgICAgICAgICAgIGxvb2tWYXJpYW50cyA9IHRydWU7 Ci0gICAgICAgICAgICAgICAgY29udGludWU7CisgICAgICAgICAgICAgICAgc3Vic3RpdHV0ZVdp dGhWZXJ0aWNhbEdseXBocyhmb250RGF0YSwgZ2x5cGhzLCBsZW5ndGgpOworICAgICAgICAgICAg ICAgIGJyZWFrOwogICAgICAgICAgICAgfQogICAgICAgICB9Ci0gICAgICAgIGlmIChsb29rVmFy aWFudHMpCi0gICAgICAgICAgICBzdWJzdGl0dXRlV2l0aFZlcnRpY2FsR2x5cGhzKGZvbnREYXRh LCBnbHlwaHMsIGxlbmd0aCk7CiAgICAgfQogCiAgICAgdW5zaWduZWQgYWxsR2x5cGhzID0gMDsg Ly8gdHJhY2sgaWYgYW55IG9mIHRoZSBnbHlwaElEcyBhcmUgbm9uLXplcm8K