83508 2012-04-09 14:38:54 -0700 merge the functionality of test_expectations and Skipped files 2012-06-20 14:43:04 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED NRWT P2 Normal --- 1 dpranke dpranke oldest_to_newest 598620 0 dpranke 2012-04-09 14:38:54 -0700 We should probably replace the functionality of test_expectations.txt and Skipped files with something that combines the best aspects of both ... Advantages of test_expectations files: - You can do finer-grained specifications of failures (IMAGE vs. TEXT vs. both) - You can programmatically specify a bug # to associate with a failure - You can specify different results for Release vs. Debug, other configurations - You can specify failures for multiple different platforms in one place Disadvantages of test_expectations files: - Entries can stay in the file too long, making it hard to manage - You can't easily stack failures on top of each other, if a test fails one way, then starts to fail differently - It can be hard to separate out failures by platform - The syntax is complicated Advantages of Skipped files: - Very simple to use - Have a clean #include / inheritance / cascade mechanism - Strong incentives to keep entries out of this file if they aren't needed Disadvantages of Skipped files: - Not very flexible 653907 1 dpranke 2012-06-20 14:43:04 -0700 closing ... this is being tracked elsewhere.