83506 2012-04-09 13:59:03 -0700 [Mac] WebProcess dies due to m_process->checkURLReceivedFromWebProcess(url) dropping a file URL 2012-04-09 19:06:40 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap jeffrey+webkit webkit.review.bot oldest_to_newest 598598 0 ap 2012-04-09 13:59:03 -0700 Steps to reproduce. 1. Launch installed Safari alongside a local build or a nightly. 2. Open any local document in installed Safari. 3. Drag favicon from installed Safari's address bar to another copy's content window. Results: assertion failure. <rdar://problem/11171264> 598613 1 136305 ap 2012-04-09 14:30:01 -0700 Created attachment 136305 proposed fix 598881 2 136305 webkit.review.bot 2012-04-09 19:06:36 -0700 Comment on attachment 136305 proposed fix Clearing flags on attachment: 136305 Committed r113659: <http://trac.webkit.org/changeset/113659> 598882 3 webkit.review.bot 2012-04-09 19:06:40 -0700 All reviewed patches have been landed. Closing bug. 136305 2012-04-09 14:30:01 -0700 2012-04-09 19:06:36 -0700 proposed fix FileURLDrop.txt text/plain 3249 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMzYxNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA0LTA5ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIFdlYlByb2Nlc3Mg ZGllcyBkdWUgdG8gbV9wcm9jZXNzLT5jaGVja1VSTFJlY2VpdmVkRnJvbVdlYlByb2Nlc3ModXJs KSBkcm9wcGluZyBhIGZpbGUgVVJMCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04MzUwNgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTExNzEyNjQ+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2Fubm90IHRl c3QsIGJlY2F1c2UgZHJhZ2dpbmcgd2l0aGluIGEgc2luZ2xlIHdpbmRvdyBuZXZlciBpbml0aWF0 ZXMgYSBuYXZpZ2F0aW9uLCBhbmQgZHJhZ2dpbmcKKyAgICAgICAgYWNyb3NzIHdpbmRvd3MgaXMg dG9vIG11Y2ggZm9yIERSVCBhbmQgV1RSLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL0RyYWdE YXRhTWFjLm1tOiAoV2ViQ29yZTo6RHJhZ0RhdGE6OmFzVVJMKTogQWRkIHRoZSBzYW1lIGNoZWNr cyB0aGF0IHdlIGhhZAorICAgICAgICBmb3IgTlNVUkxQYm9hcmRUeXBlIHRvIE5TU3RyaW5nUGJv YXJkVHlwZSBjYXNlLCBwcmV2ZW50aW5nIGRyb3BwaW5nIG9mIG5vbi1IVFRQIFVSTHMuCisgICAg ICAgIFN0cmluZyB0eXBlcyBjYW5ub3QgYmUgc2FuaXRpemVkIHdoZW4gdGhleSBhcmUgbW9kaWZp ZWQgYnkgSmF2YVNjcmlwdCwgYW5kIGFyZSB0aHVzIGxlc3MgdHJ1c3RlZC4KKyAgICAgICAgU3Ry aW5nIGNoZWNrcyBzaG91bGQgYmUgYXQgbGVhc3QgYXMgcmVzdHJpY3RpdmUgYXMgVVJMIG9uZXMu CisKIDIwMTItMDQtMDkgIFNhZHJ1bCBIYWJpYiBDaG93ZGh1cnkgIDxzYWRydWxAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gQWRkIEJhdHRlcnkgU3RhdHVzIEFQSSBzdXBwb3J0 LgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL0RyYWdEYXRhTWFjLm1tCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9EcmFnRGF0YU1hYy5tbQkocmV2 aXNpb24gMTEzNjAxKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL0RyYWdEYXRhTWFj Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xNjAsMTUgKzE2MCwxOSBAQCBTdHJpbmcgRHJhZ0RhdGE6 OmFzVVJMKEZyYW1lKiBmcmFtZSwgRmlsCiAgICAgaWYgKHR5cGVzLmNvbnRhaW5zKFN0cmluZyhO U1VSTFBib2FyZFR5cGUpKSkgewogICAgICAgICBOU1VSTCAqVVJMRnJvbVBhc3RlYm9hcmQgPSBb TlNVUkwgVVJMV2l0aFN0cmluZzpwbGF0Zm9ybVN0cmF0ZWdpZXMoKS0+cGFzdGVib2FyZFN0cmF0 ZWd5KCktPnN0cmluZ0ZvclR5cGUoU3RyaW5nKE5TVVJMUGJvYXJkVHlwZSksIG1fcGFzdGVib2Fy ZE5hbWUpXTsKICAgICAgICAgTlNTdHJpbmcgKnNjaGVtZSA9IFtVUkxGcm9tUGFzdGVib2FyZCBz Y2hlbWVdOwotICAgICAgICBpZiAoW3NjaGVtZSBpc0VxdWFsVG9TdHJpbmc6QCJodHRwIl0gfHwg W3NjaGVtZSBpc0VxdWFsVG9TdHJpbmc6QCJodHRwcyJdKSB7CisgICAgICAgIC8vIENhbm5vdCBk cm9wIG90aGVyIHNjaGVtZXMgdW5sZXNzIDxyZGFyOi8vcHJvYmxlbS8xMDU2MjY2Mj4gYW5kIDxy ZGFyOi8vcHJvYmxlbS8xMTE4NzMxNT4gYXJlIGZpeGVkLgorICAgICAgICBpZiAoW3NjaGVtZSBp c0VxdWFsVG9TdHJpbmc6QCJodHRwIl0gfHwgW3NjaGVtZSBpc0VxdWFsVG9TdHJpbmc6QCJodHRw cyJdKQogICAgICAgICAgICAgcmV0dXJuIFtmcmFtZS0+ZWRpdG9yKCktPmNsaWVudCgpLT5jYW5v bmljYWxpemVVUkwoVVJMRnJvbVBhc3RlYm9hcmQpIGFic29sdXRlU3RyaW5nXTsKLSAgICAgICAg fQogICAgIH0KICAgICAKICAgICBpZiAodHlwZXMuY29udGFpbnMoU3RyaW5nKE5TU3RyaW5nUGJv YXJkVHlwZSkpKSB7Ci0gICAgICAgIE5TVVJMICpVUkwgPSBmcmFtZS0+ZWRpdG9yKCktPmNsaWVu dCgpLT5jYW5vbmljYWxpemVVUkxTdHJpbmcocGxhdGZvcm1TdHJhdGVnaWVzKCktPnBhc3RlYm9h cmRTdHJhdGVneSgpLT5zdHJpbmdGb3JUeXBlKFN0cmluZyhOU1N0cmluZ1Bib2FyZFR5cGUpLCBt X3Bhc3RlYm9hcmROYW1lKSk7Ci0gICAgICAgIGlmIChVUkwpCi0gICAgICAgICAgICByZXR1cm4g W1VSTCBhYnNvbHV0ZVN0cmluZ107CisgICAgICAgIE5TVVJMICpVUkxGcm9tUGFzdGVib2FyZCA9 IFtOU1VSTCBVUkxXaXRoU3RyaW5nOnBsYXRmb3JtU3RyYXRlZ2llcygpLT5wYXN0ZWJvYXJkU3Ry YXRlZ3koKS0+c3RyaW5nRm9yVHlwZShTdHJpbmcoTlNTdHJpbmdQYm9hcmRUeXBlKSwgbV9wYXN0 ZWJvYXJkTmFtZSldOworICAgICAgICBOU1N0cmluZyAqc2NoZW1lID0gW1VSTEZyb21QYXN0ZWJv YXJkIHNjaGVtZV07CisgICAgICAgIC8vIFBhc3RlYm9hcmQgY29udGVudCBpcyBub3QgdHJ1c3Rl ZCwgYmVjYXVzZSBKYXZhU2NyaXB0IGNvZGUgY2FuIG1vZGlmeSBpdC4gV2UgY2FuIHNhbml0aXpl IGl0IGZvciBVUkxzIGFuZCBvdGhlciB0eXBlZCBjb250ZW50LCBidXQgbm90IGZvciBzdHJpbmdz LgorICAgICAgICAvLyBUaGUgcmVzdWx0IG9mIHRoaXMgZnVuY3Rpb24gaXMgdXNlZCB0byBpbml0 aWF0ZSBuYXZpZ2F0aW9uLCBzbyB3ZSBzaG91bGRuJ3QgYWxsb3cgYXJiaXRyYXJ5IGZpbGUgVVJM cy4KKyAgICAgICAgLy8gRklYTUU6IFNob3VsZCB3ZSBhbGxvdyBvbmx5IGh0dHAgZmFtaWx5IHNj aGVtZXMsIG9yIGFueXRoaW5nIG5vbi1sb2NhbD8KKyAgICAgICAgaWYgKFtzY2hlbWUgaXNFcXVh bFRvU3RyaW5nOkAiaHR0cCJdIHx8IFtzY2hlbWUgaXNFcXVhbFRvU3RyaW5nOkAiaHR0cHMiXSkK KyAgICAgICAgICAgIHJldHVybiBbZnJhbWUtPmVkaXRvcigpLT5jbGllbnQoKS0+Y2Fub25pY2Fs aXplVVJMKFVSTEZyb21QYXN0ZWJvYXJkKSBhYnNvbHV0ZVN0cmluZ107CiAgICAgfQogICAgIAog ICAgIGlmICh0eXBlcy5jb250YWlucyhTdHJpbmcoTlNGaWxlbmFtZXNQYm9hcmRUeXBlKSkpIHsK