83501 2012-04-09 13:16:34 -0700 [Gtk] atk_text_set_caret_offset() fails for table cells 2012-08-15 12:18:46 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 25531 0 jdiggs webkit-unassigned cfleizach mario webkit.review.bot oldest_to_newest 598553 0 136289 jdiggs 2012-04-09 13:16:34 -0700 Created attachment 136289 test script Steps to reproduce: 1. Launch the test script 2. View the test case in Epiphany When the Epiphany window is activated the following output is seen: Headings found: 2 Able to set caret in [heading | item 1]: True Able to set caret in [heading | item 2]: True Paragraphs found: 2 Able to set caret in [paragraph | ]: True Able to set caret in [paragraph | ]: True Cells found: 2 Able to set caret in [table cell | ]: False Able to set caret in [table cell | ]: False List items found: 2 Able to set caret in [list item | ]: True Able to set caret in [list item | ]: True For some reason we cannot set the caret in table cells. As a result, Orca's structural navigation to and within tables fails. 598554 1 136290 jdiggs 2012-04-09 13:17:11 -0700 Created attachment 136290 test case 696202 2 158605 jdiggs 2012-08-15 11:36:03 -0700 Created attachment 158605 proposed patch with updated unit test 696233 3 jdiggs 2012-08-15 11:59:52 -0700 Chris, another one-liner fix with updated unit tests. And hopefully clear comments this time. ;) Thanks in advance! 696234 4 158605 cfleizach 2012-08-15 12:01:19 -0700 Comment on attachment 158605 proposed patch with updated unit test r=me 696253 5 158605 webkit.review.bot 2012-08-15 12:18:43 -0700 Comment on attachment 158605 proposed patch with updated unit test Clearing flags on attachment: 158605 Committed r125692: <http://trac.webkit.org/changeset/125692> 696254 6 webkit.review.bot 2012-08-15 12:18:46 -0700 All reviewed patches have been landed. Closing bug. 136289 2012-04-09 13:16:34 -0700 2012-04-09 13:16:34 -0700 test script caret.py text/plain 1286 jdiggs IyEvdXNyL2Jpbi9weXRob24KaW1wb3J0IHB5YXRzcGkKCmRlZiBmaW5kQnlSb2xlKHdpbmRvdywg cm9sZSk6CiAgICBpc01hdGNoID0gbGFtYmRhIHg6IHguZ2V0Um9sZSgpID09IHJvbGUKICAgIHJl dHVybiBweWF0c3BpLnV0aWxzLmZpbmRBbGxEZXNjZW5kYW50cyh3aW5kb3csIGlzTWF0Y2gpCgpk ZWYgc2V0Q2FyZXRPZmZzZXQob2JqKToKICAgIHRyeToKICAgICAgICB0ZXh0ID0gb2JqLnF1ZXJ5 VGV4dCgpCiAgICBleGNlcHQgTm90SW1wbGVtZW50ZWRFcnJvcjoKICAgICAgICBwcmludCAnVGV4 dCBpbnRlcmZhY2Ugbm90IGltcGxlbWVudGVkIGZvciAlcy4nICUgb2JqCiAgICBleGNlcHQgQXR0 cmlidXRlRXJyb3I6CiAgICAgICAgcHJpbnQgJyVzIG1heSBoYXZlIGdvbmUgYXdheS4nICUgb2Jq CiAgICBlbHNlOgogICAgICAgIHByaW50ICdBYmxlIHRvIHNldCBjYXJldCBpbiAlczogJXMnICUg KG9iaiwgdGV4dC5zZXRDYXJldE9mZnNldCgzKSkKCmRlZiBsaXN0ZW5lcihlKToKICAgIGlmIGUu aG9zdF9hcHBsaWNhdGlvbiBhbmQgZS5ob3N0X2FwcGxpY2F0aW9uLm5hbWUgIT0gJ2VwaXBoYW55 JzoKICAgICAgICByZXR1cm4KCiAgICBvYmpzID0gZmluZEJ5Um9sZShlLnNvdXJjZSwgcHlhdHNw aS5ST0xFX0hFQURJTkcpCiAgICBwcmludCAnXG5IZWFkaW5ncyBmb3VuZDogJWknICUgbGVuKG9i anMpCiAgICBmb3Igb2JqIGluIG9ianM6CiAgICAgICAgc2V0Q2FyZXRPZmZzZXQob2JqKQoKICAg IG9ianMgPSBmaW5kQnlSb2xlKGUuc291cmNlLCBweWF0c3BpLlJPTEVfUEFSQUdSQVBIKQogICAg cHJpbnQgJ1xuUGFyYWdyYXBocyBmb3VuZDogJWknICUgbGVuKG9ianMpCiAgICBmb3Igb2JqIGlu IG9ianM6CiAgICAgICAgc2V0Q2FyZXRPZmZzZXQob2JqKQoKICAgIG9ianMgPSBmaW5kQnlSb2xl KGUuc291cmNlLCBweWF0c3BpLlJPTEVfVEFCTEVfQ0VMTCkKICAgIHByaW50ICdcbkNlbGxzIGZv dW5kOiAlaScgJSBsZW4ob2JqcykKICAgIGZvciBvYmogaW4gb2JqczoKICAgICAgICBzZXRDYXJl dE9mZnNldChvYmopCgogICAgb2JqcyA9IGZpbmRCeVJvbGUoZS5zb3VyY2UsIHB5YXRzcGkuUk9M RV9MSVNUX0lURU0pCiAgICBwcmludCAnXG5MaXN0IGl0ZW1zIGZvdW5kOiAlaScgJSBsZW4ob2Jq cykKICAgIGZvciBvYmogaW4gb2JqczoKICAgICAgICBzZXRDYXJldE9mZnNldChvYmopCgpweWF0 c3BpLlJlZ2lzdHJ5LnJlZ2lzdGVyRXZlbnRMaXN0ZW5lcihsaXN0ZW5lciwgIndpbmRvdzphY3Rp dmF0ZSIpCnB5YXRzcGkuUmVnaXN0cnkuc3RhcnQoKQo= 136290 2012-04-09 13:17:11 -0700 2012-04-09 13:17:11 -0700 test case caret.html text/html 237 jdiggs PGh0bWw+CjxoZWFkPgo8dGl0bGU+VGFibGVzPC90aXRsZT4KPC9oZWFkPgo8Ym9keT4KPGgxPml0 ZW0gMTwvaDE+CjxoMT5pdGVtIDI8L2gxPgo8cD5pdGVtIDE8L3A+CjxwPml0ZW0gMjwvcD4KPHRh YmxlPgo8dHI+PHRkPml0ZW0gMTwvdGQ+PC90cj4KPHRyPjx0ZD5pdGVtIDI8L3RkPjwvdHI+Cjwv dGFibGU+Cjx1bD4KPGxpPml0ZW0gMTwvbGk+CjxsaT5pdGVtIDI8L2xpPgo8L3VsPgo8L2JvZHk+ CjwvaHRtbD4K 158605 2012-08-15 11:36:03 -0700 2012-08-15 12:18:42 -0700 proposed patch with updated unit test 83501.patch text/plain 5679 jdiggs RnJvbSBhMTQ1MWFlNmI0ZDk3OWIyNjg4OWY4YzY3NDJhZmZmZTFlN2M4MGEyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2FubWFyaWUgRGlnZ3MgPGpkaWdnc0BpZ2FsaWEuY29tPgpE YXRlOiBXZWQsIDE1IEF1ZyAyMDEyIDEyOjM1OjE0IC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gRml4 IGZvciBidWcgODM1MDEgLSBbR3RrXSBhdGtfdGV4dF9zZXRfY2FyZXRfb2Zmc2V0KCkgZmFpbHMK IGZvciB0YWJsZSBjZWxscwoKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAg ICAgICAgICAgICAgICAgICAgfCAxMyArKysrKysrKysrKysrCiAuLi4vYWNjZXNzaWJpbGl0eS9n dGsvQWNjZXNzaWJpbGl0eU9iamVjdEF0ay5jcHAgICAgfCAgMiArLQogU291cmNlL1dlYktpdC9n dGsvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgIHwgMTIgKysrKysrKysrKysrCiBT b3VyY2UvV2ViS2l0L2d0ay90ZXN0cy90ZXN0YXRrLmMgICAgICAgICAgICAgICAgICAgfCAyMSAr KysrKysrKysrKysrKysrKysrKy0KIDQgZmlsZXMgY2hhbmdlZCwgNDYgaW5zZXJ0aW9ucygrKSwg MiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGM4OTU0Mi4uMzk0YjgyZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA4LTE1ICBKb2FubWFyaWUgRGlnZ3MgIDxqZGlnZ3NA aWdhbGlhLmNvbT4KKworICAgICAgICBbR3RrXSBhdGtfdGV4dF9zZXRfY2FyZXRfb2Zmc2V0KCkg ZmFpbHMgZm9yIHRhYmxlIGNlbGxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04MzUwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEFsbG93IHVzaW5nIHRleHQgcmFuZ2VzIGluIGFjY2Vzc2libGUgdGFibGUg Y2VsbHMuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0 QXRrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlPYmplY3Q6OmFsbG93c1Rl eHRSYW5nZXMpOgorICAgICAgICBBZGQgdGFibGUgY2VsbHMgdG8gdGhlIGxpc3Qgb2YgYWNjZXNz aWJpbGl0eSBvYmplY3RzIHN1cHBvcnRpbmcgdGV4dCByYW5nZXMuCisKIDIwMTItMDgtMTUgIFZz ZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3Bl Y3RvcjogW1JFR1JFU1NJT05dICJzYXZlIGFzIiBvZiBlZGl0ZWQgc291cmNlIGluIGRldmVsb3Bl ciBtb2RlIGZhaWxzIHRvIHVwZGF0ZSBzYXZlZCBmaWxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9hY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0QXRrLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RBdGsuY3BwCmlu ZGV4IDEwMTgzNDkuLjM5ZjQ4ODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2li aWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RBdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2FjY2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RBdGsuY3BwCkBAIC0xMDMsNyAr MTAzLDcgQEAgdm9pZCBBY2Nlc3NpYmlsaXR5T2JqZWN0OjpzZXRXcmFwcGVyKEFjY2Vzc2liaWxp dHlPYmplY3RXcmFwcGVyKiB3cmFwcGVyKQogYm9vbCBBY2Nlc3NpYmlsaXR5T2JqZWN0OjphbGxv d3NUZXh0UmFuZ2VzKCkgY29uc3QKIHsKICAgICAvLyBDaGVjayB0eXBlIGZvciB0aGUgQWNjZXNz aWJpbGl0eU9iamVjdC4KLSAgICBpZiAoaXNUZXh0Q29udHJvbCgpIHx8IGlzV2ViQXJlYSgpIHx8 IGlzR3JvdXAoKSB8fCBpc0xpbmsoKSB8fCBpc0hlYWRpbmcoKSB8fCBpc0xpc3RJdGVtKCkpCisg ICAgaWYgKGlzVGV4dENvbnRyb2woKSB8fCBpc1dlYkFyZWEoKSB8fCBpc0dyb3VwKCkgfHwgaXNM aW5rKCkgfHwgaXNIZWFkaW5nKCkgfHwgaXNMaXN0SXRlbSgpIHx8IGlzVGFibGVDZWxsKCkpCiAg ICAgICAgIHJldHVybiB0cnVlOwogCiAgICAgLy8gQ2hlY2sgcm9sZXMgYXMgdGhlIGxhc3QgZmFs bGJhY2sgbWVjaGFuaXNtLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n IGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IDI1ODY2ODMuLmZkNDI5ZTggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0 L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wOC0xNSAgSm9hbm1hcmllIERp Z2dzICA8amRpZ2dzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0d0a10gYXRrX3RleHRfc2V0X2Nh cmV0X29mZnNldCgpIGZhaWxzIGZvciB0YWJsZSBjZWxscworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODM1MDEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgdW5pdCB0ZXN0IHRvIGluY2x1ZGUgc2V0 dGluZyB0aGUgY2FyZXQgaW4gYSB0YWJsZSBjZWxsIHZpYSB0aGUgQXRrVGV4dCBpbnRlcmZhY2Uu CisKKyAgICAgICAgKiB0ZXN0cy90ZXN0YXRrLmM6CisgICAgICAgICh0ZXN0V2Via2l0QXRrQ2Fy ZXRPZmZzZXRzKTogQWRkIHNldHRpbmcgdGhlIGNhcmV0IGluc2lkZSB0aGUgdGV4dCBvZiBhIHRh YmxlIGNlbGwuCisKIDIwMTItMDgtMTQgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4K IAogICAgICAgICBEZWxldGUgRnJhbWU6OmRvbVdpbmRvdygpIGFuZCBGcmFtZTo6ZXhpc3RpbmdE T01XaW5kb3coKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvdGVzdHMvdGVzdGF0ay5j IGIvU291cmNlL1dlYktpdC9ndGsvdGVzdHMvdGVzdGF0ay5jCmluZGV4IDUwMzEwOTEuLmFlNzM0 OTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3RhdGsuYworKysgYi9T b3VyY2UvV2ViS2l0L2d0ay90ZXN0cy90ZXN0YXRrLmMKQEAgLTY1LDcgKzY1LDcgQEAgc3RhdGlj IGNvbnN0IGNoYXIqIGxpbmtzV2l0aElubGluZUltYWdlcyA9ICI8aHRtbD48aGVhZD48c3R5bGU+ YS5odHRwOmJlZm9yZSB7Y28KIAogc3RhdGljIGNvbnN0IGNoYXIqIGxpc3RzT2ZJdGVtcyA9ICI8 aHRtbD48Ym9keT48dWw+PGxpPnRleHQgb25seTwvbGk+PGxpPjxhIGhyZWY9J2Zvbyc+bGluayBv bmx5PC9hPjwvbGk+PGxpPnRleHQgYW5kIGEgPGEgaHJlZj0nYmFyJz5saW5rPC9hPjwvbGk+PC91 bD48b2w+PGxpPnRleHQgb25seTwvbGk+PGxpPjxhIGhyZWY9J2Zvbyc+bGluayBvbmx5PC9hPjwv bGk+PGxpPnRleHQgYW5kIGEgPGEgaHJlZj0nYmFyJz5saW5rPC9hPjwvbGk+PC9vbD48L2JvZHk+ PC9odG1sPiI7CiAKLXN0YXRpYyBjb25zdCBjaGFyKiB0ZXh0Rm9yQ2FyZXRCcm93c2luZyA9ICI8 aHRtbD48Ym9keT48aDE+QSB0ZXh0IGhlYWRlcjwvaDE+PHA+QSBwYXJhZ3JhcGggPGEgaHJlZj0n aHR0cDovL2Zvby5iYXIuYmF6Lyc+d2l0aCBhIGxpbms8L2E+IGluIHRoZSBtaWRkbGU8L3A+PG9s PjxsaT5BIGxpc3QgaXRlbTwvbGk+PC9vbD48c2VsZWN0PjxvcHRpb24gc2VsZWN0ZWQgdmFsdWU9 J2Zvbyc+QW4gb3B0aW9uIGluIGEgY29tYm8gYm94PC9vcHRpb24+PC9zZWxlY3Q+PGlucHV0IHR5 cGU9J3RleHQnJyBuYW1lPSdmb28nJyB2YWx1ZT0nZm9vIGJhciBiYXonIC8+PC9ib2R5PjwvaHRt bD4iOworc3RhdGljIGNvbnN0IGNoYXIqIHRleHRGb3JDYXJldEJyb3dzaW5nID0gIjxodG1sPjxi b2R5PjxoMT5BIHRleHQgaGVhZGVyPC9oMT48cD5BIHBhcmFncmFwaCA8YSBocmVmPSdodHRwOi8v Zm9vLmJhci5iYXovJz53aXRoIGEgbGluazwvYT4gaW4gdGhlIG1pZGRsZTwvcD48b2w+PGxpPkEg bGlzdCBpdGVtPC9saT48L29sPjxzZWxlY3Q+PG9wdGlvbiBzZWxlY3RlZCB2YWx1ZT0nZm9vJz5B biBvcHRpb24gaW4gYSBjb21ibyBib3g8L29wdGlvbj48L3NlbGVjdD48aW5wdXQgdHlwZT0ndGV4 dCcnIG5hbWU9J2ZvbycnIHZhbHVlPSdmb28gYmFyIGJheicgLz48dGFibGU+PHRyPjx0ZD5hIHRh YmxlIGNlbGw8L3RkPjwvdHI+PC90YWJsZT48L2JvZHk+PC9odG1sPiI7CiAKIHN0YXRpYyBjb25z dCBjaGFyKiB0ZXh0Rm9yU2VsZWN0aW9ucyA9ICI8aHRtbD48Ym9keT48cD5BIHBhcmFncmFwaCB3 aXRoIHBsYWluIHRleHQ8L3A+PHA+QSBwYXJhZ3JhcGggd2l0aCA8YSBocmVmPSdodHRwOi8vd2Vi a2l0Lm9yZyc+YSBsaW5rPC9hPiBpbiB0aGUgbWlkZGxlPC9wPjxvbD48bGk+QSBsaXN0IGl0ZW08 L2xpPjwvb2w+PHNlbGVjdD48L2JvZHk+PC9odG1sPiI7CiAKQEAgLTM4OSw2ICszODksMjMgQEAg c3RhdGljIHZvaWQgdGVzdFdlYmtpdEF0a0NhcmV0T2Zmc2V0cygpCiAgICAgb2Zmc2V0ID0gYXRr X3RleHRfZ2V0X2NhcmV0X29mZnNldChBVEtfVEVYVCh0ZXh0RW50cnkpKTsKICAgICBnX2Fzc2Vy dF9jbXBpbnQob2Zmc2V0LCA9PSwgNSk7CiAKKyAgICBBdGtPYmplY3QqIHRhYmxlID0gYXRrX29i amVjdF9yZWZfYWNjZXNzaWJsZV9jaGlsZChvYmplY3QsIDQpOworICAgIGdfYXNzZXJ0KEFUS19J U19PQkpFQ1QodGFibGUpKTsKKyAgICBnX2Fzc2VydChhdGtfb2JqZWN0X2dldF9yb2xlKHRhYmxl KSA9PSBBVEtfUk9MRV9UQUJMRSk7CisgICAgZ19hc3NlcnRfY21waW50KGF0a19vYmplY3RfZ2V0 X25fYWNjZXNzaWJsZV9jaGlsZHJlbih0YWJsZSksID09LCAxKTsKKworICAgIEF0a09iamVjdCog dGFibGVDZWxsID0gYXRrX29iamVjdF9yZWZfYWNjZXNzaWJsZV9jaGlsZCh0YWJsZSwgMCk7Cisg ICAgZ19hc3NlcnQoQVRLX0lTX1RFWFQodGFibGVDZWxsKSk7CisgICAgZ19hc3NlcnQoYXRrX29i amVjdF9nZXRfcm9sZSh0YWJsZUNlbGwpID09IEFUS19ST0xFX1RBQkxFX0NFTEwpOworICAgIHRl eHQgPSBhdGtfdGV4dF9nZXRfdGV4dChBVEtfVEVYVCh0YWJsZUNlbGwpLCAwLCAtMSk7CisgICAg Z19hc3NlcnRfY21wc3RyKHRleHQsID09LCAiYSB0YWJsZSBjZWxsIik7CisgICAgZ19mcmVlKHRl eHQpOworCisgICAgcmVzdWx0ID0gYXRrX3RleHRfc2V0X2NhcmV0X29mZnNldChBVEtfVEVYVCh0 YWJsZUNlbGwpLCAyKTsKKyAgICBnX2Fzc2VydF9jbXBpbnQocmVzdWx0LCA9PSwgVFJVRSk7Cisg ICAgb2Zmc2V0ID0gYXRrX3RleHRfZ2V0X2NhcmV0X29mZnNldChBVEtfVEVYVCh0YWJsZUNlbGwp KTsKKyAgICBnX2Fzc2VydF9jbXBpbnQob2Zmc2V0LCA9PSwgMik7CisKICAgICBnX2ZyZWUodGV4 dENhcmV0TW92ZWRSZXN1bHQpOwogCiAgICAgZ19vYmplY3RfdW5yZWYoaGVhZGVyKTsKQEAgLTQw MSw2ICs0MTgsOCBAQCBzdGF0aWMgdm9pZCB0ZXN0V2Via2l0QXRrQ2FyZXRPZmZzZXRzKCkKICAg ICBnX29iamVjdF91bnJlZihtZW51UG9wdXApOwogICAgIGdfb2JqZWN0X3VucmVmKGNvbWJvQm94 T3B0aW9uKTsKICAgICBnX29iamVjdF91bnJlZih0ZXh0RW50cnkpOworICAgIGdfb2JqZWN0X3Vu cmVmKHRhYmxlKTsKKyAgICBnX29iamVjdF91bnJlZih0YWJsZUNlbGwpOwogICAgIGdfb2JqZWN0 X3VucmVmKHdlYlZpZXcpOwogfQogCi0tIAoxLjcuMTEuMgoK