83499 2012-04-09 12:44:22 -0700 [BlackBerry] requestAnimationFrame performance choppy & inconsistent 2012-04-09 17:01:24 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 anlo webkit-unassigned tonikitoo webkit.review.bot oldest_to_newest 598536 0 anlo 2012-04-09 12:44:22 -0700 Reproduction: 1. http://webstuff.nfshost.com/anim-timing/raftime.html 2. Slide delay slider to the right to add delay to each frame. Notice that when moving the slider slightly, performance becomes extremely choppy. Much choppier than it should be given the reported FPS. Also much choppier than it should be given the delay. When you slide the delay slider, it should get choppier since you are lowering frame rate. However, the choppiness should be consistent, meaning the same time interval between frames. The bug is that it is inconsistent and stutters. When this is performing correctly, it should transition smoothly to being more choppy as you move the slider to the right. The FPS should reflect the amount of choppiness you see, and the choppiness should be consistent. 598560 1 136292 anlo 2012-04-09 13:23:37 -0700 Created attachment 136292 Patch 598567 2 136292 rwlbuis 2012-04-09 13:30:55 -0700 Comment on attachment 136292 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136292&action=review Looks good, but fix ChangeLog first please :) > Source/WebCore/ChangeLog:10 > + Reviewed by NOBODY (OOPS!). The reviewed by line should go between bug/title and explanation. 598576 3 136296 anlo 2012-04-09 13:38:31 -0700 Created attachment 136296 Patch 598589 4 136296 rwlbuis 2012-04-09 13:52:31 -0700 Comment on attachment 136296 Patch Looks good. 598774 5 136296 webkit.review.bot 2012-04-09 17:01:19 -0700 Comment on attachment 136296 Patch Clearing flags on attachment: 136296 Committed r113644: <http://trac.webkit.org/changeset/113644> 598776 6 webkit.review.bot 2012-04-09 17:01:24 -0700 All reviewed patches have been landed. Closing bug. 136292 2012-04-09 13:23:37 -0700 2012-04-09 13:38:25 -0700 Patch bug-83499-20120409162742.patch text/plain 1753 anlo U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNjA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTk3ODkwZTNhMDFjNDVl NGRhYzJlNWM4MGE0Yzk1YWQ4MTBiYjU0My4uZDVmYWVjN2QwMjNjNTc5ODkwNjIyNTM2MTRhYTkx OTkxY2ZmMTk1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA0LTA5ICBBbmRy ZXcgTG8gIDxhbmxvQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIHJlcXVlc3RBbmlt YXRpb25GcmFtZSBwZXJmb3JtYW5jZSBjaG9wcHkgJiBpbmNvbnNpc3RlbnQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzNDk5CisKKyAgICAgICAgUmVz cGVjdCBtX3NjaGVkdWxlZCAmIG1fcHJldmlvdXNGcmFtZURvbmUgZmxhZ3MgbGlrZSB0aGUgTWFj IHBvcnQgb2YKKyAgICAgICAgRGlzcGxheVJlZnJlc2hNb25pdG9yIGRvZXMuCisgICAgICAgIElu dGVybmFsIFBSOiAxNDc4MjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICByZXF1ZXN0QW5pbWF0aW9uRnJhbWUgYWxyZWFkeSBjb3ZlcmVkIGJ5IHRlc3Rz IGluIExheW91dFRlc3RzL2Zhc3QvYW5pbWF0aW9uLgorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvYmxhY2tiZXJyeS9EaXNwbGF5UmVmcmVzaE1vbml0b3JCbGFja0JlcnJ5LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkRpc3BsYXlSZWZyZXNoTW9uaXRvcjo6ZGlzcGxheUxpbmtGaXJlZCk6 CisKIDIwMTItMDQtMDkgIFNoYXduIFNpbmdoICA8c2hhd25zaW5naEBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgW2Nocm9taXVtXSBGaXggbGF5ZXIgc29ydGluZyBwZXJzcGVjdGl2ZSB3IGlmIHcg YmVjb21lcyBuZWdhdGl2ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvYmxhY2tiZXJyeS9EaXNwbGF5UmVmcmVzaE1vbml0b3JCbGFja0JlcnJ5LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvRGlzcGxheVJlZnJlc2hN b25pdG9yQmxhY2tCZXJyeS5jcHAKaW5kZXggZGVkOGVmMDU5NmUyNmZkMWY0YWU0ZmMxYThkMzY1 YmI1ZjNiOWI2Ni4uZjcwNGUyYThiMGNlMjMzNTk5Y2U2YzZiN2JiNzFmZGMyZGNkNjhmNyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9EaXNw bGF5UmVmcmVzaE1vbml0b3JCbGFja0JlcnJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0Rpc3BsYXlSZWZyZXNoTW9uaXRvckJsYWNrQmVycnku Y3BwCkBAIC03Niw3ICs3NiwxMSBAQCB2b2lkIERpc3BsYXlSZWZyZXNoTW9uaXRvcjo6ZGlzcGxh eUxpbmtGaXJlZCgpCiB7CiAgICAgTXV0ZXhMb2NrZXIgbG9jayhtX211dGV4KTsKIAotICAgIG1f c2NoZWR1bGVkID0gZmFsc2U7CisgICAgaWYgKCFtX3NjaGVkdWxlZCB8fCAhbV9wcmV2aW91c0Zy YW1lRG9uZSkKKyAgICAgICAgcmV0dXJuOworCisgICAgbV9wcmV2aW91c0ZyYW1lRG9uZSA9IGZh bHNlOworCiAgICAgbV90aW1lc3RhbXAgPSBjdXJyZW50VGltZSgpOwogCiAgICAgY2FsbE9uTWFp blRocmVhZChyZWZyZXNoRGlzcGxheU9uTWFpblRocmVhZCwgdGhpcyk7Cg== 136296 2012-04-09 13:38:31 -0700 2012-04-09 17:01:19 -0700 Patch bug-83499-20120409164236.patch text/plain 1753 anlo U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNjA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTk3ODkwZTNhMDFjNDVl NGRhYzJlNWM4MGE0Yzk1YWQ4MTBiYjU0My4uN2E2MzE3YTFlNDg2MmQ4YzgzYzcxOGI0YTRjM2Zl ODlmMmQwMzkxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA0LTA5ICBBbmRy ZXcgTG8gIDxhbmxvQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIHJlcXVlc3RBbmlt YXRpb25GcmFtZSBwZXJmb3JtYW5jZSBjaG9wcHkgJiBpbmNvbnNpc3RlbnQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzNDk5CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVzcGVjdCBtX3NjaGVkdWxlZCAm IG1fcHJldmlvdXNGcmFtZURvbmUgZmxhZ3MgbGlrZSB0aGUgTWFjIHBvcnQgb2YKKyAgICAgICAg RGlzcGxheVJlZnJlc2hNb25pdG9yIGRvZXMuCisgICAgICAgIEludGVybmFsIFBSOiAxNDc4MjYK KworICAgICAgICByZXF1ZXN0QW5pbWF0aW9uRnJhbWUgYWxyZWFkeSBjb3ZlcmVkIGJ5IHRlc3Rz IGluIExheW91dFRlc3RzL2Zhc3QvYW5pbWF0aW9uLgorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvYmxhY2tiZXJyeS9EaXNwbGF5UmVmcmVzaE1vbml0b3JCbGFja0JlcnJ5LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkRpc3BsYXlSZWZyZXNoTW9uaXRvcjo6ZGlzcGxheUxpbmtGaXJlZCk6 CisKIDIwMTItMDQtMDkgIFNoYXduIFNpbmdoICA8c2hhd25zaW5naEBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgW2Nocm9taXVtXSBGaXggbGF5ZXIgc29ydGluZyBwZXJzcGVjdGl2ZSB3IGlmIHcg YmVjb21lcyBuZWdhdGl2ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvYmxhY2tiZXJyeS9EaXNwbGF5UmVmcmVzaE1vbml0b3JCbGFja0JlcnJ5LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvRGlzcGxheVJlZnJlc2hN b25pdG9yQmxhY2tCZXJyeS5jcHAKaW5kZXggZGVkOGVmMDU5NmUyNmZkMWY0YWU0ZmMxYThkMzY1 YmI1ZjNiOWI2Ni4uZjcwNGUyYThiMGNlMjMzNTk5Y2U2YzZiN2JiNzFmZGMyZGNkNjhmNyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9EaXNw bGF5UmVmcmVzaE1vbml0b3JCbGFja0JlcnJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0Rpc3BsYXlSZWZyZXNoTW9uaXRvckJsYWNrQmVycnku Y3BwCkBAIC03Niw3ICs3NiwxMSBAQCB2b2lkIERpc3BsYXlSZWZyZXNoTW9uaXRvcjo6ZGlzcGxh eUxpbmtGaXJlZCgpCiB7CiAgICAgTXV0ZXhMb2NrZXIgbG9jayhtX211dGV4KTsKIAotICAgIG1f c2NoZWR1bGVkID0gZmFsc2U7CisgICAgaWYgKCFtX3NjaGVkdWxlZCB8fCAhbV9wcmV2aW91c0Zy YW1lRG9uZSkKKyAgICAgICAgcmV0dXJuOworCisgICAgbV9wcmV2aW91c0ZyYW1lRG9uZSA9IGZh bHNlOworCiAgICAgbV90aW1lc3RhbXAgPSBjdXJyZW50VGltZSgpOwogCiAgICAgY2FsbE9uTWFp blRocmVhZChyZWZyZXNoRGlzcGxheU9uTWFpblRocmVhZCwgdGhpcyk7Cg==