83456 2012-04-08 23:38:45 -0700 [BlackBerry] Revert the changes that depend on Event changes, which is reverted already internally. 2012-04-11 20:34:39 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 charles.wei charles.wei ap efidler gmak hausmann leo.yang manyoso rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 598149 0 charles.wei 2012-04-08 23:38:45 -0700 BlackBerry porting enhances the Event by adding a member variable m_pluginHandled to indicate if the event is handled by the plugin. Need to upstream this change. 598151 1 136189 charles.wei 2012-04-08 23:46:59 -0700 Created attachment 136189 Patch 598399 2 136189 ap 2012-04-09 10:25:56 -0700 Comment on attachment 136189 Patch Even under PLATFORM(BLACKBERRY), this affects other ports by injecting a layering violation that will make future refactoring work more complicated. Core DOM should not know anything about plugins. 598911 3 charles.wei 2012-04-09 19:32:15 -0700 Looked into more detail of how BlackBerry porting uses this, I believe this should be removed, Will discuss internally in RIM first and will get back to this later. Possibly close this bug with resolution as "invalid". 600011 4 charles.wei 2012-04-10 21:28:35 -0700 An internal discussion and bug has been created , 148887, to remove this change to Event. If the internal change is approved and landed, we need to partially apply that change upstreaming, including the change to plugins/blackberry/PluginViewBlackBerry.cpp and page/EventHandler.cpp, to remove setPluginHandled() and pluginHandled() accordingly. 600821 5 charles.wei 2012-04-11 19:57:33 -0700 After internal discussion ,we decided that we won't need the change to Event, so we will revert our change to Event internally (which is already done with internal tracking 148887), and we will have this bug to revert the corresponding changes which has already been upstreamed. I will update the title of this PR accordingly. 600830 6 136815 charles.wei 2012-04-11 20:10:54 -0700 Created attachment 136815 Patch 600841 7 136815 webkit.review.bot 2012-04-11 20:34:33 -0700 Comment on attachment 136815 Patch Clearing flags on attachment: 136815 Committed r113939: <http://trac.webkit.org/changeset/113939> 600842 8 webkit.review.bot 2012-04-11 20:34:39 -0700 All reviewed patches have been landed. Closing bug. 136189 2012-04-08 23:46:59 -0700 2012-04-11 20:10:48 -0700 Patch bug-83456-20120409145242.patch text/plain 4065 charles.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNTU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTAzNzg5MjQzOWYyM2Y4 Y2Y2N2RlNDQ0ZDgxMGYwNzEzOTEwNTRiMy4uM2RlMjYyNzlmMDhmMzU0M2EzYzRiYmQ2Yzk1NGMy NTA4MTllMzg3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA0LTA4ICBDaGFy bGVzIFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBbQmxh Y2tCZXJyeV0gVXBzdHJlYW0gQmxhY2tCZXJyeSBjaGFuZ2UgdG8gV2ViQ29yZTo6RXZlbnQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzNDU2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQmxhY2tCZXJyeS1w b3J0aW5nIGVuaGFuY2VzIFdlYkNvcmU6OkV2ZW50IHdpdGggaW5kaWNhdGlvbiBpZiB0aGUgZXZl bnQKKyAgICAgICAgaXMgaGFuZGxlZCBieSBwbHVnaW4sIGJ5IGEgbmV3IG1lbWJlciB2YXJpYWJs ZTogbV9wbHVnaW5IYW5kbGVkLgorCisgICAgICAgICogZG9tL0V2ZW50LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkV2ZW50OjpFdmVudCk6CisgICAgICAgICogZG9tL0V2ZW50Lmg6CisgICAgICAg IChFdmVudCk6CisgICAgICAgIChXZWJDb3JlOjpFdmVudDo6c2V0UGx1Z2luSGFuZGxlZCk6Cisg ICAgICAgIChXZWJDb3JlOjpFdmVudDo6cGx1Z2luSGFuZGxlZCk6CisKIDIwMTItMDQtMDggIFRh a2FzaGkgU2FrYW1vdG8gIDx0YXNha0Bnb29nbGUuY29tPgogCiAgICAgICAgIDxjb250ZW50PiBp biA8bWV0ZXI+IGlzIG5vdCByZW5kZXJlZCBjb3JyZWN0bHkuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9kb20vRXZlbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50LmNwcAppbmRl eCA5MTIxZTRmMjU5ZjI0MWJjZjc4M2YzN2RmMGE3MTcwYjZhZjZhYTQ1Li42NTViMTI4YzA2ZDZk OWExYWVmZThiMzdmYmQzMzQ3MzZiNTI3MzJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9k b20vRXZlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudC5jcHAKQEAgLTMsNiAr Myw3IEBACiAgKiBDb3B5cmlnaHQgKEMpIDIwMDEgVG9iaWFzIEFudG9uIChhbnRvbkBzdHVkLmZi aS5maC1kYXJtc3RhZHQuZGUpCiAgKiBDb3B5cmlnaHQgKEMpIDIwMDYgU2FtdWVsIFdlaW5pZyAo c2FtLndlaW5pZ0BnbWFpbC5jb20pCiAgKiBDb3B5cmlnaHQgKEMpIDIwMDMsIDIwMDUsIDIwMDYs IDIwMDggQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAy MDEyIFJlc2VhcmNoIEluIE1vdGlvbiBMaW1pdGVkLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoK ICAqIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBp dCBhbmQvb3IKICAqIG1vZGlmeSBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMaWJyYXJ5 IEdlbmVyYWwgUHVibGljCkBAIC00Nyw2ICs0OCw5IEBAIEV2ZW50OjpFdmVudCgpCiAgICAgLCBt X2RlZmF1bHRQcmV2ZW50ZWQoZmFsc2UpCiAgICAgLCBtX2RlZmF1bHRIYW5kbGVkKGZhbHNlKQog ICAgICwgbV9jYW5jZWxCdWJibGUoZmFsc2UpCisjaWYgUExBVEZPUk0oQkxBQ0tCRVJSWSkKKyAg ICAsIG1fcGx1Z2luSGFuZGxlZChmYWxzZSkKKyNlbmRpZgogICAgICwgbV9ldmVudFBoYXNlKDAp CiAgICAgLCBtX2N1cnJlbnRUYXJnZXQoMCkKICAgICAsIG1fY3JlYXRlVGltZShjb252ZXJ0U2Vj b25kc1RvRE9NVGltZVN0YW1wKGN1cnJlbnRUaW1lKCkpKQpAQCAtNjIsNiArNjYsOSBAQCBFdmVu dDo6RXZlbnQoY29uc3QgQXRvbWljU3RyaW5nJiBldmVudFR5cGUsIGJvb2wgY2FuQnViYmxlQXJn LCBib29sIGNhbmNlbGFibGVBcgogICAgICwgbV9kZWZhdWx0UHJldmVudGVkKGZhbHNlKQogICAg ICwgbV9kZWZhdWx0SGFuZGxlZChmYWxzZSkKICAgICAsIG1fY2FuY2VsQnViYmxlKGZhbHNlKQor I2lmIFBMQVRGT1JNKEJMQUNLQkVSUlkpCisgICAgLCBtX3BsdWdpbkhhbmRsZWQoZmFsc2UpCisj ZW5kaWYKICAgICAsIG1fZXZlbnRQaGFzZSgwKQogICAgICwgbV9jdXJyZW50VGFyZ2V0KDApCiAg ICAgLCBtX2NyZWF0ZVRpbWUoY29udmVydFNlY29uZHNUb0RPTVRpbWVTdGFtcChjdXJyZW50VGlt ZSgpKSkKQEAgLTc3LDYgKzg0LDkgQEAgRXZlbnQ6OkV2ZW50KGNvbnN0IEF0b21pY1N0cmluZyYg ZXZlbnRUeXBlLCBjb25zdCBFdmVudEluaXQmIGluaXRpYWxpemVyKQogICAgICwgbV9kZWZhdWx0 UHJldmVudGVkKGZhbHNlKQogICAgICwgbV9kZWZhdWx0SGFuZGxlZChmYWxzZSkKICAgICAsIG1f Y2FuY2VsQnViYmxlKGZhbHNlKQorI2lmIFBMQVRGT1JNKEJMQUNLQkVSUlkpCisgICAgLCBtX3Bs dWdpbkhhbmRsZWQoZmFsc2UpCisjZW5kaWYKICAgICAsIG1fZXZlbnRQaGFzZSgwKQogICAgICwg bV9jdXJyZW50VGFyZ2V0KDApCiAgICAgLCBtX2NyZWF0ZVRpbWUoY29udmVydFNlY29uZHNUb0RP TVRpbWVTdGFtcChjdXJyZW50VGltZSgpKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9FdmVudC5oIGIvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50LmgKaW5kZXggODAwNWI2M2UyNTlh NmU1YTM5YjdhY2I3ZmE3MDM2YjdmOTk2MGVjNy4uMjcwOWJhZWI4MmJhNDk3YjAwYjI4M2ViZmEw ZTExYWQxYTU2ZjQ0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50LmgKKysr IGIvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50LmgKQEAgLTMsNiArMyw3IEBACiAgKiBDb3B5cmln aHQgKEMpIDIwMDEgVG9iaWFzIEFudG9uIChhbnRvbkBzdHVkLmZiaS5maC1kYXJtc3RhZHQuZGUp CiAgKiBDb3B5cmlnaHQgKEMpIDIwMDYgU2FtdWVsIFdlaW5pZyAoc2FtLndlaW5pZ0BnbWFpbC5j b20pCiAgKiBDb3B5cmlnaHQgKEMpIDIwMDMsIDIwMDQsIDIwMDUsIDIwMDYsIDIwMDcsIDIwMDgg QXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDEyIFJl c2VhcmNoIEluIE1vdGlvbiBMaW1pdGVkLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFRo aXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQv b3IKICAqIG1vZGlmeSBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMaWJyYXJ5IEdlbmVy YWwgUHVibGljCkBAIC0xMzcsNiArMTM4LDExIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAg ICAgYm9vbCBkZWZhdWx0SGFuZGxlZCgpIGNvbnN0IHsgcmV0dXJuIG1fZGVmYXVsdEhhbmRsZWQ7 IH0KICAgICAgICAgdm9pZCBzZXREZWZhdWx0SGFuZGxlZCgpIHsgbV9kZWZhdWx0SGFuZGxlZCA9 IHRydWU7IH0KIAorI2lmIFBMQVRGT1JNKEJMQUNLQkVSUlkpCisgICAgICAgIHZvaWQgc2V0UGx1 Z2luSGFuZGxlZCgpIHsgbV9wbHVnaW5IYW5kbGVkID0gdHJ1ZTsgfQorICAgICAgICBib29sIHBs dWdpbkhhbmRsZWQoKSBjb25zdCB7IHJldHVybiBtX3BsdWdpbkhhbmRsZWQ7IH0KKyNlbmRpZgor CiAgICAgICAgIGJvb2wgY2FuY2VsQnViYmxlKCkgY29uc3QgeyByZXR1cm4gbV9jYW5jZWxCdWJi bGU7IH0KICAgICAgICAgdm9pZCBzZXRDYW5jZWxCdWJibGUoYm9vbCBjYW5jZWwpIHsgbV9jYW5j ZWxCdWJibGUgPSBjYW5jZWw7IH0KIApAQCAtMTY4LDYgKzE3NCw5IEBAIG5hbWVzcGFjZSBXZWJD b3JlIHsKICAgICAgICAgYm9vbCBtX2RlZmF1bHRQcmV2ZW50ZWQ7CiAgICAgICAgIGJvb2wgbV9k ZWZhdWx0SGFuZGxlZDsKICAgICAgICAgYm9vbCBtX2NhbmNlbEJ1YmJsZTsKKyNpZiBQTEFURk9S TShCTEFDS0JFUlJZKQorICAgICAgICBib29sIG1fcGx1Z2luSGFuZGxlZDsKKyNlbmRpZgogCiAg ICAgICAgIHVuc2lnbmVkIHNob3J0IG1fZXZlbnRQaGFzZTsKICAgICAgICAgRXZlbnRUYXJnZXQq IG1fY3VycmVudFRhcmdldDsK 136815 2012-04-11 20:10:54 -0700 2012-04-11 20:34:33 -0700 Patch bug-83456-20120412111651.patch text/plain 2688 charles.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzOTM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDU1MWM4MTYxNTBiYmVj MDliZWM3Yzc2OTAxMzdmYzgyMTczYWM3MC4uNzViNzc3MDkyMjU5MGYzNDY2ODZmMThkNzNmY2I0 ZjVjMWQ1NThhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA0LTExICBDaGFy bGVzIFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBbQmxh Y2tCZXJyeV0gUmV2ZXJ0IHRoZSBjaGFuZ2VzIHRoYXQgZGVwZW5kIG9uIEV2ZW50IGNoYW5nZXMs IHdoaWNoIGlzIHJldmVydGVkIGFscmVhZHkgaW50ZXJuYWxseS4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzNDU2CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBqdXN0IHRvIG1ha2Ug QmxhY2tCZXJyeS1wb3J0aW5nIHRvIGJ1aWxkLgorCisgICAgICAgICogcGx1Z2lucy9ibGFja2Jl cnJ5L1BsdWdpblZpZXdCbGFja0JlcnJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsdWdpblZp ZXc6OmhhbmRsZVdoZWVsRXZlbnQpOgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2luVmlldzo6aGFu ZGxlVG91Y2hFdmVudCk6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3OjpoYW5kbGVNb3Vz ZUV2ZW50KToKKwogMjAxMi0wNC0xMSAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4K IAogICAgICAgICBMYXlvdXQgVGVzdCB3ZWJhdWRpby8qIGlzIGZsYWt5CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbHVnaW5zL2JsYWNrYmVycnkvUGx1Z2luVmlld0JsYWNrQmVycnkuY3Bw IGIvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9ibGFja2JlcnJ5L1BsdWdpblZpZXdCbGFja0JlcnJ5 LmNwcAppbmRleCBjZjkyYjNjZGVhZDI2NmY5MDM0ZGJlOTgzOGE2NDZjMmRhZTlmZDY3Li5mNWJk NTAwYTRjYjBlNWZiZDY4M2NiZTE0MWE5MGQyN2JmZDdhNTA3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbHVnaW5zL2JsYWNrYmVycnkvUGx1Z2luVmlld0JsYWNrQmVycnkuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvYmxhY2tiZXJyeS9QbHVnaW5WaWV3QmxhY2tCZXJyeS5j cHAKQEAgLTQ3MywxMCArNDczLDggQEAgdm9pZCBQbHVnaW5WaWV3OjpoYW5kbGVXaGVlbEV2ZW50 KFdoZWVsRXZlbnQqIGV2ZW50KQogICAgIG5wRXZlbnQudHlwZSA9IE5QX1doZWVsRXZlbnQ7CiAg ICAgbnBFdmVudC5kYXRhID0gJndoZWVsRXZlbnQ7CiAKLSAgICBpZiAoZGlzcGF0Y2hOUEV2ZW50 KG5wRXZlbnQpKSB7CisgICAgaWYgKGRpc3BhdGNoTlBFdmVudChucEV2ZW50KSkKICAgICAgICAg ZXZlbnQtPnNldERlZmF1bHRIYW5kbGVkKCk7Ci0gICAgICAgIGV2ZW50LT5zZXRQbHVnaW5IYW5k bGVkKCk7Ci0gICAgfQogfQogCiB2b2lkIFBsdWdpblZpZXc6OmhhbmRsZVRvdWNoRXZlbnQoVG91 Y2hFdmVudCogZXZlbnQpCkBAIC01MzcsMTcgKzUzNSwxNCBAQCB2b2lkIFBsdWdpblZpZXc6Omhh bmRsZVRvdWNoRXZlbnQoVG91Y2hFdmVudCogZXZlbnQpCiAgICAgbnBFdmVudC50eXBlID0gTlBf VG91Y2hFdmVudDsKICAgICBucEV2ZW50LmRhdGEgPSAmbnBUb3VjaEV2ZW50OwogCi0gICAgaWYg KGRpc3BhdGNoTlBFdmVudChucEV2ZW50KSkgeworICAgIGlmIChkaXNwYXRjaE5QRXZlbnQobnBF dmVudCkpCiAgICAgICAgIGV2ZW50LT5zZXREZWZhdWx0SGFuZGxlZCgpOwotICAgICAgICBldmVu dC0+c2V0UGx1Z2luSGFuZGxlZCgpOwotICAgIH0gZWxzZSBpZiAobnBUb3VjaEV2ZW50LnR5cGUg PT0gVE9VQ0hfRVZFTlRfRE9VQkxFVEFQKSB7CisgICAgZWxzZSBpZiAobnBUb3VjaEV2ZW50LnR5 cGUgPT0gVE9VQ0hfRVZFTlRfRE9VQkxFVEFQKSB7CiAgICAgICAgIC8vIFNlbmQgVG91Y2ggVXAg aWYgZG91YmxlIHRhcCBub3QgY29uc3VtZWQKICAgICAgICAgbnBUb3VjaEV2ZW50LnR5cGUgPSBU T1VDSF9FVkVOVF9FTkQ7CiAgICAgICAgIG5wRXZlbnQuZGF0YSA9ICZucFRvdWNoRXZlbnQ7Ci0g ICAgICAgIGlmIChkaXNwYXRjaE5QRXZlbnQobnBFdmVudCkpIHsKKyAgICAgICAgaWYgKGRpc3Bh dGNoTlBFdmVudChucEV2ZW50KSkKICAgICAgICAgICAgIGV2ZW50LT5zZXREZWZhdWx0SGFuZGxl ZCgpOwotICAgICAgICAgICAgZXZlbnQtPnNldFBsdWdpbkhhbmRsZWQoKTsKLSAgICAgICAgfQog ICAgIH0KIH0KIApAQCAtNTg2LDEwICs1ODEsOCBAQCB2b2lkIFBsdWdpblZpZXc6OmhhbmRsZU1v dXNlRXZlbnQoTW91c2VFdmVudCogZXZlbnQpCiAgICAgbnBFdmVudC50eXBlID0gTlBfTW91c2VF dmVudDsKICAgICBucEV2ZW50LmRhdGEgPSAmbW91c2VFdmVudDsKIAotICAgIGlmIChkaXNwYXRj aE5QRXZlbnQobnBFdmVudCkpIHsKKyAgICBpZiAoZGlzcGF0Y2hOUEV2ZW50KG5wRXZlbnQpKQog ICAgICAgICBldmVudC0+c2V0RGVmYXVsdEhhbmRsZWQoKTsKLSAgICAgICAgZXZlbnQtPnNldFBs dWdpbkhhbmRsZWQoKTsKLSAgICB9CiB9CiAKIHZvaWQgUGx1Z2luVmlldzo6aGFuZGxlRm9jdXNJ bkV2ZW50KCkK