83447 2012-04-08 20:03:28 -0700 [Blackberry] m_isRequestedByPlugin should be copied in ResourceRequest 2012-04-11 00:54:32 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 logingx webkit-unassigned rwlbuis tonikitoo webkit.review.bot oldest_to_newest 598104 0 logingx 2012-04-08 20:03:28 -0700 Add m_isRequestedByPlugin in doPlatformCopyData(...) and doPlatformAdopt(...) in ResourceRequest. 598107 1 136172 logingx 2012-04-08 20:12:56 -0700 Created attachment 136172 Patch 598108 2 136173 logingx 2012-04-08 20:18:42 -0700 Created attachment 136173 Patch 598216 3 136173 webkit.review.bot 2012-04-09 03:33:39 -0700 Comment on attachment 136173 Patch Clearing flags on attachment: 136173 Committed r113569: <http://trac.webkit.org/changeset/113569> 598217 4 webkit.review.bot 2012-04-09 03:33:43 -0700 All reviewed patches have been landed. Closing bug. 598366 5 ap 2012-04-09 10:05:18 -0700 Keep in mind that this is a layering violation, so future WebCore refactorings can break your m_isRequestedByPlugin in unexpected ways. ResourceRequest is a network level abstraction, and it should not know anything about web concepts such as plug-ins. 600009 6 136173 tonikitoo 2012-04-10 21:26:21 -0700 Comment on attachment 136173 Patch I do not think this flag should even exist :( it was introduced to "fix" a bug in Flash, that it was starting a load in a new window when swapping/scrolling. It did not even fix the problem :/ Also this patch has parts in PluginView (iirc) that are not upstreamed, so they should get upstreamed all together. 600010 7 tonikitoo 2012-04-10 21:26:53 -0700 Please file a follow up bug to clean it up , as per mine and ap's comments. 600114 8 logingx 2012-04-11 00:54:32 -0700 I already added this in my task queue after AP had comments. I am following up. Actually we had a discussion internally related to this bug, I will add you in. 136172 2012-04-08 20:12:56 -0700 2012-04-08 20:18:24 -0700 Patch bug-83447-20120409111253.patch text/plain 2115 logingx U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDQ1NTdjNzhjOGVlZDU3 MjljNjU4Nzg3ZjBlOTgzMjRkMDUwYzUwMC4uZTRiNjZlOTM1MDQ0ZjJkMzY5ZmExNGU5YTFiMGJk OTViYWVkM2ZjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA0LTA4ICBDaHJp cyBHdWFuICA8Y2hyaXMuZ3VhbkB0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgW0JsYWNr YmVycnldIG1faXNSZXF1ZXN0ZWRCeVBsdWdpbiBzaG91bGQgYmUgY29waWVkIGluIFJlc291cmNl UmVxdWVzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 ODM0NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisg ICAgICAgIEl0IGlzIGFuIG9idmlvdXMgZXJyb3IsIFdlIHNob3VsZCBjb3B5IG1faXNSZXF1ZXN0 ZWRCeVBsdWdpbiBpbiBSZXNvdXJjZVJldWVzdC4gCisgICAgICAgIAorICAgICAgICBObyBuZXcg dGVzdHMsIGJlY2F1c2UgdGhvc2UgZXhpc3RpbmcgcGx1Z2luIHRlc3QgY2FzZXMgYXJlIGVub3Vn aC4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9SZXNvdXJjZVJlcXVl c3RCbGFja0JlcnJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdDo6ZG9Q bGF0Zm9ybUNvcHlEYXRhKToKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdDo6ZG9Q bGF0Zm9ybUFkb3B0KToKKwogMjAxMi0wNC0wOCAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FA d2Via2l0Lm9yZz4KIAogICAgICAgICBCdWlsZCBmaXggZm9yICFFTkFCTEUoQ1NTX0ZJTFRFUlMp ICYmIEFTU0VSVF9ESVNBQkxFRCBhZnRlciByMTA5OTUzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L1Jlc291cmNlUmVxdWVzdEJsYWNrQmVy cnkuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L1Jlc291 cmNlUmVxdWVzdEJsYWNrQmVycnkuY3BwCmluZGV4IDk3ZDZiMjg3Mjk3MTc1ZTdjYzk4OGQ0ODZh Njg3Mzg0NzAzZWQ3ODUuLjZhNzg5MGJmYjczYjM1ODExMTg0NDUwMTYwYThlNjc5ZTE4ZjFiMTAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9S ZXNvdXJjZVJlcXVlc3RCbGFja0JlcnJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL2JsYWNrYmVycnkvUmVzb3VyY2VSZXF1ZXN0QmxhY2tCZXJyeS5jcHAKQEAgLTIz MCw2ICsyMzAsNyBAQCBQYXNzT3duUHRyPENyb3NzVGhyZWFkUmVzb3VyY2VSZXF1ZXN0RGF0YT4g UmVzb3VyY2VSZXF1ZXN0Ojpkb1BsYXRmb3JtQ29weURhdGEoUAogICAgIGRhdGEtPm1fYW5jaG9y VGV4dCA9IG1fYW5jaG9yVGV4dDsKICAgICBkYXRhLT5tX2lzWE1MSFRUUFJlcXVlc3QgPSBtX2lz WE1MSFRUUFJlcXVlc3Q7CiAgICAgZGF0YS0+bV9tdXN0SGFuZGxlSW50ZXJuYWxseSA9IG1fbXVz dEhhbmRsZUludGVybmFsbHk7CisgICAgZGF0YS0+bV9pc1JlcXVlc3RlZEJ5UGx1Z2luID0gbV9p c1JlcXVlc3RlZEJ5UGx1Z2luOwogICAgIHJldHVybiBkYXRhOwogfQogCkBAIC0yMzksNiArMjQw LDcgQEAgdm9pZCBSZXNvdXJjZVJlcXVlc3Q6OmRvUGxhdGZvcm1BZG9wdChQYXNzT3duUHRyPENy b3NzVGhyZWFkUmVzb3VyY2VSZXF1ZXN0RGF0YT4KICAgICBtX2FuY2hvclRleHQgPSBkYXRhLT5t X2FuY2hvclRleHQ7CiAgICAgbV9pc1hNTEhUVFBSZXF1ZXN0ID0gZGF0YS0+bV9pc1hNTEhUVFBS ZXF1ZXN0OwogICAgIG1fbXVzdEhhbmRsZUludGVybmFsbHkgPSBkYXRhLT5tX211c3RIYW5kbGVJ bnRlcm5hbGx5OworICAgIG1faXNSZXF1ZXN0ZWRCeVBsdWdpbiA9IGRhdGEtPm1faXNSZXF1ZXN0 ZWRCeVBsdWdpbjsKICAgICBtX2ZvcmNlRG93bmxvYWQgPSBkYXRhLT5tX2ZvcmNlRG93bmxvYWQ7 CiB9CiAK 136173 2012-04-08 20:18:42 -0700 2012-04-10 21:26:21 -0700 Patch bug-83447-20120409111837.patch text/plain 2098 logingx U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDQ1NTdjNzhjOGVlZDU3 MjljNjU4Nzg3ZjBlOTgzMjRkMDUwYzUwMC4uNzc2MjYwYjJlNGRhNmQ1ZjI2MWY1NmNjNDYwY2Fh ZWVlNGI3NmZhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA0LTA4ICBDaHJp cyBHdWFuICA8Y2hyaXMuZ3VhbkB0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgW0JsYWNr YmVycnldIG1faXNSZXF1ZXN0ZWRCeVBsdWdpbiBzaG91bGQgYmUgY29waWVkIGluIFJlc291cmNl UmVxdWVzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 ODM0NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJ dCBpcyBhbiBvYnZpb3VzIGVycm9yLCBXZSBzaG91bGQgY29weSBtX2lzUmVxdWVzdGVkQnlQbHVn aW4gaW4gUmVzb3VyY2VSZXVlc3QuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBiZWNhdXNlIHRo b3NlIGV4aXN0aW5nIHBsdWdpbiB0ZXN0IGNhc2VzIGFyZSBlbm91Z2guCisKKyAgICAgICAgKiBw bGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvUmVzb3VyY2VSZXF1ZXN0QmxhY2tCZXJyeS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3Q6OmRvUGxhdGZvcm1Db3B5RGF0YSk6 CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3Q6OmRvUGxhdGZvcm1BZG9wdCk6CisK IDIwMTItMDQtMDggIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgQnVpbGQgZml4IGZvciAhRU5BQkxFKENTU19GSUxURVJTKSAmJiBBU1NFUlRfRElTQUJM RUQgYWZ0ZXIgcjEwOTk1My4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvYmxhY2tiZXJyeS9SZXNvdXJjZVJlcXVlc3RCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9SZXNvdXJjZVJlcXVlc3RCbGFja0Jl cnJ5LmNwcAppbmRleCA5N2Q2YjI4NzI5NzE3NWU3Y2M5ODhkNDg2YTY4NzM4NDcwM2VkNzg1Li42 YTc4OTBiZmI3M2IzNTgxMTE4NDQ1MDE2MGE4ZTY3OWUxOGYxYjEwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvUmVzb3VyY2VSZXF1ZXN0Qmxh Y2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2Jl cnJ5L1Jlc291cmNlUmVxdWVzdEJsYWNrQmVycnkuY3BwCkBAIC0yMzAsNiArMjMwLDcgQEAgUGFz c093blB0cjxDcm9zc1RocmVhZFJlc291cmNlUmVxdWVzdERhdGE+IFJlc291cmNlUmVxdWVzdDo6 ZG9QbGF0Zm9ybUNvcHlEYXRhKFAKICAgICBkYXRhLT5tX2FuY2hvclRleHQgPSBtX2FuY2hvclRl eHQ7CiAgICAgZGF0YS0+bV9pc1hNTEhUVFBSZXF1ZXN0ID0gbV9pc1hNTEhUVFBSZXF1ZXN0Owog ICAgIGRhdGEtPm1fbXVzdEhhbmRsZUludGVybmFsbHkgPSBtX211c3RIYW5kbGVJbnRlcm5hbGx5 OworICAgIGRhdGEtPm1faXNSZXF1ZXN0ZWRCeVBsdWdpbiA9IG1faXNSZXF1ZXN0ZWRCeVBsdWdp bjsKICAgICByZXR1cm4gZGF0YTsKIH0KIApAQCAtMjM5LDYgKzI0MCw3IEBAIHZvaWQgUmVzb3Vy Y2VSZXF1ZXN0Ojpkb1BsYXRmb3JtQWRvcHQoUGFzc093blB0cjxDcm9zc1RocmVhZFJlc291cmNl UmVxdWVzdERhdGE+CiAgICAgbV9hbmNob3JUZXh0ID0gZGF0YS0+bV9hbmNob3JUZXh0OwogICAg IG1faXNYTUxIVFRQUmVxdWVzdCA9IGRhdGEtPm1faXNYTUxIVFRQUmVxdWVzdDsKICAgICBtX211 c3RIYW5kbGVJbnRlcm5hbGx5ID0gZGF0YS0+bV9tdXN0SGFuZGxlSW50ZXJuYWxseTsKKyAgICBt X2lzUmVxdWVzdGVkQnlQbHVnaW4gPSBkYXRhLT5tX2lzUmVxdWVzdGVkQnlQbHVnaW47CiAgICAg bV9mb3JjZURvd25sb2FkID0gZGF0YS0+bV9mb3JjZURvd25sb2FkOwogfQogCg==