83444 2012-04-08 18:12:26 -0700 combine two arrays in SVGException.cpp into one 2012-04-09 22:36:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 83441 0 guanqun.lu webkit-unassigned abarth haraken webkit.review.bot oldest_to_newest 598086 0 guanqun.lu 2012-04-08 18:12:26 -0700 combine two arrays in SVGException.cpp into one, this helps to fix one FIXME in the file. 598087 1 136166 guanqun.lu 2012-04-08 18:14:09 -0700 Created attachment 136166 Patch 599017 2 136166 webkit.review.bot 2012-04-09 22:36:55 -0700 Comment on attachment 136166 Patch Clearing flags on attachment: 136166 Committed r113680: <http://trac.webkit.org/changeset/113680> 599018 3 webkit.review.bot 2012-04-09 22:36:59 -0700 All reviewed patches have been landed. Closing bug. 136166 2012-04-08 18:14:09 -0700 2012-04-09 22:36:55 -0700 Patch 0001-combine-two-arrays-in-SVGException.cpp-into-one.patch text/plain 3326 guanqun.lu RnJvbSBjNjdmNjhhM2E2ZjE4NWNkYWE0MjgwZjU0NjQ4YTYwMjgzOTBiYzdlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMdSBHdWFucXVuIDxndWFucXVuLmx1QGludGVsLmNvbT4KRGF0 ZTogTW9uLCA5IEFwciAyMDEyIDA5OjEzOjAxICswODAwClN1YmplY3Q6IFtQQVRDSF0gY29tYmlu ZSB0d28gYXJyYXlzIGluIFNWR0V4Y2VwdGlvbi5jcHAgaW50byBvbmUKCi0tLQogU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgfCAgIDE0ICsrKysrKysrKysrKysrCiBTb3VyY2Uv V2ViQ29yZS9zdmcvU1ZHRXhjZXB0aW9uLmNwcCB8ICAgMjYgKysrKysrKysrKy0tLS0tLS0tLS0t LS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCmluZGV4IGI1YzA1NDguLmY3ZjMwZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NyBAQAorMjAxMi0wNC0wOCAgTHUgR3VhbnF1biAgPGd1YW5xdW4ubHVAaW50ZWwuY29tPgorCisg ICAgICAgIGNvbWJpbmUgdHdvIGFycmF5cyBpbiBTVkdFeGNlcHRpb24uY3BwIGludG8gb25lCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzQ0NAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cyByZXF1aXJlZC4KKworICAgICAgICAqIHN2Zy9TVkdFeGNlcHRpb24uY3BwOgorICAgICAgICAo U1ZHRXhjZXB0aW9uTmFtZURlc2NyaXB0aW9uKToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAg ICAoV2ViQ29yZTo6U1ZHRXhjZXB0aW9uOjppbml0aWFsaXplRGVzY3JpcHRpb24pOgorCiAyMDEy LTA0LTA1ICBMdSBHdWFucXVuICA8Z3VhbnF1bi5sdUBpbnRlbC5jb20+CiAKICAgICAgICAgY29t YmluZSB0d28gYXJyYXlzIChjb3JlRXhjZXB0aW9uTmFtZXMgYW5kIGNvcmVFeGNlcHRpb25EZXNj cmlwdGlvbnMpIGludG8gb25lIGFycmF5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdmcv U1ZHRXhjZXB0aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdFeGNlcHRpb24uY3BwCmlu ZGV4IGMwY2Q0YjguLjRmNGI4NDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdF eGNlcHRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdFeGNlcHRpb24uY3BwCkBA IC0zNCwyMSArMzQsMTUgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi0vLyBGSVhNRTogVGhp cyBzaG91bGQgYmUgYW4gYXJyYXkgb2Ygc3RydWN0cyB0byBwYWlyIHRoZSBuYW1lcyBhbmQgZGVz Y3JpcHRpb25zLgotc3RhdGljIGNvbnN0IGNoYXIqIGNvbnN0IGV4Y2VwdGlvbk5hbWVzW10gPSB7 Ci0gICAgIlNWR19XUk9OR19UWVBFX0VSUiIsCi0gICAgIlNWR19JTlZBTElEX1ZBTFVFX0VSUiIs Ci0gICAgIlNWR19NQVRSSVhfTk9UX0lOVkVSVEFCTEUiCitzdGF0aWMgc3RydWN0IFNWR0V4Y2Vw dGlvbk5hbWVEZXNjcmlwdGlvbiB7CisgICAgY29uc3QgY2hhciogY29uc3QgbmFtZTsKKyAgICBj b25zdCBjaGFyKiBjb25zdCBkZXNjcmlwdGlvbjsKK30gZXhjZXB0aW9uc1tdID0geworICAgIHsg IlNWR19XUk9OR19UWVBFX0VSUiIsICJBbiBvYmplY3Qgb2YgdGhlIHdyb25nIHR5cGUgd2FzIHBh c3NlZCB0byBhbiBvcGVyYXRpb24uIiB9LAorICAgIHsgIlNWR19JTlZBTElEX1ZBTFVFX0VSUiIs ICJBbiBpbnZhbGlkIHZhbHVlIHdhcyBwYXNzZWQgdG8gYW4gb3BlcmF0aW9uIG9yIGFzc2lnbmVk IHRvIGFuIGF0dHJpYnV0ZS4iIH0sCisgICAgeyAiU1ZHX01BVFJJWF9OT1RfSU5WRVJUQUJMRSIs ICJBbiBhdHRlbXB0IHdhcyBtYWRlIHRvIGludmVydCBhIG1hdHJpeCB0aGF0IGlzIG5vdCBpbnZl cnRpYmxlLiIgfQogfTsKIAotc3RhdGljIGNvbnN0IGNoYXIqIGNvbnN0IGV4Y2VwdGlvbkRlc2Ny aXB0aW9uc1tdID0gewotICAgICJBbiBvYmplY3Qgb2YgdGhlIHdyb25nIHR5cGUgd2FzIHBhc3Nl ZCB0byBhbiBvcGVyYXRpb24uIiwKLSAgICAiQW4gaW52YWxpZCB2YWx1ZSB3YXMgcGFzc2VkIHRv IGFuIG9wZXJhdGlvbiBvciBhc3NpZ25lZCB0byBhbiBhdHRyaWJ1dGUuIiwKLSAgICAiQW4gYXR0 ZW1wdCB3YXMgbWFkZSB0byBpbnZlcnQgYSBtYXRyaXggdGhhdCBpcyBub3QgaW52ZXJ0aWJsZS4i Ci19OwotCi1DT01QSUxFX0FTU0VSVChXVEZfQVJSQVlfTEVOR1RIKGV4Y2VwdGlvbk5hbWVzKSA9 PSBXVEZfQVJSQVlfTEVOR1RIKGV4Y2VwdGlvbkRlc2NyaXB0aW9ucyksIFNWR0V4Y2VwdGlvblRh Ymxlc011c3RNYXRjaCk7Ci0KIGJvb2wgU1ZHRXhjZXB0aW9uOjppbml0aWFsaXplRGVzY3JpcHRp b24oRXhjZXB0aW9uQ29kZSBlYywgRXhjZXB0aW9uQ29kZURlc2NyaXB0aW9uKiBkZXNjcmlwdGlv bikKIHsKICAgICBpZiAoZWMgPCBTVkdFeGNlcHRpb25PZmZzZXQgfHwgZWMgPiBTVkdFeGNlcHRp b25NYXgpCkBAIC01OCwxMSArNTIsMTEgQEAgYm9vbCBTVkdFeGNlcHRpb246OmluaXRpYWxpemVE ZXNjcmlwdGlvbihFeGNlcHRpb25Db2RlIGVjLCBFeGNlcHRpb25Db2RlRGVzY3JpcHQKICAgICBk ZXNjcmlwdGlvbi0+Y29kZSA9IGVjIC0gU1ZHRXhjZXB0aW9uT2Zmc2V0OwogICAgIGRlc2NyaXB0 aW9uLT50eXBlID0gU1ZHRXhjZXB0aW9uVHlwZTsKIAotICAgIHNpemVfdCB0YWJsZVNpemUgPSBX VEZfQVJSQVlfTEVOR1RIKGV4Y2VwdGlvbk5hbWVzKTsKKyAgICBzaXplX3QgdGFibGVTaXplID0g V1RGX0FSUkFZX0xFTkdUSChleGNlcHRpb25zKTsKICAgICBzaXplX3QgdGFibGVJbmRleCA9IGVj IC0gU1ZHX1dST05HX1RZUEVfRVJSOwogCi0gICAgZGVzY3JpcHRpb24tPm5hbWUgPSB0YWJsZUlu ZGV4IDwgdGFibGVTaXplID8gZXhjZXB0aW9uTmFtZXNbdGFibGVJbmRleF0gOiAwOwotICAgIGRl c2NyaXB0aW9uLT5kZXNjcmlwdGlvbiA9IHRhYmxlSW5kZXggPCB0YWJsZVNpemUgPyBleGNlcHRp b25EZXNjcmlwdGlvbnNbdGFibGVJbmRleF0gOiAwOworICAgIGRlc2NyaXB0aW9uLT5uYW1lID0g dGFibGVJbmRleCA8IHRhYmxlU2l6ZSA/IGV4Y2VwdGlvbnNbdGFibGVJbmRleF0ubmFtZSA6IDA7 CisgICAgZGVzY3JpcHRpb24tPmRlc2NyaXB0aW9uID0gdGFibGVJbmRleCA8IHRhYmxlU2l6ZSA/ IGV4Y2VwdGlvbnNbdGFibGVJbmRleF0uZGVzY3JpcHRpb24gOiAwOwogCiAgICAgcmV0dXJuIHRy dWU7CiB9Ci0tIAoxLjcuNy42Cgo=