83429 2012-04-07 21:20:10 -0700 Remove unused data member from Lexer class 2012-04-10 14:12:37 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 darin darin haraken webkit.review.bot oldest_to_newest 598018 0 darin 2012-04-07 21:20:10 -0700 Remove unused data member from Lexer class 598019 1 136144 darin 2012-04-07 21:21:09 -0700 Created attachment 136144 Patch 599625 2 136144 webkit.review.bot 2012-04-10 14:12:32 -0700 Comment on attachment 136144 Patch Clearing flags on attachment: 136144 Committed r113765: <http://trac.webkit.org/changeset/113765> 599626 3 webkit.review.bot 2012-04-10 14:12:37 -0700 All reviewed patches have been landed. Closing bug. 136144 2012-04-07 21:21:09 -0700 2012-04-10 14:12:32 -0700 Patch bug-83429-20120407212108.patch text/plain 4162 darin SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTEzNTUwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDEyLTA0LTA3ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBS ZW1vdmUgdW51c2VkIGRhdGEgbWVtYmVyIGZyb20gTGV4ZXIgY2xhc3MKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzNDI5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSSBub3RpY2VkIHRoYXQgbV9kZWxpbWl0 ZWQgd2FzICJ3cml0ZS1vbmx5Iiwgc28gSSBkZWxldGVkIGl0LgorCisgICAgICAgICogcGFyc2Vy L0xleGVyLmNwcDoKKyAgICAgICAgKEpTQzo6TGV4ZXI6OnNldENvZGUpOiBSZW1vdmVkIGNvZGUg dG8gc2V0IG1fZGVsaW1pdGVkLgorICAgICAgICAoSlNDOjpMZXhlcjo6cGFyc2VJZGVudGlmaWVy KTogRGl0dG8uCisgICAgICAgIChKU0M6OkxleGVyOjpwYXJzZUlkZW50aWZpZXJTbG93Q2FzZSk6 IERpdHRvLgorICAgICAgICAoSlNDOjpMZXhlcjo6bGV4KTogRGl0dG8uCisgICAgICAgICogcGFy c2VyL0xleGVyLmg6IERlbGV0ZWQgbV9kZWxpbWl0ZWQuCisKIDIwMTItMDQtMDYgIEJlbmphbWlu IFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgRG8gbm90IGFidXNlIEFy cmF5U3RvcmFnZSdzIG1fbGVuZ3RoIGZvciB0ZXN0aW5nIGFycmF5IGNvbnNpc3RlbmN5CkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL0xleGVyLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL0xleGVyLmNwcAkocmV2aXNpb24gMTEzNTQ5KQor KysgU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9MZXhlci5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTQwMyw3ICs0MDMsNiBAQCB2b2lkIExleGVyPFQ+OjpzZXRDb2RlKGNvbnN0IFNvdXJjZUNv ZGUmCiAgICAgbV9hcmVuYSA9ICZhcmVuYS0+aWRlbnRpZmllckFyZW5hKCk7CiAgICAgCiAgICAg bV9saW5lTnVtYmVyID0gc291cmNlLmZpcnN0TGluZSgpOwotICAgIG1fZGVsaW1pdGVkID0gZmFs c2U7CiAgICAgbV9sYXN0VG9rZW4gPSAtMTsKICAgICAKICAgICBjb25zdCBTdHJpbmdJbXBsKiBz b3VyY2VTdHJpbmcgPSBzb3VyY2UucHJvdmlkZXIoKS0+ZGF0YSgpOwpAQCAtNjY1LDggKzY2NCw2 IEBAIHRlbXBsYXRlIDw+CiAgICAgfSBlbHNlCiAgICAgICAgIHRva2VuRGF0YS0+aWRlbnQgPSAw OwogCi0gICAgbV9kZWxpbWl0ZWQgPSBmYWxzZTsKLQogICAgIGlmIChVTkxJS0VMWSgocmVtYWlu aW5nIDwgbWF4VG9rZW5MZW5ndGgpICYmICEobGV4ZXJGbGFncyAmIExleGVyRmxhZ3NJZ25vcmVS ZXNlcnZlZFdvcmRzKSkpIHsKICAgICAgICAgQVNTRVJUKHNob3VsZENyZWF0ZUlkZW50aWZpZXIp OwogICAgICAgICBpZiAocmVtYWluaW5nIDwgbWF4VG9rZW5MZW5ndGgpIHsKQEAgLTcyNiw4ICs3 MjMsNiBAQCB0ZW1wbGF0ZSA8Ym9vbCBzaG91bGRDcmVhdGVJZGVudGlmaWVyPiBBCiAgICAgfSBl bHNlCiAgICAgICAgIHRva2VuRGF0YS0+aWRlbnQgPSAwOwogICAgIAotICAgIG1fZGVsaW1pdGVk ID0gZmFsc2U7Ci0gICAgCiAgICAgaWYgKFVOTElLRUxZKChyZW1haW5pbmcgPCBtYXhUb2tlbkxl bmd0aCkgJiYgIShsZXhlckZsYWdzICYgTGV4ZXJGbGFnc0lnbm9yZVJlc2VydmVkV29yZHMpKSkg ewogICAgICAgICBBU1NFUlQoc2hvdWxkQ3JlYXRlSWRlbnRpZmllcik7CiAgICAgICAgIGlmIChy ZW1haW5pbmcgPCBtYXhUb2tlbkxlbmd0aCkgewpAQCAtNzk0LDggKzc4OSw2IEBAIHRlbXBsYXRl IDxib29sIHNob3VsZENyZWF0ZUlkZW50aWZpZXI+IEoKICAgICB9IGVsc2UKICAgICAgICAgdG9r ZW5EYXRhLT5pZGVudCA9IDA7CiAKLSAgICBtX2RlbGltaXRlZCA9IGZhbHNlOwotCiAgICAgaWYg KExJS0VMWSghYnVmZmVyUmVxdWlyZWQgJiYgIShsZXhlckZsYWdzICYgTGV4ZXJGbGFnc0lnbm9y ZVJlc2VydmVkV29yZHMpKSkgewogICAgICAgICBBU1NFUlQoc2hvdWxkQ3JlYXRlSWRlbnRpZmll cik7CiAgICAgICAgIC8vIEtleXdvcmRzIG11c3Qgbm90IGJlIHJlY29nbml6ZWQgaWYgdGhlcmUg d2FzIGFuIFx1WFhYWCBpbiB0aGUgaWRlbnRpZmllci4KQEAgLTExOTIsOCArMTE4NSw2IEBAIHN0 YXJ0OgogICAgIGlmIChVTkxJS0VMWShtX2N1cnJlbnQgPT0gLTEpKQogICAgICAgICByZXR1cm4g RU9GVE9LOwogCi0gICAgbV9kZWxpbWl0ZWQgPSBmYWxzZTsKLQogICAgIENoYXJhY3RlclR5cGUg dHlwZTsKICAgICBpZiAoTElLRUxZKGlzTGF0aW4xKHN0YXRpY19jYXN0PFQ+KG1fY3VycmVudCkp KSkKICAgICAgICAgdHlwZSA9IHN0YXRpY19jYXN0PENoYXJhY3RlclR5cGU+KHR5cGVzT2ZMYXRp bjFDaGFyYWN0ZXJzW21fY3VycmVudF0pOwpAQCAtMTQyNSw3ICsxNDE2LDYgQEAgc3RhcnQ6CiAg ICAgICAgIHNoaWZ0KCk7CiAgICAgICAgIGJyZWFrOwogICAgIGNhc2UgQ2hhcmFjdGVyU2VtaWNv bG9uOgotICAgICAgICBtX2RlbGltaXRlZCA9IHRydWU7CiAgICAgICAgIHNoaWZ0KCk7CiAgICAg ICAgIHRva2VuID0gU0VNSUNPTE9OOwogICAgICAgICBicmVhazsKQEAgLTE0MzYsNyArMTQyNiw2 IEBAIHN0YXJ0OgogICAgICAgICBicmVhazsKICAgICBjYXNlIENoYXJhY3RlckNsb3NlQnJhY2U6 CiAgICAgICAgIHRva2VuRGF0YS0+aW50VmFsdWUgPSBjdXJyZW50T2Zmc2V0KCk7Ci0gICAgICAg IG1fZGVsaW1pdGVkID0gdHJ1ZTsKICAgICAgICAgc2hpZnQoKTsKICAgICAgICAgdG9rZW4gPSBD TE9TRUJSQUNFOwogICAgICAgICBicmVhazsKQEAgLTE0OTEsNyArMTQ4MCw2IEBAIGluTnVtYmVy QWZ0ZXJEZWNpbWFsUG9pbnQ6CiAgICAgICAgICAgICBnb3RvIHJldHVybkVycm9yOwogICAgICAg ICB9CiAgICAgICAgIG1fYnVmZmVyOC5yZXNpemUoMCk7Ci0gICAgICAgIG1fZGVsaW1pdGVkID0g ZmFsc2U7CiAgICAgICAgIGJyZWFrOwogICAgIGNhc2UgQ2hhcmFjdGVyUXVvdGU6CiAgICAgICAg IGlmIChsZXhlckZsYWdzICYgTGV4ZXJGbGFnc0RvbnRCdWlsZFN0cmluZ3MpIHsKQEAgLTE1MDIs NyArMTQ5MCw2IEBAIGluTnVtYmVyQWZ0ZXJEZWNpbWFsUG9pbnQ6CiAgICAgICAgICAgICAgICAg Z290byByZXR1cm5FcnJvcjsKICAgICAgICAgfQogICAgICAgICBzaGlmdCgpOwotICAgICAgICBt X2RlbGltaXRlZCA9IGZhbHNlOwogICAgICAgICB0b2tlbiA9IFNUUklORzsKICAgICAgICAgYnJl YWs7CiAgICAgY2FzZSBDaGFyYWN0ZXJJZGVudGlmaWVyU3RhcnQ6CkBAIC0xNTQ1LDcgKzE1MzIs NiBAQCBpblNpbmdsZUxpbmVDb21tZW50OgogICAgICAgICBnb3RvIHN0YXJ0OwogCiAgICAgdG9r ZW4gPSBTRU1JQ09MT047Ci0gICAgbV9kZWxpbWl0ZWQgPSB0cnVlOwogICAgIC8vIEZhbGwgdGhy b3VnaCBpbnRvIHJldHVyblRva2VuLgogCiByZXR1cm5Ub2tlbjoKSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9wYXJzZXIvTGV4ZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvcGFyc2VyL0xleGVyLmgJKHJldmlzaW9uIDExMzU0OSkKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9wYXJzZXIvTGV4ZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMTcxLDcgKzE3MSw2IEBA IHByaXZhdGU6CiAgICAgVmVjdG9yPExDaGFyPiBtX2J1ZmZlcjg7CiAgICAgVmVjdG9yPFVDaGFy PiBtX2J1ZmZlcjE2OwogICAgIGJvb2wgbV90ZXJtaW5hdG9yOwotICAgIGJvb2wgbV9kZWxpbWl0 ZWQ7IC8vIGVuY291bnRlcmVkIGRlbGltaXRlciBsaWtlICInIiBhbmQgIn0iIG9uIGxhc3QgcnVu CiAgICAgaW50IG1fbGFzdFRva2VuOwogCiAgICAgY29uc3QgU291cmNlQ29kZSogbV9zb3VyY2U7 Cg==