83412 2012-04-06 16:48:14 -0700 check-webkit-style should ignore NULL usage in gtk_style_context_get_style 2012-04-09 02:48:51 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson abarth dpranke levin ojan webkit.review.bot oldest_to_newest 597812 0 mrobinson 2012-04-06 16:48:14 -0700 NULL usage is required for use as a sentinal for a variable argument list in gtk_style_context_get_style, so check-webkit-style should ignore it. 597817 1 136098 mrobinson 2012-04-06 16:51:39 -0700 Created attachment 136098 Patch 597900 2 136098 mrobinson 2012-04-06 19:10:01 -0700 Comment on attachment 136098 Patch Thanks for the review! 598196 3 136098 webkit.review.bot 2012-04-09 02:48:46 -0700 Comment on attachment 136098 Patch Clearing flags on attachment: 136098 Committed r113565: <http://trac.webkit.org/changeset/113565> 598197 4 webkit.review.bot 2012-04-09 02:48:51 -0700 All reviewed patches have been landed. Closing bug. 136098 2012-04-06 16:51:39 -0700 2012-04-09 02:48:46 -0700 Patch bug-83412-20120406165138.patch text/plain 2758 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNDc0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzdlMzU0MjJhNGM5MGI2NWM2ZGYzYmU4NTlhNzcxODY2 MmRiNDdkNS4uNjI0OGE5NWFkOGJiOTYxNjY0ZjQzMDljOWRkOWQwMmNhNjNhZjQ0NiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTA0LTA2ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4K KworICAgICAgICBjaGVjay13ZWJraXQtc3R5bGUgc2hvdWxkIGlnbm9yZSBOVUxMIHVzYWdlIGlu IGd0a19zdHlsZV9jb250ZXh0X2dldF9zdHlsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODM0MTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBY2NlcHQgTlVMTCBhcyBhbiBhcmd1bWVudCBmb3IgZ3RrX3N0 eWxlX2NvbnRleHRfZ2V0X3N0eWxlLCBiZWNhdXNlIGl0J3MKKyAgICAgICAgdXNlZCBhcyBhIHNl bnRpbmVsIGluIGEgdmFyaWFibGUgYXJndW1lbnQgbGlzdC4gCisKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weToKKyAgICAgICAgKGNoZWNrX2Zvcl9udWxs KTogQWRkIGFuIGV4Y2VwdGlvbi4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2No ZWNrZXJzL2NwcF91bml0dGVzdC5weToKKyAgICAgICAgKFdlYktpdFN0eWxlVGVzdC50ZXN0X251 bGxfZmFsc2VfemVybyk6IEFkZCBhIHRlc3QgZm9yIHRoZSBleGNlcHRpb24uCisKIDIwMTItMDQt MDYgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICA8cmRhcjovL3By b2JsZW0vMTA5MTI0NzY+IEhpRFBJOiBIYXZlIGNhbnZhcyB1c2UgYSBoaWRwaSBiYWNraW5nIHN0 b3JlLCBidXQgZG93bnNhbXBsZSB1cG9uIGFjY2VzcwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3N0eWxlL2NoZWNrZXJzL2NwcC5weQppbmRleCBmODk4NzBjZWQxNzcwNjlmZWQ1M2ZkMDdjMjQy ZDA1ZGFhNGIwZDQ4Li4yYzMxYTVkYzNkMzQwMTBjY2RjMDg3ZWM5NzBhOTVkYWIyNzM4OTQ0IDEw MDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQor KysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQpAQCAtMjQz Myw4ICsyNDMzLDggQEAgZGVmIGNoZWNrX2Zvcl9udWxsKGNsZWFuX2xpbmVzLCBsaW5lX251bWJl ciwgZmlsZV9zdGF0ZSwgZXJyb3IpOgogICAgIGlmIHNlYXJjaChyJ1xiZ2RrX3BpeGJ1Zl9zYXZl X3RvXHcrXGInLCBsaW5lKToKICAgICAgICAgcmV0dXJuCiAKLSAgICAjIERvbid0IHdhcm4gYWJv dXQgTlVMTCB1c2FnZSBpbiBndGtfd2lkZ2V0X3N0eWxlX2dldCgpLiBTZWUgQnVnIDUxNzU4Lgot ICAgIGlmIHNlYXJjaChyJ1xiZ3RrX3dpZGdldF9zdHlsZV9nZXRcKFx3K1xiJywgbGluZSk6Cisg ICAgIyBEb24ndCB3YXJuIGFib3V0IE5VTEwgdXNhZ2UgaW4gZ3RrX3dpZGdldF9zdHlsZV9nZXQo KSBvciBndGtfc3R5bGVfY29udGV4dF9nZXRfc3R5bGUuIFNlZSBCdWcgNTE3NTgKKyAgICBpZiBz ZWFyY2gocidcYmd0a193aWRnZXRfc3R5bGVfZ2V0XChcdytcYicsIGxpbmUpIG9yIHNlYXJjaChy J1xiZ3RrX3N0eWxlX2NvbnRleHRfZ2V0X3N0eWxlXChcdytcYicsIGxpbmUpOgogICAgICAgICBy ZXR1cm4KIAogICAgICMgRG9uJ3Qgd2FybiBhYm91dCBOVUxMIHVzYWdlIGluIHNvdXBfc2VydmVy X25ldygpLiBTZWUgQnVnIDc3ODkwLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQppbmRleCA5Mzk0NzhjNDQyMTk2NDk1ODU4 MDFmYjdmOWQxMWQ4NjAzZTAyMGI2Li5jYmE5MTcxMDg1MDkwMzM0YWM0Y2NjYzRhYzg2ZjIyMjMy MzczMTEyIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJz L2NwcF91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNr ZXJzL2NwcF91bml0dGVzdC5weQpAQCAtNDI2OCw2ICs0MjY4LDkgQEAgY2xhc3MgV2ViS2l0U3R5 bGVUZXN0KENwcFN0eWxlVGVzdEJhc2UpOgogICAgICAgICAgICAgJ2d0a193aWRnZXRfc3R5bGVf Z2V0KHN0eWxlLCAicHJvcGVydHlOYW1lIiwgJnZhbHVlLCAib3RoZXJOYW1lIiwgJm90aGVyVmFs dWUsIE5VTEwpOycsCiAgICAgICAgICAgICAnJykKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgK KyAgICAgICAgICAgICdndGtfc3R5bGVfY29udGV4dF9nZXRfc3R5bGUoY29udGV4dCwgInByb3Bl cnR5TmFtZSIsICZ2YWx1ZSwgIm90aGVyTmFtZSIsICZvdGhlclZhbHVlLCBOVUxMKTsnLAorICAg ICAgICAgICAgJycpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoCiAgICAgICAgICAgICAnZ3Rr X3dpZGdldF9zdHlsZV9nZXRfcHJvcGVydHkoc3R5bGUsIE5VTEwsIE5VTEwpOycsCiAgICAgICAg ICAgICAnVXNlIDAgaW5zdGVhZCBvZiBOVUxMLiAgW3JlYWRhYmlsaXR5L251bGxdIFs1XScsCiAg ICAgICAgICAgICAnZm9vLmNwcCcpCg==