83403 2012-04-06 15:33:10 -0700 Do not abuse ArrayStorage's m_length for testing array consistency 2012-04-06 18:12:25 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 benjamin benjamin barraclough ggaren oldest_to_newest 597735 0 benjamin 2012-04-06 15:33:10 -0700 Do not abuse ArrayStorage's m_length for testing array consistency. Doing so forces the compiler to maintain two counters and increment both. 597736 1 benjamin 2012-04-06 15:34:21 -0700 Related to <rdar://problem/11197244> 597748 2 136077 benjamin 2012-04-06 15:43:14 -0700 Created attachment 136077 Patch 597784 3 136077 ggaren 2012-04-06 16:09:06 -0700 Comment on attachment 136077 Patch r=me 597873 4 benjamin 2012-04-06 18:12:25 -0700 Committed r113530: <http://trac.webkit.org/changeset/113530> 136077 2012-04-06 15:43:14 -0700 2012-04-06 16:09:06 -0700 Patch bug-83403-20120406154313.patch text/plain 7027 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMzk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk YjBiZDI4MGExMWFiOTEyOGE4MjkzNzM4ZmQ4YTEzZWY0M2U4NTBlLi44YTE2NGFkMDc1NmQ0Nzky MTI5ODE2ZTVjYmYyZTZiNzNkOTU5YjNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSw0MCBAQAorMjAxMi0wNC0wNiAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBEbyBub3QgYWJ1c2UgQXJyYXlTdG9yYWdlJ3MgbV9sZW5ndGggZm9y IHRlc3RpbmcgYXJyYXkgY29uc2lzdGVuY3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTgzNDAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQXJyYXkgY3JlYXRpb24gZnJvbSBhIGxpc3Qgb2YgdmFsdWVzIGlz IGEgMyBzdGVwcyBwcm9jZXNzOgorICAgICAgICAtSlNBcnJheTo6dHJ5Q3JlYXRlVW5pbml0aWFs aXplZCgpCisgICAgICAgIC1KU0FycmF5Ojppbml0aWFsaXplSW5kZXgoKSBmb3IgZWFjaCB2YWx1 ZXMKKyAgICAgICAgLUpTQXJyYXk6OmNvbXBsZXRlSW5pdGlhbGl6YXRpb24oKQorCisgICAgICAg IFByZXZpb3VzbHksIHRoZSBhdHRyaWJ1dGUgbV9sZW5ndGggd2FzIG5vdCBzZXQgdG8gdGhlIGZp bmFsIHNpemUKKyAgICAgICAgSlNBcnJheTo6dHJ5Q3JlYXRlVW5pbml0aWFsaXplZCgpIGJlY2F1 c2UgaXQgd2FzIHVzZWQgdG8gdGVzdCB0aGUgYXJyYXkKKyAgICAgICAgY29uc2lzdGVuY3kgSlNB cnJheTo6aW5pdGlhbGl6ZUluZGV4KCkuCisKKyAgICAgICAgVGhpcyBjYXVzZWQgdGhlIGluaXRp YWxpemF0aW9uIGxvb3AgdXNpbmcgSlNBcnJheTo6aW5pdGlhbGl6ZUluZGV4KCkgbWFpbnRhaW4K KyAgICAgICAgdHdvIGNvdW50ZXJzOgorICAgICAgICAtaW5kZXggb2YgdGhlIGxvb3AKKyAgICAg ICAgLXN0b3JhZ2UtPm1fbGVuZ3RoKysKKworICAgICAgICBUaGlzIHBhdGNoIGZpeGVzIHRoaXMg YnkgdXNpbmcgdGhlIGluZGV4IG9mIHRoZSBpbml0aWFsaXphdGlvbiBsb29wIGZvciB0aGUgaW5k aW5jZXMgb2YKKyAgICAgICAgSlNBcnJheTo6aW5pdGlhbGl6ZUluZGV4KCkuIEZvciB0ZXN0aW5n IGNvbnNpc3RlbmN5LCB0aGUgdmFyaWFibGUgbV9pbml0aWFsaXphdGlvbkluZGV4CisgICAgICAg IGlzIGludHJvZHVjZWQgaWYgQ0hFQ0tfQVJSQVlfQ09OU0lTVEVOQ1kgaXMgZGVmaW5lZC4KKwor ICAgICAgICBUaGUgcGF0Y2ggYWxzbyBmaXhlcyBtaW5vciB1bnJlbGF0ZWQgYnVpbGQgaXNzdWUg d2hlbiBDSEVDS19BUlJBWV9DT05TSVNURU5DWSBpcyBkZWZpbmVkLgorCisgICAgICAgIFRoaXMg aW1wcm92ZXMgdGhlIHBlcmZvcm1hbmNlIG9mIEpTQXJyYXkgY3JlYXRpb24gZnJvbSBsaXRlcmFs cyBieSA4JS4KKworICAgICAgICAqIHJ1bnRpbWUvSlNBcnJheS5jcHA6CisgICAgICAgIChKU0M6 OkpTQXJyYXk6OnRyeUZpbmlzaENyZWF0aW9uVW5pbml0aWFsaXplZCk6CisgICAgICAgIChKU0M6 OkpTQXJyYXk6OmNoZWNrQ29uc2lzdGVuY3kpOgorICAgICAgICAqIHJ1bnRpbWUvSlNBcnJheS5o OgorICAgICAgICAoQXJyYXlTdG9yYWdlKToKKyAgICAgICAgKEpTQzo6SlNBcnJheTo6aW5pdGlh bGl6ZUluZGV4KToKKyAgICAgICAgKEpTQzo6SlNBcnJheTo6Y29tcGxldGVJbml0aWFsaXphdGlv bik6CisKIDIwMTItMDQtMDUgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+ CiAKICAgICAgICAgU3BlZWQgdXAgdGhlIGNvbnZlcnNpb24gZnJvbSBKU1ZhbHVlIHRvIFN0cmlu ZyBmb3IgYnVsayBvcGVyYXRpb25zCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9KU0FycmF5LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJy YXkuY3BwCmluZGV4IDdlYzBjMmY4NzJmZTdmZmRlYzA1NTI3OWU1MjMzZDVjMDA1ZjJhZGIuLjBk MTE0ZTNlYWRkYTFkZTE3OWY4MjgxZWY1OTEyZTFiOWQ2Y2Y4ZTYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXkuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0pTQXJyYXkuY3BwCkBAIC0xNzYsMTEgKzE3NiwxMiBAQCBKU0FycmF5 KiBKU0FycmF5Ojp0cnlGaW5pc2hDcmVhdGlvblVuaW5pdGlhbGl6ZWQoSlNHbG9iYWxEYXRhJiBn bG9iYWxEYXRhLCB1bnNpZwogICAgIAogICAgIG1fc3RvcmFnZSA9IHN0YXRpY19jYXN0PEFycmF5 U3RvcmFnZSo+KG5ld1N0b3JhZ2UpOwogICAgIG1fc3RvcmFnZS0+bV9hbGxvY0Jhc2UgPSBtX3N0 b3JhZ2U7Ci0gICAgbV9zdG9yYWdlLT5tX2xlbmd0aCA9IDA7CisgICAgbV9zdG9yYWdlLT5tX2xl bmd0aCA9IGluaXRpYWxMZW5ndGg7CiAgICAgbV92ZWN0b3JMZW5ndGggPSBpbml0aWFsVmVjdG9y TGVuZ3RoOwogICAgIG1fc3RvcmFnZS0+bV9udW1WYWx1ZXNJblZlY3RvciA9IGluaXRpYWxMZW5n dGg7CiAKICNpZiBDSEVDS19BUlJBWV9DT05TSVNURU5DWQorICAgIG1fc3RvcmFnZS0+bV9pbml0 aWFsaXphdGlvbkluZGV4ID0gMDsKICAgICBtX3N0b3JhZ2UtPm1faW5Db21wYWN0SW5pdGlhbGl6 YXRpb24gPSB0cnVlOwogI2VuZGlmCiAKQEAgLTE4MzMsNyArMTgzNCw3IEBAIHZvaWQgSlNBcnJh eTo6Y2hlY2tDb25zaXN0ZW5jeShDb25zaXN0ZW5jeUNoZWNrVHlwZSB0eXBlKQogCiAgICAgdW5z aWduZWQgbnVtVmFsdWVzSW5WZWN0b3IgPSAwOwogICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkg PCBtX3ZlY3Rvckxlbmd0aDsgKytpKSB7Ci0gICAgICAgIGlmIChKU1ZhbHVlIHZhbHVlID0gc3Rv cmFnZS0+bV92ZWN0b3JbaV0pIHsKKyAgICAgICAgaWYgKEpTVmFsdWUgdmFsdWUgPSBzdG9yYWdl LT5tX3ZlY3RvcltpXS5nZXQoKSkgewogICAgICAgICAgICAgQVNTRVJUKGkgPCBzdG9yYWdlLT5t X2xlbmd0aCk7CiAgICAgICAgICAgICBpZiAodHlwZSAhPSBEZXN0cnVjdG9yQ29uc2lzdGVuY3lD aGVjaykKICAgICAgICAgICAgICAgICB2YWx1ZS5pc1VuZGVmaW5lZCgpOyAvLyBMaWtlbHkgdG8g Y3Jhc2ggaWYgdGhlIG9iamVjdCB3YXMgZGVhbGxvY2F0ZWQuCkBAIC0xODQ3LDE1ICsxODQ4LDE1 IEBAIHZvaWQgSlNBcnJheTo6Y2hlY2tDb25zaXN0ZW5jeShDb25zaXN0ZW5jeUNoZWNrVHlwZSB0 eXBlKQogICAgIEFTU0VSVChudW1WYWx1ZXNJblZlY3RvciA8PSBzdG9yYWdlLT5tX2xlbmd0aCk7 CiAKICAgICBpZiAobV9zcGFyc2VWYWx1ZU1hcCkgewotICAgICAgICBTcGFyc2VBcnJheVZhbHVl TWFwOjppdGVyYXRvciBlbmQgPSBtX3NwYXJzZVZhbHVlTWFwLT5lbmQoKTsKLSAgICAgICAgZm9y IChTcGFyc2VBcnJheVZhbHVlTWFwOjppdGVyYXRvciBpdCA9IG1fc3BhcnNlVmFsdWVNYXAtPmJl Z2luKCk7IGl0ICE9IGVuZDsgKytpdCkgeworICAgICAgICBTcGFyc2VBcnJheVZhbHVlTWFwOjpj b25zdF9pdGVyYXRvciBlbmQgPSBtX3NwYXJzZVZhbHVlTWFwLT5lbmQoKTsKKyAgICAgICAgZm9y IChTcGFyc2VBcnJheVZhbHVlTWFwOjpjb25zdF9pdGVyYXRvciBpdCA9IG1fc3BhcnNlVmFsdWVN YXAtPmJlZ2luKCk7IGl0ICE9IGVuZDsgKytpdCkgewogICAgICAgICAgICAgdW5zaWduZWQgaW5k ZXggPSBpdC0+Zmlyc3Q7CiAgICAgICAgICAgICBBU1NFUlQoaW5kZXggPCBzdG9yYWdlLT5tX2xl bmd0aCk7Ci0gICAgICAgICAgICBBU1NFUlQoaW5kZXggPj0gc3RvcmFnZS0+bV92ZWN0b3JMZW5n dGgpOworICAgICAgICAgICAgQVNTRVJUKGluZGV4ID49IG1fdmVjdG9yTGVuZ3RoKTsKICAgICAg ICAgICAgIEFTU0VSVChpbmRleCA8PSBNQVhfQVJSQVlfSU5ERVgpOwogICAgICAgICAgICAgQVNT RVJUKGl0LT5zZWNvbmQpOwogICAgICAgICAgICAgaWYgKHR5cGUgIT0gRGVzdHJ1Y3RvckNvbnNp c3RlbmN5Q2hlY2spCi0gICAgICAgICAgICAgICAgaXQtPnNlY29uZC5pc1VuZGVmaW5lZCgpOyAv LyBMaWtlbHkgdG8gY3Jhc2ggaWYgdGhlIG9iamVjdCB3YXMgZGVhbGxvY2F0ZWQuCisgICAgICAg ICAgICAgICAgaXQtPnNlY29uZC5nZXROb25TcGFyc2VNb2RlKCkuaXNVbmRlZmluZWQoKTsgLy8g TGlrZWx5IHRvIGNyYXNoIGlmIHRoZSBvYmplY3Qgd2FzIGRlYWxsb2NhdGVkLgogICAgICAgICB9 CiAgICAgfQogfQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNB cnJheS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNBcnJheS5oCmluZGV4IGNh MzE2YjJlYzFjMDIxNGFlNGRhZDkxYzNjYjJmNmRiMWUwZTExM2QuLjk4ZWUzMmUzMTFjY2Y3NjRl MDAwYWU5NWY2MTA0Y2QxOWYyMzU3NjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0pTQXJyYXkuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9K U0FycmF5LmgKQEAgLTExOSw3ICsxMTksOSBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgdW5z aWduZWQgbV9udW1WYWx1ZXNJblZlY3RvcjsKICAgICAgICAgdm9pZCogbV9hbGxvY0Jhc2U7IC8v IFBvaW50ZXIgdG8gYmFzZSBhZGRyZXNzIHJldHVybmVkIGJ5IG1hbGxvYygpLiAgS2VlcGluZyB0 aGlzIHBvaW50ZXIgZG9lcyBlbGltaW5hdGUgZmFsc2UgcG9zaXRpdmVzIGZyb20gdGhlIGxlYWsg ZGV0ZWN0b3IuCiAjaWYgQ0hFQ0tfQVJSQVlfQ09OU0lTVEVOQ1kKLSAgICAgICAgdWludHB0cl90 IG1faW5Db21wYWN0SW5pdGlhbGl6YXRpb247IC8vIE5lZWRzIHRvIGJlIGEgdWludHB0cl90IGZv ciBhbGlnbm1lbnQgcHVycG9zZXMuCisgICAgICAgIC8vIE5lZWRzIHRvIGJlIGEgdWludHB0cl90 IGZvciBhbGlnbm1lbnQgcHVycG9zZXMuCisgICAgICAgIHVpbnRwdHJfdCBtX2luaXRpYWxpemF0 aW9uSW5kZXg7CisgICAgICAgIHVpbnRwdHJfdCBtX2luQ29tcGFjdEluaXRpYWxpemF0aW9uOwog I2Vsc2UKICAgICAgICAgdWludHB0cl90IG1fcGFkZGluZzsKICNlbmRpZgpAQCAtMjE5LDI0ICsy MjEsMjUgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgICAgICBBcnJheVN0b3JhZ2UgKnN0b3Jh Z2UgPSBtX3N0b3JhZ2U7CiAjaWYgQ0hFQ0tfQVJSQVlfQ09OU0lTVEVOQ1kKICAgICAgICAgICAg IEFTU0VSVChzdG9yYWdlLT5tX2luQ29tcGFjdEluaXRpYWxpemF0aW9uKTsKLSNlbmRpZgogICAg ICAgICAgICAgLy8gQ2hlY2sgdGhhdCB3ZSBhcmUgaW5pdGlhbGl6aW5nIHRoZSBuZXh0IGluZGV4 IGluIHNlcXVlbmNlLgotICAgICAgICAgICAgQVNTRVJUX1VOVVNFRChpLCBpID09IHN0b3JhZ2Ut Pm1fbGVuZ3RoKTsKKyAgICAgICAgICAgIEFTU0VSVChpID09IHN0b3JhZ2UtPm1faW5pdGlhbGl6 YXRpb25JbmRleCk7CiAgICAgICAgICAgICAvLyB0cnlDcmVhdGVVbmluaXRpYWxpemVkIHNldCBt X251bVZhbHVlc0luVmVjdG9yIHRvIHRoZSBpbml0aWFsTGVuZ3RoLAogICAgICAgICAgICAgLy8g Y2hlY2sgd2UgZG8gbm90IHRyeSB0byBpbml0aWFsaXplIG1vcmUgdGhhbiB0aGlzIG51bWJlciBv ZiBwcm9wZXJ0aWVzLgotICAgICAgICAgICAgQVNTRVJUKHN0b3JhZ2UtPm1fbGVuZ3RoIDwgc3Rv cmFnZS0+bV9udW1WYWx1ZXNJblZlY3Rvcik7Ci0gICAgICAgICAgICAvLyBJdCBpcyBpbXByb3Rh bnQgdGhhdCB3ZSBpbmNyZW1lbnQgbGVuZ3RoIGhlcmUsIHNvIHRoYXQgYWxsIG5ld2x5IGFkZGVk Ci0gICAgICAgICAgICAvLyB2YWx1ZXMgaW4gdGhlIGFycmF5IHN0aWxsIGdldCBtYXJrZWQgZHVy aW5nIHRoZSBpbml0aWFsaXphdGlvbiBwaGFzZS4KLSAgICAgICAgICAgIHN0b3JhZ2UtPm1fdmVj dG9yW3N0b3JhZ2UtPm1fbGVuZ3RoKytdLnNldChnbG9iYWxEYXRhLCB0aGlzLCB2KTsKKyAgICAg ICAgICAgIEFTU0VSVChzdG9yYWdlLT5tX2luaXRpYWxpemF0aW9uSW5kZXggPCBzdG9yYWdlLT5t X251bVZhbHVlc0luVmVjdG9yKTsKKyAgICAgICAgICAgIHN0b3JhZ2UtPm1faW5pdGlhbGl6YXRp b25JbmRleCsrOworI2VuZGlmCisgICAgICAgICAgICBBU1NFUlQoaSA8IHN0b3JhZ2UtPm1fbGVu Z3RoKTsKKyAgICAgICAgICAgIEFTU0VSVChpIDwgc3RvcmFnZS0+bV9udW1WYWx1ZXNJblZlY3Rv cik7CisgICAgICAgICAgICBzdG9yYWdlLT5tX3ZlY3RvcltpXS5zZXQoZ2xvYmFsRGF0YSwgdGhp cywgdik7CiAgICAgICAgIH0KIAogICAgICAgICBpbmxpbmUgdm9pZCBjb21wbGV0ZUluaXRpYWxp emF0aW9uKHVuc2lnbmVkIG5ld0xlbmd0aCkKICAgICAgICAgewogICAgICAgICAgICAgLy8gQ2hl Y2sgdGhhdCB3ZSBoYXZlIGluaXRpYWxpemVkIGFzIG1lbnkgcHJvcGVydGllcyBhcyB3ZSB0aGlu ayB3ZSBoYXZlLgogICAgICAgICAgICAgQVNTRVJUX1VOVVNFRChuZXdMZW5ndGgsIG5ld0xlbmd0 aCA9PSBtX3N0b3JhZ2UtPm1fbGVuZ3RoKTsKLSAgICAgICAgICAgIC8vIENoZWNrIHRoYXQgdGhl IG51bWJlciBvZiBwcm9wcmV0aWVzIGluaXRpYWxpemVkIG1hdGNoZXMgdGhlIGluaXRpYWxMZW5n dGguCi0gICAgICAgICAgICBBU1NFUlQobV9zdG9yYWdlLT5tX2xlbmd0aCA9PSBtX3N0b3JhZ2Ut Pm1fbnVtVmFsdWVzSW5WZWN0b3IpOwogI2lmIENIRUNLX0FSUkFZX0NPTlNJU1RFTkNZCisgICAg ICAgICAgICAvLyBDaGVjayB0aGF0IHRoZSBudW1iZXIgb2YgcHJvcHJldGllcyBpbml0aWFsaXpl ZCBtYXRjaGVzIHRoZSBpbml0aWFsTGVuZ3RoLgorICAgICAgICAgICAgQVNTRVJUKG1fc3RvcmFn ZS0+bV9pbml0aWFsaXphdGlvbkluZGV4ID09IG1fc3RvcmFnZS0+bV9udW1WYWx1ZXNJblZlY3Rv cik7CiAgICAgICAgICAgICBBU1NFUlQobV9zdG9yYWdlLT5tX2luQ29tcGFjdEluaXRpYWxpemF0 aW9uKTsKICAgICAgICAgICAgIG1fc3RvcmFnZS0+bV9pbkNvbXBhY3RJbml0aWFsaXphdGlvbiA9 IGZhbHNlOwogI2VuZGlmCg==