<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>83400</bug_id>
          
          <creation_ts>2012-04-06 15:09:11 -0700</creation_ts>
          <short_desc>[chromium] Hundreds of mac failures are due to a slightly different color repaint background</short_desc>
          <delta_ts>2013-04-09 17:05:54 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>WONTFIX</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ojan Vafai">ojan</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>caryclark</cc>
    
    <cc>danakj</cc>
    
    <cc>epoger</cc>
    
    <cc>reed</cc>
    
    <cc>senorblanco</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>597704</commentid>
    <comment_count>0</comment_count>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2012-04-06 15:09:11 -0700</bug_when>
    <thetext>For example, see http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&amp;tests=fast%2Ftable%2Fempty-section-crash.html.

The repaint background on the platform/chromium-win and platform/chromium-linux results is #575757. On the Chromium mac bot, some pixels are #575757 and some are #565656. Not really sure how image_diff translates that to the whole background not matching.

The platform/mac result has a background that is #6a6a6a, with a color profile. Diffing the chromium win/linux result with the platform/mac result only shows a diff on the text though (i.e. the backgrounds match). I assume image-diff accounts for the color-profile somehow.

Also, curiously, on some of the snowleopard bots, we sometimes get a result that matches the platform/mac result: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&amp;showExpectations=true&amp;tests=fast%2Ftable%2Fempty-section-crash.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>597763</commentid>
    <comment_count>1</comment_count>
    <who name="Dana Jansens">danakj</who>
    <bug_when>2012-04-06 15:51:41 -0700</bug_when>
    <thetext>Probably this https://codereview.appspot.com/5758043</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>597765</commentid>
    <comment_count>2</comment_count>
    <who name="Dana Jansens">danakj</who>
    <bug_when>2012-04-06 15:52:06 -0700</bug_when>
    <thetext>Here&apos;s the skia bug http://code.google.com/p/skia/issues/detail?id=420</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>598496</commentid>
    <comment_count>3</comment_count>
    <who name="">epoger</who>
    <bug_when>2012-04-09 12:04:22 -0700</bug_when>
    <thetext>Ojan, can you please tell me how to get a list of the &quot;hundreds&quot; of tests that fall into this category?  (Or at least a good chunk of them?)

Taking the example given, empty-section-crash, I see (via svn blame) that it was marked as expected to IMAGE fail at least 16 months ago (http://trac.webkit.org/changeset/74070/trunk/LayoutTests/platform/chromium/test_expectations.txt).  Its expectations line refers to http://crbug.com/23489 , which was filed in Sept 2009...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>598653</commentid>
    <comment_count>4</comment_count>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2012-04-09 15:02:36 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; Ojan, can you please tell me how to get a list of the &quot;hundreds&quot; of tests that fall into this category?  (Or at least a good chunk of them?)

1. load &quot;webkit-patch garden-o-matic&quot;
2. go to the expected failures tab
3. examine the fast/repaint tests

Fixing the color issue probably won&apos;t make all these tests pass, but it will make it so that the pixel diffs are just text-rendering/antialiasing. So, they would be straightforward rebaselines.

I think a large percentage of these have also be rebaselined. I know I rebaselined a lot of these for the Lion port before I realized that it was a more widespread problem. So, fixing this would cause a number of tests to &quot;fail&quot; that would need rebaselining.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>872400</commentid>
    <comment_count>5</comment_count>
    <who name="Stephen Chenney">schenney</who>
    <bug_when>2013-04-09 17:05:54 -0700</bug_when>
    <thetext>Marked LayoutTest bugs, bugs with Chromium IDs, and some others as WontFix. Test failure bugs still are trackable via TestExpectations or disabled unit tests.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>