83396 2012-04-06 14:51:03 -0700 [chromium] Avoid deleting impl tree when becoming invisible 2012-04-06 19:13:34 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr cc-bugs webkit.review.bot oldest_to_newest 597682 0 jamesr 2012-04-06 14:51:03 -0700 [chromium] Avoid deleting impl tree when becoming invisible 597686 1 136070 jamesr 2012-04-06 14:53:42 -0700 Created attachment 136070 Patch 597893 2 136070 enne 2012-04-06 18:52:14 -0700 Comment on attachment 136070 Patch Ok, I think I'm convinced. I feel like this code maybe made some sense in the distant past, but it clearly doesn't now. 597894 3 136070 jamesr 2012-04-06 18:55:31 -0700 Comment on attachment 136070 Patch I don't think it did, but looked kind of like it would make sense which is why it's so insidious. 597902 4 136070 webkit.review.bot 2012-04-06 19:13:30 -0700 Comment on attachment 136070 Patch Clearing flags on attachment: 136070 Committed r113538: <http://trac.webkit.org/changeset/113538> 597903 5 webkit.review.bot 2012-04-06 19:13:34 -0700 All reviewed patches have been landed. Closing bug. 136070 2012-04-06 14:53:42 -0700 2012-04-06 19:13:30 -0700 Patch bug-83396-20120406145341.patch text/plain 2561 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNDkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjhkYTJhN2Y4NDcyOWZk NmMyM2VhYWMyOWIzZGZlNDMxYjZjNTA3ZC4uNzYxYTg4N2NlNDMzODFhZTk5MTZkYjZmZDYzMzY5 OTVjOWFhYTVkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDEyLTA0LTA2ICBKYW1l cyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgW2Nocm9taXVtXSBB dm9pZCBkZWxldGluZyBpbXBsIHRyZWUgd2hlbiBiZWNvbWluZyBpbnZpc2libGUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzMzk2CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBiaXQgb2YgY29kZSBp biBDQ0xheWVyVHJlZUhvc3Q6OmRpZEJlY29tZUludmlzaWJsZS4uKCkgd2FzIGFuIGF0dGVtcHQg dG8gZHJvcCByZXNvdXJjZXMgd2hlbiBiZWNvbWluZworICAgICAgICBpbnZpc2libGUuIEhvd2V2 ZXIsIGl0J3MgZmFpcmx5IGNvbmZ1c2VkIC0gd2UgZHJvcCB0ZXh0dXJlcyB2aWEgVGV4dHVyZU1h bmFnZXJzIHdoZW4gZ29pbmcgaW52aXNpYmxlIGFuZAorICAgICAgICBDQ0xheWVySW1wbCBkZXN0 cnVjdG9ycyBjYW4ndCBkZWxldGUgbm9uLW1hbmFnZWQgcmVzb3VyY2VzIHNpbmNlIHRoZXkgZG8g bm90IGhhdmUgYWNjZXNzIHRvIGEgY29udGV4dCAtIHNvIHRoaXMKKyAgICAgICAgY29kZSB3YXMg bmV2ZXIgYWN0dWFsbHkgZnJlZWluZyB1cCBHUFUgcmVzb3VyY2VzLiBIYXZpbmcgYSBzb21ldGlt ZXMtbnVsbCBDQ0xheWVySW1wbCB0cmVlIHdoZW4gd2Ugc3RpbGwgaGF2ZSBhCisgICAgICAgIHZh bGlkIExheWVyQ2hyb21pdW0gdHJlZSBoYXMgbGVhZCB0byB2YXJpb3VzIHRyaWNreSBidWdzLgor CisgICAgICAgIE5vIG5ldyB0ZXN0cyBzaW5jZSB0aGlzIGNvZGUgd2Fzbid0IGRvaW5nIGFueXRo aW5nIHVzZWZ1bCBpbiB0aGUgZmlyc3QgcGxhY2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Q0NMYXllclRyZWVIb3N0OjpkaWRCZWNvbWVJbnZpc2libGVPbkltcGxUaHJlYWQpOgorCisyMDEy LTA0LTA2ICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CisKICAgICAgICAg V2ViR0wgY29udGVudCBzd2FwcGVkIGF0IHdyb25nIHRpbWUgaW4gdGhyZWFkZWQgY29tcG9zaXRp bmcgbW9kZQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 ODIyNzUKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hy b21pdW0vY2MvQ0NMYXllclRyZWVIb3N0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdC5jcHAKaW5kZXggZDNmYzk3MGJkMzY3 M2Q3MWM4MjBiYTMzOGE2YmQwNmQ0NjIzNTZlZS4uOGRjOWI0ZjNkMDJhOTZiMWFkNzFhNmE1YmRi ZjFkYTE4NWM1MWRiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3QuY3BwCkBAIC0zODYs MTQgKzM4Niw2IEBAIHZvaWQgQ0NMYXllclRyZWVIb3N0OjpkaWRCZWNvbWVJbnZpc2libGVPbklt cGxUaHJlYWQoQ0NMYXllclRyZWVIb3N0SW1wbCogaG9zdEltCiAgICAgICAgIGNvbnRlbnRzVGV4 dHVyZU1hbmFnZXIoKS0+ZGVsZXRlRXZpY3RlZFRleHR1cmVzKGhvc3RJbXBsLT5jb250ZW50c1Rl eHR1cmVBbGxvY2F0b3IoKSk7CiAgICAgfQogCi0gICAgLy8gRW5zdXJlIHRoYXQgdGhlIGRyb3Bw ZWQgdGlsZXMgYXJlIHByb3BhZ2F0ZWQgdG8gdGhlIGltcGwgdHJlZS4KLSAgICAvLyBJZiB0aGUg ZnJvbnRidWZmZXIgaXMgY2FjaGVkLCB0aGVuIGNsb2JiZXIgdGhlIGltcGwgdHJlZS4gT3RoZXJ3 aXNlLAotICAgIC8vIHB1c2ggb3ZlciB0aGUgdHJlZSBjaGFuZ2VzLgotICAgIGlmIChtX3Byb3h5 LT5sYXllclJlbmRlcmVyQ2FwYWJpbGl0aWVzKCkuY29udGV4dEhhc0NhY2hlZEZyb250QnVmZmVy KSB7Ci0gICAgICAgIGhvc3RJbXBsLT5zZXRSb290TGF5ZXIobnVsbHB0cik7Ci0gICAgICAgIHJl dHVybjsKLSAgICB9Ci0KICAgICBob3N0SW1wbC0+c2V0Um9vdExheWVyKFRyZWVTeW5jaHJvbml6 ZXI6OnN5bmNocm9uaXplVHJlZXMocm9vdExheWVyKCksIGhvc3RJbXBsLT5yZWxlYXNlUm9vdExh eWVyKCkpKTsKIAogICAgIC8vIFdlIG1heSBoYXZlIGFkZGVkIGFuIGFuaW1hdGlvbiBkdXJpbmcg dGhlIHRyZWUgc3luYy4gVGhpcyB3aWxsIGNhdXNlIGJvdGggbGF5ZXIgdHJlZSBob3N0cwo=