83393 2012-04-06 14:38:27 -0700 [GTK] Accelerated compositing is broken after recent TextureMapper reorganizations 2012-04-06 18:26:11 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson alex noam webkit.review.bot oldest_to_newest 597665 0 mrobinson 2012-04-06 14:38:27 -0700 After some recent TextureMapper reorganizations, accelerated compositing via the TextureMapper is broken on GTK+. 597705 1 noam 2012-04-06 15:09:51 -0700 Sorry about that, let me know how I can help... Since texture-mapper is not enabled in the bots it's hard to notice breakages. 597720 2 mrobinson 2012-04-06 15:21:14 -0700 (In reply to comment #1) > Sorry about that, let me know how I can help... Since texture-mapper is not enabled in the bots it's hard to notice breakages. Not a problem! Our AC implementation is still pretty young. I hope to give it a lot more care in the coming months. 597727 3 136072 mrobinson 2012-04-06 15:24:22 -0700 Created attachment 136072 Patch 597738 4 136072 mrobinson 2012-04-06 15:35:39 -0700 Comment on attachment 136072 Patch Thanks for the review! 597884 5 136072 webkit.review.bot 2012-04-06 18:26:07 -0700 Comment on attachment 136072 Patch Clearing flags on attachment: 136072 Committed r113533: <http://trac.webkit.org/changeset/113533> 597885 6 webkit.review.bot 2012-04-06 18:26:11 -0700 All reviewed patches have been landed. Closing bug. 136072 2012-04-06 15:24:22 -0700 2012-04-06 18:26:07 -0700 Patch bug-83393-20120406152421.patch text/plain 4082 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNDc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWU0MWY5MWFhZTIyN2M3 M2ZiY2I4NGQ1ZDIwYzkwZTMzYTg4ZThmYy4uZTMzMjE1YjM5ZDg3NzgxMDZkMWRiNThhNDFjOWE2 MGY5OWE2YjUzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA0LTA2ICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBBY2Nl bGVyYXRlZCBjb21wb3NpdGluZyBpcyBicm9rZW4gYWZ0ZXIgcmVjZW50IFRleHR1cmVNYXBwZXIg cmVvcmdhbml6YXRpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04MzM5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cy4gVGhpcyB3aWxsIGJlIGNvdmVyZWQgYnkgZXhpc3RpbmcgYWNj ZWxlcmF0ZWQgY29tcG9zaXRpbmcgdGVzdHMKKyAgICAgICAgb25jZSB0aGUgaW1wbGVtZW50YXRp b24gaXMgY29tcGxldGUuCisKKyAgICAgICAgVGhlIEdUSysgaW1wbGVtZW50YXRpb24gZG9lc24n dCBjbGlwIGN1cnJlbnRseSwgc28gaG9sZCBvZmYgZW5hYmxpbmcgdGhlCisgICAgICAgIHNjaXNz b3IgdGVzdCB1bnRpbCBuZWNlc3NhcnkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90 ZXhtYXAvVGV4dHVyZU1hcHBlckdMLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRleHR1cmVNYXBw ZXJHTDo6YmVnaW5QYWludGluZyk6IERvIG5vdCBlbmFibGUgdGhlIHNjaXNzb3IgdGVzdC4KKyAg ICAgICAgKFdlYkNvcmU6OlRleHR1cmVNYXBwZXJHTDo6YmVnaW5TY2lzc29yQ2xpcCk6IEVuYWJs ZSB0aGUgc2Npc3NvciB0ZXN0IG9uY2UKKyAgICAgICAgd2Uga25vdyBmb3Igc3VyZSB3ZSB3aWxs IGJlIHVzaW5nIHNjaXNzb3JlZCBjbGlwcGluZy4KKwogMjAxMi0wNC0wNiAgSm9zaHVhIEJlbGwg IDxqc2JlbGxAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEluZGV4ZWREQjogT2JqZWN0U3RvcmUv SW5kZXggc2hvdWxkbid0IGhvbGQgcmVmZXJlbmNlIHRvIGJhY2tpbmcgc3RvcmUKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5n ZUxvZwppbmRleCAxMTMwODZhNWZlYmQyOTkxMjM4YTA4NmE4YzA1NTdiMmJmNDZhYjZkLi5jZDZh MTFhMzEzZWE0MTA1NDg1ZTJiZWVmOGY0MjBmZjQ0YTA5OTAxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTItMDQtMDYgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBp Z2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIGlzIGJy b2tlbiBhZnRlciByZWNlbnQgVGV4dHVyZU1hcHBlciByZW9yZ2FuaXphdGlvbnMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzMzkzCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRW5zdXJlIHRoYXQgdGhlIGxh eWVyIHRyZWUgaXMgc3luY2VkIHdoZW4gdGhlIHJvb3QgbGF5ZXIgaXMgcmVzaXplZC4KKworICAg ICAgICAqIFdlYkNvcmVTdXBwb3J0L0FjY2VsZXJhdGVkQ29tcG9zaXRpbmdDb250ZXh0R0wuY3Bw OgorICAgICAgICAoV2ViS2l0OjpBY2NlbGVyYXRlZENvbXBvc2l0aW5nQ29udGV4dDo6cmVzaXpl Um9vdExheWVyKTogRW5zdXJlIHRoYXQgdGhlIGxheWVyCisgICAgICAgIHRyZWUgaXMgc3luY2Vk IHdoZW4gdGhlIHJvb3QgbGF5ZXIgcmVzaXplcyBhbmQgcmVtb3ZlIGEgY2FsbCB0byByZWNvbXBv c2l0ZQorICAgICAgICB0aGUgdHJlZSwgYXMgaXQgaGFwcGVucyBhbnl3YXkuCisKIDIwMTItMDQt MDUgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtH VEtdIFNjcm9sbGluZyBzb21lIGlmcmFtZXMgdGhhdCBhcmUgcGFydGlhbGx5IG91dCBvZiB0aGUg dmlld3BvcnQgbGVhZHMgdG8gcmVwYWludCBlcnJvcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyR0wuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJHTC5jcHAKaW5k ZXggYjhmOGI1NGJlYjg5NmZkN2U2MzBjYWY3OTA1MzEwZDVhYTBhNjQ5NS4uYmE0OWZiMjgyMGM0 ZmUzYmRlZWVjZGM2NGU5ODExYTYwZmQ5NTczNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJHTC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJHTC5jcHAKQEAg LTI1Myw3ICsyNTMsNiBAQCB2b2lkIFRleHR1cmVNYXBwZXJHTDo6YmVnaW5QYWludGluZygpCiAg ICAgZGF0YSgpLnByZXZpb3VzU2Npc3NvclN0YXRlID0gZ2xJc0VuYWJsZWQoR0xfU0NJU1NPUl9U RVNUKTsKICAgICBkYXRhKCkucHJldmlvdXNEZXB0aFN0YXRlID0gZ2xJc0VuYWJsZWQoR0xfREVQ VEhfVEVTVCk7CiAgICAgZ2xEaXNhYmxlKEdMX0RFUFRIX1RFU1QpOwotICAgIGdsRW5hYmxlKEdM X1NDSVNTT1JfVEVTVCk7CiAjaWYgUExBVEZPUk0oUVQpCiAgICAgaWYgKG1fY29udGV4dCkgewog ICAgICAgICBRUGFpbnRlciogcGFpbnRlciA9IG1fY29udGV4dC0+cGxhdGZvcm1Db250ZXh0KCk7 CkBAIC01OTcsNiArNTk2LDggQEAgdm9pZCBUZXh0dXJlTWFwcGVyR0w6OmJpbmRTdXJmYWNlKEJp dG1hcFRleHR1cmUgKnN1cmZhY2VQb2ludGVyKQogCiBib29sIFRleHR1cmVNYXBwZXJHTDo6YmVn aW5TY2lzc29yQ2xpcChjb25zdCBUcmFuc2Zvcm1hdGlvbk1hdHJpeCYgbW9kZWxWaWV3TWF0cml4 LCBjb25zdCBGbG9hdFJlY3QmIHRhcmdldFJlY3QpCiB7CisgICAgZ2xFbmFibGUoR0xfU0NJU1NP Ul9URVNUKTsKKwogICAgIC8vIDNEIHRyYW5zZm9ybXMgYXJlIGN1cnJlbnRseSBub3Qgc3VwcG9y dGVkIGluIHNjaXNzb3IgY2xpcHBpbmcKICAgICAvLyByZXN1bHRpbmcgaW4gY3JvcHBlZCBzdXJm YWNlcyB3aGVuIHo+MC4KICAgICBpZiAoIW1vZGVsVmlld01hdHJpeC5pc0FmZmluZSgpKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvQWNjZWxlcmF0ZWRDb21w b3NpdGluZ0NvbnRleHRHTC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9B Y2NlbGVyYXRlZENvbXBvc2l0aW5nQ29udGV4dEdMLmNwcAppbmRleCA2ZDMzODk3MGE4YTMwM2Vj OWQ3ODQ1NTMyNWE3OGIwNzA1YjZkYjg0Li44YzYzYTg3NzI3Mzc4MDY3MDUxZDY1MzQ2OGUxNWM1 OTczMzQzOWNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9B Y2NlbGVyYXRlZENvbXBvc2l0aW5nQ29udGV4dEdMLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2d0 ay9XZWJDb3JlU3VwcG9ydC9BY2NlbGVyYXRlZENvbXBvc2l0aW5nQ29udGV4dEdMLmNwcApAQCAt MTM5LDcgKzEzOSw3IEBAIHZvaWQgQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHQ6OnJlc2l6 ZVJvb3RMYXllcihjb25zdCBJbnRTaXplJiBzaXplKQogICAgIGlmICghbV9yb290R3JhcGhpY3NM YXllcikKICAgICAgICAgcmV0dXJuOwogICAgIG1fcm9vdEdyYXBoaWNzTGF5ZXItPnNldFNpemUo c2l6ZSk7Ci0gICAgbV9yb290R3JhcGhpY3NMYXllci0+c2V0TmVlZHNEaXNwbGF5KCk7CisgICAg bV9yb290R3JhcGhpY3NMYXllci0+c3luY0NvbXBvc2l0aW5nU3RhdGVGb3JUaGlzTGF5ZXJPbmx5 KCk7CiB9CiAKIHN0YXRpYyBnYm9vbGVhbiBzeW5jTGF5ZXJzVGltZW91dENhbGxiYWNrKEFjY2Vs ZXJhdGVkQ29tcG9zaXRpbmdDb250ZXh0KiBjb250ZXh0KQo=