83388 2012-04-06 13:45:35 -0700 WebFullScreenManagerProxy::isFullScreen() will create an empty full screen window; steal focus. 2012-04-06 14:49:31 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble oldest_to_newest 597624 0 jer.noble 2012-04-06 13:45:35 -0700 WebFullScreenManagerProxy::isFullScreen() will create an empty full screen window; steal focus. 597625 1 jer.noble 2012-04-06 13:46:05 -0700 <rdar://problem/11191249> 597628 2 136061 jer.noble 2012-04-06 13:50:31 -0700 Created attachment 136061 Patch 597655 3 136061 ggaren 2012-04-06 14:28:02 -0700 Comment on attachment 136061 Patch r=me It's a little squirrelly for object allocation (in this case) or deallocation (in the general case) to change program behavior. Long-term, it would be nice to separate allocating the full screen window controller from giving it focus. 597663 4 jer.noble 2012-04-06 14:35:51 -0700 (In reply to comment #3) > (From update of attachment 136061 [details]) > r=me > > It's a little squirrelly for object allocation (in this case) or deallocation (in the general case) to change program behavior. Long-term, it would be nice to separate allocating the full screen window controller from giving it focus. That stems from using a NSWindowController, which expects to have created a NSWindow as part of its own init process. But you're right, and this is something we should try to mitigate. 597678 5 jer.noble 2012-04-06 14:49:31 -0700 Committed r113501: <http://trac.webkit.org/changeset/113501> 136061 2012-04-06 13:50:31 -0700 2012-04-06 14:28:02 -0700 Patch bug-83388-20120406135030.patch text/plain 3176 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNDc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTBkOGExNTNiYjUzYzQ0 ODRhODZiYmE5ZjA2OTFhNzljMzNmODU5NS4uNjI2ZDhhY2IyMmZkMjQ5MDUxMjI0NmY3NGJjZTE5 NjE3M2Y5OWRmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA0LTA2ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFdlYkZ1bGxTY3JlZW5NYW5h Z2VyUHJveHk6OmlzRnVsbFNjcmVlbigpIHdpbGwgY3JlYXRlIGFuIGVtcHR5IGZ1bGwgc2NyZWVu IHdpbmRvdzsgc3RlYWwgZm9jdXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04MzM4OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIENhbGxpbmcgV2ViRnVsbFNjcmVlbk1hbmFnZXJQcm94eTo6aXNGdWxsU2Ny ZWVuKCkgd2lsbCBjcmVhdGUgYSBXS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyIGlmIAorICAg ICAgICBvbmUgZG9lcyBub3QgYWxyZWFkeSBleGlzdCwgc2luY2UgdGhlIC1bV0tWaWV3IGZ1bGxT Y3JlZW5XaW5kb3dDb250cm9sbGVyXSBtZXRob2Qgd2lsbCBjcmVhdGUtb24tYWNjZXNzLgorICAg ICAgICBBZGQgYSBuZXcgY2FsbCwgLVtXS1ZpZXcgaGFzRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xs ZXJdLCB3aGljaCBkb2VzIG5vdCBhdXRvLWNyZWF0ZSB0aGUgY29udHJvbGxlcgorICAgICAgICBh bmQgYWRkIHRoYXQgY2hlY2sgdG8gV2ViRnVsbFNjcmVlbk1hbmFnZXJQcm94eTo6aXNGdWxsU2Ny ZWVuKCkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW06CisgICAgICAg ICgtW1dLVmlldyBoYXNGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlcl0pOgorICAgICAgICAqIFVJ UHJvY2Vzcy9BUEkvbWFjL1dLVmlld0ludGVybmFsLmg6CisgICAgICAgICogVUlQcm9jZXNzL21h Yy9XZWJGdWxsU2NyZWVuTWFuYWdlclByb3h5TWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJG dWxsU2NyZWVuTWFuYWdlclByb3h5Ojppc0Z1bGxTY3JlZW4pOgorCiAyMDEyLTA0LTA2ICBEYW4g QmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEw OTEyNDc2PiBIaURQSTogSGF2ZSBjYW52YXMgdXNlIGEgaGlkcGkgYmFja2luZyBzdG9yZSwgYnV0 IGRvd25zYW1wbGUgdXBvbiBhY2Nlc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvbWFjL1dLVmlldy5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFj L1dLVmlldy5tbQppbmRleCAzOGVhYTE1MjM1Mzc5ZjJmMGU2NWM1YzU5MWJlYWRjYzU0YzVlZGEx Li5mZjA1NjNhMWQzYWIzMmVlY2YwYTlmNzU3MDNmNDRkZjg5OWRlMmY1IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0KKysrIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCkBAIC0yNzk5LDYgKzI3OTksMTEgQEAg c3RhdGljIE5TU3RyaW5nICpwYXRoV2l0aFVuaXF1ZUZpbGVuYW1lRm9yUGF0aChOU1N0cmluZyAq cGF0aCkKIH0KIAogI2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkKKy0gKEJPT0wpaGFzRnVsbFNj cmVlbldpbmRvd0NvbnRyb2xsZXIKK3sKKyAgICByZXR1cm4gKGJvb2wpX2RhdGEtPl9mdWxsU2Ny ZWVuV2luZG93Q29udHJvbGxlcjsKK30KKwogLSAoV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxl ciopZnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIKIHsKICAgICBpZiAoIV9kYXRhLT5fZnVsbFNj cmVlbldpbmRvd0NvbnRyb2xsZXIpIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvbWFjL1dLVmlld0ludGVybmFsLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL21hYy9XS1ZpZXdJbnRlcm5hbC5oCmluZGV4IGFkNDZkMGFhYWJkZDU0ZDJiODVlMTIxZDlj OTg4MjFkMzIxOTc0MTUuLjZiNmViNmJmNDFkMTkxNGQzZDZkMDZmMGYyMzI2MzBjMzkyYjgwNWIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlld0ludGVy bmFsLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3SW50ZXJu YWwuaApAQCAtODgsNiArODgsNyBAQCBuYW1lc3BhY2UgV2ViS2l0IHsKIC0gKHZvaWQpX2RpZENo YW5nZVNjcm9sbGJhcnNGb3JNYWluRnJhbWU7CiAKICNpZiBFTkFCTEUoRlVMTFNDUkVFTl9BUEkp CistIChCT09MKWhhc0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyOwogLSAoV0tGdWxsU2NyZWVu V2luZG93Q29udHJvbGxlciopZnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXI7CiAtICh2b2lkKWNs b3NlRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXI7CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViRnVsbFNjcmVlbk1hbmFnZXJQcm94eU1hYy5tbSBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViRnVsbFNjcmVlbk1hbmFnZXJQcm94eU1h Yy5tbQppbmRleCAwM2M3YjU4Njc4M2E4NWJjNGViZGNjMWJjMTllMzAyMGU2YTdiYWFiLi42MzI1 ZmNhNDUwOTFhMzZiNGVkNTViNWY5YmJmMWU5YjA1OWJmNjdjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYkZ1bGxTY3JlZW5NYW5hZ2VyUHJveHlNYWMubW0KKysr IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XZWJGdWxsU2NyZWVuTWFuYWdlclByb3h5 TWFjLm1tCkBAIC01Nyw2ICs1Nyw5IEBAIGJvb2wgV2ViRnVsbFNjcmVlbk1hbmFnZXJQcm94eTo6 aXNGdWxsU2NyZWVuKCkKIHsKICAgICBpZiAoIW1fd2ViVmlldykKICAgICAgICAgcmV0dXJuIGZh bHNlOworICAgIGlmICghW21fd2ViVmlldyBoYXNGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlcl0p CisgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAgIHJldHVybiBbW21fd2ViVmlldyBmdWxsU2Ny ZWVuV2luZG93Q29udHJvbGxlcl0gaXNGdWxsU2NyZWVuXTsKIH0KIAo=