83379 2012-04-06 10:39:37 -0700 Web Inspector: zoom on vertical mousewheel in Timeline overview 2012-04-09 10:37:27 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 597469 0 caseq 2012-04-06 10:39:37 -0700 This adds support for zooming via mouse wheel in the Timeline overview. 598376 1 136252 caseq 2012-04-09 10:10:07 -0700 Created attachment 136252 Patch 598380 2 136252 pfeldman 2012-04-09 10:14:38 -0700 Comment on attachment 136252 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136252&action=review > Source/WebCore/inspector/front-end/TimelineOverviewPane.js:594 > + // If you drink too much from a bottle marked 'poison' it is almost certain to disagree with you sooner or later. We only practice necessary comments in the WebKit source base. 598408 3 caseq 2012-04-09 10:37:27 -0700 Committed r113591: <http://trac.webkit.org/changeset/113591> 136252 2012-04-09 10:10:07 -0700 2012-04-09 10:14:38 -0700 Patch bug-83379-20120409211005.patch text/plain 4381 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNDQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWNlZGU1MWIzZGMzYTZj NzEwZGNlYzNlZTdkNGEyMjdiZTg3ZmNmMS4uN2FkYmRiMTA0ZTljNzAzZmY0MDJjYTU1ZWNlNTgw ZWZjYjI5NjZjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDEyLTA0LTA2ICBBbmRy ZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogem9vbSBvbiB2ZXJ0aWNhbCBtb3VzZXdoZWVsIGluIFRpbWVsaW5lIG92ZXJ2aWV3CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzM3OQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gYWRkZWQgc3VwcG9y dCBmb3Igem9vbWluZyBhcm91bmQgbW91c2UgY3Vyc29yIHVwb24gbW91c2V3aGVlbCBldmVudDsK KyAgICAgICAgLSBoYW5kbGUgbW91c2V3aGVlbCBldmVudCBieSBfb25Nb3VzZVdoZWVsLCBub3Qg c2Nyb2xsV2luZG93LCBzbyB3ZSBvbmx5IHpvb20gb24gZXZlbnRzIGludGVybmFsIHRvIG92ZXJ2 aWV3LgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZU92ZXJ2aWV3UGFu ZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3V2luZG93KToKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3V2luZG93LnByb3RvdHlwZS5fZW5k V2luZG93U2VsZWN0b3JEcmFnZ2luZyk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVP dmVydmlld1dpbmRvdy5wcm90b3R5cGUuX29uTW91c2VXaGVlbCk6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuVGltZWxpbmVPdmVydmlld1dpbmRvdy5wcm90b3R5cGUuX3pvb20pOgorCisyMDEyLTA0 LTA2ICBBbmRyZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgV2Vi IEluc3BlY3Rvcjogb24gYSBzaW5nbGUgY2xpY2sgaW4gVGltZWxpbmUgb3ZlcnZpZXcsIG1ha2Ug YSBtaW5pbWFsIHNlbGVjdGlvbiBjZW50ZXJlZCBhcm91bmQgY3Vyc29yCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjYxNgogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lT3ZlcnZpZXdQYW5lLmpz IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZU92ZXJ2aWV3UGFu ZS5qcwppbmRleCA4YzZhYjQ0YjhkOGMzNzU1OWE3NDI4MzllODdmMDU5ZmRiYWNjZTkxLi43MTAx MTAxNDlhNDg1ZjkxZDc1NDFjZTEzMDcwZjEwZDlhYmQ1YWZhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lT3ZlcnZpZXdQYW5lLmpzCisrKyBi L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVPdmVydmlld1BhbmUu anMKQEAgLTM5Nyw3ICszOTcsNyBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVPdmVydmlld1dpbmRv dyA9IGZ1bmN0aW9uKHBhcmVudEVsZW1lbnQpCiAgICAgdGhpcy53aW5kb3dSaWdodCA9IDEuMDsK IAogICAgIHRoaXMuX3BhcmVudEVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigibW91c2Vkb3duIiwg dGhpcy5fZHJhZ1dpbmRvdy5iaW5kKHRoaXMpLCB0cnVlKTsKLSAgICB0aGlzLl9wYXJlbnRFbGVt ZW50LmFkZEV2ZW50TGlzdGVuZXIoIm1vdXNld2hlZWwiLCB0aGlzLnNjcm9sbFdpbmRvdy5iaW5k KHRoaXMpLCB0cnVlKTsKKyAgICB0aGlzLl9wYXJlbnRFbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIo Im1vdXNld2hlZWwiLCB0aGlzLl9vbk1vdXNlV2hlZWwuYmluZCh0aGlzKSwgdHJ1ZSk7CiAgICAg dGhpcy5fcGFyZW50RWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJkYmxjbGljayIsIHRoaXMuX3Jl c2l6ZVdpbmRvd01heGltdW0uYmluZCh0aGlzKSwgdHJ1ZSk7CiAKICAgICB0aGlzLl9vdmVydmll d1dpbmRvd0VsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKQEAgLTQ4Nyw3 ICs0ODcsNyBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVPdmVydmlld1dpbmRvdy5wcm90b3R5cGUg PSB7CiAgICAgICAgIFdlYkluc3BlY3Rvci5lbGVtZW50RHJhZ0VuZChldmVudCk7CiAgICAgICAg IHZhciB3aW5kb3cgPSB0aGlzLl9vdmVydmlld1dpbmRvd1NlbGVjdG9yLl9jbG9zZShldmVudC5w YWdlWCAtIHRoaXMuX3BhcmVudEVsZW1lbnQub2Zmc2V0TGVmdCk7CiAgICAgICAgIGRlbGV0ZSB0 aGlzLl9vdmVydmlld1dpbmRvd1NlbGVjdG9yOwotICAgICAgICBpZiAod2luZG93LmVuZCA9PT0g d2luZG93LnN0YXJ0KSB7IC8vIENsaWNrLCBub3QgZHJhZy5cCisgICAgICAgIGlmICh3aW5kb3cu ZW5kID09PSB3aW5kb3cuc3RhcnQpIHsgLy8gQ2xpY2ssIG5vdCBkcmFnLgogICAgICAgICAgICAg dmFyIG1pZGRsZSA9IHdpbmRvdy5lbmQ7CiAgICAgICAgICAgICB3aW5kb3cuc3RhcnQgPSBNYXRo Lm1heCgwLCBtaWRkbGUgLSBXZWJJbnNwZWN0b3IuVGltZWxpbmVPdmVydmlld1BhbmUuTWluU2Vs ZWN0YWJsZVNpemUgLyAyKTsKICAgICAgICAgICAgIHdpbmRvdy5lbmQgPSBNYXRoLm1pbih0aGlz Ll9wYXJlbnRFbGVtZW50LmNsaWVudFdpZHRoLCBtaWRkbGUgKyBXZWJJbnNwZWN0b3IuVGltZWxp bmVPdmVydmlld1BhbmUuTWluU2VsZWN0YWJsZVNpemUgLyAyKTsKQEAgLTU3MCw2ICs1NzAsMzUg QEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lT3ZlcnZpZXdXaW5kb3cucHJvdG90eXBlID0gewogICAg ICAgICBXZWJJbnNwZWN0b3IuZWxlbWVudERyYWdFbmQoZXZlbnQpOwogICAgIH0sCiAKKyAgICBf b25Nb3VzZVdoZWVsOiBmdW5jdGlvbihldmVudCkKKyAgICB7CisgICAgICAgIGNvbnN0IHpvb21G YWN0b3IgPSAxLjE7CisgICAgICAgIGNvbnN0IG1vdXNlV2hlZWxab29tU3BlZWQgPSAxIC8gMTIw OworCisgICAgICAgIGlmICh0eXBlb2YgZXZlbnQud2hlZWxEZWx0YVkgPT09ICJudW1iZXIiICYm IGV2ZW50LndoZWVsRGVsdGFZICE9PSAwKSB7CisgICAgICAgICAgICB2YXIgcmVmZXJlbmNlUG9p bnQgPSBldmVudC5wYWdlWCAtIHRoaXMuX3BhcmVudEVsZW1lbnQub2Zmc2V0TGVmdDsKKyAgICAg ICAgICAgIHRoaXMuX3pvb20oTWF0aC5wb3coem9vbUZhY3RvciwgLWV2ZW50LndoZWVsRGVsdGFZ ICogbW91c2VXaGVlbFpvb21TcGVlZCksIHJlZmVyZW5jZVBvaW50KTsKKyAgICAgICAgfQorICAg ICAgICB0aGlzLnNjcm9sbFdpbmRvdyhldmVudCk7CisgICAgfSwKKworICAgIC8qKgorICAgICAq IEBwYXJhbSB7bnVtYmVyfSBmYWN0b3IKKyAgICAgKiBAcGFyYW0ge251bWJlcn0gcmVmZXJlbmNl UG9pbnQKKyAgICAgKi8KKyAgICBfem9vbTogZnVuY3Rpb24oZmFjdG9yLCByZWZlcmVuY2VQb2lu dCkKKyAgICB7CisgICAgICAgIHZhciBsZWZ0ID0gdGhpcy5fbGVmdFJlc2l6ZUVsZW1lbnQub2Zm c2V0TGVmdCArIFdlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3UGFuZS5SZXNpemVyT2Zmc2V0 OworICAgICAgICB2YXIgcmlnaHQgPSB0aGlzLl9yaWdodFJlc2l6ZUVsZW1lbnQub2Zmc2V0TGVm dCArIFdlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3UGFuZS5SZXNpemVyT2Zmc2V0OworICAg ICAgICAKKyAgICAgICAgLy8gSWYgeW91IGRyaW5rIHRvbyBtdWNoIGZyb20gYSBib3R0bGUgbWFy a2VkICdwb2lzb24nIGl0IGlzIGFsbW9zdCBjZXJ0YWluIHRvIGRpc2FncmVlIHdpdGggeW91IHNv b25lciBvciBsYXRlci4KKyAgICAgICAgaWYgKGZhY3RvciA8IDEgJiYgKHJpZ2h0IC0gbGVmdCkg PCBXZWJJbnNwZWN0b3IuVGltZWxpbmVPdmVydmlld1BhbmUuTWluU2VsZWN0YWJsZVNpemUpCisg ICAgICAgICAgICByZXR1cm47CisgICAgICAgIGxlZnQgPSBNYXRoLm1heCgwLCByZWZlcmVuY2VQ b2ludCArIChsZWZ0IC0gcmVmZXJlbmNlUG9pbnQpICogZmFjdG9yKTsKKyAgICAgICAgcmlnaHQg PSBNYXRoLm1pbih0aGlzLl9wYXJlbnRFbGVtZW50LmNsaWVudFdpZHRoLCByZWZlcmVuY2VQb2lu dCArIChyaWdodCAtIHJlZmVyZW5jZVBvaW50KSAqIGZhY3Rvcik7CisgICAgICAgIHRoaXMuX3Nl dFdpbmRvd1Bvc2l0aW9uKGxlZnQsIHJpZ2h0KTsKKyAgICB9LAorCiAgICAgc2Nyb2xsV2luZG93 OiBmdW5jdGlvbihldmVudCkKICAgICB7CiAgICAgICAgIGlmICh0eXBlb2YgZXZlbnQud2hlZWxE ZWx0YVggPT09ICJudW1iZXIiICYmIGV2ZW50LndoZWVsRGVsdGFYICE9PSAwKSB7Cg==