83376 2012-04-06 09:48:02 -0700 Correct LayoutUnit usgae in RenderThemeQt and RenderThemeQStyle 2012-04-06 12:54:55 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 leviw leviw eae eric jchaffraix ossy webkit.review.bot oldest_to_newest 597415 0 leviw 2012-04-06 09:48:02 -0700 A couple minor changes to get Qt's WebKit code ready for FractionalLayoutUnits. 597430 1 136039 leviw 2012-04-06 10:02:36 -0700 Created attachment 136039 Patch 597574 2 136039 webkit.review.bot 2012-04-06 12:54:45 -0700 Comment on attachment 136039 Patch Clearing flags on attachment: 136039 Committed r113484: <http://trac.webkit.org/changeset/113484> 597575 3 webkit.review.bot 2012-04-06 12:54:55 -0700 All reviewed patches have been landed. Closing bug. 136039 2012-04-06 10:02:36 -0700 2012-04-06 12:54:45 -0700 Patch bug-83376-20120406190233.patch text/plain 4046 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMzQ0OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA0LTA2ICBMZXZpIFdl aW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICBDb3JyZWN0IExheW91dFVu aXQgdXNnYWUgaW4gUmVuZGVyVGhlbWVRdCBhbmQgUmVuZGVyVGhlbWVRU3R5bGUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzMzc2CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29ycmVjdGluZyBMYXlvdXRV bml0IHVzYWdlIGluIFFUIFJlbmRlclRoZW1lIGNvZGUuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz LiBObyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9SZW5kZXJU aGVtZVF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lUXQ6OmNvbnZlcnRUb1Bh aW50aW5nUmVjdCk6IFJvdW5kaW5nIHRoZSBhbmNlc3RvciBvZmZzZXQgYmVmb3JlCisgICAgICAg IGFwcGx5aW5nIGl0IHRvIHRoZSBwaXhlbCBzbmFwcGVkIHBhcnRSZWN0LgorICAgICAgICAoV2Vi Q29yZTo6UmVuZGVyVGhlbWVRdDo6cGFpbnRTZWFyY2hGaWVsZENhbmNlbEJ1dHRvbik6IEFsc28g cm91bmRpbmcgdGhlIGFuY2VzdG9yCisgICAgICAgIG9mZnNldCwgYW5kIGFsc28gcGl4ZWwgc25h cHBpbmcgdGhlIGNvbnRlbnQgcmVjdCBiZWZvcmUgcGFpbnRpbmcuCisKIDIwMTItMDQtMDYgIFNo ZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2 aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMTM0NDIuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9xdC9SZW5kZXJUaGVtZVF0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9xdC9SZW5kZXJUaGVtZVF0LmNwcAkocmV2aXNpb24gMTEzNDQxKQorKysgU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vcXQvUmVuZGVyVGhlbWVRdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQz NSw3ICs0MzUsNyBAQCB2b2lkIFJlbmRlclRoZW1lUXQ6OmFkanVzdFNlYXJjaEZpZWxkQ2FuCiBJ bnRSZWN0IFJlbmRlclRoZW1lUXQ6OmNvbnZlcnRUb1BhaW50aW5nUmVjdChSZW5kZXJPYmplY3Qq IGlucHV0UmVuZGVyZXIsIGNvbnN0IFJlbmRlck9iamVjdCogcGFydFJlbmRlcmVyLCBJbnRSZWN0 IHBhcnRSZWN0LCBjb25zdCBJbnRSZWN0JiBsb2NhbE9mZnNldCkgY29uc3QKIHsKICAgICAvLyBD b21wdXRlIGFuIG9mZnNldCBiZXR3ZWVuIHRoZSBwYXJ0IHJlbmRlcmVyIGFuZCB0aGUgaW5wdXQg cmVuZGVyZXIuCi0gICAgSW50U2l6ZSBvZmZzZXRGcm9tSW5wdXRSZW5kZXJlciA9IC0ocGFydFJl bmRlcmVyLT5vZmZzZXRGcm9tQW5jZXN0b3JDb250YWluZXIoaW5wdXRSZW5kZXJlcikpOworICAg IEludFNpemUgb2Zmc2V0RnJvbUlucHV0UmVuZGVyZXIgPSAtcm91bmRlZEludFNpemUocGFydFJl bmRlcmVyLT5vZmZzZXRGcm9tQW5jZXN0b3JDb250YWluZXIoaW5wdXRSZW5kZXJlcikpOwogICAg IC8vIE1vdmUgdGhlIHJlY3QgaW50byBwYXJ0UmVuZGVyZXIncyBjb29yZHMuCiAgICAgcGFydFJl Y3QubW92ZShvZmZzZXRGcm9tSW5wdXRSZW5kZXJlcik7CiAgICAgLy8gQWNjb3VudCBmb3IgdGhl IGxvY2FsIGRyYXdpbmcgb2Zmc2V0LgpAQCAtNDU0LDcgKzQ1NCw3IEBAIGJvb2wgUmVuZGVyVGhl bWVRdDo6cGFpbnRTZWFyY2hGaWVsZENhbmMKICAgICBpZiAoIWlucHV0LT5yZW5kZXJlcigpLT5p c0JveCgpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgUmVuZGVyQm94KiBpbnB1dFJlbmRl ckJveCA9IHRvUmVuZGVyQm94KGlucHV0LT5yZW5kZXJlcigpKTsKLSAgICBJbnRSZWN0IGlucHV0 Q29udGVudEJveCA9IGlucHV0UmVuZGVyQm94LT5jb250ZW50Qm94UmVjdCgpOworICAgIEludFJl Y3QgaW5wdXRDb250ZW50Qm94ID0gcGl4ZWxTbmFwcGVkSW50UmVjdChpbnB1dFJlbmRlckJveC0+ Y29udGVudEJveFJlY3QoKSk7CiAKICAgICAvLyBNYWtlIHN1cmUgdGhlIHNjYWxlZCBidXR0b24g c3RheXMgc3F1YXJlIGFuZCB3aWxsIGZpdCBpbiBpdHMgcGFyZW50J3MgYm94LgogICAgIGludCBj YW5jZWxCdXR0b25TaXplID0gcU1pbihpbnB1dENvbnRlbnRCb3gud2lkdGgoKSwgcU1pbihpbnB1 dENvbnRlbnRCb3guaGVpZ2h0KCksIHIuaGVpZ2h0KCkpKTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQv cXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCShy ZXZpc2lvbiAxMTM0NDgpCisrKyBTb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZwkod29ya2luZyBj b3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA0LTA2ICBMZXZpIFdlaW50cmF1YiAgPGxldml3 QGNocm9taXVtLm9yZz4KKworICAgICAgICBDb3JyZWN0IExheW91dFVuaXQgdXNnYWUgaW4gUmVu ZGVyVGhlbWVRdCBhbmQgUmVuZGVyVGhlbWVRU3R5bGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzMzc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQ2FsY3VsYXRpbmcgdGhlIHByb2dyZXNzIGFuaW1hdGlv biB1c2luZyB0aGUgcGl4ZWwtc25hcHBlZCBSZW5kZXJQcm9ncmVzcyBzaXplIGluc3RlYWQKKyAg ICAgICAgb2YgdGhlIGludGVybmFsIHN1Yi1waXhlbCB2ZXJzaW9uLgorCisgICAgICAgICogV2Vi Q29yZVN1cHBvcnQvUmVuZGVyVGhlbWVRU3R5bGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyVGhlbWVRU3R5bGU6OmFuaW1hdGlvbkR1cmF0aW9uRm9yUHJvZ3Jlc3NCYXIpOgorCiAyMDEy LTA0LTA1ICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgogCiAgICAgICAg IFtRdF0gQ29ycmVjdCA8d3RmLyouaD4gaW5jbHVkZSBwYXRocy4KSW5kZXg6IFNvdXJjZS9XZWJL aXQvcXQvV2ViQ29yZVN1cHBvcnQvUmVuZGVyVGhlbWVRU3R5bGUuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvUmVuZGVyVGhlbWVRU3R5bGUuY3BwCShy ZXZpc2lvbiAxMTM0NDEpCisrKyBTb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L1JlbmRl clRoZW1lUVN0eWxlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDk5LDcgKzQ5OSw3IEBAIGRvdWJs ZSBSZW5kZXJUaGVtZVFTdHlsZTo6YW5pbWF0aW9uRHVyYXQKICAgICAgICAgcmV0dXJuIDA7CiAK ICAgICBRU3R5bGVPcHRpb25Qcm9ncmVzc0JhclYyIG9wdGlvbjsKLSAgICBvcHRpb24ucmVjdC5z ZXRTaXplKHJlbmRlclByb2dyZXNzLT5zaXplKCkpOworICAgIG9wdGlvbi5yZWN0LnNldFNpemUo cmVuZGVyUHJvZ3Jlc3MtPnBpeGVsU25hcHBlZFNpemUoKSk7CiAgICAgLy8gRklYTUU6IFVudGls IGh0dHA6Ly9idWdyZXBvcnRzLnF0Lm5va2lhLmNvbS9icm93c2UvUVRCVUctOTE3MSBpcyBmaXhl ZCwKICAgICAvLyB3ZSBzaW11bGF0ZSBvbmUgc3F1YXJlIGFuaW1hdGluZyBhY3Jvc3MgdGhlIHBy b2dyZXNzIGJhci4KICAgICByZXR1cm4gKG9wdGlvbi5yZWN0LndpZHRoKCkgLyBxU3R5bGUoKS0+ cGl4ZWxNZXRyaWMoUVN0eWxlOjpQTV9Qcm9ncmVzc0JhckNodW5rV2lkdGgsICZvcHRpb24pKSAq IGFuaW1hdGlvblJlcGVhdEludGVydmFsRm9yUHJvZ3Jlc3NCYXIocmVuZGVyUHJvZ3Jlc3MpOwo=