83361 2012-04-06 04:47:51 -0700 [BlackBerry] Upstream BlackBerry change to PatternSkia.cpp 2012-04-11 13:25:59 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 charles.wei charles.wei rwlbuis staikos tonikitoo oldest_to_newest 597290 0 charles.wei 2012-04-06 04:47:51 -0700 BlackBerry porting uses the same PatternSkia.cpp, but doesn't want the v8 specific code. 597292 1 136003 charles.wei 2012-04-06 04:52:01 -0700 Created attachment 136003 Patch 597308 2 136003 rwlbuis 2012-04-06 05:43:40 -0700 Comment on attachment 136003 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136003&action=review One mistake found. Also is Filip not working on this? Or did he touch this file already? > Source/WebCore/platform/graphics/skia/PatternSkia.cpp:52 > m_pattern = 0; This seems wrong. 600274 3 136003 rwlbuis 2012-04-11 08:10:24 -0700 Comment on attachment 136003 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136003&action=review >> Source/WebCore/platform/graphics/skia/PatternSkia.cpp:52 >> m_pattern = 0; > > This seems wrong. To be clear, it seems like we still want to delete m_pattern? I can imagine we do not want V8 code of course. 600525 4 136733 rwlbuis 2012-04-11 13:06:14 -0700 Created attachment 136733 Patch 600543 5 rwlbuis 2012-04-11 13:25:59 -0700 Landed in r113903. 136003 2012-04-06 04:52:01 -0700 2012-04-11 13:06:09 -0700 Patch bug-83361-20120406195735.patch text/plain 2445 charles.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNDI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjUxNzllMTFkMzUzOWZm YmM1NWFkZGNjNjM5Mzc5N2Q0MWI3ZjgxYi4uODIzMDQ4NzdjMWRhMTQ4NzgwNGYyOGQyODVmMTdk ZTk5MjI1ODJhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA0LTA2ICBDaGFy bGVzIFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBbQmxh Y2tCZXJyeV0gVXBzdHJlYW0gQmxhY2tCZXJyeSBjaGFuZ2UgdG8gUGF0dGVyblNraWEuY3BwCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzM2MQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJsYWNrQmVycnkg cG9ydGluZyB1c2VzIFBhdHRlcm5Ta2lhLmNwcCBidXQgZG9lc24ndCB3YW50IHRoZSB2OC1zcGVj aWZpYyBjb2RlIG9mIGl0LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QYXR0 ZXJuU2tpYS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYXR0ZXJuOjpwbGF0Zm9ybURlc3Ryb3kp OgorICAgICAgICAoV2ViQ29yZTo6UGF0dGVybjo6cGxhdGZvcm1QYXR0ZXJuKToKKwogMjAxMi0w NC0wNiAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVG91Y2gg Q2hyb21lQ2xpZW50LmggdG8gZml4IENocm9taXVtIGJ1aWxkLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QYXR0ZXJuU2tpYS5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BhdHRlcm5Ta2lhLmNwcAppbmRleCBjYzkx YzYzZGFjZThlMWI1MTg0MjhmODZhYTRiYTIzNTY3Yjc3ZTIyLi4yZGU3Y2NhMGIyNjg0ODljNzE5 MzQ0ZjM0ZDg1OTZlNWExMzQzYmFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9za2lhL1BhdHRlcm5Ta2lhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9za2lhL1BhdHRlcm5Ta2lhLmNwcApAQCAtMSw1ICsxLDYgQEAKIC8qCiAg KiBDb3B5cmlnaHQgKEMpIDIwMDggR29vZ2xlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAq IENvcHlyaWdodCAoQykgMjAxMiBSZXNlYXJjaCBJbiBNb3Rpb24gTGltaXRlZC4gQWxsIHJpZ2h0 cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQg YmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1p dHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtMzgsMTggKzM5 LDIyIEBACiAjaW5jbHVkZSAiU2tDb2xvclNoYWRlci5oIgogI2luY2x1ZGUgIlNrU2hhZGVyLmgi CiAKKyNpZiAhUExBVEZPUk0oQkxBQ0tCRVJSWSkKICNpbmNsdWRlIDx2OC5oPgorI2VuZGlmCiAK IG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogdm9pZCBQYXR0ZXJuOjpwbGF0Zm9ybURlc3Ryb3koKQog eworI2lmICFQTEFURk9STShCTEFDS0JFUlJZKQogICAgIFNrU2FmZVVucmVmKG1fcGF0dGVybik7 CiAgICAgbV9wYXR0ZXJuID0gMDsKICAgICBpZiAobV9leHRlcm5hbE1lbW9yeUFsbG9jYXRlZCkg ewogICAgICAgICB2ODo6Vjg6OkFkanVzdEFtb3VudE9mRXh0ZXJuYWxBbGxvY2F0ZWRNZW1vcnko LW1fZXh0ZXJuYWxNZW1vcnlBbGxvY2F0ZWQpOwogICAgICAgICBtX2V4dGVybmFsTWVtb3J5QWxs b2NhdGVkID0gMDsKICAgICB9CisjZW5kaWYKIH0KIAogUGxhdGZvcm1QYXR0ZXJuUHRyIFBhdHRl cm46OnBsYXRmb3JtUGF0dGVybihjb25zdCBBZmZpbmVUcmFuc2Zvcm0mIHBhdHRlcm5UcmFuc2Zv cm0pCkBAIC05Nyw3ICsxMDIsOSBAQCBQbGF0Zm9ybVBhdHRlcm5QdHIgUGF0dGVybjo6cGxhdGZv cm1QYXR0ZXJuKGNvbnN0IEFmZmluZVRyYW5zZm9ybSYgcGF0dGVyblRyYW5zZgogICAgICAgICBt X3BhdHRlcm4gPSBTa1NoYWRlcjo6Q3JlYXRlQml0bWFwU2hhZGVyKGJtMiwgdGlsZU1vZGVYLCB0 aWxlTW9kZVkpOwogCiAgICAgICAgIG1fZXh0ZXJuYWxNZW1vcnlBbGxvY2F0ZWQgPSBibTIuZ2V0 U2FmZVNpemUoKTsKKyNpZiAhUExBVEZPUk0oQkxBQ0tCRVJSWSkKICAgICAgICAgdjg6OlY4OjpB ZGp1c3RBbW91bnRPZkV4dGVybmFsQWxsb2NhdGVkTWVtb3J5KG1fZXh0ZXJuYWxNZW1vcnlBbGxv Y2F0ZWQpOworI2VuZGlmCiAgICAgfQogICAgIG1fcGF0dGVybi0+c2V0TG9jYWxNYXRyaXgobV9w YXR0ZXJuU3BhY2VUcmFuc2Zvcm1hdGlvbik7CiAgICAgcmV0dXJuIG1fcGF0dGVybjsK 136733 2012-04-11 13:06:14 -0700 2012-04-11 13:08:21 -0700 Patch bug-83361-20120411160645.patch text/plain 1956 rwlbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNzY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDg0MjE3ZmFiZjhlNDIx ZDA1MGQ5YWY4ZDY4Mjg1ZmIyZGE0YjUyYi4uNjJhNWZiNzg1NzFiNjFiNjliYTczMDdmODBkMTg1 NjM4YTE5YTU5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA0LTExICBSb2Ig QnVpcyAgPHJidWlzQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFVwc3RyZWFtIEJs YWNrQmVycnkgY2hhbmdlIHRvIFBhdHRlcm5Ta2lhLmNwcAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODMzNjEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcHN0cmVhbSBhIGNsZWFuZWQgdXAgdmVyc2lvbi4K KworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGF0dGVyblNraWEuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UGF0dGVybjo6cGxhdGZvcm1EZXN0cm95KToKKyAgICAgICAgKFdlYkNv cmU6OlBhdHRlcm46OnBsYXRmb3JtUGF0dGVybik6CisKIDIwMTItMDQtMTAgIFBhdHJpY2sgR2Fu c3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW0NNYWtlXSBFbmFibGUgVVNF X0ZPTERFUlMgcHJvcGVydHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3NraWEvUGF0dGVyblNraWEuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3Mvc2tpYS9QYXR0ZXJuU2tpYS5jcHAKaW5kZXggY2M5MWM2M2RhY2U4ZTFiNTE4NDI4Zjg2 YWE0YmEyMzU2N2I3N2UyMi4uY2E4YzU0ZmRjMTg4MWZmNjZmNmMwYTkyZTZlODFiNGEzNTExNjdl NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QYXR0 ZXJuU2tpYS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9Q YXR0ZXJuU2tpYS5jcHAKQEAgLTM4LDcgKzM4LDkgQEAKICNpbmNsdWRlICJTa0NvbG9yU2hhZGVy LmgiCiAjaW5jbHVkZSAiU2tTaGFkZXIuaCIKIAorI2lmIFVTRShWOCkKICNpbmNsdWRlIDx2OC5o PgorI2VuZGlmCiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIApAQCAtNDcsNyArNDksOSBAQCB2b2lk IFBhdHRlcm46OnBsYXRmb3JtRGVzdHJveSgpCiAgICAgU2tTYWZlVW5yZWYobV9wYXR0ZXJuKTsK ICAgICBtX3BhdHRlcm4gPSAwOwogICAgIGlmIChtX2V4dGVybmFsTWVtb3J5QWxsb2NhdGVkKSB7 CisjaWYgVVNFKFY4KQogICAgICAgICB2ODo6Vjg6OkFkanVzdEFtb3VudE9mRXh0ZXJuYWxBbGxv Y2F0ZWRNZW1vcnkoLW1fZXh0ZXJuYWxNZW1vcnlBbGxvY2F0ZWQpOworI2VuZGlmCiAgICAgICAg IG1fZXh0ZXJuYWxNZW1vcnlBbGxvY2F0ZWQgPSAwOwogICAgIH0KIH0KQEAgLTk3LDcgKzEwMSw5 IEBAIFBsYXRmb3JtUGF0dGVyblB0ciBQYXR0ZXJuOjpwbGF0Zm9ybVBhdHRlcm4oY29uc3QgQWZm aW5lVHJhbnNmb3JtJiBwYXR0ZXJuVHJhbnNmCiAgICAgICAgIG1fcGF0dGVybiA9IFNrU2hhZGVy OjpDcmVhdGVCaXRtYXBTaGFkZXIoYm0yLCB0aWxlTW9kZVgsIHRpbGVNb2RlWSk7CiAKICAgICAg ICAgbV9leHRlcm5hbE1lbW9yeUFsbG9jYXRlZCA9IGJtMi5nZXRTYWZlU2l6ZSgpOworI2lmIFVT RShWOCkKICAgICAgICAgdjg6OlY4OjpBZGp1c3RBbW91bnRPZkV4dGVybmFsQWxsb2NhdGVkTWVt b3J5KG1fZXh0ZXJuYWxNZW1vcnlBbGxvY2F0ZWQpOworI2VuZGlmCiAgICAgfQogICAgIG1fcGF0 dGVybi0+c2V0TG9jYWxNYXRyaXgobV9wYXR0ZXJuU3BhY2VUcmFuc2Zvcm1hdGlvbik7CiAgICAg cmV0dXJuIG1fcGF0dGVybjsK