83358 2012-04-06 03:08:01 -0700 [BlackBerry] Build fix to match the latest WebCore change 2012-04-06 17:33:40 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 charles.wei charles.wei leo.yang mxie rakuco rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 597268 0 charles.wei 2012-04-06 03:08:01 -0700 1. FDMXParser.cpp moved from platform/graphics/skia/ to platform/graphics/chromium. 2. websockets moved from Source/WebCore to Source/WebCore/Modules 3. geolocation moved from Source/WebCore to Source/WebCore/Modules Need to update the corresponding platform cmake files for blackberry. 597270 1 135996 charles.wei 2012-04-06 03:16:01 -0700 Created attachment 135996 Patch 597311 2 135996 rwlbuis 2012-04-06 05:47:47 -0700 Comment on attachment 135996 Patch LGTM. 597792 3 135996 charles.wei 2012-04-06 16:17:58 -0700 Comment on attachment 135996 Patch Thanks for the review,Rob. 597848 4 135996 webkit.review.bot 2012-04-06 17:33:34 -0700 Comment on attachment 135996 Patch Clearing flags on attachment: 135996 Committed r113525: <http://trac.webkit.org/changeset/113525> 597849 5 webkit.review.bot 2012-04-06 17:33:40 -0700 All reviewed patches have been landed. Closing bug. 135996 2012-04-06 03:16:01 -0700 2012-04-06 17:33:34 -0700 Patch bug-83358-20120406182125.patch text/plain 2904 charles.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNDIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmNlZjYyN2M0YTE5ZDUz NWQ3YWYzN2M5OTQ2YTgzYjY5MmZiZjFiNy4uMDAyODhlNzY0NmFkZTY5NTlmY2I3MGY5ZDEyNTdm MWM0ZGYzZWY1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA0LTA2ICBDaGFy bGVzIFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBbQmxh Y2tCZXJyeV0gQnVpbGQgZml4IHRvIG1hdGNoIHRoZSBsYXRlc3QgV2ViQ29yZSBjaGFuZ2UKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzMzU4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIHRoZSBC bGFja0JlcnJ5IGNtYWtlIGZpbGUgdG8gcmVmbGVjdCB0aGUgZmFjdCB0aGF0OgorICAgICAgICAx LlZETVhQYXJzZXIuY3BwIG1vdmVkIGZyb20gZ3JhcGhpY3Mvc2tpYSB0byBncmFwaGljcy9jaHJv bWl1bS4KKyAgICAgICAgMi5nZW9sb2NhdGlvbiBtb3ZlZCB0byBNb2R1bGVzL2dlb2xvY2F0aW9u CisgICAgICAgIDMud2Vic29ja2V0cyBtb3ZlZCB0byBNb2R1bGVzL3dlYnNvY2tldHMKKworICAg ICAgICAqIFBsYXRmb3JtQmxhY2tCZXJyeS5jbWFrZToKKwogMjAxMi0wNC0wNSAgQWxleGFuZGVy IFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtSRUdSRVNTSU9OXSBS ZWZyZXNoZWQgYXV0b2ZpbGwgcG9wdXAgcmVuZGVycyBnYXJiYWdlCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI0ZjM2 ZWY3OTQ0MGVhZjViZTUzMTBhYjQ0MjNkYzc2MWEzNGFkMjEuLjJmYjViZjcxNmRmY2MyNWU1NTRh YjZlNzgxYmMxZTUyMzQ5NDA4ZjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTItMDQt MDYgIENoYXJsZXMgV2VpICA8Y2hhcmxlcy53ZWlAdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAg ICAgIFtCbGFja0JlcnJ5XSBCdWlsZCBmaXggdG8gbWF0Y2ggdGhlIGxhdGVzdCBXZWJDb3JlIGNo YW5nZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODMz NTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFBs YXRmb3JtQmxhY2tCZXJyeS5jbWFrZToKKwogMjAxMi0wNC0wNSAgR2VvcmdlIFN0YWlrb3MgIDxz dGFpa29zQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkIHRoZSB2aWJyYXRpb24gY2xpZW50IGZv ciBCbGFja0JlcnJ5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1CbGFja0Jl cnJ5LmNtYWtlIGIvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1CbGFja0JlcnJ5LmNtYWtlCmluZGV4 IGQ3YzJmNjQ1N2Q2MTA1MTRhMDNkNDliMDYxMWExNzMyZTQ1YzQ5MGMuLmRmOWJjZDhhMTBlZjBj NDExMjliZmRhMjEyMGZmNjE1OWVmYTkwZjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1Bs YXRmb3JtQmxhY2tCZXJyeS5jbWFrZQorKysgYi9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUJsYWNr QmVycnkuY21ha2UKQEAgLTM0LDcgKzM0LDcgQEAgTElTVChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VT CiAgICAgcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QbGF0Zm9ybUNvbnRleHRTa2lhLmNwcAogICAg IHBsYXRmb3JtL2dyYXBoaWNzL3NraWEvU2tpYVV0aWxzLmNwcAogICAgIHBsYXRmb3JtL2dyYXBo aWNzL3NraWEvVHJhbnNmb3JtYXRpb25NYXRyaXhTa2lhLmNwcAotICAgIHBsYXRmb3JtL2dyYXBo aWNzL3NraWEvVkRNWFBhcnNlci5jcHAKKyAgICBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9W RE1YUGFyc2VyLmNwcAogICAgIHBsYXRmb3JtL2ltYWdlLWRlY29kZXJzL3NraWEvSW1hZ2VEZWNv ZGVyU2tpYS5jcHAKICAgICBwbGF0Zm9ybS9pbWFnZS1lbmNvZGVycy9za2lhL1BOR0ltYWdlRW5j b2Rlci5jcHAKICkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1CbGFja0JlcnJ5 LmNtYWtlIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybUJsYWNrQmVycnkuY21ha2UKaW5kZXggNjU5 NjIyMDZjODQ4ZjYxZDhlNmIzNGM0ZmQyZWFhNDExMDljYjI1Ni4uYTQ4OWM4Nzg4NDEyMzkzNGJl MzdjMDE2OWQzMDFjZWE2MTg5NzdkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9QbGF0Zm9y bUJsYWNrQmVycnkuY21ha2UKKysrIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybUJsYWNrQmVycnku Y21ha2UKQEAgLTE2LDcgKzE2LDggQEAgTElTVChBUFBFTkQgV2ViS2l0X0lOQ0xVREVfRElSRUNU T1JJRVMKICAgICAiJHtXRUJDT1JFX0RJUn0vcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9z a2lhIgogICAgICIke1dFQkNPUkVfRElSfS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhIgogICAgICIk e1dFQkNPUkVfRElSfS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkiCi0gICAgIiR7V0VCQ09S RV9ESVJ9L3dlYnNvY2tldHMiCisgICAgIiR7V0VCQ09SRV9ESVJ9L01vZHVsZXMvd2Vic29ja2V0 cyIKKyAgICAiJHtXRUJDT1JFX0RJUn0vTW9kdWxlcy9nZW9sb2NhdGlvbiIKICAgICAiJHtXRUJD T1JFX0RJUn0vTW9kdWxlcy92aWJyYXRpb24iCiAgICAgIiR7V0VCS0lUX0RJUn0vYmxhY2tiZXJy eS9BcGkiCiAgICAgIiR7V0VCS0lUX0RJUn0vYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydCIK